Callum Waters
90fe178b52
mempool: don't return an error on checktx with the same tx ( #6199 )
4 years ago
Marko
0d0181856b
indexer: remove info log ( #6194 )
## Description
Replace info log with Debug.
4 years ago
Anton Kaliaev
36d92cd0b6
test/fuzz: fix rpc, secret_connection and pex tests ( #6190 )
* test/fuzz: fix rpc, secret_connection and pex tests
- ignore empty data in rpc
- provide correct IP in pex
- spawn a goroutine for Write and do multiple Read(s)
* test/fuzz: fix init in pex test
* test/fuzz: assign NewServeMux to global var
* test/fuzz: only try to Unmarshal if blob is not empty
* run fuzz tests for PRs which modify fuzz tests themselves
* test/fuzz: move MakeSwitch into init
4 years ago
Anton Kaliaev
fe4e97afe0
rpc/jsonrpc: Unmarshal RPCRequest correctly ( #6191 )
i.e. without double pointer. With double pointer, it was possible to
submit `null` value, which will crash the server.
```
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x189ddc0]
goroutine 1 [running]:
github.com/tendermint/tendermint/rpc/jsonrpc/types.(*RPCRequest).UnmarshalJSON(0xc0000147e0, 0xc00029f201, 0x4, 0x1ff, 0x883baa0, 0xc0000147e0)
/Users/anton/go/src/github.com/tendermint/tendermint/rpc/jsonrpc/types/types.go:70 +0x100
encoding/json.(*decodeState).literalStore(0xc000216bb0, 0xc00029f201, 0x4, 0x1ff, 0x1998800, 0xc0000147e0, 0x199, 0xc000231700, 0x10e0a5e, 0x197)
/usr/local/Cellar/go/1.16/libexec/src/encoding/json/decode.go:860 +0x30ce
encoding/json.(*decodeState).value(0xc000216bb0, 0x1998800, 0xc0000147e0, 0x199, 0x1998800, 0xc0000147e0)
/usr/local/Cellar/go/1.16/libexec/src/encoding/json/decode.go:384 +0x40c
encoding/json.(*decodeState).array(0xc000216bb0, 0x18df040, 0xc0001be540, 0x16, 0xc000216bd8, 0x10e405b)
/usr/local/Cellar/go/1.16/libexec/src/encoding/json/decode.go:558 +0x365
encoding/json.(*decodeState).value(0xc000216bb0, 0x18df040, 0xc0001be540, 0x16, 0x16, 0x6e)
/usr/local/Cellar/go/1.16/libexec/src/encoding/json/decode.go:360 +0x22f
encoding/json.(*decodeState).unmarshal(0xc000216bb0, 0x18df040, 0xc0001be540, 0xc000216bd8, 0x0)
/usr/local/Cellar/go/1.16/libexec/src/encoding/json/decode.go:180 +0x2c9
encoding/json.Unmarshal(0xc00029f200, 0x6, 0x200, 0x18df040, 0xc0001be540, 0x0, 0x0)
/usr/local/Cellar/go/1.16/libexec/src/encoding/json/decode.go:107 +0x15d
```
4 years ago
Tess Rinearson
ddba7f931a
changelog: update for 0.34.8 ( #6183 )
4 years ago
Anton Kaliaev
089b314bdb
test/fuzz: fix PEX reactor test ( #6188 )
* test/fuzz: fix PEX reactor test
* .github: [fuzz] increase retention period for crashers
4 years ago
Callum Waters
37d36cd5bc
light: improve provider handling ( #6053 )
Introduces heuristics that track the amount of no responses or unavailable blocks a provider has for more robust provider handling by the light client. Use concurrent calls to all witnesses when a new primary is needed.
4 years ago
Marko
e2384a00ce
privval: return errors on loadFilePV ( #6185 )
## Description
- return errors on `loadFilePv`
closes #6182
4 years ago
winor
f57aaa4925
docs/tutorials: fix sample code ( #6186 )
4 years ago
dependabot[bot]
611dd5ad46
build(deps): Bump google.golang.org/grpc from 1.35.0 to 1.36.0 ( #6180 )
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go ) from 1.35.0 to 1.36.0.
- [Release notes](https://github.com/grpc/grpc-go/releases )
- [Commits](https://github.com/grpc/grpc-go/compare/v1.35.0...v1.36.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
4 years ago
Anton Kaliaev
fc5a108d53
libs/log: [JSON format] include timestamp ( #6174 )
Closes #6146
4 years ago
Anton Kaliaev
e9e5026dac
rpc/client/http: drop endpoint arg from New and add WSOptions ( #6176 )
also
- replace `MaxReconnectAttempts`, `ReadWait`, `WriteWait` and `PingPeriod` options with `WSOptions` in `WSClient` (rpc/jsonrpc/client/ws_client.go).
- set default write wait to 10s for `WSClient`(rpc/jsonrpc/client/ws_client.go)
- unexpose `WSEvents`(rpc/client/http.go)
Closes #6162
4 years ago
dependabot[bot]
bd14bb66e9
build(deps): Bump golangci/golangci-lint-action from v2.4.0 to v2.5.1 ( #6175 )
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action ) from v2.4.0 to v2.5.1.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases )
- [Commits](https://github.com/golangci/golangci-lint-action/compare/v2.4.0...d9f0e73c0497685d68af8c58280f49fcaf0545ff )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
4 years ago
Marko
45572117ae
logging: print string instead of callback ( #6177 )
## Description
Fixes marshaling error in sdk
closes https://github.com/cosmos/cosmos-sdk/issues/8578
the output stays the same, we are avoiding the passing of the callback because sdk uses typed logging.
4 years ago
Anton Kaliaev
0f4124fb54
rpc/client/http: Do not drop events even if the `out` channel is full ( #6163 )
```
// unbuffered
out, err := httpClient.Subscribe(ctx, "event.type=NewTx and account.name=Jack", 0)
// buffered
out, err := httpClient.Subscribe(ctx, "event.type=NewTx AND account.name=Jack", 20)
```
Before: when the `out` channel is buffered and becomes full, we drop an event (+ log the error)
After: when the `out` channel is buffered and becomes full, we block
**Before it was not apparent to the app when an event was dropped (looking at the logs is manual task). After this PR, if the user does not read from `out` on 1 subscription, all other subscriptions will be stuck too.**
Closes #6161
4 years ago
Tess Rinearson
be35c893d3
docs/security: add preallocated list of security vulnerability names ( #6167 )
I'm also going to add the retros for all previous security incidents to this directory - I'd like to have them somewhere more central than the Cosmos Forum, where they currently live.
4 years ago
Aleksandr Bezobchuk
c21f4c6fde
state executor: groom logs ( #6152 )
ref: #5912
4 years ago
githubsands
d5cf7831f1
state: save in batches within the state store ( #6067 )
4 years ago
Silas Davis
9498cd80bd
Normalise GenesisDoc before saving to state ( #6059 )
Co-authored-by: Callum <cmwaters19@gmail.com>
4 years ago
Anton Kaliaev
c1ca749afa
rpc: change default sorting to desc for `/tx_search` results ( #6168 )
Closes #6155
4 years ago
Anton Kaliaev
98bbde5385
.github: [jepsen] archive results ( #6164 )
4 years ago
Callum Waters
42f6c40751
p2p: enable scheme-less parsing of IPv6 strings ( #6158 )
4 years ago
Aleksandr Bezobchuk
6912c34b58
cmd: ignore missing wal in debug kill command ( #6160 )
closes : #6159
4 years ago
Anton Kaliaev
5a39f72aa8
.github: [jepsen] add more docs ( #6141 )
4 years ago
Tess Rinearson
93719c2eb3
changelog: update with changes from 0.34.7 (and failed 0.34.5, 0.34.6) ( #6150 )
4 years ago
Marko
ab69153037
docs: how to add tm version to RPC ( #6151 )
## Description
Add docs on how to get tendermint version into RPC version outputs
4 years ago
Callum Waters
29360f955c
light: improve timeout functionality ( #6145 )
4 years ago
Aleksandr Bezobchuk
27eb10a2e7
consensus: log private validator address and not struct ( #6144 )
ref: https://github.com/tendermint/tendermint/pull/6140#discussion_r578635756
4 years ago
Aleksandr Bezobchuk
8a3637a249
consensus: more log grooming ( #6140 )
ref: https://github.com/tendermint/tendermint/issues/5912
4 years ago
Bipul Prasad
90c290ac52
rpc: standardize error codes ( #6019 )
4 years ago
Anton Kaliaev
54a14cfeed
.github: [jepsen] source .bashrc ( #6139 )
fixes https://github.com/tendermint/tendermint/runs/1926771645
```
ERROR [2021-02-18 12:16:30,492] main - jepsen.cli Oh jeez, I'm sorry,
Jepsen broke. Here's why:
clojure.lang.ExceptionInfo: throw+: {:dir "/", :private-key-path nil,
:password "root", :username "root", :type :jepsen.control/session-error,
:port 22, :strict-host-key-checking false, :host nil, :sudo nil, :dummy
false, :message "Error opening SSH session. Verify username, password,
and node hostnames are correct.", :session nil}
```
4 years ago
Anton Kaliaev
a48c6bdf5e
.github: [jepsen] fix directory name ( #6138 )
```
bash: line 0: cd: tendermint: No such file or directory
```
4 years ago
Anton Kaliaev
27b05d6b39
.github: [jepsen] cd inside the container, not outside ( #6137 )
fixes https://github.com/tendermint/tendermint/runs/1925580432
```
No :main namespace specified in project.clj.
```
4 years ago
Anton Kaliaev
6cb4b5d8ad
.github: [jepsen] use "bash -c" to execute lein run cmd ( #6136 )
Fixes https://github.com/tendermint/tendermint/runs/1925329781
```
OCI runtime exec failed: exec failed: container_linux.go:370: starting
container process caused: exec: "lein run test --nemesis none --workload
cas-register --concurrency 10 --tendermint-url
https://github.com/melekes/katas/releases/download/0.2.0/tendermint.tar.gz
--merkleeyes-url
https://github.com/melekes/katas/releases/download/0.2.0/merkleeyes_0.1.7.tar.gz ":
stat lein run test --nemesis none --workload cas-register --concurrency
10 --tendermint-url
https://github.com/melekes/katas/releases/download/0.2.0/tendermint.tar.gz
--merkleeyes-url
https://github.com/melekes/katas/releases/download/0.2.0/merkleeyes_0.1.7.tar.gz :
no such file or directory: unknown
```
4 years ago
Anton Kaliaev
07cf71146c
.github: [jepsen] use working-directory instead of 'cd' ( #6135 )
4 years ago
Anton Kaliaev
df0bf4b0ee
.github: [jepsen] fix inputs and remove TTY from docker ( #6134 )
fixes https://github.com/tendermint/tendermint/runs/1924860805
```
Run docker exec -it jepsen-control 'cd tendermint && lein run test
--nemesis --workload ' the input device is not a TTY
```
4 years ago
Anton Kaliaev
9f697db54f
.github: Jepsen workflow - initial version ( #6123 )
4 years ago
Aleksandr Bezobchuk
bc3e3d134e
tests: Fix TestByzantinePrevoteEquivocation ( #6132 )
Missed setting the buffer size on the subscription. Note, this doesn't really "fix" this test (a la ref: https://github.com/tendermint/tendermint/pull/5710 ).
However, I spent a good chunk of time looking at this test with many logs and I'm pretty sure this is mainly due to the fact that none of the nodes get the conflicting vote in time.
closes : #6127
4 years ago
Aleksandr Bezobchuk
5b52f87789
ABCI: Fix ReCheckTx for Socket Client ( #6124 )
Fixes the race condition between a callback being set and called during ReCheckTx. Note, I do not see equivalent logic in the gRPC client (anymore) as #5439 suggests, so only the socket client was updated.
closes : #5439
4 years ago
Erik Grinaker
b6be889b97
node: feature flag for legacy p2p support ( #6056 )
4 years ago
Aleksandr Bezobchuk
16bbe8c862
consensus: p2p refactor ( #5969 )
4 years ago
Marko
10b9fb9f21
adr: batch verification ( #6008 )
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
4 years ago
Marko
809a5e876c
docs/tutorials: fix proto file names ( #6112 )
## Description
Fix protobuf file names
4 years ago
dependabot[bot]
670b27fe3c
build(deps): Bump golangci/golangci-lint-action from v2.3.0 to v2.4.0 ( #6111 )
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action ) from v2.3.0 to v2.4.0.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases )
- [Commits](https://github.com/golangci/golangci-lint-action/compare/v2.3.0...544d2efb307b3f205f34886f2787046abe7fb26e )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
4 years ago
Tess Rinearson
df0b868415
changelog: update 0.34.3 changelog with details on security vuln ( #6108 )
Closes #6095 .
4 years ago
Marko
195916fa32
backports: mergify ( #6107 )
Co-authored-by: Tess Rinearson <tess.rinearson@gmail.com>
4 years ago
Tess Rinearson
3e6f9329c1
changelog: update to reflect v0.34.4 release ( #6105 )
4 years ago
Marko
2d57043aa4
tooling: remove tools/Makefile ( #6102 )
Co-authored-by: Tess Rinearson <tess.rinearson@gmail.com>
4 years ago
Callum Waters
c8a661091d
CHANGELOG_PENDING: update changelog for changes to American spelling ( #6100 )
4 years ago
Callum Waters
d4b04776bd
e2e: disconnect maverick ( #6099 )
4 years ago