You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

1501 lines
52 KiB

10 years ago
7 years ago
8 years ago
7 years ago
10 years ago
10 years ago
9 years ago
9 years ago
9 years ago
9 years ago
9 years ago
10 years ago
new pubsub package comment out failing consensus tests for now rewrite rpc httpclient to use new pubsub package import pubsub as tmpubsub, query as tmquery make event IDs constants EventKey -> EventTypeKey rename EventsPubsub to PubSub mempool does not use pubsub rename eventsSub to pubsub new subscribe API fix channel size issues and consensus tests bugs refactor rpc client add missing discardFromChan method add mutex rename pubsub to eventBus remove IsRunning from WSRPCConnection interface (not needed) add a comment in broadcastNewRoundStepsAndVotes rename registerEventCallbacks to broadcastNewRoundStepsAndVotes See https://dave.cheney.net/2014/03/19/channel-axioms stop eventBuses after reactor tests remove unnecessary Unsubscribe return subscribe helper function move discardFromChan to where it is used subscribe now returns an err this gives us ability to refuse to subscribe if pubsub is at its max capacity. use context for control overflow cache queries handle err when subscribing in replay_test rename testClientID to testSubscriber extract var set channel buffer capacity to 1 in replay_file fix byzantine_test unsubscribe from single event, not all events refactor httpclient to return events to appropriate channels return failing testReplayCrashBeforeWriteVote test fix TestValidatorSetChanges refactor code a bit fix testReplayCrashBeforeWriteVote add comment fix TestValidatorSetChanges fixes from Bucky's review update comment [ci skip] test TxEventBuffer update changelog fix TestValidatorSetChanges (2nd attempt) only do wg.Done when no errors benchmark event bus create pubsub server inside NewEventBus only expose config params (later if needed) set buffer capacity to 0 so we are not testing cache new tx event format: key = "Tx" plus a tag {"tx.hash": XYZ} This should allow to subscribe to all transactions! or a specific one using a query: "tm.events.type = Tx and tx.hash = '013ABF99434...'" use TimeoutCommit instead of afterPublishEventNewBlockTimeout TimeoutCommit is the time a node waits after committing a block, before it goes into the next height. So it will finish everything from the last block, but then wait a bit. The idea is this gives it time to hear more votes from other validators, to strengthen the commit it includes in the next block. But it also gives it time to hear about new transactions. waitForBlockWithUpdatedVals rewrite WAL crash tests Task: test that we can recover from any WAL crash. Solution: the old tests were relying on event hub being run in the same thread (we were injecting the private validator's last signature). when considering a rewrite, we considered two possible solutions: write a "fuzzy" testing system where WAL is crashing upon receiving a new message, or inject failures and trigger them in tests using something like https://github.com/coreos/gofail. remove sleep no cs.Lock around wal.Save test different cases (empty block, non-empty block, ...) comments add comments test 4 cases: empty block, non-empty block, non-empty block with smaller part size, many blocks fixes as per Bucky's last review reset subscriptions on UnsubscribeAll use a simple counter to track message for which we panicked also, set a smaller part size for all test cases
7 years ago
new pubsub package comment out failing consensus tests for now rewrite rpc httpclient to use new pubsub package import pubsub as tmpubsub, query as tmquery make event IDs constants EventKey -> EventTypeKey rename EventsPubsub to PubSub mempool does not use pubsub rename eventsSub to pubsub new subscribe API fix channel size issues and consensus tests bugs refactor rpc client add missing discardFromChan method add mutex rename pubsub to eventBus remove IsRunning from WSRPCConnection interface (not needed) add a comment in broadcastNewRoundStepsAndVotes rename registerEventCallbacks to broadcastNewRoundStepsAndVotes See https://dave.cheney.net/2014/03/19/channel-axioms stop eventBuses after reactor tests remove unnecessary Unsubscribe return subscribe helper function move discardFromChan to where it is used subscribe now returns an err this gives us ability to refuse to subscribe if pubsub is at its max capacity. use context for control overflow cache queries handle err when subscribing in replay_test rename testClientID to testSubscriber extract var set channel buffer capacity to 1 in replay_file fix byzantine_test unsubscribe from single event, not all events refactor httpclient to return events to appropriate channels return failing testReplayCrashBeforeWriteVote test fix TestValidatorSetChanges refactor code a bit fix testReplayCrashBeforeWriteVote add comment fix TestValidatorSetChanges fixes from Bucky's review update comment [ci skip] test TxEventBuffer update changelog fix TestValidatorSetChanges (2nd attempt) only do wg.Done when no errors benchmark event bus create pubsub server inside NewEventBus only expose config params (later if needed) set buffer capacity to 0 so we are not testing cache new tx event format: key = "Tx" plus a tag {"tx.hash": XYZ} This should allow to subscribe to all transactions! or a specific one using a query: "tm.events.type = Tx and tx.hash = '013ABF99434...'" use TimeoutCommit instead of afterPublishEventNewBlockTimeout TimeoutCommit is the time a node waits after committing a block, before it goes into the next height. So it will finish everything from the last block, but then wait a bit. The idea is this gives it time to hear more votes from other validators, to strengthen the commit it includes in the next block. But it also gives it time to hear about new transactions. waitForBlockWithUpdatedVals rewrite WAL crash tests Task: test that we can recover from any WAL crash. Solution: the old tests were relying on event hub being run in the same thread (we were injecting the private validator's last signature). when considering a rewrite, we considered two possible solutions: write a "fuzzy" testing system where WAL is crashing upon receiving a new message, or inject failures and trigger them in tests using something like https://github.com/coreos/gofail. remove sleep no cs.Lock around wal.Save test different cases (empty block, non-empty block, ...) comments add comments test 4 cases: empty block, non-empty block, non-empty block with smaller part size, many blocks fixes as per Bucky's last review reset subscriptions on UnsubscribeAll use a simple counter to track message for which we panicked also, set a smaller part size for all test cases
7 years ago
new pubsub package comment out failing consensus tests for now rewrite rpc httpclient to use new pubsub package import pubsub as tmpubsub, query as tmquery make event IDs constants EventKey -> EventTypeKey rename EventsPubsub to PubSub mempool does not use pubsub rename eventsSub to pubsub new subscribe API fix channel size issues and consensus tests bugs refactor rpc client add missing discardFromChan method add mutex rename pubsub to eventBus remove IsRunning from WSRPCConnection interface (not needed) add a comment in broadcastNewRoundStepsAndVotes rename registerEventCallbacks to broadcastNewRoundStepsAndVotes See https://dave.cheney.net/2014/03/19/channel-axioms stop eventBuses after reactor tests remove unnecessary Unsubscribe return subscribe helper function move discardFromChan to where it is used subscribe now returns an err this gives us ability to refuse to subscribe if pubsub is at its max capacity. use context for control overflow cache queries handle err when subscribing in replay_test rename testClientID to testSubscriber extract var set channel buffer capacity to 1 in replay_file fix byzantine_test unsubscribe from single event, not all events refactor httpclient to return events to appropriate channels return failing testReplayCrashBeforeWriteVote test fix TestValidatorSetChanges refactor code a bit fix testReplayCrashBeforeWriteVote add comment fix TestValidatorSetChanges fixes from Bucky's review update comment [ci skip] test TxEventBuffer update changelog fix TestValidatorSetChanges (2nd attempt) only do wg.Done when no errors benchmark event bus create pubsub server inside NewEventBus only expose config params (later if needed) set buffer capacity to 0 so we are not testing cache new tx event format: key = "Tx" plus a tag {"tx.hash": XYZ} This should allow to subscribe to all transactions! or a specific one using a query: "tm.events.type = Tx and tx.hash = '013ABF99434...'" use TimeoutCommit instead of afterPublishEventNewBlockTimeout TimeoutCommit is the time a node waits after committing a block, before it goes into the next height. So it will finish everything from the last block, but then wait a bit. The idea is this gives it time to hear more votes from other validators, to strengthen the commit it includes in the next block. But it also gives it time to hear about new transactions. waitForBlockWithUpdatedVals rewrite WAL crash tests Task: test that we can recover from any WAL crash. Solution: the old tests were relying on event hub being run in the same thread (we were injecting the private validator's last signature). when considering a rewrite, we considered two possible solutions: write a "fuzzy" testing system where WAL is crashing upon receiving a new message, or inject failures and trigger them in tests using something like https://github.com/coreos/gofail. remove sleep no cs.Lock around wal.Save test different cases (empty block, non-empty block, ...) comments add comments test 4 cases: empty block, non-empty block, non-empty block with smaller part size, many blocks fixes as per Bucky's last review reset subscriptions on UnsubscribeAll use a simple counter to track message for which we panicked also, set a smaller part size for all test cases
7 years ago
8 years ago
8 years ago
10 years ago
10 years ago
8 years ago
new pubsub package comment out failing consensus tests for now rewrite rpc httpclient to use new pubsub package import pubsub as tmpubsub, query as tmquery make event IDs constants EventKey -> EventTypeKey rename EventsPubsub to PubSub mempool does not use pubsub rename eventsSub to pubsub new subscribe API fix channel size issues and consensus tests bugs refactor rpc client add missing discardFromChan method add mutex rename pubsub to eventBus remove IsRunning from WSRPCConnection interface (not needed) add a comment in broadcastNewRoundStepsAndVotes rename registerEventCallbacks to broadcastNewRoundStepsAndVotes See https://dave.cheney.net/2014/03/19/channel-axioms stop eventBuses after reactor tests remove unnecessary Unsubscribe return subscribe helper function move discardFromChan to where it is used subscribe now returns an err this gives us ability to refuse to subscribe if pubsub is at its max capacity. use context for control overflow cache queries handle err when subscribing in replay_test rename testClientID to testSubscriber extract var set channel buffer capacity to 1 in replay_file fix byzantine_test unsubscribe from single event, not all events refactor httpclient to return events to appropriate channels return failing testReplayCrashBeforeWriteVote test fix TestValidatorSetChanges refactor code a bit fix testReplayCrashBeforeWriteVote add comment fix TestValidatorSetChanges fixes from Bucky's review update comment [ci skip] test TxEventBuffer update changelog fix TestValidatorSetChanges (2nd attempt) only do wg.Done when no errors benchmark event bus create pubsub server inside NewEventBus only expose config params (later if needed) set buffer capacity to 0 so we are not testing cache new tx event format: key = "Tx" plus a tag {"tx.hash": XYZ} This should allow to subscribe to all transactions! or a specific one using a query: "tm.events.type = Tx and tx.hash = '013ABF99434...'" use TimeoutCommit instead of afterPublishEventNewBlockTimeout TimeoutCommit is the time a node waits after committing a block, before it goes into the next height. So it will finish everything from the last block, but then wait a bit. The idea is this gives it time to hear more votes from other validators, to strengthen the commit it includes in the next block. But it also gives it time to hear about new transactions. waitForBlockWithUpdatedVals rewrite WAL crash tests Task: test that we can recover from any WAL crash. Solution: the old tests were relying on event hub being run in the same thread (we were injecting the private validator's last signature). when considering a rewrite, we considered two possible solutions: write a "fuzzy" testing system where WAL is crashing upon receiving a new message, or inject failures and trigger them in tests using something like https://github.com/coreos/gofail. remove sleep no cs.Lock around wal.Save test different cases (empty block, non-empty block, ...) comments add comments test 4 cases: empty block, non-empty block, non-empty block with smaller part size, many blocks fixes as per Bucky's last review reset subscriptions on UnsubscribeAll use a simple counter to track message for which we panicked also, set a smaller part size for all test cases
7 years ago
10 years ago
9 years ago
10 years ago
8 years ago
new pubsub package comment out failing consensus tests for now rewrite rpc httpclient to use new pubsub package import pubsub as tmpubsub, query as tmquery make event IDs constants EventKey -> EventTypeKey rename EventsPubsub to PubSub mempool does not use pubsub rename eventsSub to pubsub new subscribe API fix channel size issues and consensus tests bugs refactor rpc client add missing discardFromChan method add mutex rename pubsub to eventBus remove IsRunning from WSRPCConnection interface (not needed) add a comment in broadcastNewRoundStepsAndVotes rename registerEventCallbacks to broadcastNewRoundStepsAndVotes See https://dave.cheney.net/2014/03/19/channel-axioms stop eventBuses after reactor tests remove unnecessary Unsubscribe return subscribe helper function move discardFromChan to where it is used subscribe now returns an err this gives us ability to refuse to subscribe if pubsub is at its max capacity. use context for control overflow cache queries handle err when subscribing in replay_test rename testClientID to testSubscriber extract var set channel buffer capacity to 1 in replay_file fix byzantine_test unsubscribe from single event, not all events refactor httpclient to return events to appropriate channels return failing testReplayCrashBeforeWriteVote test fix TestValidatorSetChanges refactor code a bit fix testReplayCrashBeforeWriteVote add comment fix TestValidatorSetChanges fixes from Bucky's review update comment [ci skip] test TxEventBuffer update changelog fix TestValidatorSetChanges (2nd attempt) only do wg.Done when no errors benchmark event bus create pubsub server inside NewEventBus only expose config params (later if needed) set buffer capacity to 0 so we are not testing cache new tx event format: key = "Tx" plus a tag {"tx.hash": XYZ} This should allow to subscribe to all transactions! or a specific one using a query: "tm.events.type = Tx and tx.hash = '013ABF99434...'" use TimeoutCommit instead of afterPublishEventNewBlockTimeout TimeoutCommit is the time a node waits after committing a block, before it goes into the next height. So it will finish everything from the last block, but then wait a bit. The idea is this gives it time to hear more votes from other validators, to strengthen the commit it includes in the next block. But it also gives it time to hear about new transactions. waitForBlockWithUpdatedVals rewrite WAL crash tests Task: test that we can recover from any WAL crash. Solution: the old tests were relying on event hub being run in the same thread (we were injecting the private validator's last signature). when considering a rewrite, we considered two possible solutions: write a "fuzzy" testing system where WAL is crashing upon receiving a new message, or inject failures and trigger them in tests using something like https://github.com/coreos/gofail. remove sleep no cs.Lock around wal.Save test different cases (empty block, non-empty block, ...) comments add comments test 4 cases: empty block, non-empty block, non-empty block with smaller part size, many blocks fixes as per Bucky's last review reset subscriptions on UnsubscribeAll use a simple counter to track message for which we panicked also, set a smaller part size for all test cases
7 years ago
10 years ago
10 years ago
new pubsub package comment out failing consensus tests for now rewrite rpc httpclient to use new pubsub package import pubsub as tmpubsub, query as tmquery make event IDs constants EventKey -> EventTypeKey rename EventsPubsub to PubSub mempool does not use pubsub rename eventsSub to pubsub new subscribe API fix channel size issues and consensus tests bugs refactor rpc client add missing discardFromChan method add mutex rename pubsub to eventBus remove IsRunning from WSRPCConnection interface (not needed) add a comment in broadcastNewRoundStepsAndVotes rename registerEventCallbacks to broadcastNewRoundStepsAndVotes See https://dave.cheney.net/2014/03/19/channel-axioms stop eventBuses after reactor tests remove unnecessary Unsubscribe return subscribe helper function move discardFromChan to where it is used subscribe now returns an err this gives us ability to refuse to subscribe if pubsub is at its max capacity. use context for control overflow cache queries handle err when subscribing in replay_test rename testClientID to testSubscriber extract var set channel buffer capacity to 1 in replay_file fix byzantine_test unsubscribe from single event, not all events refactor httpclient to return events to appropriate channels return failing testReplayCrashBeforeWriteVote test fix TestValidatorSetChanges refactor code a bit fix testReplayCrashBeforeWriteVote add comment fix TestValidatorSetChanges fixes from Bucky's review update comment [ci skip] test TxEventBuffer update changelog fix TestValidatorSetChanges (2nd attempt) only do wg.Done when no errors benchmark event bus create pubsub server inside NewEventBus only expose config params (later if needed) set buffer capacity to 0 so we are not testing cache new tx event format: key = "Tx" plus a tag {"tx.hash": XYZ} This should allow to subscribe to all transactions! or a specific one using a query: "tm.events.type = Tx and tx.hash = '013ABF99434...'" use TimeoutCommit instead of afterPublishEventNewBlockTimeout TimeoutCommit is the time a node waits after committing a block, before it goes into the next height. So it will finish everything from the last block, but then wait a bit. The idea is this gives it time to hear more votes from other validators, to strengthen the commit it includes in the next block. But it also gives it time to hear about new transactions. waitForBlockWithUpdatedVals rewrite WAL crash tests Task: test that we can recover from any WAL crash. Solution: the old tests were relying on event hub being run in the same thread (we were injecting the private validator's last signature). when considering a rewrite, we considered two possible solutions: write a "fuzzy" testing system where WAL is crashing upon receiving a new message, or inject failures and trigger them in tests using something like https://github.com/coreos/gofail. remove sleep no cs.Lock around wal.Save test different cases (empty block, non-empty block, ...) comments add comments test 4 cases: empty block, non-empty block, non-empty block with smaller part size, many blocks fixes as per Bucky's last review reset subscriptions on UnsubscribeAll use a simple counter to track message for which we panicked also, set a smaller part size for all test cases
7 years ago
new pubsub package comment out failing consensus tests for now rewrite rpc httpclient to use new pubsub package import pubsub as tmpubsub, query as tmquery make event IDs constants EventKey -> EventTypeKey rename EventsPubsub to PubSub mempool does not use pubsub rename eventsSub to pubsub new subscribe API fix channel size issues and consensus tests bugs refactor rpc client add missing discardFromChan method add mutex rename pubsub to eventBus remove IsRunning from WSRPCConnection interface (not needed) add a comment in broadcastNewRoundStepsAndVotes rename registerEventCallbacks to broadcastNewRoundStepsAndVotes See https://dave.cheney.net/2014/03/19/channel-axioms stop eventBuses after reactor tests remove unnecessary Unsubscribe return subscribe helper function move discardFromChan to where it is used subscribe now returns an err this gives us ability to refuse to subscribe if pubsub is at its max capacity. use context for control overflow cache queries handle err when subscribing in replay_test rename testClientID to testSubscriber extract var set channel buffer capacity to 1 in replay_file fix byzantine_test unsubscribe from single event, not all events refactor httpclient to return events to appropriate channels return failing testReplayCrashBeforeWriteVote test fix TestValidatorSetChanges refactor code a bit fix testReplayCrashBeforeWriteVote add comment fix TestValidatorSetChanges fixes from Bucky's review update comment [ci skip] test TxEventBuffer update changelog fix TestValidatorSetChanges (2nd attempt) only do wg.Done when no errors benchmark event bus create pubsub server inside NewEventBus only expose config params (later if needed) set buffer capacity to 0 so we are not testing cache new tx event format: key = "Tx" plus a tag {"tx.hash": XYZ} This should allow to subscribe to all transactions! or a specific one using a query: "tm.events.type = Tx and tx.hash = '013ABF99434...'" use TimeoutCommit instead of afterPublishEventNewBlockTimeout TimeoutCommit is the time a node waits after committing a block, before it goes into the next height. So it will finish everything from the last block, but then wait a bit. The idea is this gives it time to hear more votes from other validators, to strengthen the commit it includes in the next block. But it also gives it time to hear about new transactions. waitForBlockWithUpdatedVals rewrite WAL crash tests Task: test that we can recover from any WAL crash. Solution: the old tests were relying on event hub being run in the same thread (we were injecting the private validator's last signature). when considering a rewrite, we considered two possible solutions: write a "fuzzy" testing system where WAL is crashing upon receiving a new message, or inject failures and trigger them in tests using something like https://github.com/coreos/gofail. remove sleep no cs.Lock around wal.Save test different cases (empty block, non-empty block, ...) comments add comments test 4 cases: empty block, non-empty block, non-empty block with smaller part size, many blocks fixes as per Bucky's last review reset subscriptions on UnsubscribeAll use a simple counter to track message for which we panicked also, set a smaller part size for all test cases
7 years ago
10 years ago
8 years ago
new pubsub package comment out failing consensus tests for now rewrite rpc httpclient to use new pubsub package import pubsub as tmpubsub, query as tmquery make event IDs constants EventKey -> EventTypeKey rename EventsPubsub to PubSub mempool does not use pubsub rename eventsSub to pubsub new subscribe API fix channel size issues and consensus tests bugs refactor rpc client add missing discardFromChan method add mutex rename pubsub to eventBus remove IsRunning from WSRPCConnection interface (not needed) add a comment in broadcastNewRoundStepsAndVotes rename registerEventCallbacks to broadcastNewRoundStepsAndVotes See https://dave.cheney.net/2014/03/19/channel-axioms stop eventBuses after reactor tests remove unnecessary Unsubscribe return subscribe helper function move discardFromChan to where it is used subscribe now returns an err this gives us ability to refuse to subscribe if pubsub is at its max capacity. use context for control overflow cache queries handle err when subscribing in replay_test rename testClientID to testSubscriber extract var set channel buffer capacity to 1 in replay_file fix byzantine_test unsubscribe from single event, not all events refactor httpclient to return events to appropriate channels return failing testReplayCrashBeforeWriteVote test fix TestValidatorSetChanges refactor code a bit fix testReplayCrashBeforeWriteVote add comment fix TestValidatorSetChanges fixes from Bucky's review update comment [ci skip] test TxEventBuffer update changelog fix TestValidatorSetChanges (2nd attempt) only do wg.Done when no errors benchmark event bus create pubsub server inside NewEventBus only expose config params (later if needed) set buffer capacity to 0 so we are not testing cache new tx event format: key = "Tx" plus a tag {"tx.hash": XYZ} This should allow to subscribe to all transactions! or a specific one using a query: "tm.events.type = Tx and tx.hash = '013ABF99434...'" use TimeoutCommit instead of afterPublishEventNewBlockTimeout TimeoutCommit is the time a node waits after committing a block, before it goes into the next height. So it will finish everything from the last block, but then wait a bit. The idea is this gives it time to hear more votes from other validators, to strengthen the commit it includes in the next block. But it also gives it time to hear about new transactions. waitForBlockWithUpdatedVals rewrite WAL crash tests Task: test that we can recover from any WAL crash. Solution: the old tests were relying on event hub being run in the same thread (we were injecting the private validator's last signature). when considering a rewrite, we considered two possible solutions: write a "fuzzy" testing system where WAL is crashing upon receiving a new message, or inject failures and trigger them in tests using something like https://github.com/coreos/gofail. remove sleep no cs.Lock around wal.Save test different cases (empty block, non-empty block, ...) comments add comments test 4 cases: empty block, non-empty block, non-empty block with smaller part size, many blocks fixes as per Bucky's last review reset subscriptions on UnsubscribeAll use a simple counter to track message for which we panicked also, set a smaller part size for all test cases
7 years ago
new pubsub package comment out failing consensus tests for now rewrite rpc httpclient to use new pubsub package import pubsub as tmpubsub, query as tmquery make event IDs constants EventKey -> EventTypeKey rename EventsPubsub to PubSub mempool does not use pubsub rename eventsSub to pubsub new subscribe API fix channel size issues and consensus tests bugs refactor rpc client add missing discardFromChan method add mutex rename pubsub to eventBus remove IsRunning from WSRPCConnection interface (not needed) add a comment in broadcastNewRoundStepsAndVotes rename registerEventCallbacks to broadcastNewRoundStepsAndVotes See https://dave.cheney.net/2014/03/19/channel-axioms stop eventBuses after reactor tests remove unnecessary Unsubscribe return subscribe helper function move discardFromChan to where it is used subscribe now returns an err this gives us ability to refuse to subscribe if pubsub is at its max capacity. use context for control overflow cache queries handle err when subscribing in replay_test rename testClientID to testSubscriber extract var set channel buffer capacity to 1 in replay_file fix byzantine_test unsubscribe from single event, not all events refactor httpclient to return events to appropriate channels return failing testReplayCrashBeforeWriteVote test fix TestValidatorSetChanges refactor code a bit fix testReplayCrashBeforeWriteVote add comment fix TestValidatorSetChanges fixes from Bucky's review update comment [ci skip] test TxEventBuffer update changelog fix TestValidatorSetChanges (2nd attempt) only do wg.Done when no errors benchmark event bus create pubsub server inside NewEventBus only expose config params (later if needed) set buffer capacity to 0 so we are not testing cache new tx event format: key = "Tx" plus a tag {"tx.hash": XYZ} This should allow to subscribe to all transactions! or a specific one using a query: "tm.events.type = Tx and tx.hash = '013ABF99434...'" use TimeoutCommit instead of afterPublishEventNewBlockTimeout TimeoutCommit is the time a node waits after committing a block, before it goes into the next height. So it will finish everything from the last block, but then wait a bit. The idea is this gives it time to hear more votes from other validators, to strengthen the commit it includes in the next block. But it also gives it time to hear about new transactions. waitForBlockWithUpdatedVals rewrite WAL crash tests Task: test that we can recover from any WAL crash. Solution: the old tests were relying on event hub being run in the same thread (we were injecting the private validator's last signature). when considering a rewrite, we considered two possible solutions: write a "fuzzy" testing system where WAL is crashing upon receiving a new message, or inject failures and trigger them in tests using something like https://github.com/coreos/gofail. remove sleep no cs.Lock around wal.Save test different cases (empty block, non-empty block, ...) comments add comments test 4 cases: empty block, non-empty block, non-empty block with smaller part size, many blocks fixes as per Bucky's last review reset subscriptions on UnsubscribeAll use a simple counter to track message for which we panicked also, set a smaller part size for all test cases
7 years ago
new pubsub package comment out failing consensus tests for now rewrite rpc httpclient to use new pubsub package import pubsub as tmpubsub, query as tmquery make event IDs constants EventKey -> EventTypeKey rename EventsPubsub to PubSub mempool does not use pubsub rename eventsSub to pubsub new subscribe API fix channel size issues and consensus tests bugs refactor rpc client add missing discardFromChan method add mutex rename pubsub to eventBus remove IsRunning from WSRPCConnection interface (not needed) add a comment in broadcastNewRoundStepsAndVotes rename registerEventCallbacks to broadcastNewRoundStepsAndVotes See https://dave.cheney.net/2014/03/19/channel-axioms stop eventBuses after reactor tests remove unnecessary Unsubscribe return subscribe helper function move discardFromChan to where it is used subscribe now returns an err this gives us ability to refuse to subscribe if pubsub is at its max capacity. use context for control overflow cache queries handle err when subscribing in replay_test rename testClientID to testSubscriber extract var set channel buffer capacity to 1 in replay_file fix byzantine_test unsubscribe from single event, not all events refactor httpclient to return events to appropriate channels return failing testReplayCrashBeforeWriteVote test fix TestValidatorSetChanges refactor code a bit fix testReplayCrashBeforeWriteVote add comment fix TestValidatorSetChanges fixes from Bucky's review update comment [ci skip] test TxEventBuffer update changelog fix TestValidatorSetChanges (2nd attempt) only do wg.Done when no errors benchmark event bus create pubsub server inside NewEventBus only expose config params (later if needed) set buffer capacity to 0 so we are not testing cache new tx event format: key = "Tx" plus a tag {"tx.hash": XYZ} This should allow to subscribe to all transactions! or a specific one using a query: "tm.events.type = Tx and tx.hash = '013ABF99434...'" use TimeoutCommit instead of afterPublishEventNewBlockTimeout TimeoutCommit is the time a node waits after committing a block, before it goes into the next height. So it will finish everything from the last block, but then wait a bit. The idea is this gives it time to hear more votes from other validators, to strengthen the commit it includes in the next block. But it also gives it time to hear about new transactions. waitForBlockWithUpdatedVals rewrite WAL crash tests Task: test that we can recover from any WAL crash. Solution: the old tests were relying on event hub being run in the same thread (we were injecting the private validator's last signature). when considering a rewrite, we considered two possible solutions: write a "fuzzy" testing system where WAL is crashing upon receiving a new message, or inject failures and trigger them in tests using something like https://github.com/coreos/gofail. remove sleep no cs.Lock around wal.Save test different cases (empty block, non-empty block, ...) comments add comments test 4 cases: empty block, non-empty block, non-empty block with smaller part size, many blocks fixes as per Bucky's last review reset subscriptions on UnsubscribeAll use a simple counter to track message for which we panicked also, set a smaller part size for all test cases
7 years ago
new pubsub package comment out failing consensus tests for now rewrite rpc httpclient to use new pubsub package import pubsub as tmpubsub, query as tmquery make event IDs constants EventKey -> EventTypeKey rename EventsPubsub to PubSub mempool does not use pubsub rename eventsSub to pubsub new subscribe API fix channel size issues and consensus tests bugs refactor rpc client add missing discardFromChan method add mutex rename pubsub to eventBus remove IsRunning from WSRPCConnection interface (not needed) add a comment in broadcastNewRoundStepsAndVotes rename registerEventCallbacks to broadcastNewRoundStepsAndVotes See https://dave.cheney.net/2014/03/19/channel-axioms stop eventBuses after reactor tests remove unnecessary Unsubscribe return subscribe helper function move discardFromChan to where it is used subscribe now returns an err this gives us ability to refuse to subscribe if pubsub is at its max capacity. use context for control overflow cache queries handle err when subscribing in replay_test rename testClientID to testSubscriber extract var set channel buffer capacity to 1 in replay_file fix byzantine_test unsubscribe from single event, not all events refactor httpclient to return events to appropriate channels return failing testReplayCrashBeforeWriteVote test fix TestValidatorSetChanges refactor code a bit fix testReplayCrashBeforeWriteVote add comment fix TestValidatorSetChanges fixes from Bucky's review update comment [ci skip] test TxEventBuffer update changelog fix TestValidatorSetChanges (2nd attempt) only do wg.Done when no errors benchmark event bus create pubsub server inside NewEventBus only expose config params (later if needed) set buffer capacity to 0 so we are not testing cache new tx event format: key = "Tx" plus a tag {"tx.hash": XYZ} This should allow to subscribe to all transactions! or a specific one using a query: "tm.events.type = Tx and tx.hash = '013ABF99434...'" use TimeoutCommit instead of afterPublishEventNewBlockTimeout TimeoutCommit is the time a node waits after committing a block, before it goes into the next height. So it will finish everything from the last block, but then wait a bit. The idea is this gives it time to hear more votes from other validators, to strengthen the commit it includes in the next block. But it also gives it time to hear about new transactions. waitForBlockWithUpdatedVals rewrite WAL crash tests Task: test that we can recover from any WAL crash. Solution: the old tests were relying on event hub being run in the same thread (we were injecting the private validator's last signature). when considering a rewrite, we considered two possible solutions: write a "fuzzy" testing system where WAL is crashing upon receiving a new message, or inject failures and trigger them in tests using something like https://github.com/coreos/gofail. remove sleep no cs.Lock around wal.Save test different cases (empty block, non-empty block, ...) comments add comments test 4 cases: empty block, non-empty block, non-empty block with smaller part size, many blocks fixes as per Bucky's last review reset subscriptions on UnsubscribeAll use a simple counter to track message for which we panicked also, set a smaller part size for all test cases
7 years ago
9 years ago
9 years ago
8 years ago
9 years ago
8 years ago
8 years ago
new pubsub package comment out failing consensus tests for now rewrite rpc httpclient to use new pubsub package import pubsub as tmpubsub, query as tmquery make event IDs constants EventKey -> EventTypeKey rename EventsPubsub to PubSub mempool does not use pubsub rename eventsSub to pubsub new subscribe API fix channel size issues and consensus tests bugs refactor rpc client add missing discardFromChan method add mutex rename pubsub to eventBus remove IsRunning from WSRPCConnection interface (not needed) add a comment in broadcastNewRoundStepsAndVotes rename registerEventCallbacks to broadcastNewRoundStepsAndVotes See https://dave.cheney.net/2014/03/19/channel-axioms stop eventBuses after reactor tests remove unnecessary Unsubscribe return subscribe helper function move discardFromChan to where it is used subscribe now returns an err this gives us ability to refuse to subscribe if pubsub is at its max capacity. use context for control overflow cache queries handle err when subscribing in replay_test rename testClientID to testSubscriber extract var set channel buffer capacity to 1 in replay_file fix byzantine_test unsubscribe from single event, not all events refactor httpclient to return events to appropriate channels return failing testReplayCrashBeforeWriteVote test fix TestValidatorSetChanges refactor code a bit fix testReplayCrashBeforeWriteVote add comment fix TestValidatorSetChanges fixes from Bucky's review update comment [ci skip] test TxEventBuffer update changelog fix TestValidatorSetChanges (2nd attempt) only do wg.Done when no errors benchmark event bus create pubsub server inside NewEventBus only expose config params (later if needed) set buffer capacity to 0 so we are not testing cache new tx event format: key = "Tx" plus a tag {"tx.hash": XYZ} This should allow to subscribe to all transactions! or a specific one using a query: "tm.events.type = Tx and tx.hash = '013ABF99434...'" use TimeoutCommit instead of afterPublishEventNewBlockTimeout TimeoutCommit is the time a node waits after committing a block, before it goes into the next height. So it will finish everything from the last block, but then wait a bit. The idea is this gives it time to hear more votes from other validators, to strengthen the commit it includes in the next block. But it also gives it time to hear about new transactions. waitForBlockWithUpdatedVals rewrite WAL crash tests Task: test that we can recover from any WAL crash. Solution: the old tests were relying on event hub being run in the same thread (we were injecting the private validator's last signature). when considering a rewrite, we considered two possible solutions: write a "fuzzy" testing system where WAL is crashing upon receiving a new message, or inject failures and trigger them in tests using something like https://github.com/coreos/gofail. remove sleep no cs.Lock around wal.Save test different cases (empty block, non-empty block, ...) comments add comments test 4 cases: empty block, non-empty block, non-empty block with smaller part size, many blocks fixes as per Bucky's last review reset subscriptions on UnsubscribeAll use a simple counter to track message for which we panicked also, set a smaller part size for all test cases
7 years ago
new pubsub package comment out failing consensus tests for now rewrite rpc httpclient to use new pubsub package import pubsub as tmpubsub, query as tmquery make event IDs constants EventKey -> EventTypeKey rename EventsPubsub to PubSub mempool does not use pubsub rename eventsSub to pubsub new subscribe API fix channel size issues and consensus tests bugs refactor rpc client add missing discardFromChan method add mutex rename pubsub to eventBus remove IsRunning from WSRPCConnection interface (not needed) add a comment in broadcastNewRoundStepsAndVotes rename registerEventCallbacks to broadcastNewRoundStepsAndVotes See https://dave.cheney.net/2014/03/19/channel-axioms stop eventBuses after reactor tests remove unnecessary Unsubscribe return subscribe helper function move discardFromChan to where it is used subscribe now returns an err this gives us ability to refuse to subscribe if pubsub is at its max capacity. use context for control overflow cache queries handle err when subscribing in replay_test rename testClientID to testSubscriber extract var set channel buffer capacity to 1 in replay_file fix byzantine_test unsubscribe from single event, not all events refactor httpclient to return events to appropriate channels return failing testReplayCrashBeforeWriteVote test fix TestValidatorSetChanges refactor code a bit fix testReplayCrashBeforeWriteVote add comment fix TestValidatorSetChanges fixes from Bucky's review update comment [ci skip] test TxEventBuffer update changelog fix TestValidatorSetChanges (2nd attempt) only do wg.Done when no errors benchmark event bus create pubsub server inside NewEventBus only expose config params (later if needed) set buffer capacity to 0 so we are not testing cache new tx event format: key = "Tx" plus a tag {"tx.hash": XYZ} This should allow to subscribe to all transactions! or a specific one using a query: "tm.events.type = Tx and tx.hash = '013ABF99434...'" use TimeoutCommit instead of afterPublishEventNewBlockTimeout TimeoutCommit is the time a node waits after committing a block, before it goes into the next height. So it will finish everything from the last block, but then wait a bit. The idea is this gives it time to hear more votes from other validators, to strengthen the commit it includes in the next block. But it also gives it time to hear about new transactions. waitForBlockWithUpdatedVals rewrite WAL crash tests Task: test that we can recover from any WAL crash. Solution: the old tests were relying on event hub being run in the same thread (we were injecting the private validator's last signature). when considering a rewrite, we considered two possible solutions: write a "fuzzy" testing system where WAL is crashing upon receiving a new message, or inject failures and trigger them in tests using something like https://github.com/coreos/gofail. remove sleep no cs.Lock around wal.Save test different cases (empty block, non-empty block, ...) comments add comments test 4 cases: empty block, non-empty block, non-empty block with smaller part size, many blocks fixes as per Bucky's last review reset subscriptions on UnsubscribeAll use a simple counter to track message for which we panicked also, set a smaller part size for all test cases
7 years ago
8 years ago
8 years ago
8 years ago
8 years ago
new pubsub package comment out failing consensus tests for now rewrite rpc httpclient to use new pubsub package import pubsub as tmpubsub, query as tmquery make event IDs constants EventKey -> EventTypeKey rename EventsPubsub to PubSub mempool does not use pubsub rename eventsSub to pubsub new subscribe API fix channel size issues and consensus tests bugs refactor rpc client add missing discardFromChan method add mutex rename pubsub to eventBus remove IsRunning from WSRPCConnection interface (not needed) add a comment in broadcastNewRoundStepsAndVotes rename registerEventCallbacks to broadcastNewRoundStepsAndVotes See https://dave.cheney.net/2014/03/19/channel-axioms stop eventBuses after reactor tests remove unnecessary Unsubscribe return subscribe helper function move discardFromChan to where it is used subscribe now returns an err this gives us ability to refuse to subscribe if pubsub is at its max capacity. use context for control overflow cache queries handle err when subscribing in replay_test rename testClientID to testSubscriber extract var set channel buffer capacity to 1 in replay_file fix byzantine_test unsubscribe from single event, not all events refactor httpclient to return events to appropriate channels return failing testReplayCrashBeforeWriteVote test fix TestValidatorSetChanges refactor code a bit fix testReplayCrashBeforeWriteVote add comment fix TestValidatorSetChanges fixes from Bucky's review update comment [ci skip] test TxEventBuffer update changelog fix TestValidatorSetChanges (2nd attempt) only do wg.Done when no errors benchmark event bus create pubsub server inside NewEventBus only expose config params (later if needed) set buffer capacity to 0 so we are not testing cache new tx event format: key = "Tx" plus a tag {"tx.hash": XYZ} This should allow to subscribe to all transactions! or a specific one using a query: "tm.events.type = Tx and tx.hash = '013ABF99434...'" use TimeoutCommit instead of afterPublishEventNewBlockTimeout TimeoutCommit is the time a node waits after committing a block, before it goes into the next height. So it will finish everything from the last block, but then wait a bit. The idea is this gives it time to hear more votes from other validators, to strengthen the commit it includes in the next block. But it also gives it time to hear about new transactions. waitForBlockWithUpdatedVals rewrite WAL crash tests Task: test that we can recover from any WAL crash. Solution: the old tests were relying on event hub being run in the same thread (we were injecting the private validator's last signature). when considering a rewrite, we considered two possible solutions: write a "fuzzy" testing system where WAL is crashing upon receiving a new message, or inject failures and trigger them in tests using something like https://github.com/coreos/gofail. remove sleep no cs.Lock around wal.Save test different cases (empty block, non-empty block, ...) comments add comments test 4 cases: empty block, non-empty block, non-empty block with smaller part size, many blocks fixes as per Bucky's last review reset subscriptions on UnsubscribeAll use a simple counter to track message for which we panicked also, set a smaller part size for all test cases
7 years ago
new pubsub package comment out failing consensus tests for now rewrite rpc httpclient to use new pubsub package import pubsub as tmpubsub, query as tmquery make event IDs constants EventKey -> EventTypeKey rename EventsPubsub to PubSub mempool does not use pubsub rename eventsSub to pubsub new subscribe API fix channel size issues and consensus tests bugs refactor rpc client add missing discardFromChan method add mutex rename pubsub to eventBus remove IsRunning from WSRPCConnection interface (not needed) add a comment in broadcastNewRoundStepsAndVotes rename registerEventCallbacks to broadcastNewRoundStepsAndVotes See https://dave.cheney.net/2014/03/19/channel-axioms stop eventBuses after reactor tests remove unnecessary Unsubscribe return subscribe helper function move discardFromChan to where it is used subscribe now returns an err this gives us ability to refuse to subscribe if pubsub is at its max capacity. use context for control overflow cache queries handle err when subscribing in replay_test rename testClientID to testSubscriber extract var set channel buffer capacity to 1 in replay_file fix byzantine_test unsubscribe from single event, not all events refactor httpclient to return events to appropriate channels return failing testReplayCrashBeforeWriteVote test fix TestValidatorSetChanges refactor code a bit fix testReplayCrashBeforeWriteVote add comment fix TestValidatorSetChanges fixes from Bucky's review update comment [ci skip] test TxEventBuffer update changelog fix TestValidatorSetChanges (2nd attempt) only do wg.Done when no errors benchmark event bus create pubsub server inside NewEventBus only expose config params (later if needed) set buffer capacity to 0 so we are not testing cache new tx event format: key = "Tx" plus a tag {"tx.hash": XYZ} This should allow to subscribe to all transactions! or a specific one using a query: "tm.events.type = Tx and tx.hash = '013ABF99434...'" use TimeoutCommit instead of afterPublishEventNewBlockTimeout TimeoutCommit is the time a node waits after committing a block, before it goes into the next height. So it will finish everything from the last block, but then wait a bit. The idea is this gives it time to hear more votes from other validators, to strengthen the commit it includes in the next block. But it also gives it time to hear about new transactions. waitForBlockWithUpdatedVals rewrite WAL crash tests Task: test that we can recover from any WAL crash. Solution: the old tests were relying on event hub being run in the same thread (we were injecting the private validator's last signature). when considering a rewrite, we considered two possible solutions: write a "fuzzy" testing system where WAL is crashing upon receiving a new message, or inject failures and trigger them in tests using something like https://github.com/coreos/gofail. remove sleep no cs.Lock around wal.Save test different cases (empty block, non-empty block, ...) comments add comments test 4 cases: empty block, non-empty block, non-empty block with smaller part size, many blocks fixes as per Bucky's last review reset subscriptions on UnsubscribeAll use a simple counter to track message for which we panicked also, set a smaller part size for all test cases
7 years ago
new pubsub package comment out failing consensus tests for now rewrite rpc httpclient to use new pubsub package import pubsub as tmpubsub, query as tmquery make event IDs constants EventKey -> EventTypeKey rename EventsPubsub to PubSub mempool does not use pubsub rename eventsSub to pubsub new subscribe API fix channel size issues and consensus tests bugs refactor rpc client add missing discardFromChan method add mutex rename pubsub to eventBus remove IsRunning from WSRPCConnection interface (not needed) add a comment in broadcastNewRoundStepsAndVotes rename registerEventCallbacks to broadcastNewRoundStepsAndVotes See https://dave.cheney.net/2014/03/19/channel-axioms stop eventBuses after reactor tests remove unnecessary Unsubscribe return subscribe helper function move discardFromChan to where it is used subscribe now returns an err this gives us ability to refuse to subscribe if pubsub is at its max capacity. use context for control overflow cache queries handle err when subscribing in replay_test rename testClientID to testSubscriber extract var set channel buffer capacity to 1 in replay_file fix byzantine_test unsubscribe from single event, not all events refactor httpclient to return events to appropriate channels return failing testReplayCrashBeforeWriteVote test fix TestValidatorSetChanges refactor code a bit fix testReplayCrashBeforeWriteVote add comment fix TestValidatorSetChanges fixes from Bucky's review update comment [ci skip] test TxEventBuffer update changelog fix TestValidatorSetChanges (2nd attempt) only do wg.Done when no errors benchmark event bus create pubsub server inside NewEventBus only expose config params (later if needed) set buffer capacity to 0 so we are not testing cache new tx event format: key = "Tx" plus a tag {"tx.hash": XYZ} This should allow to subscribe to all transactions! or a specific one using a query: "tm.events.type = Tx and tx.hash = '013ABF99434...'" use TimeoutCommit instead of afterPublishEventNewBlockTimeout TimeoutCommit is the time a node waits after committing a block, before it goes into the next height. So it will finish everything from the last block, but then wait a bit. The idea is this gives it time to hear more votes from other validators, to strengthen the commit it includes in the next block. But it also gives it time to hear about new transactions. waitForBlockWithUpdatedVals rewrite WAL crash tests Task: test that we can recover from any WAL crash. Solution: the old tests were relying on event hub being run in the same thread (we were injecting the private validator's last signature). when considering a rewrite, we considered two possible solutions: write a "fuzzy" testing system where WAL is crashing upon receiving a new message, or inject failures and trigger them in tests using something like https://github.com/coreos/gofail. remove sleep no cs.Lock around wal.Save test different cases (empty block, non-empty block, ...) comments add comments test 4 cases: empty block, non-empty block, non-empty block with smaller part size, many blocks fixes as per Bucky's last review reset subscriptions on UnsubscribeAll use a simple counter to track message for which we panicked also, set a smaller part size for all test cases
7 years ago
8 years ago
10 years ago
8 years ago
10 years ago
8 years ago
10 years ago
10 years ago
new pubsub package comment out failing consensus tests for now rewrite rpc httpclient to use new pubsub package import pubsub as tmpubsub, query as tmquery make event IDs constants EventKey -> EventTypeKey rename EventsPubsub to PubSub mempool does not use pubsub rename eventsSub to pubsub new subscribe API fix channel size issues and consensus tests bugs refactor rpc client add missing discardFromChan method add mutex rename pubsub to eventBus remove IsRunning from WSRPCConnection interface (not needed) add a comment in broadcastNewRoundStepsAndVotes rename registerEventCallbacks to broadcastNewRoundStepsAndVotes See https://dave.cheney.net/2014/03/19/channel-axioms stop eventBuses after reactor tests remove unnecessary Unsubscribe return subscribe helper function move discardFromChan to where it is used subscribe now returns an err this gives us ability to refuse to subscribe if pubsub is at its max capacity. use context for control overflow cache queries handle err when subscribing in replay_test rename testClientID to testSubscriber extract var set channel buffer capacity to 1 in replay_file fix byzantine_test unsubscribe from single event, not all events refactor httpclient to return events to appropriate channels return failing testReplayCrashBeforeWriteVote test fix TestValidatorSetChanges refactor code a bit fix testReplayCrashBeforeWriteVote add comment fix TestValidatorSetChanges fixes from Bucky's review update comment [ci skip] test TxEventBuffer update changelog fix TestValidatorSetChanges (2nd attempt) only do wg.Done when no errors benchmark event bus create pubsub server inside NewEventBus only expose config params (later if needed) set buffer capacity to 0 so we are not testing cache new tx event format: key = "Tx" plus a tag {"tx.hash": XYZ} This should allow to subscribe to all transactions! or a specific one using a query: "tm.events.type = Tx and tx.hash = '013ABF99434...'" use TimeoutCommit instead of afterPublishEventNewBlockTimeout TimeoutCommit is the time a node waits after committing a block, before it goes into the next height. So it will finish everything from the last block, but then wait a bit. The idea is this gives it time to hear more votes from other validators, to strengthen the commit it includes in the next block. But it also gives it time to hear about new transactions. waitForBlockWithUpdatedVals rewrite WAL crash tests Task: test that we can recover from any WAL crash. Solution: the old tests were relying on event hub being run in the same thread (we were injecting the private validator's last signature). when considering a rewrite, we considered two possible solutions: write a "fuzzy" testing system where WAL is crashing upon receiving a new message, or inject failures and trigger them in tests using something like https://github.com/coreos/gofail. remove sleep no cs.Lock around wal.Save test different cases (empty block, non-empty block, ...) comments add comments test 4 cases: empty block, non-empty block, non-empty block with smaller part size, many blocks fixes as per Bucky's last review reset subscriptions on UnsubscribeAll use a simple counter to track message for which we panicked also, set a smaller part size for all test cases
7 years ago
7 years ago
7 years ago
7 years ago
7 years ago
7 years ago
7 years ago
7 years ago
new pubsub package comment out failing consensus tests for now rewrite rpc httpclient to use new pubsub package import pubsub as tmpubsub, query as tmquery make event IDs constants EventKey -> EventTypeKey rename EventsPubsub to PubSub mempool does not use pubsub rename eventsSub to pubsub new subscribe API fix channel size issues and consensus tests bugs refactor rpc client add missing discardFromChan method add mutex rename pubsub to eventBus remove IsRunning from WSRPCConnection interface (not needed) add a comment in broadcastNewRoundStepsAndVotes rename registerEventCallbacks to broadcastNewRoundStepsAndVotes See https://dave.cheney.net/2014/03/19/channel-axioms stop eventBuses after reactor tests remove unnecessary Unsubscribe return subscribe helper function move discardFromChan to where it is used subscribe now returns an err this gives us ability to refuse to subscribe if pubsub is at its max capacity. use context for control overflow cache queries handle err when subscribing in replay_test rename testClientID to testSubscriber extract var set channel buffer capacity to 1 in replay_file fix byzantine_test unsubscribe from single event, not all events refactor httpclient to return events to appropriate channels return failing testReplayCrashBeforeWriteVote test fix TestValidatorSetChanges refactor code a bit fix testReplayCrashBeforeWriteVote add comment fix TestValidatorSetChanges fixes from Bucky's review update comment [ci skip] test TxEventBuffer update changelog fix TestValidatorSetChanges (2nd attempt) only do wg.Done when no errors benchmark event bus create pubsub server inside NewEventBus only expose config params (later if needed) set buffer capacity to 0 so we are not testing cache new tx event format: key = "Tx" plus a tag {"tx.hash": XYZ} This should allow to subscribe to all transactions! or a specific one using a query: "tm.events.type = Tx and tx.hash = '013ABF99434...'" use TimeoutCommit instead of afterPublishEventNewBlockTimeout TimeoutCommit is the time a node waits after committing a block, before it goes into the next height. So it will finish everything from the last block, but then wait a bit. The idea is this gives it time to hear more votes from other validators, to strengthen the commit it includes in the next block. But it also gives it time to hear about new transactions. waitForBlockWithUpdatedVals rewrite WAL crash tests Task: test that we can recover from any WAL crash. Solution: the old tests were relying on event hub being run in the same thread (we were injecting the private validator's last signature). when considering a rewrite, we considered two possible solutions: write a "fuzzy" testing system where WAL is crashing upon receiving a new message, or inject failures and trigger them in tests using something like https://github.com/coreos/gofail. remove sleep no cs.Lock around wal.Save test different cases (empty block, non-empty block, ...) comments add comments test 4 cases: empty block, non-empty block, non-empty block with smaller part size, many blocks fixes as per Bucky's last review reset subscriptions on UnsubscribeAll use a simple counter to track message for which we panicked also, set a smaller part size for all test cases
7 years ago
7 years ago
7 years ago
10 years ago
8 years ago
8 years ago
10 years ago
8 years ago
8 years ago
10 years ago
10 years ago
10 years ago
8 years ago
10 years ago
10 years ago
10 years ago
8 years ago
7 years ago
10 years ago
8 years ago
new pubsub package comment out failing consensus tests for now rewrite rpc httpclient to use new pubsub package import pubsub as tmpubsub, query as tmquery make event IDs constants EventKey -> EventTypeKey rename EventsPubsub to PubSub mempool does not use pubsub rename eventsSub to pubsub new subscribe API fix channel size issues and consensus tests bugs refactor rpc client add missing discardFromChan method add mutex rename pubsub to eventBus remove IsRunning from WSRPCConnection interface (not needed) add a comment in broadcastNewRoundStepsAndVotes rename registerEventCallbacks to broadcastNewRoundStepsAndVotes See https://dave.cheney.net/2014/03/19/channel-axioms stop eventBuses after reactor tests remove unnecessary Unsubscribe return subscribe helper function move discardFromChan to where it is used subscribe now returns an err this gives us ability to refuse to subscribe if pubsub is at its max capacity. use context for control overflow cache queries handle err when subscribing in replay_test rename testClientID to testSubscriber extract var set channel buffer capacity to 1 in replay_file fix byzantine_test unsubscribe from single event, not all events refactor httpclient to return events to appropriate channels return failing testReplayCrashBeforeWriteVote test fix TestValidatorSetChanges refactor code a bit fix testReplayCrashBeforeWriteVote add comment fix TestValidatorSetChanges fixes from Bucky's review update comment [ci skip] test TxEventBuffer update changelog fix TestValidatorSetChanges (2nd attempt) only do wg.Done when no errors benchmark event bus create pubsub server inside NewEventBus only expose config params (later if needed) set buffer capacity to 0 so we are not testing cache new tx event format: key = "Tx" plus a tag {"tx.hash": XYZ} This should allow to subscribe to all transactions! or a specific one using a query: "tm.events.type = Tx and tx.hash = '013ABF99434...'" use TimeoutCommit instead of afterPublishEventNewBlockTimeout TimeoutCommit is the time a node waits after committing a block, before it goes into the next height. So it will finish everything from the last block, but then wait a bit. The idea is this gives it time to hear more votes from other validators, to strengthen the commit it includes in the next block. But it also gives it time to hear about new transactions. waitForBlockWithUpdatedVals rewrite WAL crash tests Task: test that we can recover from any WAL crash. Solution: the old tests were relying on event hub being run in the same thread (we were injecting the private validator's last signature). when considering a rewrite, we considered two possible solutions: write a "fuzzy" testing system where WAL is crashing upon receiving a new message, or inject failures and trigger them in tests using something like https://github.com/coreos/gofail. remove sleep no cs.Lock around wal.Save test different cases (empty block, non-empty block, ...) comments add comments test 4 cases: empty block, non-empty block, non-empty block with smaller part size, many blocks fixes as per Bucky's last review reset subscriptions on UnsubscribeAll use a simple counter to track message for which we panicked also, set a smaller part size for all test cases
7 years ago
8 years ago
10 years ago
10 years ago
10 years ago
10 years ago
10 years ago
10 years ago
10 years ago
7 years ago
8 years ago
8 years ago
8 years ago
10 years ago
8 years ago
10 years ago
10 years ago
8 years ago
8 years ago
10 years ago
10 years ago
new pubsub package comment out failing consensus tests for now rewrite rpc httpclient to use new pubsub package import pubsub as tmpubsub, query as tmquery make event IDs constants EventKey -> EventTypeKey rename EventsPubsub to PubSub mempool does not use pubsub rename eventsSub to pubsub new subscribe API fix channel size issues and consensus tests bugs refactor rpc client add missing discardFromChan method add mutex rename pubsub to eventBus remove IsRunning from WSRPCConnection interface (not needed) add a comment in broadcastNewRoundStepsAndVotes rename registerEventCallbacks to broadcastNewRoundStepsAndVotes See https://dave.cheney.net/2014/03/19/channel-axioms stop eventBuses after reactor tests remove unnecessary Unsubscribe return subscribe helper function move discardFromChan to where it is used subscribe now returns an err this gives us ability to refuse to subscribe if pubsub is at its max capacity. use context for control overflow cache queries handle err when subscribing in replay_test rename testClientID to testSubscriber extract var set channel buffer capacity to 1 in replay_file fix byzantine_test unsubscribe from single event, not all events refactor httpclient to return events to appropriate channels return failing testReplayCrashBeforeWriteVote test fix TestValidatorSetChanges refactor code a bit fix testReplayCrashBeforeWriteVote add comment fix TestValidatorSetChanges fixes from Bucky's review update comment [ci skip] test TxEventBuffer update changelog fix TestValidatorSetChanges (2nd attempt) only do wg.Done when no errors benchmark event bus create pubsub server inside NewEventBus only expose config params (later if needed) set buffer capacity to 0 so we are not testing cache new tx event format: key = "Tx" plus a tag {"tx.hash": XYZ} This should allow to subscribe to all transactions! or a specific one using a query: "tm.events.type = Tx and tx.hash = '013ABF99434...'" use TimeoutCommit instead of afterPublishEventNewBlockTimeout TimeoutCommit is the time a node waits after committing a block, before it goes into the next height. So it will finish everything from the last block, but then wait a bit. The idea is this gives it time to hear more votes from other validators, to strengthen the commit it includes in the next block. But it also gives it time to hear about new transactions. waitForBlockWithUpdatedVals rewrite WAL crash tests Task: test that we can recover from any WAL crash. Solution: the old tests were relying on event hub being run in the same thread (we were injecting the private validator's last signature). when considering a rewrite, we considered two possible solutions: write a "fuzzy" testing system where WAL is crashing upon receiving a new message, or inject failures and trigger them in tests using something like https://github.com/coreos/gofail. remove sleep no cs.Lock around wal.Save test different cases (empty block, non-empty block, ...) comments add comments test 4 cases: empty block, non-empty block, non-empty block with smaller part size, many blocks fixes as per Bucky's last review reset subscriptions on UnsubscribeAll use a simple counter to track message for which we panicked also, set a smaller part size for all test cases
7 years ago
8 years ago
8 years ago
new pubsub package comment out failing consensus tests for now rewrite rpc httpclient to use new pubsub package import pubsub as tmpubsub, query as tmquery make event IDs constants EventKey -> EventTypeKey rename EventsPubsub to PubSub mempool does not use pubsub rename eventsSub to pubsub new subscribe API fix channel size issues and consensus tests bugs refactor rpc client add missing discardFromChan method add mutex rename pubsub to eventBus remove IsRunning from WSRPCConnection interface (not needed) add a comment in broadcastNewRoundStepsAndVotes rename registerEventCallbacks to broadcastNewRoundStepsAndVotes See https://dave.cheney.net/2014/03/19/channel-axioms stop eventBuses after reactor tests remove unnecessary Unsubscribe return subscribe helper function move discardFromChan to where it is used subscribe now returns an err this gives us ability to refuse to subscribe if pubsub is at its max capacity. use context for control overflow cache queries handle err when subscribing in replay_test rename testClientID to testSubscriber extract var set channel buffer capacity to 1 in replay_file fix byzantine_test unsubscribe from single event, not all events refactor httpclient to return events to appropriate channels return failing testReplayCrashBeforeWriteVote test fix TestValidatorSetChanges refactor code a bit fix testReplayCrashBeforeWriteVote add comment fix TestValidatorSetChanges fixes from Bucky's review update comment [ci skip] test TxEventBuffer update changelog fix TestValidatorSetChanges (2nd attempt) only do wg.Done when no errors benchmark event bus create pubsub server inside NewEventBus only expose config params (later if needed) set buffer capacity to 0 so we are not testing cache new tx event format: key = "Tx" plus a tag {"tx.hash": XYZ} This should allow to subscribe to all transactions! or a specific one using a query: "tm.events.type = Tx and tx.hash = '013ABF99434...'" use TimeoutCommit instead of afterPublishEventNewBlockTimeout TimeoutCommit is the time a node waits after committing a block, before it goes into the next height. So it will finish everything from the last block, but then wait a bit. The idea is this gives it time to hear more votes from other validators, to strengthen the commit it includes in the next block. But it also gives it time to hear about new transactions. waitForBlockWithUpdatedVals rewrite WAL crash tests Task: test that we can recover from any WAL crash. Solution: the old tests were relying on event hub being run in the same thread (we were injecting the private validator's last signature). when considering a rewrite, we considered two possible solutions: write a "fuzzy" testing system where WAL is crashing upon receiving a new message, or inject failures and trigger them in tests using something like https://github.com/coreos/gofail. remove sleep no cs.Lock around wal.Save test different cases (empty block, non-empty block, ...) comments add comments test 4 cases: empty block, non-empty block, non-empty block with smaller part size, many blocks fixes as per Bucky's last review reset subscriptions on UnsubscribeAll use a simple counter to track message for which we panicked also, set a smaller part size for all test cases
7 years ago
10 years ago
10 years ago
8 years ago
new pubsub package comment out failing consensus tests for now rewrite rpc httpclient to use new pubsub package import pubsub as tmpubsub, query as tmquery make event IDs constants EventKey -> EventTypeKey rename EventsPubsub to PubSub mempool does not use pubsub rename eventsSub to pubsub new subscribe API fix channel size issues and consensus tests bugs refactor rpc client add missing discardFromChan method add mutex rename pubsub to eventBus remove IsRunning from WSRPCConnection interface (not needed) add a comment in broadcastNewRoundStepsAndVotes rename registerEventCallbacks to broadcastNewRoundStepsAndVotes See https://dave.cheney.net/2014/03/19/channel-axioms stop eventBuses after reactor tests remove unnecessary Unsubscribe return subscribe helper function move discardFromChan to where it is used subscribe now returns an err this gives us ability to refuse to subscribe if pubsub is at its max capacity. use context for control overflow cache queries handle err when subscribing in replay_test rename testClientID to testSubscriber extract var set channel buffer capacity to 1 in replay_file fix byzantine_test unsubscribe from single event, not all events refactor httpclient to return events to appropriate channels return failing testReplayCrashBeforeWriteVote test fix TestValidatorSetChanges refactor code a bit fix testReplayCrashBeforeWriteVote add comment fix TestValidatorSetChanges fixes from Bucky's review update comment [ci skip] test TxEventBuffer update changelog fix TestValidatorSetChanges (2nd attempt) only do wg.Done when no errors benchmark event bus create pubsub server inside NewEventBus only expose config params (later if needed) set buffer capacity to 0 so we are not testing cache new tx event format: key = "Tx" plus a tag {"tx.hash": XYZ} This should allow to subscribe to all transactions! or a specific one using a query: "tm.events.type = Tx and tx.hash = '013ABF99434...'" use TimeoutCommit instead of afterPublishEventNewBlockTimeout TimeoutCommit is the time a node waits after committing a block, before it goes into the next height. So it will finish everything from the last block, but then wait a bit. The idea is this gives it time to hear more votes from other validators, to strengthen the commit it includes in the next block. But it also gives it time to hear about new transactions. waitForBlockWithUpdatedVals rewrite WAL crash tests Task: test that we can recover from any WAL crash. Solution: the old tests were relying on event hub being run in the same thread (we were injecting the private validator's last signature). when considering a rewrite, we considered two possible solutions: write a "fuzzy" testing system where WAL is crashing upon receiving a new message, or inject failures and trigger them in tests using something like https://github.com/coreos/gofail. remove sleep no cs.Lock around wal.Save test different cases (empty block, non-empty block, ...) comments add comments test 4 cases: empty block, non-empty block, non-empty block with smaller part size, many blocks fixes as per Bucky's last review reset subscriptions on UnsubscribeAll use a simple counter to track message for which we panicked also, set a smaller part size for all test cases
7 years ago
10 years ago
10 years ago
8 years ago
new pubsub package comment out failing consensus tests for now rewrite rpc httpclient to use new pubsub package import pubsub as tmpubsub, query as tmquery make event IDs constants EventKey -> EventTypeKey rename EventsPubsub to PubSub mempool does not use pubsub rename eventsSub to pubsub new subscribe API fix channel size issues and consensus tests bugs refactor rpc client add missing discardFromChan method add mutex rename pubsub to eventBus remove IsRunning from WSRPCConnection interface (not needed) add a comment in broadcastNewRoundStepsAndVotes rename registerEventCallbacks to broadcastNewRoundStepsAndVotes See https://dave.cheney.net/2014/03/19/channel-axioms stop eventBuses after reactor tests remove unnecessary Unsubscribe return subscribe helper function move discardFromChan to where it is used subscribe now returns an err this gives us ability to refuse to subscribe if pubsub is at its max capacity. use context for control overflow cache queries handle err when subscribing in replay_test rename testClientID to testSubscriber extract var set channel buffer capacity to 1 in replay_file fix byzantine_test unsubscribe from single event, not all events refactor httpclient to return events to appropriate channels return failing testReplayCrashBeforeWriteVote test fix TestValidatorSetChanges refactor code a bit fix testReplayCrashBeforeWriteVote add comment fix TestValidatorSetChanges fixes from Bucky's review update comment [ci skip] test TxEventBuffer update changelog fix TestValidatorSetChanges (2nd attempt) only do wg.Done when no errors benchmark event bus create pubsub server inside NewEventBus only expose config params (later if needed) set buffer capacity to 0 so we are not testing cache new tx event format: key = "Tx" plus a tag {"tx.hash": XYZ} This should allow to subscribe to all transactions! or a specific one using a query: "tm.events.type = Tx and tx.hash = '013ABF99434...'" use TimeoutCommit instead of afterPublishEventNewBlockTimeout TimeoutCommit is the time a node waits after committing a block, before it goes into the next height. So it will finish everything from the last block, but then wait a bit. The idea is this gives it time to hear more votes from other validators, to strengthen the commit it includes in the next block. But it also gives it time to hear about new transactions. waitForBlockWithUpdatedVals rewrite WAL crash tests Task: test that we can recover from any WAL crash. Solution: the old tests were relying on event hub being run in the same thread (we were injecting the private validator's last signature). when considering a rewrite, we considered two possible solutions: write a "fuzzy" testing system where WAL is crashing upon receiving a new message, or inject failures and trigger them in tests using something like https://github.com/coreos/gofail. remove sleep no cs.Lock around wal.Save test different cases (empty block, non-empty block, ...) comments add comments test 4 cases: empty block, non-empty block, non-empty block with smaller part size, many blocks fixes as per Bucky's last review reset subscriptions on UnsubscribeAll use a simple counter to track message for which we panicked also, set a smaller part size for all test cases
7 years ago
10 years ago
10 years ago
new pubsub package comment out failing consensus tests for now rewrite rpc httpclient to use new pubsub package import pubsub as tmpubsub, query as tmquery make event IDs constants EventKey -> EventTypeKey rename EventsPubsub to PubSub mempool does not use pubsub rename eventsSub to pubsub new subscribe API fix channel size issues and consensus tests bugs refactor rpc client add missing discardFromChan method add mutex rename pubsub to eventBus remove IsRunning from WSRPCConnection interface (not needed) add a comment in broadcastNewRoundStepsAndVotes rename registerEventCallbacks to broadcastNewRoundStepsAndVotes See https://dave.cheney.net/2014/03/19/channel-axioms stop eventBuses after reactor tests remove unnecessary Unsubscribe return subscribe helper function move discardFromChan to where it is used subscribe now returns an err this gives us ability to refuse to subscribe if pubsub is at its max capacity. use context for control overflow cache queries handle err when subscribing in replay_test rename testClientID to testSubscriber extract var set channel buffer capacity to 1 in replay_file fix byzantine_test unsubscribe from single event, not all events refactor httpclient to return events to appropriate channels return failing testReplayCrashBeforeWriteVote test fix TestValidatorSetChanges refactor code a bit fix testReplayCrashBeforeWriteVote add comment fix TestValidatorSetChanges fixes from Bucky's review update comment [ci skip] test TxEventBuffer update changelog fix TestValidatorSetChanges (2nd attempt) only do wg.Done when no errors benchmark event bus create pubsub server inside NewEventBus only expose config params (later if needed) set buffer capacity to 0 so we are not testing cache new tx event format: key = "Tx" plus a tag {"tx.hash": XYZ} This should allow to subscribe to all transactions! or a specific one using a query: "tm.events.type = Tx and tx.hash = '013ABF99434...'" use TimeoutCommit instead of afterPublishEventNewBlockTimeout TimeoutCommit is the time a node waits after committing a block, before it goes into the next height. So it will finish everything from the last block, but then wait a bit. The idea is this gives it time to hear more votes from other validators, to strengthen the commit it includes in the next block. But it also gives it time to hear about new transactions. waitForBlockWithUpdatedVals rewrite WAL crash tests Task: test that we can recover from any WAL crash. Solution: the old tests were relying on event hub being run in the same thread (we were injecting the private validator's last signature). when considering a rewrite, we considered two possible solutions: write a "fuzzy" testing system where WAL is crashing upon receiving a new message, or inject failures and trigger them in tests using something like https://github.com/coreos/gofail. remove sleep no cs.Lock around wal.Save test different cases (empty block, non-empty block, ...) comments add comments test 4 cases: empty block, non-empty block, non-empty block with smaller part size, many blocks fixes as per Bucky's last review reset subscriptions on UnsubscribeAll use a simple counter to track message for which we panicked also, set a smaller part size for all test cases
7 years ago
10 years ago
8 years ago
8 years ago
9 years ago
8 years ago
10 years ago
8 years ago
9 years ago
9 years ago
10 years ago
10 years ago
10 years ago
10 years ago
10 years ago
10 years ago
10 years ago
8 years ago
10 years ago
10 years ago
8 years ago
10 years ago
10 years ago
8 years ago
8 years ago
8 years ago
8 years ago
10 years ago
10 years ago
10 years ago
10 years ago
10 years ago
10 years ago
9 years ago
8 years ago
9 years ago
7 years ago
8 years ago
new pubsub package comment out failing consensus tests for now rewrite rpc httpclient to use new pubsub package import pubsub as tmpubsub, query as tmquery make event IDs constants EventKey -> EventTypeKey rename EventsPubsub to PubSub mempool does not use pubsub rename eventsSub to pubsub new subscribe API fix channel size issues and consensus tests bugs refactor rpc client add missing discardFromChan method add mutex rename pubsub to eventBus remove IsRunning from WSRPCConnection interface (not needed) add a comment in broadcastNewRoundStepsAndVotes rename registerEventCallbacks to broadcastNewRoundStepsAndVotes See https://dave.cheney.net/2014/03/19/channel-axioms stop eventBuses after reactor tests remove unnecessary Unsubscribe return subscribe helper function move discardFromChan to where it is used subscribe now returns an err this gives us ability to refuse to subscribe if pubsub is at its max capacity. use context for control overflow cache queries handle err when subscribing in replay_test rename testClientID to testSubscriber extract var set channel buffer capacity to 1 in replay_file fix byzantine_test unsubscribe from single event, not all events refactor httpclient to return events to appropriate channels return failing testReplayCrashBeforeWriteVote test fix TestValidatorSetChanges refactor code a bit fix testReplayCrashBeforeWriteVote add comment fix TestValidatorSetChanges fixes from Bucky's review update comment [ci skip] test TxEventBuffer update changelog fix TestValidatorSetChanges (2nd attempt) only do wg.Done when no errors benchmark event bus create pubsub server inside NewEventBus only expose config params (later if needed) set buffer capacity to 0 so we are not testing cache new tx event format: key = "Tx" plus a tag {"tx.hash": XYZ} This should allow to subscribe to all transactions! or a specific one using a query: "tm.events.type = Tx and tx.hash = '013ABF99434...'" use TimeoutCommit instead of afterPublishEventNewBlockTimeout TimeoutCommit is the time a node waits after committing a block, before it goes into the next height. So it will finish everything from the last block, but then wait a bit. The idea is this gives it time to hear more votes from other validators, to strengthen the commit it includes in the next block. But it also gives it time to hear about new transactions. waitForBlockWithUpdatedVals rewrite WAL crash tests Task: test that we can recover from any WAL crash. Solution: the old tests were relying on event hub being run in the same thread (we were injecting the private validator's last signature). when considering a rewrite, we considered two possible solutions: write a "fuzzy" testing system where WAL is crashing upon receiving a new message, or inject failures and trigger them in tests using something like https://github.com/coreos/gofail. remove sleep no cs.Lock around wal.Save test different cases (empty block, non-empty block, ...) comments add comments test 4 cases: empty block, non-empty block, non-empty block with smaller part size, many blocks fixes as per Bucky's last review reset subscriptions on UnsubscribeAll use a simple counter to track message for which we panicked also, set a smaller part size for all test cases
7 years ago
10 years ago
new pubsub package comment out failing consensus tests for now rewrite rpc httpclient to use new pubsub package import pubsub as tmpubsub, query as tmquery make event IDs constants EventKey -> EventTypeKey rename EventsPubsub to PubSub mempool does not use pubsub rename eventsSub to pubsub new subscribe API fix channel size issues and consensus tests bugs refactor rpc client add missing discardFromChan method add mutex rename pubsub to eventBus remove IsRunning from WSRPCConnection interface (not needed) add a comment in broadcastNewRoundStepsAndVotes rename registerEventCallbacks to broadcastNewRoundStepsAndVotes See https://dave.cheney.net/2014/03/19/channel-axioms stop eventBuses after reactor tests remove unnecessary Unsubscribe return subscribe helper function move discardFromChan to where it is used subscribe now returns an err this gives us ability to refuse to subscribe if pubsub is at its max capacity. use context for control overflow cache queries handle err when subscribing in replay_test rename testClientID to testSubscriber extract var set channel buffer capacity to 1 in replay_file fix byzantine_test unsubscribe from single event, not all events refactor httpclient to return events to appropriate channels return failing testReplayCrashBeforeWriteVote test fix TestValidatorSetChanges refactor code a bit fix testReplayCrashBeforeWriteVote add comment fix TestValidatorSetChanges fixes from Bucky's review update comment [ci skip] test TxEventBuffer update changelog fix TestValidatorSetChanges (2nd attempt) only do wg.Done when no errors benchmark event bus create pubsub server inside NewEventBus only expose config params (later if needed) set buffer capacity to 0 so we are not testing cache new tx event format: key = "Tx" plus a tag {"tx.hash": XYZ} This should allow to subscribe to all transactions! or a specific one using a query: "tm.events.type = Tx and tx.hash = '013ABF99434...'" use TimeoutCommit instead of afterPublishEventNewBlockTimeout TimeoutCommit is the time a node waits after committing a block, before it goes into the next height. So it will finish everything from the last block, but then wait a bit. The idea is this gives it time to hear more votes from other validators, to strengthen the commit it includes in the next block. But it also gives it time to hear about new transactions. waitForBlockWithUpdatedVals rewrite WAL crash tests Task: test that we can recover from any WAL crash. Solution: the old tests were relying on event hub being run in the same thread (we were injecting the private validator's last signature). when considering a rewrite, we considered two possible solutions: write a "fuzzy" testing system where WAL is crashing upon receiving a new message, or inject failures and trigger them in tests using something like https://github.com/coreos/gofail. remove sleep no cs.Lock around wal.Save test different cases (empty block, non-empty block, ...) comments add comments test 4 cases: empty block, non-empty block, non-empty block with smaller part size, many blocks fixes as per Bucky's last review reset subscriptions on UnsubscribeAll use a simple counter to track message for which we panicked also, set a smaller part size for all test cases
7 years ago
8 years ago
10 years ago
10 years ago
8 years ago
new pubsub package comment out failing consensus tests for now rewrite rpc httpclient to use new pubsub package import pubsub as tmpubsub, query as tmquery make event IDs constants EventKey -> EventTypeKey rename EventsPubsub to PubSub mempool does not use pubsub rename eventsSub to pubsub new subscribe API fix channel size issues and consensus tests bugs refactor rpc client add missing discardFromChan method add mutex rename pubsub to eventBus remove IsRunning from WSRPCConnection interface (not needed) add a comment in broadcastNewRoundStepsAndVotes rename registerEventCallbacks to broadcastNewRoundStepsAndVotes See https://dave.cheney.net/2014/03/19/channel-axioms stop eventBuses after reactor tests remove unnecessary Unsubscribe return subscribe helper function move discardFromChan to where it is used subscribe now returns an err this gives us ability to refuse to subscribe if pubsub is at its max capacity. use context for control overflow cache queries handle err when subscribing in replay_test rename testClientID to testSubscriber extract var set channel buffer capacity to 1 in replay_file fix byzantine_test unsubscribe from single event, not all events refactor httpclient to return events to appropriate channels return failing testReplayCrashBeforeWriteVote test fix TestValidatorSetChanges refactor code a bit fix testReplayCrashBeforeWriteVote add comment fix TestValidatorSetChanges fixes from Bucky's review update comment [ci skip] test TxEventBuffer update changelog fix TestValidatorSetChanges (2nd attempt) only do wg.Done when no errors benchmark event bus create pubsub server inside NewEventBus only expose config params (later if needed) set buffer capacity to 0 so we are not testing cache new tx event format: key = "Tx" plus a tag {"tx.hash": XYZ} This should allow to subscribe to all transactions! or a specific one using a query: "tm.events.type = Tx and tx.hash = '013ABF99434...'" use TimeoutCommit instead of afterPublishEventNewBlockTimeout TimeoutCommit is the time a node waits after committing a block, before it goes into the next height. So it will finish everything from the last block, but then wait a bit. The idea is this gives it time to hear more votes from other validators, to strengthen the commit it includes in the next block. But it also gives it time to hear about new transactions. waitForBlockWithUpdatedVals rewrite WAL crash tests Task: test that we can recover from any WAL crash. Solution: the old tests were relying on event hub being run in the same thread (we were injecting the private validator's last signature). when considering a rewrite, we considered two possible solutions: write a "fuzzy" testing system where WAL is crashing upon receiving a new message, or inject failures and trigger them in tests using something like https://github.com/coreos/gofail. remove sleep no cs.Lock around wal.Save test different cases (empty block, non-empty block, ...) comments add comments test 4 cases: empty block, non-empty block, non-empty block with smaller part size, many blocks fixes as per Bucky's last review reset subscriptions on UnsubscribeAll use a simple counter to track message for which we panicked also, set a smaller part size for all test cases
7 years ago
8 years ago
10 years ago
8 years ago
10 years ago
  1. package consensus
  2. import (
  3. "bytes"
  4. "errors"
  5. "fmt"
  6. "reflect"
  7. "runtime/debug"
  8. "sync"
  9. "time"
  10. fail "github.com/ebuchman/fail-test"
  11. wire "github.com/tendermint/go-wire"
  12. cmn "github.com/tendermint/tmlibs/common"
  13. "github.com/tendermint/tmlibs/log"
  14. cfg "github.com/tendermint/tendermint/config"
  15. cstypes "github.com/tendermint/tendermint/consensus/types"
  16. "github.com/tendermint/tendermint/p2p"
  17. sm "github.com/tendermint/tendermint/state"
  18. "github.com/tendermint/tendermint/types"
  19. )
  20. //-----------------------------------------------------------------------------
  21. // Config
  22. const (
  23. proposalHeartbeatIntervalSeconds = 2
  24. )
  25. //-----------------------------------------------------------------------------
  26. // Errors
  27. var (
  28. ErrInvalidProposalSignature = errors.New("Error invalid proposal signature")
  29. ErrInvalidProposalPOLRound = errors.New("Error invalid proposal POL round")
  30. ErrAddingVote = errors.New("Error adding vote")
  31. ErrVoteHeightMismatch = errors.New("Error vote height mismatch")
  32. )
  33. //-----------------------------------------------------------------------------
  34. var (
  35. msgQueueSize = 1000
  36. )
  37. // msgs from the reactor which may update the state
  38. type msgInfo struct {
  39. Msg ConsensusMessage `json:"msg"`
  40. PeerID p2p.ID `json:"peer_key"`
  41. }
  42. // internally generated messages which may update the state
  43. type timeoutInfo struct {
  44. Duration time.Duration `json:"duration"`
  45. Height int64 `json:"height"`
  46. Round int `json:"round"`
  47. Step cstypes.RoundStepType `json:"step"`
  48. }
  49. func (ti *timeoutInfo) String() string {
  50. return fmt.Sprintf("%v ; %d/%d %v", ti.Duration, ti.Height, ti.Round, ti.Step)
  51. }
  52. // ConsensusState handles execution of the consensus algorithm.
  53. // It processes votes and proposals, and upon reaching agreement,
  54. // commits blocks to the chain and executes them against the application.
  55. // The internal state machine receives input from peers, the internal validator, and from a timer.
  56. type ConsensusState struct {
  57. cmn.BaseService
  58. // config details
  59. config *cfg.ConsensusConfig
  60. privValidator types.PrivValidator // for signing votes
  61. // services for creating and executing blocks
  62. // TODO: encapsulate all of this in one "BlockManager"
  63. blockExec *sm.BlockExecutor
  64. blockStore types.BlockStore
  65. mempool types.Mempool
  66. evpool types.EvidencePool
  67. // internal state
  68. mtx sync.Mutex
  69. cstypes.RoundState
  70. state sm.State // State until height-1.
  71. // state changes may be triggered by msgs from peers,
  72. // msgs from ourself, or by timeouts
  73. peerMsgQueue chan msgInfo
  74. internalMsgQueue chan msgInfo
  75. timeoutTicker TimeoutTicker
  76. // we use eventBus to trigger msg broadcasts in the reactor,
  77. // and to notify external subscribers, eg. through a websocket
  78. eventBus *types.EventBus
  79. // a Write-Ahead Log ensures we can recover from any kind of crash
  80. // and helps us avoid signing conflicting votes
  81. wal WAL
  82. replayMode bool // so we don't log signing errors during replay
  83. doWALCatchup bool // determines if we even try to do the catchup
  84. // for tests where we want to limit the number of transitions the state makes
  85. nSteps int
  86. // some functions can be overwritten for testing
  87. decideProposal func(height int64, round int)
  88. doPrevote func(height int64, round int)
  89. setProposal func(proposal *types.Proposal) error
  90. // closed when we finish shutting down
  91. done chan struct{}
  92. }
  93. // NewConsensusState returns a new ConsensusState.
  94. func NewConsensusState(config *cfg.ConsensusConfig, state sm.State, blockExec *sm.BlockExecutor, blockStore types.BlockStore, mempool types.Mempool, evpool types.EvidencePool) *ConsensusState {
  95. cs := &ConsensusState{
  96. config: config,
  97. blockExec: blockExec,
  98. blockStore: blockStore,
  99. mempool: mempool,
  100. peerMsgQueue: make(chan msgInfo, msgQueueSize),
  101. internalMsgQueue: make(chan msgInfo, msgQueueSize),
  102. timeoutTicker: NewTimeoutTicker(),
  103. done: make(chan struct{}),
  104. doWALCatchup: true,
  105. wal: nilWAL{},
  106. evpool: evpool,
  107. }
  108. // set function defaults (may be overwritten before calling Start)
  109. cs.decideProposal = cs.defaultDecideProposal
  110. cs.doPrevote = cs.defaultDoPrevote
  111. cs.setProposal = cs.defaultSetProposal
  112. cs.updateToState(state)
  113. // Don't call scheduleRound0 yet.
  114. // We do that upon Start().
  115. cs.reconstructLastCommit(state)
  116. cs.BaseService = *cmn.NewBaseService(nil, "ConsensusState", cs)
  117. return cs
  118. }
  119. //----------------------------------------
  120. // Public interface
  121. // SetLogger implements Service.
  122. func (cs *ConsensusState) SetLogger(l log.Logger) {
  123. cs.BaseService.Logger = l
  124. cs.timeoutTicker.SetLogger(l)
  125. }
  126. // SetEventBus sets event bus.
  127. func (cs *ConsensusState) SetEventBus(b *types.EventBus) {
  128. cs.eventBus = b
  129. cs.blockExec.SetEventBus(b)
  130. }
  131. // String returns a string.
  132. func (cs *ConsensusState) String() string {
  133. // better not to access shared variables
  134. return cmn.Fmt("ConsensusState") //(H:%v R:%v S:%v", cs.Height, cs.Round, cs.Step)
  135. }
  136. // GetState returns a copy of the chain state.
  137. func (cs *ConsensusState) GetState() sm.State {
  138. cs.mtx.Lock()
  139. defer cs.mtx.Unlock()
  140. return cs.state.Copy()
  141. }
  142. // GetRoundState returns a copy of the internal consensus state.
  143. func (cs *ConsensusState) GetRoundState() *cstypes.RoundState {
  144. cs.mtx.Lock()
  145. defer cs.mtx.Unlock()
  146. return cs.getRoundState()
  147. }
  148. func (cs *ConsensusState) getRoundState() *cstypes.RoundState {
  149. rs := cs.RoundState // copy
  150. return &rs
  151. }
  152. // GetValidators returns a copy of the current validators.
  153. func (cs *ConsensusState) GetValidators() (int64, []*types.Validator) {
  154. cs.mtx.Lock()
  155. defer cs.mtx.Unlock()
  156. return cs.state.LastBlockHeight, cs.state.Validators.Copy().Validators
  157. }
  158. // SetPrivValidator sets the private validator account for signing votes.
  159. func (cs *ConsensusState) SetPrivValidator(priv types.PrivValidator) {
  160. cs.mtx.Lock()
  161. defer cs.mtx.Unlock()
  162. cs.privValidator = priv
  163. }
  164. // SetTimeoutTicker sets the local timer. It may be useful to overwrite for testing.
  165. func (cs *ConsensusState) SetTimeoutTicker(timeoutTicker TimeoutTicker) {
  166. cs.mtx.Lock()
  167. defer cs.mtx.Unlock()
  168. cs.timeoutTicker = timeoutTicker
  169. }
  170. // LoadCommit loads the commit for a given height.
  171. func (cs *ConsensusState) LoadCommit(height int64) *types.Commit {
  172. cs.mtx.Lock()
  173. defer cs.mtx.Unlock()
  174. if height == cs.blockStore.Height() {
  175. return cs.blockStore.LoadSeenCommit(height)
  176. }
  177. return cs.blockStore.LoadBlockCommit(height)
  178. }
  179. // OnStart implements cmn.Service.
  180. // It loads the latest state via the WAL, and starts the timeout and receive routines.
  181. func (cs *ConsensusState) OnStart() error {
  182. // we may set the WAL in testing before calling Start,
  183. // so only OpenWAL if its still the nilWAL
  184. if _, ok := cs.wal.(nilWAL); ok {
  185. walFile := cs.config.WalFile()
  186. wal, err := cs.OpenWAL(walFile)
  187. if err != nil {
  188. cs.Logger.Error("Error loading ConsensusState wal", "err", err.Error())
  189. return err
  190. }
  191. cs.wal = wal
  192. }
  193. // we need the timeoutRoutine for replay so
  194. // we don't block on the tick chan.
  195. // NOTE: we will get a build up of garbage go routines
  196. // firing on the tockChan until the receiveRoutine is started
  197. // to deal with them (by that point, at most one will be valid)
  198. err := cs.timeoutTicker.Start()
  199. if err != nil {
  200. return err
  201. }
  202. // we may have lost some votes if the process crashed
  203. // reload from consensus log to catchup
  204. if cs.doWALCatchup {
  205. if err := cs.catchupReplay(cs.Height); err != nil {
  206. cs.Logger.Error("Error on catchup replay. Proceeding to start ConsensusState anyway", "err", err.Error())
  207. // NOTE: if we ever do return an error here,
  208. // make sure to stop the timeoutTicker
  209. }
  210. }
  211. // now start the receiveRoutine
  212. go cs.receiveRoutine(0)
  213. // schedule the first round!
  214. // use GetRoundState so we don't race the receiveRoutine for access
  215. cs.scheduleRound0(cs.GetRoundState())
  216. return nil
  217. }
  218. // timeoutRoutine: receive requests for timeouts on tickChan and fire timeouts on tockChan
  219. // receiveRoutine: serializes processing of proposoals, block parts, votes; coordinates state transitions
  220. func (cs *ConsensusState) startRoutines(maxSteps int) {
  221. err := cs.timeoutTicker.Start()
  222. if err != nil {
  223. cs.Logger.Error("Error starting timeout ticker", "err", err)
  224. return
  225. }
  226. go cs.receiveRoutine(maxSteps)
  227. }
  228. // OnStop implements cmn.Service. It stops all routines and waits for the WAL to finish.
  229. func (cs *ConsensusState) OnStop() {
  230. cs.BaseService.OnStop()
  231. cs.timeoutTicker.Stop()
  232. // Make BaseService.Wait() wait until cs.wal.Wait()
  233. if cs.IsRunning() {
  234. cs.wal.Wait()
  235. }
  236. }
  237. // Wait waits for the the main routine to return.
  238. // NOTE: be sure to Stop() the event switch and drain
  239. // any event channels or this may deadlock
  240. func (cs *ConsensusState) Wait() {
  241. <-cs.done
  242. }
  243. // OpenWAL opens a file to log all consensus messages and timeouts for deterministic accountability
  244. func (cs *ConsensusState) OpenWAL(walFile string) (WAL, error) {
  245. wal, err := NewWAL(walFile, cs.config.WalLight)
  246. if err != nil {
  247. cs.Logger.Error("Failed to open WAL for consensus state", "wal", walFile, "err", err)
  248. return nil, err
  249. }
  250. wal.SetLogger(cs.Logger.With("wal", walFile))
  251. if err := wal.Start(); err != nil {
  252. return nil, err
  253. }
  254. return wal, nil
  255. }
  256. //------------------------------------------------------------
  257. // Public interface for passing messages into the consensus state, possibly causing a state transition.
  258. // If peerID == "", the msg is considered internal.
  259. // Messages are added to the appropriate queue (peer or internal).
  260. // If the queue is full, the function may block.
  261. // TODO: should these return anything or let callers just use events?
  262. // AddVote inputs a vote.
  263. func (cs *ConsensusState) AddVote(vote *types.Vote, peerID p2p.ID) (added bool, err error) {
  264. if peerID == "" {
  265. cs.internalMsgQueue <- msgInfo{&VoteMessage{vote}, ""}
  266. } else {
  267. cs.peerMsgQueue <- msgInfo{&VoteMessage{vote}, peerID}
  268. }
  269. // TODO: wait for event?!
  270. return false, nil
  271. }
  272. // SetProposal inputs a proposal.
  273. func (cs *ConsensusState) SetProposal(proposal *types.Proposal, peerID p2p.ID) error {
  274. if peerID == "" {
  275. cs.internalMsgQueue <- msgInfo{&ProposalMessage{proposal}, ""}
  276. } else {
  277. cs.peerMsgQueue <- msgInfo{&ProposalMessage{proposal}, peerID}
  278. }
  279. // TODO: wait for event?!
  280. return nil
  281. }
  282. // AddProposalBlockPart inputs a part of the proposal block.
  283. func (cs *ConsensusState) AddProposalBlockPart(height int64, round int, part *types.Part, peerID p2p.ID) error {
  284. if peerID == "" {
  285. cs.internalMsgQueue <- msgInfo{&BlockPartMessage{height, round, part}, ""}
  286. } else {
  287. cs.peerMsgQueue <- msgInfo{&BlockPartMessage{height, round, part}, peerID}
  288. }
  289. // TODO: wait for event?!
  290. return nil
  291. }
  292. // SetProposalAndBlock inputs the proposal and all block parts.
  293. func (cs *ConsensusState) SetProposalAndBlock(proposal *types.Proposal, block *types.Block, parts *types.PartSet, peerID p2p.ID) error {
  294. if err := cs.SetProposal(proposal, peerID); err != nil {
  295. return err
  296. }
  297. for i := 0; i < parts.Total(); i++ {
  298. part := parts.GetPart(i)
  299. if err := cs.AddProposalBlockPart(proposal.Height, proposal.Round, part, peerID); err != nil {
  300. return err
  301. }
  302. }
  303. return nil
  304. }
  305. //------------------------------------------------------------
  306. // internal functions for managing the state
  307. func (cs *ConsensusState) updateHeight(height int64) {
  308. cs.Height = height
  309. }
  310. func (cs *ConsensusState) updateRoundStep(round int, step cstypes.RoundStepType) {
  311. cs.Round = round
  312. cs.Step = step
  313. }
  314. // enterNewRound(height, 0) at cs.StartTime.
  315. func (cs *ConsensusState) scheduleRound0(rs *cstypes.RoundState) {
  316. //cs.Logger.Info("scheduleRound0", "now", time.Now(), "startTime", cs.StartTime)
  317. sleepDuration := rs.StartTime.Sub(time.Now()) // nolint: gotype, gosimple
  318. cs.scheduleTimeout(sleepDuration, rs.Height, 0, cstypes.RoundStepNewHeight)
  319. }
  320. // Attempt to schedule a timeout (by sending timeoutInfo on the tickChan)
  321. func (cs *ConsensusState) scheduleTimeout(duration time.Duration, height int64, round int, step cstypes.RoundStepType) {
  322. cs.timeoutTicker.ScheduleTimeout(timeoutInfo{duration, height, round, step})
  323. }
  324. // send a msg into the receiveRoutine regarding our own proposal, block part, or vote
  325. func (cs *ConsensusState) sendInternalMessage(mi msgInfo) {
  326. select {
  327. case cs.internalMsgQueue <- mi:
  328. default:
  329. // NOTE: using the go-routine means our votes can
  330. // be processed out of order.
  331. // TODO: use CList here for strict determinism and
  332. // attempt push to internalMsgQueue in receiveRoutine
  333. cs.Logger.Info("Internal msg queue is full. Using a go-routine")
  334. go func() { cs.internalMsgQueue <- mi }()
  335. }
  336. }
  337. // Reconstruct LastCommit from SeenCommit, which we saved along with the block,
  338. // (which happens even before saving the state)
  339. func (cs *ConsensusState) reconstructLastCommit(state sm.State) {
  340. if state.LastBlockHeight == 0 {
  341. return
  342. }
  343. seenCommit := cs.blockStore.LoadSeenCommit(state.LastBlockHeight)
  344. lastPrecommits := types.NewVoteSet(state.ChainID, state.LastBlockHeight, seenCommit.Round(), types.VoteTypePrecommit, state.LastValidators)
  345. for _, precommit := range seenCommit.Precommits {
  346. if precommit == nil {
  347. continue
  348. }
  349. added, err := lastPrecommits.AddVote(precommit)
  350. if !added || err != nil {
  351. cmn.PanicCrisis(cmn.Fmt("Failed to reconstruct LastCommit: %v", err))
  352. }
  353. }
  354. if !lastPrecommits.HasTwoThirdsMajority() {
  355. cmn.PanicSanity("Failed to reconstruct LastCommit: Does not have +2/3 maj")
  356. }
  357. cs.LastCommit = lastPrecommits
  358. }
  359. // Updates ConsensusState and increments height to match that of state.
  360. // The round becomes 0 and cs.Step becomes cstypes.RoundStepNewHeight.
  361. func (cs *ConsensusState) updateToState(state sm.State) {
  362. if cs.CommitRound > -1 && 0 < cs.Height && cs.Height != state.LastBlockHeight {
  363. cmn.PanicSanity(cmn.Fmt("updateToState() expected state height of %v but found %v",
  364. cs.Height, state.LastBlockHeight))
  365. }
  366. if !cs.state.IsEmpty() && cs.state.LastBlockHeight+1 != cs.Height {
  367. // This might happen when someone else is mutating cs.state.
  368. // Someone forgot to pass in state.Copy() somewhere?!
  369. cmn.PanicSanity(cmn.Fmt("Inconsistent cs.state.LastBlockHeight+1 %v vs cs.Height %v",
  370. cs.state.LastBlockHeight+1, cs.Height))
  371. }
  372. // If state isn't further out than cs.state, just ignore.
  373. // This happens when SwitchToConsensus() is called in the reactor.
  374. // We don't want to reset e.g. the Votes.
  375. if !cs.state.IsEmpty() && (state.LastBlockHeight <= cs.state.LastBlockHeight) {
  376. cs.Logger.Info("Ignoring updateToState()", "newHeight", state.LastBlockHeight+1, "oldHeight", cs.state.LastBlockHeight+1)
  377. return
  378. }
  379. // Reset fields based on state.
  380. validators := state.Validators
  381. lastPrecommits := (*types.VoteSet)(nil)
  382. if cs.CommitRound > -1 && cs.Votes != nil {
  383. if !cs.Votes.Precommits(cs.CommitRound).HasTwoThirdsMajority() {
  384. cmn.PanicSanity("updateToState(state) called but last Precommit round didn't have +2/3")
  385. }
  386. lastPrecommits = cs.Votes.Precommits(cs.CommitRound)
  387. }
  388. // Next desired block height
  389. height := state.LastBlockHeight + 1
  390. // RoundState fields
  391. cs.updateHeight(height)
  392. cs.updateRoundStep(0, cstypes.RoundStepNewHeight)
  393. if cs.CommitTime.IsZero() {
  394. // "Now" makes it easier to sync up dev nodes.
  395. // We add timeoutCommit to allow transactions
  396. // to be gathered for the first block.
  397. // And alternative solution that relies on clocks:
  398. // cs.StartTime = state.LastBlockTime.Add(timeoutCommit)
  399. cs.StartTime = cs.config.Commit(time.Now())
  400. } else {
  401. cs.StartTime = cs.config.Commit(cs.CommitTime)
  402. }
  403. cs.Validators = validators
  404. cs.Proposal = nil
  405. cs.ProposalBlock = nil
  406. cs.ProposalBlockParts = nil
  407. cs.LockedRound = 0
  408. cs.LockedBlock = nil
  409. cs.LockedBlockParts = nil
  410. cs.Votes = cstypes.NewHeightVoteSet(state.ChainID, height, validators)
  411. cs.CommitRound = -1
  412. cs.LastCommit = lastPrecommits
  413. cs.LastValidators = state.LastValidators
  414. cs.state = state
  415. // Finally, broadcast RoundState
  416. cs.newStep()
  417. }
  418. func (cs *ConsensusState) newStep() {
  419. rs := cs.RoundStateEvent()
  420. cs.wal.Save(rs)
  421. cs.nSteps += 1
  422. // newStep is called by updateToStep in NewConsensusState before the eventBus is set!
  423. if cs.eventBus != nil {
  424. cs.eventBus.PublishEventNewRoundStep(rs)
  425. }
  426. }
  427. //-----------------------------------------
  428. // the main go routines
  429. // receiveRoutine handles messages which may cause state transitions.
  430. // it's argument (n) is the number of messages to process before exiting - use 0 to run forever
  431. // It keeps the RoundState and is the only thing that updates it.
  432. // Updates (state transitions) happen on timeouts, complete proposals, and 2/3 majorities.
  433. // ConsensusState must be locked before any internal state is updated.
  434. func (cs *ConsensusState) receiveRoutine(maxSteps int) {
  435. defer func() {
  436. if r := recover(); r != nil {
  437. cs.Logger.Error("CONSENSUS FAILURE!!!", "err", r, "stack", string(debug.Stack()))
  438. }
  439. }()
  440. for {
  441. if maxSteps > 0 {
  442. if cs.nSteps >= maxSteps {
  443. cs.Logger.Info("reached max steps. exiting receive routine")
  444. cs.nSteps = 0
  445. return
  446. }
  447. }
  448. rs := cs.RoundState
  449. var mi msgInfo
  450. select {
  451. case height := <-cs.mempool.TxsAvailable():
  452. cs.handleTxsAvailable(height)
  453. case mi = <-cs.peerMsgQueue:
  454. cs.wal.Save(mi)
  455. // handles proposals, block parts, votes
  456. // may generate internal events (votes, complete proposals, 2/3 majorities)
  457. cs.handleMsg(mi)
  458. case mi = <-cs.internalMsgQueue:
  459. cs.wal.Save(mi)
  460. // handles proposals, block parts, votes
  461. cs.handleMsg(mi)
  462. case ti := <-cs.timeoutTicker.Chan(): // tockChan:
  463. cs.wal.Save(ti)
  464. // if the timeout is relevant to the rs
  465. // go to the next step
  466. cs.handleTimeout(ti, rs)
  467. case <-cs.Quit:
  468. // NOTE: the internalMsgQueue may have signed messages from our
  469. // priv_val that haven't hit the WAL, but its ok because
  470. // priv_val tracks LastSig
  471. // close wal now that we're done writing to it
  472. cs.wal.Stop()
  473. close(cs.done)
  474. return
  475. }
  476. }
  477. }
  478. // state transitions on complete-proposal, 2/3-any, 2/3-one
  479. func (cs *ConsensusState) handleMsg(mi msgInfo) {
  480. cs.mtx.Lock()
  481. defer cs.mtx.Unlock()
  482. var err error
  483. msg, peerID := mi.Msg, mi.PeerID
  484. switch msg := msg.(type) {
  485. case *ProposalMessage:
  486. // will not cause transition.
  487. // once proposal is set, we can receive block parts
  488. err = cs.setProposal(msg.Proposal)
  489. case *BlockPartMessage:
  490. // if the proposal is complete, we'll enterPrevote or tryFinalizeCommit
  491. _, err = cs.addProposalBlockPart(msg.Height, msg.Part, peerID != "")
  492. if err != nil && msg.Round != cs.Round {
  493. err = nil
  494. }
  495. case *VoteMessage:
  496. // attempt to add the vote and dupeout the validator if its a duplicate signature
  497. // if the vote gives us a 2/3-any or 2/3-one, we transition
  498. err := cs.tryAddVote(msg.Vote, peerID)
  499. if err == ErrAddingVote {
  500. // TODO: punish peer
  501. }
  502. // NOTE: the vote is broadcast to peers by the reactor listening
  503. // for vote events
  504. // TODO: If rs.Height == vote.Height && rs.Round < vote.Round,
  505. // the peer is sending us CatchupCommit precommits.
  506. // We could make note of this and help filter in broadcastHasVoteMessage().
  507. default:
  508. cs.Logger.Error("Unknown msg type", reflect.TypeOf(msg))
  509. }
  510. if err != nil {
  511. cs.Logger.Error("Error with msg", "type", reflect.TypeOf(msg), "peer", peerID, "err", err, "msg", msg)
  512. }
  513. }
  514. func (cs *ConsensusState) handleTimeout(ti timeoutInfo, rs cstypes.RoundState) {
  515. cs.Logger.Debug("Received tock", "timeout", ti.Duration, "height", ti.Height, "round", ti.Round, "step", ti.Step)
  516. // timeouts must be for current height, round, step
  517. if ti.Height != rs.Height || ti.Round < rs.Round || (ti.Round == rs.Round && ti.Step < rs.Step) {
  518. cs.Logger.Debug("Ignoring tock because we're ahead", "height", rs.Height, "round", rs.Round, "step", rs.Step)
  519. return
  520. }
  521. // the timeout will now cause a state transition
  522. cs.mtx.Lock()
  523. defer cs.mtx.Unlock()
  524. switch ti.Step {
  525. case cstypes.RoundStepNewHeight:
  526. // NewRound event fired from enterNewRound.
  527. // XXX: should we fire timeout here (for timeout commit)?
  528. cs.enterNewRound(ti.Height, 0)
  529. case cstypes.RoundStepNewRound:
  530. cs.enterPropose(ti.Height, 0)
  531. case cstypes.RoundStepPropose:
  532. cs.eventBus.PublishEventTimeoutPropose(cs.RoundStateEvent())
  533. cs.enterPrevote(ti.Height, ti.Round)
  534. case cstypes.RoundStepPrevoteWait:
  535. cs.eventBus.PublishEventTimeoutWait(cs.RoundStateEvent())
  536. cs.enterPrecommit(ti.Height, ti.Round)
  537. case cstypes.RoundStepPrecommitWait:
  538. cs.eventBus.PublishEventTimeoutWait(cs.RoundStateEvent())
  539. cs.enterNewRound(ti.Height, ti.Round+1)
  540. default:
  541. panic(cmn.Fmt("Invalid timeout step: %v", ti.Step))
  542. }
  543. }
  544. func (cs *ConsensusState) handleTxsAvailable(height int64) {
  545. cs.mtx.Lock()
  546. defer cs.mtx.Unlock()
  547. // we only need to do this for round 0
  548. cs.enterPropose(height, 0)
  549. }
  550. //-----------------------------------------------------------------------------
  551. // State functions
  552. // Used internally by handleTimeout and handleMsg to make state transitions
  553. // Enter: `timeoutNewHeight` by startTime (commitTime+timeoutCommit),
  554. // or, if SkipTimeout==true, after receiving all precommits from (height,round-1)
  555. // Enter: `timeoutPrecommits` after any +2/3 precommits from (height,round-1)
  556. // Enter: +2/3 precommits for nil at (height,round-1)
  557. // Enter: +2/3 prevotes any or +2/3 precommits for block or any from (height, round)
  558. // NOTE: cs.StartTime was already set for height.
  559. func (cs *ConsensusState) enterNewRound(height int64, round int) {
  560. if cs.Height != height || round < cs.Round || (cs.Round == round && cs.Step != cstypes.RoundStepNewHeight) {
  561. cs.Logger.Debug(cmn.Fmt("enterNewRound(%v/%v): Invalid args. Current step: %v/%v/%v", height, round, cs.Height, cs.Round, cs.Step))
  562. return
  563. }
  564. if now := time.Now(); cs.StartTime.After(now) {
  565. cs.Logger.Info("Need to set a buffer and log message here for sanity.", "startTime", cs.StartTime, "now", now)
  566. }
  567. cs.Logger.Info(cmn.Fmt("enterNewRound(%v/%v). Current: %v/%v/%v", height, round, cs.Height, cs.Round, cs.Step))
  568. // Increment validators if necessary
  569. validators := cs.Validators
  570. if cs.Round < round {
  571. validators = validators.Copy()
  572. validators.IncrementAccum(round - cs.Round)
  573. }
  574. // Setup new round
  575. // we don't fire newStep for this step,
  576. // but we fire an event, so update the round step first
  577. cs.updateRoundStep(round, cstypes.RoundStepNewRound)
  578. cs.Validators = validators
  579. if round == 0 {
  580. // We've already reset these upon new height,
  581. // and meanwhile we might have received a proposal
  582. // for round 0.
  583. } else {
  584. cs.Proposal = nil
  585. cs.ProposalBlock = nil
  586. cs.ProposalBlockParts = nil
  587. }
  588. cs.Votes.SetRound(round + 1) // also track next round (round+1) to allow round-skipping
  589. cs.eventBus.PublishEventNewRound(cs.RoundStateEvent())
  590. // Wait for txs to be available in the mempool
  591. // before we enterPropose in round 0. If the last block changed the app hash,
  592. // we may need an empty "proof" block, and enterPropose immediately.
  593. waitForTxs := cs.config.WaitForTxs() && round == 0 && !cs.needProofBlock(height)
  594. if waitForTxs {
  595. if cs.config.CreateEmptyBlocksInterval > 0 {
  596. cs.scheduleTimeout(cs.config.EmptyBlocksInterval(), height, round, cstypes.RoundStepNewRound)
  597. }
  598. go cs.proposalHeartbeat(height, round)
  599. } else {
  600. cs.enterPropose(height, round)
  601. }
  602. }
  603. // needProofBlock returns true on the first height (so the genesis app hash is signed right away)
  604. // and where the last block (height-1) caused the app hash to change
  605. func (cs *ConsensusState) needProofBlock(height int64) bool {
  606. if height == 1 {
  607. return true
  608. }
  609. lastBlockMeta := cs.blockStore.LoadBlockMeta(height - 1)
  610. return !bytes.Equal(cs.state.AppHash, lastBlockMeta.Header.AppHash)
  611. }
  612. func (cs *ConsensusState) proposalHeartbeat(height int64, round int) {
  613. counter := 0
  614. addr := cs.privValidator.GetAddress()
  615. valIndex, v := cs.Validators.GetByAddress(addr)
  616. if v == nil {
  617. // not a validator
  618. valIndex = -1
  619. }
  620. chainID := cs.state.ChainID
  621. for {
  622. rs := cs.GetRoundState()
  623. // if we've already moved on, no need to send more heartbeats
  624. if rs.Step > cstypes.RoundStepNewRound || rs.Round > round || rs.Height > height {
  625. return
  626. }
  627. heartbeat := &types.Heartbeat{
  628. Height: rs.Height,
  629. Round: rs.Round,
  630. Sequence: counter,
  631. ValidatorAddress: addr,
  632. ValidatorIndex: valIndex,
  633. }
  634. cs.privValidator.SignHeartbeat(chainID, heartbeat)
  635. cs.eventBus.PublishEventProposalHeartbeat(types.EventDataProposalHeartbeat{heartbeat})
  636. counter += 1
  637. time.Sleep(proposalHeartbeatIntervalSeconds * time.Second)
  638. }
  639. }
  640. // Enter (CreateEmptyBlocks): from enterNewRound(height,round)
  641. // Enter (CreateEmptyBlocks, CreateEmptyBlocksInterval > 0 ): after enterNewRound(height,round), after timeout of CreateEmptyBlocksInterval
  642. // Enter (!CreateEmptyBlocks) : after enterNewRound(height,round), once txs are in the mempool
  643. func (cs *ConsensusState) enterPropose(height int64, round int) {
  644. if cs.Height != height || round < cs.Round || (cs.Round == round && cstypes.RoundStepPropose <= cs.Step) {
  645. cs.Logger.Debug(cmn.Fmt("enterPropose(%v/%v): Invalid args. Current step: %v/%v/%v", height, round, cs.Height, cs.Round, cs.Step))
  646. return
  647. }
  648. cs.Logger.Info(cmn.Fmt("enterPropose(%v/%v). Current: %v/%v/%v", height, round, cs.Height, cs.Round, cs.Step))
  649. defer func() {
  650. // Done enterPropose:
  651. cs.updateRoundStep(round, cstypes.RoundStepPropose)
  652. cs.newStep()
  653. // If we have the whole proposal + POL, then goto Prevote now.
  654. // else, we'll enterPrevote when the rest of the proposal is received (in AddProposalBlockPart),
  655. // or else after timeoutPropose
  656. if cs.isProposalComplete() {
  657. cs.enterPrevote(height, cs.Round)
  658. }
  659. }()
  660. // If we don't get the proposal and all block parts quick enough, enterPrevote
  661. cs.scheduleTimeout(cs.config.Propose(round), height, round, cstypes.RoundStepPropose)
  662. // Nothing more to do if we're not a validator
  663. if cs.privValidator == nil {
  664. cs.Logger.Debug("This node is not a validator")
  665. return
  666. }
  667. if !cs.isProposer() {
  668. cs.Logger.Info("enterPropose: Not our turn to propose", "proposer", cs.Validators.GetProposer().Address, "privValidator", cs.privValidator)
  669. if cs.Validators.HasAddress(cs.privValidator.GetAddress()) {
  670. cs.Logger.Debug("This node is a validator")
  671. } else {
  672. cs.Logger.Debug("This node is not a validator")
  673. }
  674. } else {
  675. cs.Logger.Info("enterPropose: Our turn to propose", "proposer", cs.Validators.GetProposer().Address, "privValidator", cs.privValidator)
  676. cs.Logger.Debug("This node is a validator")
  677. cs.decideProposal(height, round)
  678. }
  679. }
  680. func (cs *ConsensusState) isProposer() bool {
  681. return bytes.Equal(cs.Validators.GetProposer().Address, cs.privValidator.GetAddress())
  682. }
  683. func (cs *ConsensusState) defaultDecideProposal(height int64, round int) {
  684. var block *types.Block
  685. var blockParts *types.PartSet
  686. // Decide on block
  687. if cs.LockedBlock != nil {
  688. // If we're locked onto a block, just choose that.
  689. block, blockParts = cs.LockedBlock, cs.LockedBlockParts
  690. } else {
  691. // Create a new proposal block from state/txs from the mempool.
  692. block, blockParts = cs.createProposalBlock()
  693. if block == nil { // on error
  694. return
  695. }
  696. }
  697. // Make proposal
  698. polRound, polBlockID := cs.Votes.POLInfo()
  699. proposal := types.NewProposal(height, round, blockParts.Header(), polRound, polBlockID)
  700. if err := cs.privValidator.SignProposal(cs.state.ChainID, proposal); err == nil {
  701. // Set fields
  702. /* fields set by setProposal and addBlockPart
  703. cs.Proposal = proposal
  704. cs.ProposalBlock = block
  705. cs.ProposalBlockParts = blockParts
  706. */
  707. // send proposal and block parts on internal msg queue
  708. cs.sendInternalMessage(msgInfo{&ProposalMessage{proposal}, ""})
  709. for i := 0; i < blockParts.Total(); i++ {
  710. part := blockParts.GetPart(i)
  711. cs.sendInternalMessage(msgInfo{&BlockPartMessage{cs.Height, cs.Round, part}, ""})
  712. }
  713. cs.Logger.Info("Signed proposal", "height", height, "round", round, "proposal", proposal)
  714. cs.Logger.Debug(cmn.Fmt("Signed proposal block: %v", block))
  715. } else {
  716. if !cs.replayMode {
  717. cs.Logger.Error("enterPropose: Error signing proposal", "height", height, "round", round, "err", err)
  718. }
  719. }
  720. }
  721. // Returns true if the proposal block is complete &&
  722. // (if POLRound was proposed, we have +2/3 prevotes from there).
  723. func (cs *ConsensusState) isProposalComplete() bool {
  724. if cs.Proposal == nil || cs.ProposalBlock == nil {
  725. return false
  726. }
  727. // we have the proposal. if there's a POLRound,
  728. // make sure we have the prevotes from it too
  729. if cs.Proposal.POLRound < 0 {
  730. return true
  731. } else {
  732. // if this is false the proposer is lying or we haven't received the POL yet
  733. return cs.Votes.Prevotes(cs.Proposal.POLRound).HasTwoThirdsMajority()
  734. }
  735. }
  736. // Create the next block to propose and return it.
  737. // Returns nil block upon error.
  738. // NOTE: keep it side-effect free for clarity.
  739. func (cs *ConsensusState) createProposalBlock() (block *types.Block, blockParts *types.PartSet) {
  740. var commit *types.Commit
  741. if cs.Height == 1 {
  742. // We're creating a proposal for the first block.
  743. // The commit is empty, but not nil.
  744. commit = &types.Commit{}
  745. } else if cs.LastCommit.HasTwoThirdsMajority() {
  746. // Make the commit from LastCommit
  747. commit = cs.LastCommit.MakeCommit()
  748. } else {
  749. // This shouldn't happen.
  750. cs.Logger.Error("enterPropose: Cannot propose anything: No commit for the previous block.")
  751. return
  752. }
  753. // Mempool validated transactions
  754. txs := cs.mempool.Reap(cs.config.MaxBlockSizeTxs)
  755. block, parts := cs.state.MakeBlock(cs.Height, txs, commit)
  756. evidence := cs.evpool.PendingEvidence()
  757. block.AddEvidence(evidence)
  758. return block, parts
  759. }
  760. // Enter: `timeoutPropose` after entering Propose.
  761. // Enter: proposal block and POL is ready.
  762. // Enter: any +2/3 prevotes for future round.
  763. // Prevote for LockedBlock if we're locked, or ProposalBlock if valid.
  764. // Otherwise vote nil.
  765. func (cs *ConsensusState) enterPrevote(height int64, round int) {
  766. if cs.Height != height || round < cs.Round || (cs.Round == round && cstypes.RoundStepPrevote <= cs.Step) {
  767. cs.Logger.Debug(cmn.Fmt("enterPrevote(%v/%v): Invalid args. Current step: %v/%v/%v", height, round, cs.Height, cs.Round, cs.Step))
  768. return
  769. }
  770. defer func() {
  771. // Done enterPrevote:
  772. cs.updateRoundStep(round, cstypes.RoundStepPrevote)
  773. cs.newStep()
  774. }()
  775. // fire event for how we got here
  776. if cs.isProposalComplete() {
  777. cs.eventBus.PublishEventCompleteProposal(cs.RoundStateEvent())
  778. } else {
  779. // we received +2/3 prevotes for a future round
  780. // TODO: catchup event?
  781. }
  782. cs.Logger.Info(cmn.Fmt("enterPrevote(%v/%v). Current: %v/%v/%v", height, round, cs.Height, cs.Round, cs.Step))
  783. // Sign and broadcast vote as necessary
  784. cs.doPrevote(height, round)
  785. // Once `addVote` hits any +2/3 prevotes, we will go to PrevoteWait
  786. // (so we have more time to try and collect +2/3 prevotes for a single block)
  787. }
  788. func (cs *ConsensusState) defaultDoPrevote(height int64, round int) {
  789. logger := cs.Logger.With("height", height, "round", round)
  790. // If a block is locked, prevote that.
  791. if cs.LockedBlock != nil {
  792. logger.Info("enterPrevote: Block was locked")
  793. cs.signAddVote(types.VoteTypePrevote, cs.LockedBlock.Hash(), cs.LockedBlockParts.Header())
  794. return
  795. }
  796. // If ProposalBlock is nil, prevote nil.
  797. if cs.ProposalBlock == nil {
  798. logger.Info("enterPrevote: ProposalBlock is nil")
  799. cs.signAddVote(types.VoteTypePrevote, nil, types.PartSetHeader{})
  800. return
  801. }
  802. // Validate proposal block
  803. err := cs.blockExec.ValidateBlock(cs.state, cs.ProposalBlock)
  804. if err != nil {
  805. // ProposalBlock is invalid, prevote nil.
  806. logger.Error("enterPrevote: ProposalBlock is invalid", "err", err)
  807. cs.signAddVote(types.VoteTypePrevote, nil, types.PartSetHeader{})
  808. return
  809. }
  810. // Prevote cs.ProposalBlock
  811. // NOTE: the proposal signature is validated when it is received,
  812. // and the proposal block parts are validated as they are received (against the merkle hash in the proposal)
  813. logger.Info("enterPrevote: ProposalBlock is valid")
  814. cs.signAddVote(types.VoteTypePrevote, cs.ProposalBlock.Hash(), cs.ProposalBlockParts.Header())
  815. }
  816. // Enter: any +2/3 prevotes at next round.
  817. func (cs *ConsensusState) enterPrevoteWait(height int64, round int) {
  818. if cs.Height != height || round < cs.Round || (cs.Round == round && cstypes.RoundStepPrevoteWait <= cs.Step) {
  819. cs.Logger.Debug(cmn.Fmt("enterPrevoteWait(%v/%v): Invalid args. Current step: %v/%v/%v", height, round, cs.Height, cs.Round, cs.Step))
  820. return
  821. }
  822. if !cs.Votes.Prevotes(round).HasTwoThirdsAny() {
  823. cmn.PanicSanity(cmn.Fmt("enterPrevoteWait(%v/%v), but Prevotes does not have any +2/3 votes", height, round))
  824. }
  825. cs.Logger.Info(cmn.Fmt("enterPrevoteWait(%v/%v). Current: %v/%v/%v", height, round, cs.Height, cs.Round, cs.Step))
  826. defer func() {
  827. // Done enterPrevoteWait:
  828. cs.updateRoundStep(round, cstypes.RoundStepPrevoteWait)
  829. cs.newStep()
  830. }()
  831. // Wait for some more prevotes; enterPrecommit
  832. cs.scheduleTimeout(cs.config.Prevote(round), height, round, cstypes.RoundStepPrevoteWait)
  833. }
  834. // Enter: `timeoutPrevote` after any +2/3 prevotes.
  835. // Enter: +2/3 precomits for block or nil.
  836. // Enter: any +2/3 precommits for next round.
  837. // Lock & precommit the ProposalBlock if we have enough prevotes for it (a POL in this round)
  838. // else, unlock an existing lock and precommit nil if +2/3 of prevotes were nil,
  839. // else, precommit nil otherwise.
  840. func (cs *ConsensusState) enterPrecommit(height int64, round int) {
  841. if cs.Height != height || round < cs.Round || (cs.Round == round && cstypes.RoundStepPrecommit <= cs.Step) {
  842. cs.Logger.Debug(cmn.Fmt("enterPrecommit(%v/%v): Invalid args. Current step: %v/%v/%v", height, round, cs.Height, cs.Round, cs.Step))
  843. return
  844. }
  845. cs.Logger.Info(cmn.Fmt("enterPrecommit(%v/%v). Current: %v/%v/%v", height, round, cs.Height, cs.Round, cs.Step))
  846. defer func() {
  847. // Done enterPrecommit:
  848. cs.updateRoundStep(round, cstypes.RoundStepPrecommit)
  849. cs.newStep()
  850. }()
  851. blockID, ok := cs.Votes.Prevotes(round).TwoThirdsMajority()
  852. // If we don't have a polka, we must precommit nil
  853. if !ok {
  854. if cs.LockedBlock != nil {
  855. cs.Logger.Info("enterPrecommit: No +2/3 prevotes during enterPrecommit while we're locked. Precommitting nil")
  856. } else {
  857. cs.Logger.Info("enterPrecommit: No +2/3 prevotes during enterPrecommit. Precommitting nil.")
  858. }
  859. cs.signAddVote(types.VoteTypePrecommit, nil, types.PartSetHeader{})
  860. return
  861. }
  862. // At this point +2/3 prevoted for a particular block or nil
  863. cs.eventBus.PublishEventPolka(cs.RoundStateEvent())
  864. // the latest POLRound should be this round
  865. polRound, _ := cs.Votes.POLInfo()
  866. if polRound < round {
  867. cmn.PanicSanity(cmn.Fmt("This POLRound should be %v but got %", round, polRound))
  868. }
  869. // +2/3 prevoted nil. Unlock and precommit nil.
  870. if len(blockID.Hash) == 0 {
  871. if cs.LockedBlock == nil {
  872. cs.Logger.Info("enterPrecommit: +2/3 prevoted for nil.")
  873. } else {
  874. cs.Logger.Info("enterPrecommit: +2/3 prevoted for nil. Unlocking")
  875. cs.LockedRound = 0
  876. cs.LockedBlock = nil
  877. cs.LockedBlockParts = nil
  878. cs.eventBus.PublishEventUnlock(cs.RoundStateEvent())
  879. }
  880. cs.signAddVote(types.VoteTypePrecommit, nil, types.PartSetHeader{})
  881. return
  882. }
  883. // At this point, +2/3 prevoted for a particular block.
  884. // If we're already locked on that block, precommit it, and update the LockedRound
  885. if cs.LockedBlock.HashesTo(blockID.Hash) {
  886. cs.Logger.Info("enterPrecommit: +2/3 prevoted locked block. Relocking")
  887. cs.LockedRound = round
  888. cs.eventBus.PublishEventRelock(cs.RoundStateEvent())
  889. cs.signAddVote(types.VoteTypePrecommit, blockID.Hash, blockID.PartsHeader)
  890. return
  891. }
  892. // If +2/3 prevoted for proposal block, stage and precommit it
  893. if cs.ProposalBlock.HashesTo(blockID.Hash) {
  894. cs.Logger.Info("enterPrecommit: +2/3 prevoted proposal block. Locking", "hash", blockID.Hash)
  895. // Validate the block.
  896. if err := cs.blockExec.ValidateBlock(cs.state, cs.ProposalBlock); err != nil {
  897. cmn.PanicConsensus(cmn.Fmt("enterPrecommit: +2/3 prevoted for an invalid block: %v", err))
  898. }
  899. cs.LockedRound = round
  900. cs.LockedBlock = cs.ProposalBlock
  901. cs.LockedBlockParts = cs.ProposalBlockParts
  902. cs.eventBus.PublishEventLock(cs.RoundStateEvent())
  903. cs.signAddVote(types.VoteTypePrecommit, blockID.Hash, blockID.PartsHeader)
  904. return
  905. }
  906. // There was a polka in this round for a block we don't have.
  907. // Fetch that block, unlock, and precommit nil.
  908. // The +2/3 prevotes for this round is the POL for our unlock.
  909. // TODO: In the future save the POL prevotes for justification.
  910. cs.LockedRound = 0
  911. cs.LockedBlock = nil
  912. cs.LockedBlockParts = nil
  913. if !cs.ProposalBlockParts.HasHeader(blockID.PartsHeader) {
  914. cs.ProposalBlock = nil
  915. cs.ProposalBlockParts = types.NewPartSetFromHeader(blockID.PartsHeader)
  916. }
  917. cs.eventBus.PublishEventUnlock(cs.RoundStateEvent())
  918. cs.signAddVote(types.VoteTypePrecommit, nil, types.PartSetHeader{})
  919. }
  920. // Enter: any +2/3 precommits for next round.
  921. func (cs *ConsensusState) enterPrecommitWait(height int64, round int) {
  922. if cs.Height != height || round < cs.Round || (cs.Round == round && cstypes.RoundStepPrecommitWait <= cs.Step) {
  923. cs.Logger.Debug(cmn.Fmt("enterPrecommitWait(%v/%v): Invalid args. Current step: %v/%v/%v", height, round, cs.Height, cs.Round, cs.Step))
  924. return
  925. }
  926. if !cs.Votes.Precommits(round).HasTwoThirdsAny() {
  927. cmn.PanicSanity(cmn.Fmt("enterPrecommitWait(%v/%v), but Precommits does not have any +2/3 votes", height, round))
  928. }
  929. cs.Logger.Info(cmn.Fmt("enterPrecommitWait(%v/%v). Current: %v/%v/%v", height, round, cs.Height, cs.Round, cs.Step))
  930. defer func() {
  931. // Done enterPrecommitWait:
  932. cs.updateRoundStep(round, cstypes.RoundStepPrecommitWait)
  933. cs.newStep()
  934. }()
  935. // Wait for some more precommits; enterNewRound
  936. cs.scheduleTimeout(cs.config.Precommit(round), height, round, cstypes.RoundStepPrecommitWait)
  937. }
  938. // Enter: +2/3 precommits for block
  939. func (cs *ConsensusState) enterCommit(height int64, commitRound int) {
  940. if cs.Height != height || cstypes.RoundStepCommit <= cs.Step {
  941. cs.Logger.Debug(cmn.Fmt("enterCommit(%v/%v): Invalid args. Current step: %v/%v/%v", height, commitRound, cs.Height, cs.Round, cs.Step))
  942. return
  943. }
  944. cs.Logger.Info(cmn.Fmt("enterCommit(%v/%v). Current: %v/%v/%v", height, commitRound, cs.Height, cs.Round, cs.Step))
  945. defer func() {
  946. // Done enterCommit:
  947. // keep cs.Round the same, commitRound points to the right Precommits set.
  948. cs.updateRoundStep(cs.Round, cstypes.RoundStepCommit)
  949. cs.CommitRound = commitRound
  950. cs.CommitTime = time.Now()
  951. cs.newStep()
  952. // Maybe finalize immediately.
  953. cs.tryFinalizeCommit(height)
  954. }()
  955. blockID, ok := cs.Votes.Precommits(commitRound).TwoThirdsMajority()
  956. if !ok {
  957. cmn.PanicSanity("RunActionCommit() expects +2/3 precommits")
  958. }
  959. // The Locked* fields no longer matter.
  960. // Move them over to ProposalBlock if they match the commit hash,
  961. // otherwise they'll be cleared in updateToState.
  962. if cs.LockedBlock.HashesTo(blockID.Hash) {
  963. cs.ProposalBlock = cs.LockedBlock
  964. cs.ProposalBlockParts = cs.LockedBlockParts
  965. }
  966. // If we don't have the block being committed, set up to get it.
  967. if !cs.ProposalBlock.HashesTo(blockID.Hash) {
  968. if !cs.ProposalBlockParts.HasHeader(blockID.PartsHeader) {
  969. // We're getting the wrong block.
  970. // Set up ProposalBlockParts and keep waiting.
  971. cs.ProposalBlock = nil
  972. cs.ProposalBlockParts = types.NewPartSetFromHeader(blockID.PartsHeader)
  973. } else {
  974. // We just need to keep waiting.
  975. }
  976. }
  977. }
  978. // If we have the block AND +2/3 commits for it, finalize.
  979. func (cs *ConsensusState) tryFinalizeCommit(height int64) {
  980. if cs.Height != height {
  981. cmn.PanicSanity(cmn.Fmt("tryFinalizeCommit() cs.Height: %v vs height: %v", cs.Height, height))
  982. }
  983. blockID, ok := cs.Votes.Precommits(cs.CommitRound).TwoThirdsMajority()
  984. if !ok || len(blockID.Hash) == 0 {
  985. cs.Logger.Error("Attempt to finalize failed. There was no +2/3 majority, or +2/3 was for <nil>.", "height", height)
  986. return
  987. }
  988. if !cs.ProposalBlock.HashesTo(blockID.Hash) {
  989. // TODO: this happens every time if we're not a validator (ugly logs)
  990. // TODO: ^^ wait, why does it matter that we're a validator?
  991. cs.Logger.Info("Attempt to finalize failed. We don't have the commit block.", "height", height, "proposal-block", cs.ProposalBlock.Hash(), "commit-block", blockID.Hash)
  992. return
  993. }
  994. // go
  995. cs.finalizeCommit(height)
  996. }
  997. // Increment height and goto cstypes.RoundStepNewHeight
  998. func (cs *ConsensusState) finalizeCommit(height int64) {
  999. if cs.Height != height || cs.Step != cstypes.RoundStepCommit {
  1000. cs.Logger.Debug(cmn.Fmt("finalizeCommit(%v): Invalid args. Current step: %v/%v/%v", height, cs.Height, cs.Round, cs.Step))
  1001. return
  1002. }
  1003. blockID, ok := cs.Votes.Precommits(cs.CommitRound).TwoThirdsMajority()
  1004. block, blockParts := cs.ProposalBlock, cs.ProposalBlockParts
  1005. if !ok {
  1006. cmn.PanicSanity(cmn.Fmt("Cannot finalizeCommit, commit does not have two thirds majority"))
  1007. }
  1008. if !blockParts.HasHeader(blockID.PartsHeader) {
  1009. cmn.PanicSanity(cmn.Fmt("Expected ProposalBlockParts header to be commit header"))
  1010. }
  1011. if !block.HashesTo(blockID.Hash) {
  1012. cmn.PanicSanity(cmn.Fmt("Cannot finalizeCommit, ProposalBlock does not hash to commit hash"))
  1013. }
  1014. if err := cs.blockExec.ValidateBlock(cs.state, block); err != nil {
  1015. cmn.PanicConsensus(cmn.Fmt("+2/3 committed an invalid block: %v", err))
  1016. }
  1017. cs.Logger.Info(cmn.Fmt("Finalizing commit of block with %d txs", block.NumTxs),
  1018. "height", block.Height, "hash", block.Hash(), "root", block.AppHash)
  1019. cs.Logger.Info(cmn.Fmt("%v", block))
  1020. fail.Fail() // XXX
  1021. // Save to blockStore.
  1022. if cs.blockStore.Height() < block.Height {
  1023. // NOTE: the seenCommit is local justification to commit this block,
  1024. // but may differ from the LastCommit included in the next block
  1025. precommits := cs.Votes.Precommits(cs.CommitRound)
  1026. seenCommit := precommits.MakeCommit()
  1027. cs.blockStore.SaveBlock(block, blockParts, seenCommit)
  1028. } else {
  1029. // Happens during replay if we already saved the block but didn't commit
  1030. cs.Logger.Info("Calling finalizeCommit on already stored block", "height", block.Height)
  1031. }
  1032. fail.Fail() // XXX
  1033. // Finish writing to the WAL for this height.
  1034. // NOTE: If we fail before writing this, we'll never write it,
  1035. // and just recover by running ApplyBlock in the Handshake.
  1036. // If we moved it before persisting the block, we'd have to allow
  1037. // WAL replay for blocks with an #ENDHEIGHT
  1038. // As is, ConsensusState should not be started again
  1039. // until we successfully call ApplyBlock (ie. here or in Handshake after restart)
  1040. cs.wal.Save(EndHeightMessage{height})
  1041. fail.Fail() // XXX
  1042. // Create a copy of the state for staging
  1043. // and an event cache for txs
  1044. stateCopy := cs.state.Copy()
  1045. // Execute and commit the block, update and save the state, and update the mempool.
  1046. // NOTE: the block.AppHash wont reflect these txs until the next block
  1047. var err error
  1048. stateCopy, err = cs.blockExec.ApplyBlock(stateCopy, types.BlockID{block.Hash(), blockParts.Header()}, block)
  1049. if err != nil {
  1050. cs.Logger.Error("Error on ApplyBlock. Did the application crash? Please restart tendermint", "err", err)
  1051. err := cmn.Kill()
  1052. if err != nil {
  1053. cs.Logger.Error("Failed to kill this process - please do so manually", "err", err)
  1054. }
  1055. return
  1056. }
  1057. fail.Fail() // XXX
  1058. // NewHeightStep!
  1059. cs.updateToState(stateCopy)
  1060. fail.Fail() // XXX
  1061. // cs.StartTime is already set.
  1062. // Schedule Round0 to start soon.
  1063. cs.scheduleRound0(&cs.RoundState)
  1064. // By here,
  1065. // * cs.Height has been increment to height+1
  1066. // * cs.Step is now cstypes.RoundStepNewHeight
  1067. // * cs.StartTime is set to when we will start round0.
  1068. }
  1069. //-----------------------------------------------------------------------------
  1070. func (cs *ConsensusState) defaultSetProposal(proposal *types.Proposal) error {
  1071. // Already have one
  1072. // TODO: possibly catch double proposals
  1073. if cs.Proposal != nil {
  1074. return nil
  1075. }
  1076. // Does not apply
  1077. if proposal.Height != cs.Height || proposal.Round != cs.Round {
  1078. return nil
  1079. }
  1080. // We don't care about the proposal if we're already in cstypes.RoundStepCommit.
  1081. if cstypes.RoundStepCommit <= cs.Step {
  1082. return nil
  1083. }
  1084. // Verify POLRound, which must be -1 or between 0 and proposal.Round exclusive.
  1085. if proposal.POLRound != -1 &&
  1086. (proposal.POLRound < 0 || proposal.Round <= proposal.POLRound) {
  1087. return ErrInvalidProposalPOLRound
  1088. }
  1089. // Verify signature
  1090. if !cs.Validators.GetProposer().PubKey.VerifyBytes(types.SignBytes(cs.state.ChainID, proposal), proposal.Signature) {
  1091. return ErrInvalidProposalSignature
  1092. }
  1093. cs.Proposal = proposal
  1094. cs.ProposalBlockParts = types.NewPartSetFromHeader(proposal.BlockPartsHeader)
  1095. return nil
  1096. }
  1097. // NOTE: block is not necessarily valid.
  1098. // Asynchronously triggers either enterPrevote (before we timeout of propose) or tryFinalizeCommit, once we have the full block.
  1099. func (cs *ConsensusState) addProposalBlockPart(height int64, part *types.Part, verify bool) (added bool, err error) {
  1100. // Blocks might be reused, so round mismatch is OK
  1101. if cs.Height != height {
  1102. return false, nil
  1103. }
  1104. // We're not expecting a block part.
  1105. if cs.ProposalBlockParts == nil {
  1106. return false, nil // TODO: bad peer? Return error?
  1107. }
  1108. added, err = cs.ProposalBlockParts.AddPart(part, verify)
  1109. if err != nil {
  1110. return added, err
  1111. }
  1112. if added && cs.ProposalBlockParts.IsComplete() {
  1113. // Added and completed!
  1114. var n int
  1115. var err error
  1116. cs.ProposalBlock = wire.ReadBinary(&types.Block{}, cs.ProposalBlockParts.GetReader(),
  1117. cs.state.ConsensusParams.BlockSize.MaxBytes, &n, &err).(*types.Block)
  1118. // NOTE: it's possible to receive complete proposal blocks for future rounds without having the proposal
  1119. cs.Logger.Info("Received complete proposal block", "height", cs.ProposalBlock.Height, "hash", cs.ProposalBlock.Hash())
  1120. if cs.Step == cstypes.RoundStepPropose && cs.isProposalComplete() {
  1121. // Move onto the next step
  1122. cs.enterPrevote(height, cs.Round)
  1123. } else if cs.Step == cstypes.RoundStepCommit {
  1124. // If we're waiting on the proposal block...
  1125. cs.tryFinalizeCommit(height)
  1126. }
  1127. return true, err
  1128. }
  1129. return added, nil
  1130. }
  1131. // Attempt to add the vote. if its a duplicate signature, dupeout the validator
  1132. func (cs *ConsensusState) tryAddVote(vote *types.Vote, peerID p2p.ID) error {
  1133. _, err := cs.addVote(vote, peerID)
  1134. if err != nil {
  1135. // If the vote height is off, we'll just ignore it,
  1136. // But if it's a conflicting sig, add it to the cs.evpool.
  1137. // If it's otherwise invalid, punish peer.
  1138. if err == ErrVoteHeightMismatch {
  1139. return err
  1140. } else if voteErr, ok := err.(*types.ErrVoteConflictingVotes); ok {
  1141. if bytes.Equal(vote.ValidatorAddress, cs.privValidator.GetAddress()) {
  1142. cs.Logger.Error("Found conflicting vote from ourselves. Did you unsafe_reset a validator?", "height", vote.Height, "round", vote.Round, "type", vote.Type)
  1143. return err
  1144. }
  1145. cs.evpool.AddEvidence(voteErr.DuplicateVoteEvidence)
  1146. return err
  1147. } else {
  1148. // Probably an invalid signature / Bad peer.
  1149. // Seems this can also err sometimes with "Unexpected step" - perhaps not from a bad peer ?
  1150. cs.Logger.Error("Error attempting to add vote", "err", err)
  1151. return ErrAddingVote
  1152. }
  1153. }
  1154. return nil
  1155. }
  1156. //-----------------------------------------------------------------------------
  1157. func (cs *ConsensusState) addVote(vote *types.Vote, peerID p2p.ID) (added bool, err error) {
  1158. cs.Logger.Debug("addVote", "voteHeight", vote.Height, "voteType", vote.Type, "valIndex", vote.ValidatorIndex, "csHeight", cs.Height)
  1159. // A precommit for the previous height?
  1160. // These come in while we wait timeoutCommit
  1161. if vote.Height+1 == cs.Height {
  1162. if !(cs.Step == cstypes.RoundStepNewHeight && vote.Type == types.VoteTypePrecommit) {
  1163. // TODO: give the reason ..
  1164. // fmt.Errorf("tryAddVote: Wrong height, not a LastCommit straggler commit.")
  1165. return added, ErrVoteHeightMismatch
  1166. }
  1167. added, err = cs.LastCommit.AddVote(vote)
  1168. if added {
  1169. cs.Logger.Info(cmn.Fmt("Added to lastPrecommits: %v", cs.LastCommit.StringShort()))
  1170. cs.eventBus.PublishEventVote(types.EventDataVote{vote})
  1171. // if we can skip timeoutCommit and have all the votes now,
  1172. if cs.config.SkipTimeoutCommit && cs.LastCommit.HasAll() {
  1173. // go straight to new round (skip timeout commit)
  1174. // cs.scheduleTimeout(time.Duration(0), cs.Height, 0, cstypes.RoundStepNewHeight)
  1175. cs.enterNewRound(cs.Height, 0)
  1176. }
  1177. }
  1178. return
  1179. }
  1180. // A prevote/precommit for this height?
  1181. if vote.Height == cs.Height {
  1182. height := cs.Height
  1183. added, err = cs.Votes.AddVote(vote, peerID)
  1184. if added {
  1185. cs.eventBus.PublishEventVote(types.EventDataVote{vote})
  1186. switch vote.Type {
  1187. case types.VoteTypePrevote:
  1188. prevotes := cs.Votes.Prevotes(vote.Round)
  1189. cs.Logger.Info("Added to prevote", "vote", vote, "prevotes", prevotes.StringShort())
  1190. // First, unlock if prevotes is a valid POL.
  1191. // >> lockRound < POLRound <= unlockOrChangeLockRound (see spec)
  1192. // NOTE: If (lockRound < POLRound) but !(POLRound <= unlockOrChangeLockRound),
  1193. // we'll still enterNewRound(H,vote.R) and enterPrecommit(H,vote.R) to process it
  1194. // there.
  1195. if (cs.LockedBlock != nil) && (cs.LockedRound < vote.Round) && (vote.Round <= cs.Round) {
  1196. blockID, ok := prevotes.TwoThirdsMajority()
  1197. if ok && !cs.LockedBlock.HashesTo(blockID.Hash) {
  1198. cs.Logger.Info("Unlocking because of POL.", "lockedRound", cs.LockedRound, "POLRound", vote.Round)
  1199. cs.LockedRound = 0
  1200. cs.LockedBlock = nil
  1201. cs.LockedBlockParts = nil
  1202. cs.eventBus.PublishEventUnlock(cs.RoundStateEvent())
  1203. }
  1204. }
  1205. if cs.Round <= vote.Round && prevotes.HasTwoThirdsAny() {
  1206. // Round-skip over to PrevoteWait or goto Precommit.
  1207. cs.enterNewRound(height, vote.Round) // if the vote is ahead of us
  1208. if prevotes.HasTwoThirdsMajority() {
  1209. cs.enterPrecommit(height, vote.Round)
  1210. } else {
  1211. cs.enterPrevote(height, vote.Round) // if the vote is ahead of us
  1212. cs.enterPrevoteWait(height, vote.Round)
  1213. }
  1214. } else if cs.Proposal != nil && 0 <= cs.Proposal.POLRound && cs.Proposal.POLRound == vote.Round {
  1215. // If the proposal is now complete, enter prevote of cs.Round.
  1216. if cs.isProposalComplete() {
  1217. cs.enterPrevote(height, cs.Round)
  1218. }
  1219. }
  1220. case types.VoteTypePrecommit:
  1221. precommits := cs.Votes.Precommits(vote.Round)
  1222. cs.Logger.Info("Added to precommit", "vote", vote, "precommits", precommits.StringShort())
  1223. blockID, ok := precommits.TwoThirdsMajority()
  1224. if ok {
  1225. if len(blockID.Hash) == 0 {
  1226. cs.enterNewRound(height, vote.Round+1)
  1227. } else {
  1228. cs.enterNewRound(height, vote.Round)
  1229. cs.enterPrecommit(height, vote.Round)
  1230. cs.enterCommit(height, vote.Round)
  1231. if cs.config.SkipTimeoutCommit && precommits.HasAll() {
  1232. // if we have all the votes now,
  1233. // go straight to new round (skip timeout commit)
  1234. // cs.scheduleTimeout(time.Duration(0), cs.Height, 0, cstypes.RoundStepNewHeight)
  1235. cs.enterNewRound(cs.Height, 0)
  1236. }
  1237. }
  1238. } else if cs.Round <= vote.Round && precommits.HasTwoThirdsAny() {
  1239. cs.enterNewRound(height, vote.Round)
  1240. cs.enterPrecommit(height, vote.Round)
  1241. cs.enterPrecommitWait(height, vote.Round)
  1242. }
  1243. default:
  1244. cmn.PanicSanity(cmn.Fmt("Unexpected vote type %X", vote.Type)) // Should not happen.
  1245. }
  1246. }
  1247. // Either duplicate, or error upon cs.Votes.AddByIndex()
  1248. return
  1249. } else {
  1250. err = ErrVoteHeightMismatch
  1251. }
  1252. // Height mismatch, bad peer?
  1253. cs.Logger.Info("Vote ignored and not added", "voteHeight", vote.Height, "csHeight", cs.Height, "err", err)
  1254. return
  1255. }
  1256. func (cs *ConsensusState) signVote(type_ byte, hash []byte, header types.PartSetHeader) (*types.Vote, error) {
  1257. addr := cs.privValidator.GetAddress()
  1258. valIndex, _ := cs.Validators.GetByAddress(addr)
  1259. vote := &types.Vote{
  1260. ValidatorAddress: addr,
  1261. ValidatorIndex: valIndex,
  1262. Height: cs.Height,
  1263. Round: cs.Round,
  1264. Timestamp: time.Now().UTC(),
  1265. Type: type_,
  1266. BlockID: types.BlockID{hash, header},
  1267. }
  1268. err := cs.privValidator.SignVote(cs.state.ChainID, vote)
  1269. return vote, err
  1270. }
  1271. // sign the vote and publish on internalMsgQueue
  1272. func (cs *ConsensusState) signAddVote(type_ byte, hash []byte, header types.PartSetHeader) *types.Vote {
  1273. // if we don't have a key or we're not in the validator set, do nothing
  1274. if cs.privValidator == nil || !cs.Validators.HasAddress(cs.privValidator.GetAddress()) {
  1275. return nil
  1276. }
  1277. vote, err := cs.signVote(type_, hash, header)
  1278. if err == nil {
  1279. cs.sendInternalMessage(msgInfo{&VoteMessage{vote}, ""})
  1280. cs.Logger.Info("Signed and pushed vote", "height", cs.Height, "round", cs.Round, "vote", vote, "err", err)
  1281. return vote
  1282. } else {
  1283. //if !cs.replayMode {
  1284. cs.Logger.Error("Error signing vote", "height", cs.Height, "round", cs.Round, "vote", vote, "err", err)
  1285. //}
  1286. return nil
  1287. }
  1288. }
  1289. //---------------------------------------------------------
  1290. func CompareHRS(h1 int64, r1 int, s1 cstypes.RoundStepType, h2 int64, r2 int, s2 cstypes.RoundStepType) int {
  1291. if h1 < h2 {
  1292. return -1
  1293. } else if h1 > h2 {
  1294. return 1
  1295. }
  1296. if r1 < r2 {
  1297. return -1
  1298. } else if r1 > r2 {
  1299. return 1
  1300. }
  1301. if s1 < s2 {
  1302. return -1
  1303. } else if s1 > s2 {
  1304. return 1
  1305. }
  1306. return 0
  1307. }