You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

634 lines
16 KiB

blockchain: Reorg reactor (#3561) * go routines in blockchain reactor * Added reference to the go routine diagram * Initial commit * cleanup * Undo testing_logger change, committed by mistake * Fix the test loggers * pulled some fsm code into pool.go * added pool tests * changes to the design added block requests under peer moved the request trigger in the reactor poolRoutine, triggered now by a ticker in general moved everything required for making block requests smarter in the poolRoutine added a simple map of heights to keep track of what will need to be requested next added a few more tests * send errors to FSM in a different channel than blocks send errors (RemovePeer) from switch on a different channel than the one receiving blocks renamed channels added more pool tests * more pool tests * lint errors * more tests * more tests * switch fast sync to new implementation * fixed data race in tests * cleanup * finished fsm tests * address golangci comments :) * address golangci comments :) * Added timeout on next block needed to advance * updating docs and cleanup * fix issue in test from previous cleanup * cleanup * Added termination scenarios, tests and more cleanup * small fixes to adr, comments and cleanup * Fix bug in sendRequest() If we tried to send a request to a peer not present in the switch, a missing continue statement caused the request to be blackholed in a peer that was removed and never retried. While this bug was manifesting, the reactor kept asking for other blocks that would be stored and never consumed. Added the number of unconsumed blocks in the math for requesting blocks ahead of current processing height so eventually there will be no more blocks requested until the already received ones are consumed. * remove bpPeer's didTimeout field * Use distinct err codes for peer timeout and FSM timeouts * Don't allow peers to update with lower height * review comments from Ethan and Zarko * some cleanup, renaming, comments * Move block execution in separate goroutine * Remove pool's numPending * review comments * fix lint, remove old blockchain reactor and duplicates in fsm tests * small reorg around peer after review comments * add the reactor spec * verify block only once * review comments * change to int for max number of pending requests * cleanup and godoc * Add configuration flag fast sync version * golangci fixes * fix config template * move both reactor versions under blockchain * cleanup, golint, renaming stuff * updated documentation, fixed more golint warnings * integrate with behavior package * sync with master * gofmt * add changelog_pending entry * move to improvments * suggestion to changelog entry
6 years ago
10 years ago
8 years ago
blockchain: Reorg reactor (#3561) * go routines in blockchain reactor * Added reference to the go routine diagram * Initial commit * cleanup * Undo testing_logger change, committed by mistake * Fix the test loggers * pulled some fsm code into pool.go * added pool tests * changes to the design added block requests under peer moved the request trigger in the reactor poolRoutine, triggered now by a ticker in general moved everything required for making block requests smarter in the poolRoutine added a simple map of heights to keep track of what will need to be requested next added a few more tests * send errors to FSM in a different channel than blocks send errors (RemovePeer) from switch on a different channel than the one receiving blocks renamed channels added more pool tests * more pool tests * lint errors * more tests * more tests * switch fast sync to new implementation * fixed data race in tests * cleanup * finished fsm tests * address golangci comments :) * address golangci comments :) * Added timeout on next block needed to advance * updating docs and cleanup * fix issue in test from previous cleanup * cleanup * Added termination scenarios, tests and more cleanup * small fixes to adr, comments and cleanup * Fix bug in sendRequest() If we tried to send a request to a peer not present in the switch, a missing continue statement caused the request to be blackholed in a peer that was removed and never retried. While this bug was manifesting, the reactor kept asking for other blocks that would be stored and never consumed. Added the number of unconsumed blocks in the math for requesting blocks ahead of current processing height so eventually there will be no more blocks requested until the already received ones are consumed. * remove bpPeer's didTimeout field * Use distinct err codes for peer timeout and FSM timeouts * Don't allow peers to update with lower height * review comments from Ethan and Zarko * some cleanup, renaming, comments * Move block execution in separate goroutine * Remove pool's numPending * review comments * fix lint, remove old blockchain reactor and duplicates in fsm tests * small reorg around peer after review comments * add the reactor spec * verify block only once * review comments * change to int for max number of pending requests * cleanup and godoc * Add configuration flag fast sync version * golangci fixes * fix config template * move both reactor versions under blockchain * cleanup, golint, renaming stuff * updated documentation, fixed more golint warnings * integrate with behavior package * sync with master * gofmt * add changelog_pending entry * move to improvments * suggestion to changelog entry
6 years ago
8 years ago
9 years ago
10 years ago
blockchain: Reorg reactor (#3561) * go routines in blockchain reactor * Added reference to the go routine diagram * Initial commit * cleanup * Undo testing_logger change, committed by mistake * Fix the test loggers * pulled some fsm code into pool.go * added pool tests * changes to the design added block requests under peer moved the request trigger in the reactor poolRoutine, triggered now by a ticker in general moved everything required for making block requests smarter in the poolRoutine added a simple map of heights to keep track of what will need to be requested next added a few more tests * send errors to FSM in a different channel than blocks send errors (RemovePeer) from switch on a different channel than the one receiving blocks renamed channels added more pool tests * more pool tests * lint errors * more tests * more tests * switch fast sync to new implementation * fixed data race in tests * cleanup * finished fsm tests * address golangci comments :) * address golangci comments :) * Added timeout on next block needed to advance * updating docs and cleanup * fix issue in test from previous cleanup * cleanup * Added termination scenarios, tests and more cleanup * small fixes to adr, comments and cleanup * Fix bug in sendRequest() If we tried to send a request to a peer not present in the switch, a missing continue statement caused the request to be blackholed in a peer that was removed and never retried. While this bug was manifesting, the reactor kept asking for other blocks that would be stored and never consumed. Added the number of unconsumed blocks in the math for requesting blocks ahead of current processing height so eventually there will be no more blocks requested until the already received ones are consumed. * remove bpPeer's didTimeout field * Use distinct err codes for peer timeout and FSM timeouts * Don't allow peers to update with lower height * review comments from Ethan and Zarko * some cleanup, renaming, comments * Move block execution in separate goroutine * Remove pool's numPending * review comments * fix lint, remove old blockchain reactor and duplicates in fsm tests * small reorg around peer after review comments * add the reactor spec * verify block only once * review comments * change to int for max number of pending requests * cleanup and godoc * Add configuration flag fast sync version * golangci fixes * fix config template * move both reactor versions under blockchain * cleanup, golint, renaming stuff * updated documentation, fixed more golint warnings * integrate with behavior package * sync with master * gofmt * add changelog_pending entry * move to improvments * suggestion to changelog entry
6 years ago
blockchain: Reorg reactor (#3561) * go routines in blockchain reactor * Added reference to the go routine diagram * Initial commit * cleanup * Undo testing_logger change, committed by mistake * Fix the test loggers * pulled some fsm code into pool.go * added pool tests * changes to the design added block requests under peer moved the request trigger in the reactor poolRoutine, triggered now by a ticker in general moved everything required for making block requests smarter in the poolRoutine added a simple map of heights to keep track of what will need to be requested next added a few more tests * send errors to FSM in a different channel than blocks send errors (RemovePeer) from switch on a different channel than the one receiving blocks renamed channels added more pool tests * more pool tests * lint errors * more tests * more tests * switch fast sync to new implementation * fixed data race in tests * cleanup * finished fsm tests * address golangci comments :) * address golangci comments :) * Added timeout on next block needed to advance * updating docs and cleanup * fix issue in test from previous cleanup * cleanup * Added termination scenarios, tests and more cleanup * small fixes to adr, comments and cleanup * Fix bug in sendRequest() If we tried to send a request to a peer not present in the switch, a missing continue statement caused the request to be blackholed in a peer that was removed and never retried. While this bug was manifesting, the reactor kept asking for other blocks that would be stored and never consumed. Added the number of unconsumed blocks in the math for requesting blocks ahead of current processing height so eventually there will be no more blocks requested until the already received ones are consumed. * remove bpPeer's didTimeout field * Use distinct err codes for peer timeout and FSM timeouts * Don't allow peers to update with lower height * review comments from Ethan and Zarko * some cleanup, renaming, comments * Move block execution in separate goroutine * Remove pool's numPending * review comments * fix lint, remove old blockchain reactor and duplicates in fsm tests * small reorg around peer after review comments * add the reactor spec * verify block only once * review comments * change to int for max number of pending requests * cleanup and godoc * Add configuration flag fast sync version * golangci fixes * fix config template * move both reactor versions under blockchain * cleanup, golint, renaming stuff * updated documentation, fixed more golint warnings * integrate with behavior package * sync with master * gofmt * add changelog_pending entry * move to improvments * suggestion to changelog entry
6 years ago
blockchain: Reorg reactor (#3561) * go routines in blockchain reactor * Added reference to the go routine diagram * Initial commit * cleanup * Undo testing_logger change, committed by mistake * Fix the test loggers * pulled some fsm code into pool.go * added pool tests * changes to the design added block requests under peer moved the request trigger in the reactor poolRoutine, triggered now by a ticker in general moved everything required for making block requests smarter in the poolRoutine added a simple map of heights to keep track of what will need to be requested next added a few more tests * send errors to FSM in a different channel than blocks send errors (RemovePeer) from switch on a different channel than the one receiving blocks renamed channels added more pool tests * more pool tests * lint errors * more tests * more tests * switch fast sync to new implementation * fixed data race in tests * cleanup * finished fsm tests * address golangci comments :) * address golangci comments :) * Added timeout on next block needed to advance * updating docs and cleanup * fix issue in test from previous cleanup * cleanup * Added termination scenarios, tests and more cleanup * small fixes to adr, comments and cleanup * Fix bug in sendRequest() If we tried to send a request to a peer not present in the switch, a missing continue statement caused the request to be blackholed in a peer that was removed and never retried. While this bug was manifesting, the reactor kept asking for other blocks that would be stored and never consumed. Added the number of unconsumed blocks in the math for requesting blocks ahead of current processing height so eventually there will be no more blocks requested until the already received ones are consumed. * remove bpPeer's didTimeout field * Use distinct err codes for peer timeout and FSM timeouts * Don't allow peers to update with lower height * review comments from Ethan and Zarko * some cleanup, renaming, comments * Move block execution in separate goroutine * Remove pool's numPending * review comments * fix lint, remove old blockchain reactor and duplicates in fsm tests * small reorg around peer after review comments * add the reactor spec * verify block only once * review comments * change to int for max number of pending requests * cleanup and godoc * Add configuration flag fast sync version * golangci fixes * fix config template * move both reactor versions under blockchain * cleanup, golint, renaming stuff * updated documentation, fixed more golint warnings * integrate with behavior package * sync with master * gofmt * add changelog_pending entry * move to improvments * suggestion to changelog entry
6 years ago
blockchain: Reorg reactor (#3561) * go routines in blockchain reactor * Added reference to the go routine diagram * Initial commit * cleanup * Undo testing_logger change, committed by mistake * Fix the test loggers * pulled some fsm code into pool.go * added pool tests * changes to the design added block requests under peer moved the request trigger in the reactor poolRoutine, triggered now by a ticker in general moved everything required for making block requests smarter in the poolRoutine added a simple map of heights to keep track of what will need to be requested next added a few more tests * send errors to FSM in a different channel than blocks send errors (RemovePeer) from switch on a different channel than the one receiving blocks renamed channels added more pool tests * more pool tests * lint errors * more tests * more tests * switch fast sync to new implementation * fixed data race in tests * cleanup * finished fsm tests * address golangci comments :) * address golangci comments :) * Added timeout on next block needed to advance * updating docs and cleanup * fix issue in test from previous cleanup * cleanup * Added termination scenarios, tests and more cleanup * small fixes to adr, comments and cleanup * Fix bug in sendRequest() If we tried to send a request to a peer not present in the switch, a missing continue statement caused the request to be blackholed in a peer that was removed and never retried. While this bug was manifesting, the reactor kept asking for other blocks that would be stored and never consumed. Added the number of unconsumed blocks in the math for requesting blocks ahead of current processing height so eventually there will be no more blocks requested until the already received ones are consumed. * remove bpPeer's didTimeout field * Use distinct err codes for peer timeout and FSM timeouts * Don't allow peers to update with lower height * review comments from Ethan and Zarko * some cleanup, renaming, comments * Move block execution in separate goroutine * Remove pool's numPending * review comments * fix lint, remove old blockchain reactor and duplicates in fsm tests * small reorg around peer after review comments * add the reactor spec * verify block only once * review comments * change to int for max number of pending requests * cleanup and godoc * Add configuration flag fast sync version * golangci fixes * fix config template * move both reactor versions under blockchain * cleanup, golint, renaming stuff * updated documentation, fixed more golint warnings * integrate with behavior package * sync with master * gofmt * add changelog_pending entry * move to improvments * suggestion to changelog entry
6 years ago
fix invalid memory address or nil pointer dereference error (Refs #762) https://github.com/tendermint/tendermint/issues/762#issuecomment-338276055 ``` E[10-19|04:52:38.969] Stopping peer for error module=p2p peer="Peer{MConn{178.62.46.14:46656} B14916FAF38A out}" err="Error: runtime error: invalid memory address or nil pointer dereference\nStack: goroutine 529485 [running]:\nruntime/debug.Stack(0xc4355cfb38, 0xb463e0, 0x11b1c30)\n\t/usr/local/go/src/runtime/debug/stack.go:24 +0xa7\ngithub.com/cosmos/gaia/vendor/github.com/tendermint/tendermint/p2p.(*MConnection)._recover(0xc439a28870)\n\t/home/ubuntu/go/src/github.com/cosmos/gaia/vendor/github.com/tendermint/tendermint/p2p/connection.go:206 +0x6e\npanic(0xb463e0, 0x11b1c30)\n\t/usr/local/go/src/runtime/panic.go:491 +0x283\ngithub.com/cosmos/gaia/vendor/github.com/tendermint/tendermint/blockchain.(*bpPeer).decrPending(0x0, 0x381)\n\t/home/ubuntu/go/src/github.com/cosmos/gaia/vendor/github.com/tendermint/tendermint/blockchain/pool.go:376 +0x22\ngithub.com/cosmos/gaia/vendor/github.com/tendermint/tendermint/blockchain.(*BlockPool).AddBlock(0xc4200e4000, 0xc4266d1f00, 0x40, 0xc432ac9640, 0x381)\n\t/home/ubuntu/go/src/github.com/cosmos/gaia/vendor/github.com/tendermint/tendermint/blockchain/pool.go:215 +0x139\ngithub.com/cosmos/gaia/vendor/github.com/tendermint/tendermint/blockchain.(*BlockchainReactor).Receive(0xc42050a780, 0xc420257740, 0x1171be0, 0xc42ff302d0, 0xc4384b2000, 0x381, 0x1000)\n\t/home/ubuntu/go/src/github.com/cosmos/gaia/vendor/github.com/tendermint/tendermint/blockchain/reactor.go:160 +0x712\ngithub.com/cosmos/gaia/vendor/github.com/tendermint/tendermint/p2p.createMConnection.func1(0x11e5040, 0xc4384b2000, 0x381, 0x1000)\n\t/home/ubuntu/go/src/github.com/cosmos/gaia/vendor/github.com/tendermint/tendermint/p2p/peer.go:334 +0xbd\ngithub.com/cosmos/gaia/vendor/github.com/tendermint/tendermint/p2p.(*MConnection).recvRoutine(0xc439a28870)\n\t/home/ubuntu/go/src/github.com/cosmos/gaia/vendor/github.com/tendermint/tendermint/p2p/connection.go:475 +0x4a3\ncreated by github.com/cosmos/gaia/vendor/github.com/tendermint/tendermint/p2p.(*MConnection).OnStart\n\t/home/ubuntu/go/src/github.com/cosmos/gaia/vendor/github.com/tendermint/tendermint/p2p/connection.go:170 +0x187\n" ```
7 years ago
8 years ago
8 years ago
8 years ago
8 years ago
blockchain: Reorg reactor (#3561) * go routines in blockchain reactor * Added reference to the go routine diagram * Initial commit * cleanup * Undo testing_logger change, committed by mistake * Fix the test loggers * pulled some fsm code into pool.go * added pool tests * changes to the design added block requests under peer moved the request trigger in the reactor poolRoutine, triggered now by a ticker in general moved everything required for making block requests smarter in the poolRoutine added a simple map of heights to keep track of what will need to be requested next added a few more tests * send errors to FSM in a different channel than blocks send errors (RemovePeer) from switch on a different channel than the one receiving blocks renamed channels added more pool tests * more pool tests * lint errors * more tests * more tests * switch fast sync to new implementation * fixed data race in tests * cleanup * finished fsm tests * address golangci comments :) * address golangci comments :) * Added timeout on next block needed to advance * updating docs and cleanup * fix issue in test from previous cleanup * cleanup * Added termination scenarios, tests and more cleanup * small fixes to adr, comments and cleanup * Fix bug in sendRequest() If we tried to send a request to a peer not present in the switch, a missing continue statement caused the request to be blackholed in a peer that was removed and never retried. While this bug was manifesting, the reactor kept asking for other blocks that would be stored and never consumed. Added the number of unconsumed blocks in the math for requesting blocks ahead of current processing height so eventually there will be no more blocks requested until the already received ones are consumed. * remove bpPeer's didTimeout field * Use distinct err codes for peer timeout and FSM timeouts * Don't allow peers to update with lower height * review comments from Ethan and Zarko * some cleanup, renaming, comments * Move block execution in separate goroutine * Remove pool's numPending * review comments * fix lint, remove old blockchain reactor and duplicates in fsm tests * small reorg around peer after review comments * add the reactor spec * verify block only once * review comments * change to int for max number of pending requests * cleanup and godoc * Add configuration flag fast sync version * golangci fixes * fix config template * move both reactor versions under blockchain * cleanup, golint, renaming stuff * updated documentation, fixed more golint warnings * integrate with behavior package * sync with master * gofmt * add changelog_pending entry * move to improvments * suggestion to changelog entry
6 years ago
blockchain: Reorg reactor (#3561) * go routines in blockchain reactor * Added reference to the go routine diagram * Initial commit * cleanup * Undo testing_logger change, committed by mistake * Fix the test loggers * pulled some fsm code into pool.go * added pool tests * changes to the design added block requests under peer moved the request trigger in the reactor poolRoutine, triggered now by a ticker in general moved everything required for making block requests smarter in the poolRoutine added a simple map of heights to keep track of what will need to be requested next added a few more tests * send errors to FSM in a different channel than blocks send errors (RemovePeer) from switch on a different channel than the one receiving blocks renamed channels added more pool tests * more pool tests * lint errors * more tests * more tests * switch fast sync to new implementation * fixed data race in tests * cleanup * finished fsm tests * address golangci comments :) * address golangci comments :) * Added timeout on next block needed to advance * updating docs and cleanup * fix issue in test from previous cleanup * cleanup * Added termination scenarios, tests and more cleanup * small fixes to adr, comments and cleanup * Fix bug in sendRequest() If we tried to send a request to a peer not present in the switch, a missing continue statement caused the request to be blackholed in a peer that was removed and never retried. While this bug was manifesting, the reactor kept asking for other blocks that would be stored and never consumed. Added the number of unconsumed blocks in the math for requesting blocks ahead of current processing height so eventually there will be no more blocks requested until the already received ones are consumed. * remove bpPeer's didTimeout field * Use distinct err codes for peer timeout and FSM timeouts * Don't allow peers to update with lower height * review comments from Ethan and Zarko * some cleanup, renaming, comments * Move block execution in separate goroutine * Remove pool's numPending * review comments * fix lint, remove old blockchain reactor and duplicates in fsm tests * small reorg around peer after review comments * add the reactor spec * verify block only once * review comments * change to int for max number of pending requests * cleanup and godoc * Add configuration flag fast sync version * golangci fixes * fix config template * move both reactor versions under blockchain * cleanup, golint, renaming stuff * updated documentation, fixed more golint warnings * integrate with behavior package * sync with master * gofmt * add changelog_pending entry * move to improvments * suggestion to changelog entry
6 years ago
blockchain: Reorg reactor (#3561) * go routines in blockchain reactor * Added reference to the go routine diagram * Initial commit * cleanup * Undo testing_logger change, committed by mistake * Fix the test loggers * pulled some fsm code into pool.go * added pool tests * changes to the design added block requests under peer moved the request trigger in the reactor poolRoutine, triggered now by a ticker in general moved everything required for making block requests smarter in the poolRoutine added a simple map of heights to keep track of what will need to be requested next added a few more tests * send errors to FSM in a different channel than blocks send errors (RemovePeer) from switch on a different channel than the one receiving blocks renamed channels added more pool tests * more pool tests * lint errors * more tests * more tests * switch fast sync to new implementation * fixed data race in tests * cleanup * finished fsm tests * address golangci comments :) * address golangci comments :) * Added timeout on next block needed to advance * updating docs and cleanup * fix issue in test from previous cleanup * cleanup * Added termination scenarios, tests and more cleanup * small fixes to adr, comments and cleanup * Fix bug in sendRequest() If we tried to send a request to a peer not present in the switch, a missing continue statement caused the request to be blackholed in a peer that was removed and never retried. While this bug was manifesting, the reactor kept asking for other blocks that would be stored and never consumed. Added the number of unconsumed blocks in the math for requesting blocks ahead of current processing height so eventually there will be no more blocks requested until the already received ones are consumed. * remove bpPeer's didTimeout field * Use distinct err codes for peer timeout and FSM timeouts * Don't allow peers to update with lower height * review comments from Ethan and Zarko * some cleanup, renaming, comments * Move block execution in separate goroutine * Remove pool's numPending * review comments * fix lint, remove old blockchain reactor and duplicates in fsm tests * small reorg around peer after review comments * add the reactor spec * verify block only once * review comments * change to int for max number of pending requests * cleanup and godoc * Add configuration flag fast sync version * golangci fixes * fix config template * move both reactor versions under blockchain * cleanup, golint, renaming stuff * updated documentation, fixed more golint warnings * integrate with behavior package * sync with master * gofmt * add changelog_pending entry * move to improvments * suggestion to changelog entry
6 years ago
  1. package v0
  2. import (
  3. "errors"
  4. "fmt"
  5. "math"
  6. "sync"
  7. "sync/atomic"
  8. "time"
  9. cmn "github.com/tendermint/tendermint/libs/common"
  10. flow "github.com/tendermint/tendermint/libs/flowrate"
  11. "github.com/tendermint/tendermint/libs/log"
  12. "github.com/tendermint/tendermint/p2p"
  13. "github.com/tendermint/tendermint/types"
  14. )
  15. /*
  16. eg, L = latency = 0.1s
  17. P = num peers = 10
  18. FN = num full nodes
  19. BS = 1kB block size
  20. CB = 1 Mbit/s = 128 kB/s
  21. CB/P = 12.8 kB
  22. B/S = CB/P/BS = 12.8 blocks/s
  23. 12.8 * 0.1 = 1.28 blocks on conn
  24. */
  25. const (
  26. requestIntervalMS = 2
  27. maxTotalRequesters = 600
  28. maxPendingRequests = maxTotalRequesters
  29. maxPendingRequestsPerPeer = 20
  30. // Minimum recv rate to ensure we're receiving blocks from a peer fast
  31. // enough. If a peer is not sending us data at at least that rate, we
  32. // consider them to have timedout and we disconnect.
  33. //
  34. // Assuming a DSL connection (not a good choice) 128 Kbps (upload) ~ 15 KB/s,
  35. // sending data across atlantic ~ 7.5 KB/s.
  36. minRecvRate = 7680
  37. // Maximum difference between current and new block's height.
  38. maxDiffBetweenCurrentAndReceivedBlockHeight = 100
  39. )
  40. var peerTimeout = 15 * time.Second // not const so we can override with tests
  41. /*
  42. Peers self report their heights when we join the block pool.
  43. Starting from our latest pool.height, we request blocks
  44. in sequence from peers that reported higher heights than ours.
  45. Every so often we ask peers what height they're on so we can keep going.
  46. Requests are continuously made for blocks of higher heights until
  47. the limit is reached. If most of the requests have no available peers, and we
  48. are not at peer limits, we can probably switch to consensus reactor
  49. */
  50. // BlockPool keeps track of the fast sync peers, block requests and block responses.
  51. type BlockPool struct {
  52. cmn.BaseService
  53. startTime time.Time
  54. mtx sync.Mutex
  55. // block requests
  56. requesters map[int64]*bpRequester
  57. height int64 // the lowest key in requesters.
  58. // peers
  59. peers map[p2p.ID]*bpPeer
  60. maxPeerHeight int64 // the biggest reported height
  61. // atomic
  62. numPending int32 // number of requests pending assignment or block response
  63. requestsCh chan<- BlockRequest
  64. errorsCh chan<- peerError
  65. }
  66. // NewBlockPool returns a new BlockPool with the height equal to start. Block
  67. // requests and errors will be sent to requestsCh and errorsCh accordingly.
  68. func NewBlockPool(start int64, requestsCh chan<- BlockRequest, errorsCh chan<- peerError) *BlockPool {
  69. bp := &BlockPool{
  70. peers: make(map[p2p.ID]*bpPeer),
  71. requesters: make(map[int64]*bpRequester),
  72. height: start,
  73. numPending: 0,
  74. requestsCh: requestsCh,
  75. errorsCh: errorsCh,
  76. }
  77. bp.BaseService = *cmn.NewBaseService(nil, "BlockPool", bp)
  78. return bp
  79. }
  80. // OnStart implements cmn.Service by spawning requesters routine and recording
  81. // pool's start time.
  82. func (pool *BlockPool) OnStart() error {
  83. go pool.makeRequestersRoutine()
  84. pool.startTime = time.Now()
  85. return nil
  86. }
  87. // spawns requesters as needed
  88. func (pool *BlockPool) makeRequestersRoutine() {
  89. for {
  90. if !pool.IsRunning() {
  91. break
  92. }
  93. _, numPending, lenRequesters := pool.GetStatus()
  94. switch {
  95. case numPending >= maxPendingRequests:
  96. // sleep for a bit.
  97. time.Sleep(requestIntervalMS * time.Millisecond)
  98. // check for timed out peers
  99. pool.removeTimedoutPeers()
  100. case lenRequesters >= maxTotalRequesters:
  101. // sleep for a bit.
  102. time.Sleep(requestIntervalMS * time.Millisecond)
  103. // check for timed out peers
  104. pool.removeTimedoutPeers()
  105. default:
  106. // request for more blocks.
  107. pool.makeNextRequester()
  108. }
  109. }
  110. }
  111. func (pool *BlockPool) removeTimedoutPeers() {
  112. pool.mtx.Lock()
  113. defer pool.mtx.Unlock()
  114. for _, peer := range pool.peers {
  115. if !peer.didTimeout && peer.numPending > 0 {
  116. curRate := peer.recvMonitor.Status().CurRate
  117. // curRate can be 0 on start
  118. if curRate != 0 && curRate < minRecvRate {
  119. err := errors.New("peer is not sending us data fast enough")
  120. pool.sendError(err, peer.id)
  121. pool.Logger.Error("SendTimeout", "peer", peer.id,
  122. "reason", err,
  123. "curRate", fmt.Sprintf("%d KB/s", curRate/1024),
  124. "minRate", fmt.Sprintf("%d KB/s", minRecvRate/1024))
  125. peer.didTimeout = true
  126. }
  127. }
  128. if peer.didTimeout {
  129. pool.removePeer(peer.id)
  130. }
  131. }
  132. }
  133. // GetStatus returns pool's height, numPending requests and the number of
  134. // requesters.
  135. func (pool *BlockPool) GetStatus() (height int64, numPending int32, lenRequesters int) {
  136. pool.mtx.Lock()
  137. defer pool.mtx.Unlock()
  138. return pool.height, atomic.LoadInt32(&pool.numPending), len(pool.requesters)
  139. }
  140. // IsCaughtUp returns true if this node is caught up, false - otherwise.
  141. // TODO: relax conditions, prevent abuse.
  142. func (pool *BlockPool) IsCaughtUp() bool {
  143. pool.mtx.Lock()
  144. defer pool.mtx.Unlock()
  145. // Need at least 1 peer to be considered caught up.
  146. if len(pool.peers) == 0 {
  147. pool.Logger.Debug("Blockpool has no peers")
  148. return false
  149. }
  150. // Some conditions to determine if we're caught up.
  151. // Ensures we've either received a block or waited some amount of time,
  152. // and that we're synced to the highest known height.
  153. // Note we use maxPeerHeight - 1 because to sync block H requires block H+1
  154. // to verify the LastCommit.
  155. receivedBlockOrTimedOut := pool.height > 0 || time.Since(pool.startTime) > 5*time.Second
  156. ourChainIsLongestAmongPeers := pool.maxPeerHeight == 0 || pool.height >= (pool.maxPeerHeight-1)
  157. isCaughtUp := receivedBlockOrTimedOut && ourChainIsLongestAmongPeers
  158. return isCaughtUp
  159. }
  160. // PeekTwoBlocks returns blocks at pool.height and pool.height+1.
  161. // We need to see the second block's Commit to validate the first block.
  162. // So we peek two blocks at a time.
  163. // The caller will verify the commit.
  164. func (pool *BlockPool) PeekTwoBlocks() (first *types.Block, second *types.Block) {
  165. pool.mtx.Lock()
  166. defer pool.mtx.Unlock()
  167. if r := pool.requesters[pool.height]; r != nil {
  168. first = r.getBlock()
  169. }
  170. if r := pool.requesters[pool.height+1]; r != nil {
  171. second = r.getBlock()
  172. }
  173. return
  174. }
  175. // PopRequest pops the first block at pool.height.
  176. // It must have been validated by 'second'.Commit from PeekTwoBlocks().
  177. func (pool *BlockPool) PopRequest() {
  178. pool.mtx.Lock()
  179. defer pool.mtx.Unlock()
  180. if r := pool.requesters[pool.height]; r != nil {
  181. /* The block can disappear at any time, due to removePeer().
  182. if r := pool.requesters[pool.height]; r == nil || r.block == nil {
  183. PanicSanity("PopRequest() requires a valid block")
  184. }
  185. */
  186. r.Stop()
  187. delete(pool.requesters, pool.height)
  188. pool.height++
  189. } else {
  190. panic(fmt.Sprintf("Expected requester to pop, got nothing at height %v", pool.height))
  191. }
  192. }
  193. // RedoRequest invalidates the block at pool.height,
  194. // Remove the peer and redo request from others.
  195. // Returns the ID of the removed peer.
  196. func (pool *BlockPool) RedoRequest(height int64) p2p.ID {
  197. pool.mtx.Lock()
  198. defer pool.mtx.Unlock()
  199. request := pool.requesters[height]
  200. peerID := request.getPeerID()
  201. if peerID != p2p.ID("") {
  202. // RemovePeer will redo all requesters associated with this peer.
  203. pool.removePeer(peerID)
  204. }
  205. return peerID
  206. }
  207. // AddBlock validates that the block comes from the peer it was expected from and calls the requester to store it.
  208. // TODO: ensure that blocks come in order for each peer.
  209. func (pool *BlockPool) AddBlock(peerID p2p.ID, block *types.Block, blockSize int) {
  210. pool.mtx.Lock()
  211. defer pool.mtx.Unlock()
  212. requester := pool.requesters[block.Height]
  213. if requester == nil {
  214. pool.Logger.Info("peer sent us a block we didn't expect", "peer", peerID, "curHeight", pool.height, "blockHeight", block.Height)
  215. diff := pool.height - block.Height
  216. if diff < 0 {
  217. diff *= -1
  218. }
  219. if diff > maxDiffBetweenCurrentAndReceivedBlockHeight {
  220. pool.sendError(errors.New("peer sent us a block we didn't expect with a height too far ahead/behind"), peerID)
  221. }
  222. return
  223. }
  224. if requester.setBlock(block, peerID) {
  225. atomic.AddInt32(&pool.numPending, -1)
  226. peer := pool.peers[peerID]
  227. if peer != nil {
  228. peer.decrPending(blockSize)
  229. }
  230. } else {
  231. pool.Logger.Info("invalid peer", "peer", peerID, "blockHeight", block.Height)
  232. pool.sendError(errors.New("invalid peer"), peerID)
  233. }
  234. }
  235. // MaxPeerHeight returns the highest reported height.
  236. func (pool *BlockPool) MaxPeerHeight() int64 {
  237. pool.mtx.Lock()
  238. defer pool.mtx.Unlock()
  239. return pool.maxPeerHeight
  240. }
  241. // SetPeerHeight sets the peer's alleged blockchain height.
  242. func (pool *BlockPool) SetPeerHeight(peerID p2p.ID, height int64) {
  243. pool.mtx.Lock()
  244. defer pool.mtx.Unlock()
  245. peer := pool.peers[peerID]
  246. if peer != nil {
  247. peer.height = height
  248. } else {
  249. peer = newBPPeer(pool, peerID, height)
  250. peer.setLogger(pool.Logger.With("peer", peerID))
  251. pool.peers[peerID] = peer
  252. }
  253. if height > pool.maxPeerHeight {
  254. pool.maxPeerHeight = height
  255. }
  256. }
  257. // RemovePeer removes the peer with peerID from the pool. If there's no peer
  258. // with peerID, function is a no-op.
  259. func (pool *BlockPool) RemovePeer(peerID p2p.ID) {
  260. pool.mtx.Lock()
  261. defer pool.mtx.Unlock()
  262. pool.removePeer(peerID)
  263. }
  264. func (pool *BlockPool) removePeer(peerID p2p.ID) {
  265. for _, requester := range pool.requesters {
  266. if requester.getPeerID() == peerID {
  267. requester.redo(peerID)
  268. }
  269. }
  270. peer, ok := pool.peers[peerID]
  271. if ok {
  272. if peer.timeout != nil {
  273. peer.timeout.Stop()
  274. }
  275. delete(pool.peers, peerID)
  276. // Find a new peer with the biggest height and update maxPeerHeight if the
  277. // peer's height was the biggest.
  278. if peer.height == pool.maxPeerHeight {
  279. pool.updateMaxPeerHeight()
  280. }
  281. }
  282. }
  283. // If no peers are left, maxPeerHeight is set to 0.
  284. func (pool *BlockPool) updateMaxPeerHeight() {
  285. var max int64
  286. for _, peer := range pool.peers {
  287. if peer.height > max {
  288. max = peer.height
  289. }
  290. }
  291. pool.maxPeerHeight = max
  292. }
  293. // Pick an available peer with at least the given minHeight.
  294. // If no peers are available, returns nil.
  295. func (pool *BlockPool) pickIncrAvailablePeer(minHeight int64) *bpPeer {
  296. pool.mtx.Lock()
  297. defer pool.mtx.Unlock()
  298. for _, peer := range pool.peers {
  299. if peer.didTimeout {
  300. pool.removePeer(peer.id)
  301. continue
  302. }
  303. if peer.numPending >= maxPendingRequestsPerPeer {
  304. continue
  305. }
  306. if peer.height < minHeight {
  307. continue
  308. }
  309. peer.incrPending()
  310. return peer
  311. }
  312. return nil
  313. }
  314. func (pool *BlockPool) makeNextRequester() {
  315. pool.mtx.Lock()
  316. defer pool.mtx.Unlock()
  317. nextHeight := pool.height + pool.requestersLen()
  318. if nextHeight > pool.maxPeerHeight {
  319. return
  320. }
  321. request := newBPRequester(pool, nextHeight)
  322. pool.requesters[nextHeight] = request
  323. atomic.AddInt32(&pool.numPending, 1)
  324. err := request.Start()
  325. if err != nil {
  326. request.Logger.Error("Error starting request", "err", err)
  327. }
  328. }
  329. func (pool *BlockPool) requestersLen() int64 {
  330. return int64(len(pool.requesters))
  331. }
  332. func (pool *BlockPool) sendRequest(height int64, peerID p2p.ID) {
  333. if !pool.IsRunning() {
  334. return
  335. }
  336. pool.requestsCh <- BlockRequest{height, peerID}
  337. }
  338. func (pool *BlockPool) sendError(err error, peerID p2p.ID) {
  339. if !pool.IsRunning() {
  340. return
  341. }
  342. pool.errorsCh <- peerError{err, peerID}
  343. }
  344. // for debugging purposes
  345. //nolint:unused
  346. func (pool *BlockPool) debug() string {
  347. pool.mtx.Lock()
  348. defer pool.mtx.Unlock()
  349. str := ""
  350. nextHeight := pool.height + pool.requestersLen()
  351. for h := pool.height; h < nextHeight; h++ {
  352. if pool.requesters[h] == nil {
  353. str += fmt.Sprintf("H(%v):X ", h)
  354. } else {
  355. str += fmt.Sprintf("H(%v):", h)
  356. str += fmt.Sprintf("B?(%v) ", pool.requesters[h].block != nil)
  357. }
  358. }
  359. return str
  360. }
  361. //-------------------------------------
  362. type bpPeer struct {
  363. pool *BlockPool
  364. id p2p.ID
  365. recvMonitor *flow.Monitor
  366. height int64
  367. numPending int32
  368. timeout *time.Timer
  369. didTimeout bool
  370. logger log.Logger
  371. }
  372. func newBPPeer(pool *BlockPool, peerID p2p.ID, height int64) *bpPeer {
  373. peer := &bpPeer{
  374. pool: pool,
  375. id: peerID,
  376. height: height,
  377. numPending: 0,
  378. logger: log.NewNopLogger(),
  379. }
  380. return peer
  381. }
  382. func (peer *bpPeer) setLogger(l log.Logger) {
  383. peer.logger = l
  384. }
  385. func (peer *bpPeer) resetMonitor() {
  386. peer.recvMonitor = flow.New(time.Second, time.Second*40)
  387. initialValue := float64(minRecvRate) * math.E
  388. peer.recvMonitor.SetREMA(initialValue)
  389. }
  390. func (peer *bpPeer) resetTimeout() {
  391. if peer.timeout == nil {
  392. peer.timeout = time.AfterFunc(peerTimeout, peer.onTimeout)
  393. } else {
  394. peer.timeout.Reset(peerTimeout)
  395. }
  396. }
  397. func (peer *bpPeer) incrPending() {
  398. if peer.numPending == 0 {
  399. peer.resetMonitor()
  400. peer.resetTimeout()
  401. }
  402. peer.numPending++
  403. }
  404. func (peer *bpPeer) decrPending(recvSize int) {
  405. peer.numPending--
  406. if peer.numPending == 0 {
  407. peer.timeout.Stop()
  408. } else {
  409. peer.recvMonitor.Update(recvSize)
  410. peer.resetTimeout()
  411. }
  412. }
  413. func (peer *bpPeer) onTimeout() {
  414. peer.pool.mtx.Lock()
  415. defer peer.pool.mtx.Unlock()
  416. err := errors.New("peer did not send us anything")
  417. peer.pool.sendError(err, peer.id)
  418. peer.logger.Error("SendTimeout", "reason", err, "timeout", peerTimeout)
  419. peer.didTimeout = true
  420. }
  421. //-------------------------------------
  422. type bpRequester struct {
  423. cmn.BaseService
  424. pool *BlockPool
  425. height int64
  426. gotBlockCh chan struct{}
  427. redoCh chan p2p.ID //redo may send multitime, add peerId to identify repeat
  428. mtx sync.Mutex
  429. peerID p2p.ID
  430. block *types.Block
  431. }
  432. func newBPRequester(pool *BlockPool, height int64) *bpRequester {
  433. bpr := &bpRequester{
  434. pool: pool,
  435. height: height,
  436. gotBlockCh: make(chan struct{}, 1),
  437. redoCh: make(chan p2p.ID, 1),
  438. peerID: "",
  439. block: nil,
  440. }
  441. bpr.BaseService = *cmn.NewBaseService(nil, "bpRequester", bpr)
  442. return bpr
  443. }
  444. func (bpr *bpRequester) OnStart() error {
  445. go bpr.requestRoutine()
  446. return nil
  447. }
  448. // Returns true if the peer matches and block doesn't already exist.
  449. func (bpr *bpRequester) setBlock(block *types.Block, peerID p2p.ID) bool {
  450. bpr.mtx.Lock()
  451. if bpr.block != nil || bpr.peerID != peerID {
  452. bpr.mtx.Unlock()
  453. return false
  454. }
  455. bpr.block = block
  456. bpr.mtx.Unlock()
  457. select {
  458. case bpr.gotBlockCh <- struct{}{}:
  459. default:
  460. }
  461. return true
  462. }
  463. func (bpr *bpRequester) getBlock() *types.Block {
  464. bpr.mtx.Lock()
  465. defer bpr.mtx.Unlock()
  466. return bpr.block
  467. }
  468. func (bpr *bpRequester) getPeerID() p2p.ID {
  469. bpr.mtx.Lock()
  470. defer bpr.mtx.Unlock()
  471. return bpr.peerID
  472. }
  473. // This is called from the requestRoutine, upon redo().
  474. func (bpr *bpRequester) reset() {
  475. bpr.mtx.Lock()
  476. defer bpr.mtx.Unlock()
  477. if bpr.block != nil {
  478. atomic.AddInt32(&bpr.pool.numPending, 1)
  479. }
  480. bpr.peerID = ""
  481. bpr.block = nil
  482. }
  483. // Tells bpRequester to pick another peer and try again.
  484. // NOTE: Nonblocking, and does nothing if another redo
  485. // was already requested.
  486. func (bpr *bpRequester) redo(peerID p2p.ID) {
  487. select {
  488. case bpr.redoCh <- peerID:
  489. default:
  490. }
  491. }
  492. // Responsible for making more requests as necessary
  493. // Returns only when a block is found (e.g. AddBlock() is called)
  494. func (bpr *bpRequester) requestRoutine() {
  495. OUTER_LOOP:
  496. for {
  497. // Pick a peer to send request to.
  498. var peer *bpPeer
  499. PICK_PEER_LOOP:
  500. for {
  501. if !bpr.IsRunning() || !bpr.pool.IsRunning() {
  502. return
  503. }
  504. peer = bpr.pool.pickIncrAvailablePeer(bpr.height)
  505. if peer == nil {
  506. //log.Info("No peers available", "height", height)
  507. time.Sleep(requestIntervalMS * time.Millisecond)
  508. continue PICK_PEER_LOOP
  509. }
  510. break PICK_PEER_LOOP
  511. }
  512. bpr.mtx.Lock()
  513. bpr.peerID = peer.id
  514. bpr.mtx.Unlock()
  515. // Send request and wait.
  516. bpr.pool.sendRequest(bpr.height, peer.id)
  517. WAIT_LOOP:
  518. for {
  519. select {
  520. case <-bpr.pool.Quit():
  521. bpr.Stop()
  522. return
  523. case <-bpr.Quit():
  524. return
  525. case peerID := <-bpr.redoCh:
  526. if peerID == bpr.peerID {
  527. bpr.reset()
  528. continue OUTER_LOOP
  529. } else {
  530. continue WAIT_LOOP
  531. }
  532. case <-bpr.gotBlockCh:
  533. // We got a block!
  534. // Continue the for-loop and wait til Quit.
  535. continue WAIT_LOOP
  536. }
  537. }
  538. }
  539. }
  540. // BlockRequest stores a block request identified by the block Height and the PeerID responsible for
  541. // delivering the block
  542. type BlockRequest struct {
  543. Height int64
  544. PeerID p2p.ID
  545. }