tendermint

bft blockchain consensus consistency cryptocurrency cryptography db distributed-systems go

History

Anton Kaliaev 480b995a31 consensus: Do not allow signatures for a wrong block in commits Closes #4926 The dump consensus state had this: "last_commit": { "votes": [ "Vote{0:04CBBF43CA3E 385085/00/2(Precommit) 1B73DA9FC4C8 42C97B86D89D @ 2020-05-27T06:46:51.042392895Z}", "Vote{1:055799E028FA 385085/00/2(Precommit) 652B08AD61EA 0D507D7FA3AB @ 2020-06-28T04:57:29.20793209Z}", "Vote{2:056024CFA910 385085/00/2(Precommit) 652B08AD61EA C8E95532A4C3 @ 2020-06-28T04:57:29.452696998Z}", "Vote{3:0741C95814DA 385085/00/2(Precommit) 652B08AD61EA 36D567615F7C @ 2020-06-28T04:57:29.279788593Z}", Note there's a precommit in there from the first val from May (2020-05-27) while the rest are from today (2020-06-28). It suggests there's a validator from an old instance of the network at this height (they're using the same chain-id!). Obviously a single bad validator shouldn't be an issue. But the Commit refactor work introduced a bug. When we propose a block, we get the block.LastCommit by calling MakeCommit on the set of precommits we saw for the last height. This set may include precommits for a different block, and hence the block.LastCommit we propose may include precommits that aren't actually for the last block (but of course +2/3 will be). Before v0.33, we just skipped over these precommits during verification. But in v0.33, we expect all signatures for a blockID to be for the same block ID! Thus we end up proposing a block that we can't verify.		4 years ago
..
time	types/time: add note about stripping monotonic part	6 years ago
block.go	evidence: improve amnesia evidence handling (#5003)	4 years ago
block_meta.go	proto: folder structure adhere to buf (#5025)	4 years ago
block_meta_test.go	types: rename partsheader to partsetheader (#5029)	4 years ago
block_test.go	evidence: replace mock evidence with mocked duplicate vote evidence (#5036)	4 years ago
canonical.go	proto: folder structure adhere to buf (#5025)	4 years ago
canonical_test.go	proto: folder structure adhere to buf (#5025)	4 years ago
encoding_helper.go	proto: leftover amino (#4986)	4 years ago
errors.go	types: change `Commit` to consist of just signatures (#4146)	5 years ago
event_bus.go	state: proto migration (#4951)	4 years ago
event_bus_test.go	state: proto migration (#4951)	4 years ago
events.go	proto: leftover amino (#4986)	4 years ago
events_test.go	add tests for events public funcs	6 years ago
evidence.go	types: verify commit fully	4 years ago
evidence_test.go	evidence: replace mock evidence with mocked duplicate vote evidence (#5036)	4 years ago
genesis.go	proto: folder structure adhere to buf (#5025)	4 years ago
genesis_test.go	migrate all JSON to new JSON encoder (#4975)	4 years ago
keys.go	consensus: fixes #1754	6 years ago
params.go	types: add AppVersion to ConsensusParams (#5031)	4 years ago
params_test.go	types: add AppVersion to ConsensusParams (#5031)	4 years ago
part_set.go	proto: folder structure adhere to buf (#5025)	4 years ago
part_set_test.go	crypto/merkle: remove simple prefix (#4989)	4 years ago
priv_validator.go	proto: folder structure adhere to buf (#5025)	4 years ago
proposal.go	proto: folder structure adhere to buf (#5025)	4 years ago
proposal_test.go	proto: folder structure adhere to buf (#5025)	4 years ago
protobuf.go	evidence: replace mock evidence with mocked duplicate vote evidence (#5036)	4 years ago
protobuf_test.go	proto: leftover amino (#4986)	4 years ago
results.go	[block#LastResultsHash] add Events + GasWanted/Used (#4845)	4 years ago
results_test.go	[block#LastResultsHash] add Events + GasWanted/Used (#4845)	4 years ago
signable.go	libs/common: Refactor libs/common 5 (#4240)	5 years ago
signed_msg_type.go	proto: folder structure adhere to buf (#5025)	4 years ago
test_util.go	proto: folder structure adhere to buf (#5025)	4 years ago
tx.go	proto: folder structure adhere to buf (#5025)	4 years ago
tx_test.go	proto: folder structure adhere to buf (#5025)	4 years ago
utils.go	libs/common: refactor libs common 3 (#4232)	5 years ago
validation.go	linters: enable stylecheck (#4153)	5 years ago
validator.go	proto: folder structure adhere to buf (#5025)	4 years ago
validator_set.go	types: verify commit fully	4 years ago
validator_set_test.go	types: verify commit fully	4 years ago
validator_test.go	types: create ValidateBasic() funcs for validator and validator set (#4905)	5 years ago
vote.go	proto: folder structure adhere to buf (#5025)	4 years ago
vote_set.go	consensus: Do not allow signatures for a wrong block in commits	4 years ago
vote_set_test.go	proto: folder structure adhere to buf (#5025)	4 years ago
vote_test.go	proto: folder structure adhere to buf (#5025)	4 years ago