zolfa/tendermint - tendermint - Gitea: Git with a cup of tea

bft blockchain consensus consistency cryptocurrency cryptography db distributed-systems go

History

Emmanuel Odeke 15ef57c6d0 types: TxEventBuffer.Flush now uses capacity preserving slice clearing idiom Fixes https://github.com/tendermint/tendermint/issues/1189 For every TxEventBuffer.Flush() invoking, we were invoking a: b.events = make([]EventDataTx, 0, b.capacity) whose intention is to innocently clear the events slice but maintain the underlying capacity. However, unfortunately this is memory and garbage collection intensive which is linear in the number of events added. If an attack had access to our code somehow, invoking .Flush() in tight loops would be a sure way to cause huge GC pressure, and say if they added about 1e9 events maliciously, every Flush() would take at least 3.2seconds which is enough to now control our application. The new using of the capacity preserving slice clearing idiom takes a constant time regardless of the number of elements with zero allocations so we are killing many birds with one stone i.e b.events = b.events[:0] For benchmarking results, please see https://gist.github.com/odeke-em/532c14ab67d71c9c0b95518a7a526058 for a reference on how things can get out of hand easily.		7 years ago
..
block.go	replace data.Bytes with cmn.HexBytes	7 years ago
block_meta.go	types: comments	7 years ago
block_test.go	fixes from rebase	7 years ago
canonical_json.go	replace data.Bytes with cmn.HexBytes	7 years ago
event_buffer.go	types: TxEventBuffer.Flush now uses capacity preserving slice clearing idiom	7 years ago
event_buffer_test.go	new pubsub package	7 years ago
event_bus.go	update types	7 years ago
event_bus_test.go	fixes from Bucky's and Emmanuel's reviews	7 years ago
events.go	move fireEvents to ApplyBlock	7 years ago
evidence.go	update types	7 years ago
evidence_test.go	fixes from rebase	7 years ago
genesis.go	replace data.Bytes with cmn.HexBytes	7 years ago
genesis_test.go	Updates -> ValidatoSetUpdates	7 years ago
heartbeat.go	update for sdk2 libs. need to fix kv test	7 years ago
heartbeat_test.go	pass tests!	7 years ago
keys.go	types: comments	7 years ago
nop_event_bus.go	new pubsub package	7 years ago
params.go	update types	7 years ago
params_test.go	fix test	7 years ago
part_set.go	replace data.Bytes with cmn.HexBytes	7 years ago
part_set_test.go	all: no more anonymous imports	7 years ago
priv_validator.go	replace data.Bytes with cmn.HexBytes	7 years ago
priv_validator_test.go	update for sdk2 libs. need to fix kv test	7 years ago
proposal.go	Add timestamp to vote canonical encoding	7 years ago
proposal_test.go	Add more tests for Proposal/Vote serialization	7 years ago
protobuf.go	update for sdk2 libs. need to fix kv test	7 years ago
results.go	replace data.Bytes with cmn.HexBytes	7 years ago
results_test.go	Add /block_results?height=H as rpc endpoint	7 years ago
services.go	call FlushSync before calling CommitSync	7 years ago
signable.go	update types	7 years ago
test_util.go	forgot file	7 years ago
tx.go	replace data.Bytes with cmn.HexBytes	7 years ago
tx_test.go	all: no more anonymous imports	7 years ago
validator.go	update for sdk2 libs. need to fix kv test	7 years ago
validator_set.go	update types	7 years ago
validator_set_test.go	add safe*Clip funcs	7 years ago
vote.go	update for sdk2 libs. need to fix kv test	7 years ago
vote_set.go	improve vague error msg, closes #1158	7 years ago
vote_set_test.go	separate block vs state based validation	7 years ago
vote_test.go	types: Add test for IsVoteTypeValid	7 years ago