tendermint

Commit Graph

Author	SHA1	Message	Date
Zach Ramsay	d033470817	lil fixes	7 years ago
Zach Ramsay	7ad8a8ab55	Tests almost passing	7 years ago
Zach Ramsay	a15c7f221d	linting: moar fixes	7 years ago
Zach Ramsay	d7cb291fb2	errcheck; sort some stuff out	7 years ago
Zach Ramsay	15651a931e	linting errors: tackle p2p package	7 years ago
Zach Ramsay	68e7983c70	linting errors: afew more	7 years ago
Zach Ramsay	8f0237610e	linting errors: clean it all up	7 years ago
Zach Ramsay	b75d4f73e7	errcheck: PR comment fixes	7 years ago
Zach Ramsay	331857c9e6	linting: apply errcheck part2	7 years ago
Zach Ramsay	57ea4987f7	linting: apply errcheck part1	7 years ago
Zach Ramsay	1721543e5c	linting: apply misspell	7 years ago
Zach Ramsay	46ccbcbff6	linting: apply 'gofmt -s -w' throughout	7 years ago
Petabyte Storage	59b3dcb5cf	normalize priority and id and remove pointers in ChannelDescriptor	7 years ago
caffix	887cb6d0cd	added public methods to handle locking within the trust metric	7 years ago
Ethan Buchman	e845987503	p2p: disable trustmetric test while being fixed	7 years ago
Ethan Buchman	c4b695f78d	minor fixes from review	7 years ago
caffix	9c8100043e	made changes to address suggestions from the PR comments	7 years ago
Emmanuel Odeke	031e10133c	p2p: make Switch.DialSeeds use a new PRNG per call Fixes https://github.com/tendermint/tendermint/issues/875 Ensure that every DialSeeds call uses a new PRNG seeded from tendermint/tmlibs/common.RandInt which internally uses crypto/rand to seed its source.	7 years ago
caffix	4087326f45	fixed race condition reported in issue #881	7 years ago
Ethan Buchman	f9bc22ec6a	p2p: fix comment on addPeer (thanks @odeke-em )	7 years ago
Ethan Buchman	26cd99c66e	p2p: fix non-routable addr in test	7 years ago
Emmanuel Odeke	5c34d087d9	p2p: use bytes.Equal for key comparison Updates https://github.com/tendermint/tendermint/issues/850 My security alarms falsely blarred when I skimmed and noticed keys being compared with `==`, without the proper context so I mistakenly filed an issue, yet the purpose of that comparison was to check if the local ephemeral public key was just the least, sorted lexicographically. Anyways, let's use the proper bytes.Equal check, to save future labor.	7 years ago
Ethan Buchman	53f15fde07	update changelog	7 years ago
Ethan Buchman	af0db599b0	minor fixes	7 years ago
Ethan Buchman	feb3230160	some comments	7 years ago
Ethan Buchman	be1a16a601	p2p/pex: simplify ensurePeers	7 years ago
Ethan Buchman	8e044b0e6d	p2p/addrbook: some comments	7 years ago
Ethan Buchman	40e93a5f9e	p2p/addrbook: fix addToOldBucket	7 years ago
Ethan Buchman	435eb6e2b3	p2p/addrbook: add non-terminating test	7 years ago
Ethan Buchman	8c88cc017a	p2p/addrbook: addAddress returns error. more defensive PickAddress	7 years ago
Ethan Buchman	ed95cc160a	p2p/addrbook: simplify PickAddress	7 years ago
Ethan Buchman	2f067a3f65	p2p/addrbook: addrNew/Old -> bucketsNew/Old	7 years ago
Ethan Buchman	498a82784d	p2p/addrbook: comments	7 years ago
Guanghua Guo	b5708825a7	Failed to compile comment code	7 years ago
caffix	a724ffab25	added changes based on PR comments to the proposal	7 years ago
Emmanuel Odeke	3f9dff9aac	p2p: netPipe for <Go1.10 in own file with own build tag Follow up of `283544c7f3` putting <Go1.10 implementation of netPipe in its own file and protect it with its separate build tag.	7 years ago
Emmanuel Odeke	283544c7f3	p2p: use fake net.Pipe since only >=Go1.10 implements SetDeadline Fixes https://github.com/tendermint/tendermint/issues/851 Go1.9 and below's net.Pipe did not implement the SetDeadline method so after commit `e2dd8ca946` this problem was exposed since now we check for errors. To counter this problem, implement a simple composition for net.Conn that always returns nil on SetDeadline instead of tripping out. Added build tags so that anyone using go1.10 when it is released will be able to automatically use net.Pipe's net.Conns	7 years ago
Emmanuel Odeke	7b0fa6c889	p2p: peer should respect errors from SetDeadline Noticed while auditing the code that we aren't respecting (net.Conn) SetDeadline errors which return after a connection has been killed and is simultaneously being used. For example given program, without SetDeadline error checks ```go package main import ( "log" "net" "time" ) func main() { conn, err := net.Dial("tcp", "tendermint.com:443") if err != nil { log.Fatal(err) } go func() { <-time.After(400 time.Millisecond) conn.Close() }() for i := 0; i < 5; i++ { if err := conn.SetDeadline(time.Now().Add(time.Duration(10 * time.Second))); err != nil { log.Fatalf("set deadline #%d, err: %v", i, err) } log.Printf("Successfully set deadline #%d", i) <-time.After(150 * time.Millisecond) } } ``` erraneously gives ```shell 2017/11/14 17:46:28 Successfully set deadline #0 2017/11/14 17:46:29 Successfully set deadline #1 2017/11/14 17:46:29 Successfully set deadline #2 2017/11/14 17:46:29 Successfully set deadline #3 2017/11/14 17:46:29 Successfully set deadline #4 ``` However, if we properly fix it to respect that error with ```diff --- wild.go 2017-11-14 17:44:38.000000000 -0700 +++ main.go 2017-11-14 17:45:40.000000000 -0700 @@ -16,7 +16,9 @@ conn.Close() }() for i := 0; i < 5; i++ { - conn.SetDeadline(time.Now().Add(time.Duration(10 * time.Second))) + if err := conn.SetDeadline(time.Now().Add(time.Duration(10 * time.Second))); err != nil { + log.Fatalf("set deadline #%d, err: %v", i, err) + } log.Printf("Successfully set deadline #%d", i) <-time.After(150 * time.Millisecond) } ``` properly catches any problems and gives ```shell $ go run main.go 2017/11/14 17:43:44 Successfully set deadline #0 2017/11/14 17:43:45 Successfully set deadline #1 2017/11/14 17:43:45 Successfully set deadline #2 2017/11/14 17:43:45 set deadline #3, err: set tcp 10.182.253.51:57395: use of closed network connection exit status 1 ```	7 years ago
caffix	8b7649b90c	enhancements made in response to PR full review comments	7 years ago
caffix	687834c99e	added initial trust metric test routines	7 years ago
caffix	54c25ccbf5	integrated trust metric store as per PR comments	7 years ago
caffix	e160a6198c	added initial trust metric design doc and code	7 years ago
Ethan Buchman	e69d36d54f	some more robust sleeps	7 years ago
Emmanuel Odeke	62c1bc0a20	p2p: comment on the wg.Add before go saveRoutine() Just noticed while auditing the code in p2p/addrbook.go, wg.Add(1) but no subsequent defer. @jaekwon and I had a discussion offline and we agreed to comment about why the code was that way and why we shouldn't move the wg.Add(1) into .saveRoutine() because if go a.saveRoutine() isn't started before anyone invokes a.Wait(), then we'd have raced a.saveRoutine().	7 years ago
Petabyte Storage	3863885c71	WIP: begin parallel refactoring with go-wire Write methods and MConnection	7 years ago
Anton Kaliaev	a1cdc2b68a	set logger for peer's MConnection	7 years ago
Ethan Buchman	c931279960	p2p: some fixes re @odeke-em issues #813,#816,#817	7 years ago
Petabyte Storage	51c9211cf4	add test for MConnection TrySend and Send	7 years ago
Anton Kaliaev	7869e541f6	change MakeConnectedSwitches to not connect to itself and a test for it	7 years ago
Anton Kaliaev	e0daca5693	fixes from Bucky's review	7 years ago

... 2 3 4 5 6 ...

460 Commits (cef053386bc097f72f47628e5c834b851f023209)