tendermint

291 MiB

Tree: 97bdad8262

Author	SHA1	Message	Date
Emmanuel T Odeke	97bdad8262	common: NewBitArray never crashes on negatives (#170 ) Fixes #169 Fixes https://github.com/tendermint/tendermint/issues/1322 The previous code was very trusting assuming that rational actors will use this code. However, Byzantine actors don't care and in the case of the linked issue negative lengths can be sent to this code unfettered having been received from a peer. This code is essentially just a sign change from `==` to `<=` and we've gutted out that attack by being more defensive.	7 years ago
Emmanuel Odeke	763dc21393	common/BitArray: reduce fragility with methods Fixes https://github.com/tendermint/tmlibs/issues/145 Fixes https://github.com/tendermint/tmlibs/issues/146 The code in here has been fragile when it comes to nil but these edge cases were never tested, although they've showed up in the wild and were only noticed because the reporter actually read the logs otherwise we'd have never known. This changes covers some of these cases and adds some tests.	7 years ago
Emmanuel Odeke	85be26c675	common: BitArray: feedback from @adrianbrink to simplify tests	7 years ago
Emmanuel Odeke	84afef20f5	common: fix BitArray.Update to avoid nil dereference Update previously only checked that the receiver was non-nil but didn't check that the input parameter to update "o" was non-nil causing a nil dereference in cases such as `fe632ea32a/consensus/reactor.go (L306)` Fixes https://github.com/tendermint/tendermint/issues/1169	7 years ago
Ethan Buchman	356657a37b	move all files to common/ to begin repo merge	8 years ago
Ethan Buchman	dcfa46af13	BitArray.IsEmpty()	9 years ago
Jae Kwon	1559ae1ac9	Add BitArray.Bytes()	9 years ago
Jae Kwon	16372365c4	First commit	9 years ago

5 Commits (97bdad8262f3da14f17048dc11f095790e07fb02)