zjubfd
976b1c2ef7
fix pool timer leak bug, resolve#3353 ( #3358 )
When remove peer, block pool simple remove bpPeer,
but do not stop timer, that cause stopError for recorrected
peers. Stop timer when remove from pool.
6 years ago
Anton Kaliaev
6941d1bb35
use nolint label instead of commenting
6 years ago
Anton Kaliaev
ffd3bf8448
remove or comment out unused code
6 years ago
Ethan Buchman
47a0669d12
Fix fast sync stack with wrong block #2457 ( #2731 )
* fix fastsync may stuck by a wrong block
* fixes from updates
* fixes from review
* Align spec with the changes
* fmt
6 years ago
Dev Ojha
2756be5a59
libs: Remove usage of custom Fmt, in favor of fmt.Sprintf ( #2199 )
* libs: Remove usage of custom Fmt, in favor of fmt.Sprintf
Closes #2193
* Fix bug that was masked by custom Fmt!
6 years ago
Zach Ramsay
44dad6d70b
Revert "detele everything"
This reverts commit d02c5d1e30
.
7 years ago
Zach Ramsay
d02c5d1e30
detele everything
7 years ago
Ethan Buchman
d55243f0e6
fix import paths
7 years ago
Jae Kwon
8128627f08
Optimizing blockchain reactor.
Should be paired with https://github.com/tendermint/iavl/pull/65 .
7 years ago
Liamsi
d2c05bc5b9
Revert "delete everything" (includes everything non-go-crypto)
This reverts commit 96a3502
7 years ago
Liamsi
96a3502126
delete everything
7 years ago
Jae Kwon
fd6021876b
Potential fix for blockchain pool halting issue
7 years ago
Jae Kwon
f55725ebfa
Potential fix for blockchain pool halting issue
7 years ago
Anton Kaliaev
baf457e6d4
return error if peer sent us a block we didn't expect with a height too far ahead/behind
7 years ago
Anton Kaliaev
0c7e871ef0
[blockchain] replace timeoutsCh with more abstract errorsCh
7 years ago
Anton Kaliaev
87ce804b4a
cmn.PanicSanity is deprecated
7 years ago
Anton Kaliaev
2a24ae90c1
fixes from Jae's review
1. remove pointer
2. add Quit() method to Service interface
7 years ago
Anton Kaliaev
0c1b91b762
revert back curRate != 0
7 years ago
Anton Kaliaev
c8990d06d9
remove curRate != 0
7 years ago
Anton Kaliaev
b0a55882b2
lower the minRecvRate
See https://github.com/tendermint/tendermint/issues/1177#issuecomment-363720118
7 years ago
Anton Kaliaev
d1fa44e816
improve "curRate too low" message
Refs #1177
Note on labels:
KB - 1024
kB - 1000
https://ux.stackexchange.com/questions/13815/files-size-units-kib-vs-kb-vs-kb
7 years ago
Ethan Buchman
ee674f919f
StopPeerForError in blockchain and consensus
7 years ago
Adrian Brink
a30315276b
Formatting and documentation
7 years ago
Ethan Buchman
a17105fd46
p2p: peer.Key -> peer.ID
7 years ago
Anton Kaliaev
922af7c405
int64 height
uint64 is considered dangerous. the details will follow in a blog post.
7 years ago
Anton Kaliaev
b3492356e6
uint64 height (Refs #911 )
7 years ago
Anton Kaliaev
69b5da766c
service#Start, service#Stop signatures were changed
See https://github.com/tendermint/tmlibs/issues/45
7 years ago
Zach Ramsay
2563b4fc92
lint fixes
7 years ago
Zach Ramsay
563faa98de
address comments, pr #643
7 years ago
Zach Ramsay
8f0237610e
linting errors: clean it all up
7 years ago
Zach Ramsay
331857c9e6
linting: apply errcheck part2
7 years ago
Ethan Buchman
591dd9e662
dont catchupReplay on wal if we fast synced
7 years ago
Ethan Buchman
0bbf38141a
blockchain/pool: some comments and small changes
7 years ago
Anton Kaliaev
d64a48e0ee
set logger on blockchain pool
7 years ago
Anton Kaliaev
0a7b2ab52c
fix invalid memory address or nil pointer dereference error (Refs #762 )
https://github.com/tendermint/tendermint/issues/762#issuecomment-338276055
```
E[10-19|04:52:38.969] Stopping peer for error module=p2p peer="Peer{MConn{178.62.46.14:46656} B14916FAF38A out}" err="Error: runtime error: invalid memory address or nil pointer dereference\nStack: goroutine 529485 [running]:\nruntime/debug.Stack(0xc4355cfb38, 0xb463e0, 0x11b1c30)\n\t/usr/local/go/src/runtime/debug/stack.go:24 +0xa7\ngithub.com/cosmos/gaia/vendor/github.com/tendermint/tendermint/p2p.(*MConnection)._recover(0xc439a28870)\n\t/home/ubuntu/go/src/github.com/cosmos/gaia/vendor/github.com/tendermint/tendermint/p2p/connection.go:206 +0x6e\npanic(0xb463e0, 0x11b1c30)\n\t/usr/local/go/src/runtime/panic.go:491 +0x283\ngithub.com/cosmos/gaia/vendor/github.com/tendermint/tendermint/blockchain.(*bpPeer).decrPending(0x0, 0x381)\n\t/home/ubuntu/go/src/github.com/cosmos/gaia/vendor/github.com/tendermint/tendermint/blockchain/pool.go:376 +0x22\ngithub.com/cosmos/gaia/vendor/github.com/tendermint/tendermint/blockchain.(*BlockPool).AddBlock(0xc4200e4000, 0xc4266d1f00, 0x40, 0xc432ac9640, 0x381)\n\t/home/ubuntu/go/src/github.com/cosmos/gaia/vendor/github.com/tendermint/tendermint/blockchain/pool.go:215 +0x139\ngithub.com/cosmos/gaia/vendor/github.com/tendermint/tendermint/blockchain.(*BlockchainReactor).Receive(0xc42050a780, 0xc420257740, 0x1171be0, 0xc42ff302d0, 0xc4384b2000, 0x381, 0x1000)\n\t/home/ubuntu/go/src/github.com/cosmos/gaia/vendor/github.com/tendermint/tendermint/blockchain/reactor.go:160 +0x712\ngithub.com/cosmos/gaia/vendor/github.com/tendermint/tendermint/p2p.createMConnection.func1(0x11e5040, 0xc4384b2000, 0x381, 0x1000)\n\t/home/ubuntu/go/src/github.com/cosmos/gaia/vendor/github.com/tendermint/tendermint/p2p/peer.go:334 +0xbd\ngithub.com/cosmos/gaia/vendor/github.com/tendermint/tendermint/p2p.(*MConnection).recvRoutine(0xc439a28870)\n\t/home/ubuntu/go/src/github.com/cosmos/gaia/vendor/github.com/tendermint/tendermint/p2p/connection.go:475 +0x4a3\ncreated by github.com/cosmos/gaia/vendor/github.com/tendermint/tendermint/p2p.(*MConnection).OnStart\n\t/home/ubuntu/go/src/github.com/cosmos/gaia/vendor/github.com/tendermint/tendermint/p2p/connection.go:170 +0x187\n"
```
7 years ago
Zach Ramsay
d56b44f3a5
all: no more anonymous imports
7 years ago
Ethan Buchman
29bfcb0a31
minor comments/changes
7 years ago
Ethan Buchman
0d1fa8e884
fixes from review
8 years ago
Ethan Buchman
77a3d03385
blockchain: explain isCaughtUp logic
8 years ago
Ethan Buchman
3c0128a680
undo some megacheck suggestions
8 years ago
zramsay
cf31f8d06f
core: apply megacheck vet tool (unused, gosimple, staticcheck)
8 years ago
Anton Kaliaev
c9cd8de9c6
set logger
8 years ago
Anton Kaliaev
f803544195
new logging
8 years ago
Ethan Buchman
d1926bcad1
use tmlibs
8 years ago
Ethan Buchman
00847cdc6b
blockpool: fix removePeer bug
8 years ago
Ethan Buchman
4fd1471f11
remove BaseService.OnStart
8 years ago
Anton Kalyaev
eef9124d1b
fix typo
8 years ago
Ethan Buchman
8390e88e27
fix flowrate dep and test
8 years ago
Jae Kwon
bf1bceec87
Use go-flowcontrol
8 years ago
Jae Kwon
480f44f16c
QuitService->BaseService
8 years ago