tendermint

Commit Graph

Author	SHA1	Message	Date
Ethan Buchman	498a82784d	p2p/addrbook: comments	7 years ago
Guanghua Guo	b5708825a7	Failed to compile comment code	7 years ago
caffix	a724ffab25	added changes based on PR comments to the proposal	7 years ago
Emmanuel Odeke	3f9dff9aac	p2p: netPipe for <Go1.10 in own file with own build tag Follow up of `283544c7f3` putting <Go1.10 implementation of netPipe in its own file and protect it with its separate build tag.	7 years ago
Emmanuel Odeke	283544c7f3	p2p: use fake net.Pipe since only >=Go1.10 implements SetDeadline Fixes https://github.com/tendermint/tendermint/issues/851 Go1.9 and below's net.Pipe did not implement the SetDeadline method so after commit `e2dd8ca946` this problem was exposed since now we check for errors. To counter this problem, implement a simple composition for net.Conn that always returns nil on SetDeadline instead of tripping out. Added build tags so that anyone using go1.10 when it is released will be able to automatically use net.Pipe's net.Conns	7 years ago
Emmanuel Odeke	7b0fa6c889	p2p: peer should respect errors from SetDeadline Noticed while auditing the code that we aren't respecting (net.Conn) SetDeadline errors which return after a connection has been killed and is simultaneously being used. For example given program, without SetDeadline error checks ```go package main import ( "log" "net" "time" ) func main() { conn, err := net.Dial("tcp", "tendermint.com:443") if err != nil { log.Fatal(err) } go func() { <-time.After(400 time.Millisecond) conn.Close() }() for i := 0; i < 5; i++ { if err := conn.SetDeadline(time.Now().Add(time.Duration(10 * time.Second))); err != nil { log.Fatalf("set deadline #%d, err: %v", i, err) } log.Printf("Successfully set deadline #%d", i) <-time.After(150 * time.Millisecond) } } ``` erraneously gives ```shell 2017/11/14 17:46:28 Successfully set deadline #0 2017/11/14 17:46:29 Successfully set deadline #1 2017/11/14 17:46:29 Successfully set deadline #2 2017/11/14 17:46:29 Successfully set deadline #3 2017/11/14 17:46:29 Successfully set deadline #4 ``` However, if we properly fix it to respect that error with ```diff --- wild.go 2017-11-14 17:44:38.000000000 -0700 +++ main.go 2017-11-14 17:45:40.000000000 -0700 @@ -16,7 +16,9 @@ conn.Close() }() for i := 0; i < 5; i++ { - conn.SetDeadline(time.Now().Add(time.Duration(10 * time.Second))) + if err := conn.SetDeadline(time.Now().Add(time.Duration(10 * time.Second))); err != nil { + log.Fatalf("set deadline #%d, err: %v", i, err) + } log.Printf("Successfully set deadline #%d", i) <-time.After(150 * time.Millisecond) } ``` properly catches any problems and gives ```shell $ go run main.go 2017/11/14 17:43:44 Successfully set deadline #0 2017/11/14 17:43:45 Successfully set deadline #1 2017/11/14 17:43:45 Successfully set deadline #2 2017/11/14 17:43:45 set deadline #3, err: set tcp 10.182.253.51:57395: use of closed network connection exit status 1 ```	7 years ago
caffix	8b7649b90c	enhancements made in response to PR full review comments	7 years ago
caffix	687834c99e	added initial trust metric test routines	7 years ago
caffix	54c25ccbf5	integrated trust metric store as per PR comments	7 years ago
caffix	e160a6198c	added initial trust metric design doc and code	7 years ago
Ethan Buchman	e69d36d54f	some more robust sleeps	7 years ago
Emmanuel Odeke	62c1bc0a20	p2p: comment on the wg.Add before go saveRoutine() Just noticed while auditing the code in p2p/addrbook.go, wg.Add(1) but no subsequent defer. @jaekwon and I had a discussion offline and we agreed to comment about why the code was that way and why we shouldn't move the wg.Add(1) into .saveRoutine() because if go a.saveRoutine() isn't started before anyone invokes a.Wait(), then we'd have raced a.saveRoutine().	7 years ago
Petabyte Storage	3863885c71	WIP: begin parallel refactoring with go-wire Write methods and MConnection	7 years ago
Anton Kaliaev	a1cdc2b68a	set logger for peer's MConnection	7 years ago
Ethan Buchman	c931279960	p2p: some fixes re @odeke-em issues #813,#816,#817	7 years ago
Petabyte Storage	51c9211cf4	add test for MConnection TrySend and Send	7 years ago
Anton Kaliaev	7869e541f6	change MakeConnectedSwitches to not connect to itself and a test for it	7 years ago
Anton Kaliaev	e0daca5693	fixes from Bucky's review	7 years ago
Ethan Buchman	37ce171061	p2p/connetion: remove panics, test error cases	7 years ago
Ethan Buchman	e01986e2b3	p2p: update readme, some minor things	7 years ago
Anton Kaliaev	2d4ad02356	prefer tickers to time.Sleep (Refs #790 )	7 years ago
Anton Kaliaev	e785697a64	connect first switch to others (Refs #808 )	7 years ago
Petabyte Storage	fe9ff62297	fix comment typos	7 years ago
Petabyte Storage	6b366b2443	fix test using uncommon names	7 years ago
Petabyte Storage	ceedd4d968	remove unnecessary plus [ci skip]	7 years ago
Ethan Buchman	0bbf38141a	blockchain/pool: some comments and small changes	7 years ago
Zach Ramsay	136b6a7673	rpc/lib: remove dead files, closes #710	7 years ago
Zach Ramsay	f23d47e5d2	upnp: keep a link	7 years ago
Zach Ramsay	d56b44f3a5	all: no more anonymous imports	7 years ago
Ethan Buchman	ddb3d8945d	p2p: allow listener with no external connection	8 years ago
Ethan Buchman	b50339e8e7	p2p: sw.AddPeer -> sw.addPeer	7 years ago
Ethan Buchman	aea8629272	peer interface	7 years ago
Emmanuel Odeke	5138bcb1c7	p2p: delete unused and untested *IPRangeCount functions Fixes #602 Delete unused and untested functions: - AddToIPRangeCounts - CheckIPRangeCounts	7 years ago
Ethan Buchman	54c63726b0	p2p: minor comment fixes	7 years ago
Emmanuel Odeke	c48e772115	p2p: fully test PeerSet, more docs, parallelize PeerSet tests * Full test PeerSet and check its concurrent guarantees * Improve the doc for PeerSet.Has and remove unnecessary defer for a path that sets a variable, make it fast anyways. * Parallelize PeerSet tests with t.Parallel() * Document functions in peer_set.go more.	7 years ago
Ethan Buchman	cc2b418f7f	p2p: test fix	7 years ago
Ethan Buchman	88138c38cf	mempool: reactor test	7 years ago
Ethan Buchman	daa258ea6d	p2p: put maxMsgPacketPayloadSize, recvRate, sendRate in config Updates #628	7 years ago
caojingqi	086544e367	p2p: sw.peers.List() is empty in sw.OnStart	8 years ago
Ethan Buchman	75df0d91ba	comments from review	8 years ago
Ethan Buchman	5f6b996d22	breakup some long lines; add more comments to consensus reactor	8 years ago
Ethan Buchman	74a3a2b56a	fix comments	8 years ago
Adrian Brink	b07d01f102	Add more comments on public functions and extra logging during 'enterPrevote' Signed-off-by: Adrian Brink <adrian@brink-holdings.com>	8 years ago
Ethan Buchman	e6cecb9595	p2p: fix test	8 years ago
Ethan Buchman	3c10f7a122	add p2p flush throttle to config	8 years ago
Ethan Buchman	0d1fa8e884	fixes from review	8 years ago
Ethan Buchman	3c0128a680	undo some megacheck suggestions	8 years ago
Anton Kaliaev	b4ece65726	standardize key for errors (should be "err")	8 years ago
zramsay	bf5181d9ca	address PR comments	8 years ago
zramsay	cf31f8d06f	core: apply megacheck vet tool (unused, gosimple, staticcheck)	8 years ago

... 6 7 8 9 10 ...

635 Commits (3ebfa99f2c2403c17348e41190406892abf21d2a)