tendermint

Commit Graph

Author	SHA1	Message	Date
Jae Kwon	bf644b0984	Do not shadow assert	7 years ago
Jae Kwon	797bcdd9e0	Remove common/http	7 years ago
Jae Kwon	f2a8e95248	Add KI64Pair(s)	7 years ago
Ethan Buchman	e2d7f1aa41	cmn: fix race	7 years ago
Ethan Buchman	b0b740210c	cmn: fix repeate timer test with manual ticker	7 years ago
Ethan Buchman	a25ed5ba1b	cmn: fix race condition in prng	7 years ago
Anton Kaliaev	e17e8e425f	Revert "Refactor throttle timer"	7 years ago
Anton Kaliaev	70e30f74e6	Revert "Refactor repeat timer"	7 years ago
Jae Kwon	aab2d70dd3	Sdk2 kvpair (#102 ) * Canonical KVPair in common * Simplify common/Bytes to just hex encode	7 years ago
Emmanuel Odeke	8638961f02	common: Rand* warnings about cryptographic unsafety Lesson articulated by @jaekwon on why we need 80 bits of entropy at least before we can think of cryptographic safety. math/rand's seed is a max of 64 bits so can never be cryptographically secure. Also added some benchmarks for RandBytes	7 years ago
Emmanuel Odeke	cdc7988823	common: use genius simplification of tests from @ebuchman Massive test simplication for more reliable tests from @ebuchman	7 years ago
Ethan Buchman	b5f465b4ec	common: use names prng and mrand	7 years ago
Emmanuel Odeke	29471d75cb	common: no more relying on math/rand.DefaultSource Fixes https://github.com/tendermint/tmlibs/issues/99 Updates https://github.com/tendermint/tendermint/issues/973 Removed usages of math/rand.DefaultSource in favour of our own source that's seeded with a completely random source and is safe for use in concurrent in multiple goroutines. Also extend some functionality that the stdlib exposes such as * RandPerm * RandIntn * RandInt31 * RandInt63 Also added an integration test whose purpose is to be run as a consistency check to ensure that our results never repeat hence that our internal PRNG is uniquely seeded each time. This integration test can be triggered by setting environment variable: `TENDERMINT_INTEGRATION_TESTS=true` for example ```shell TENDERMINT_INTEGRATION_TESTS=true go test ```	7 years ago
Jae Kwon	a0b692c86d	Add PushBytes to Heap	7 years ago
Jae Kwon	03dfb724c7	Change heap.Push to mean int priority	7 years ago
Jae Kwon	988e190ef7	Deprecated Panic*	7 years ago
Anton Kaliaev	ff2fd63bf7	rename trySend to send	7 years ago
Ethan Frey	ec4adf21e0	Cleanup from PR comments	7 years ago
Ethan Frey	cc7a87e27c	Use Ticker in Repeat again to avoid drift	7 years ago
Ethan Frey	8797197cdf	No more blocking on multiple Stop()	7 years ago
Ethan Frey	887d766c86	Refactored RepeatTimer, tests hang	7 years ago
Anton Kaliaev	3779310c72	return back output internal channel (way go does with Timer)	7 years ago
Ethan Frey	8b518fadb2	Don't close throttle channel, explain why	7 years ago
Ethan Frey	e430d3f844	One more attempt with a read-only channel	7 years ago
Ethan Frey	1ac4c5dd6d	Made throttle output non-blocking	7 years ago
Ethan Frey	0a8721113a	First pass of PR updates	7 years ago
Ethan Frey	4ec7883891	Cleanup	7 years ago
Ethan Frey	dcb4395604	Refactor throttle timer	7 years ago
Ethan Frey	3d9113c16e	Add a bit more padding to tests so they pass on osx with -race	7 years ago
Ethan Frey	26abd65e34	Add tests for repeat timer	7 years ago
Ethan Frey	53cdb6cf82	Demo throttle timer is broken	7 years ago
Anton Kaliaev	33abe87c5b	IntInSlice and StringInSlice functions Refs https://github.com/tendermint/tendermint/pull/835	7 years ago
Ethan Buchman	4d991acae0	common: comments for Service	7 years ago
Anton Kaliaev	c2fcc093b2	remove bool from Service#Reset	7 years ago
Anton Kaliaev	e6164d4052	change service#Stop to be similar to Start	7 years ago
Anton Kaliaev	4123d54bf6	change service#Start to return just error (Refs #45 ) ``` @melekes yeah, bool is superfluous @ethanfrey If I remember correctly when I was writing test code, if I call Start() on a Service that is already running, it returns (false, nil). Only if I try to legitimately start it, but it fails in startup do I get an error. The distinction is quite important to make it safe for reentrant calls. The other approach would be to have a special error type like ErrAlreadyStarted, then check for that in your code explicitly. Kind of like if I make a db call in gorm, and get an error, I check if it is a RecordNotFound error, or whether there was a real error with the db query. @melekes Ah, I see. Thanks. I must say I like ErrAlreadyStarted approach more (not just in Golang) ```	7 years ago
Anton Kaliaev	49d75e223e	use os.Process#Kill (Fixes #73 )	7 years ago
Anton Kaliaev	b658294a13	use assert.Contains in cmap_test	7 years ago
Wolf	88481fc363	Make iterating over keys possible (#63 ) * Make iterating over keys possible * add test for cmap - test Keys() and Values() respectively * one cmap per test-case	7 years ago
Ethan Buchman	092eb701c7	cmn: Kill	7 years ago
Anton Kaliaev	bcf15e527d	make GoPath a function otherwise it could try to execute go binary and panic if no go binary found. See https://github.com/tendermint/tendermint/issues/782	7 years ago
Anton Kaliaev	35e38e8932	call go env GOPATH if env var is not found (Refs #60 )	7 years ago
Ethan Buchman	c8805fd7de	metalinter fixes from review	7 years ago
Zach Ramsay	cf49ba876f	linter: couple fixes	7 years ago
Ethan Buchman	3d98504c4c	common: WriteFileAtomic use tempfile in current dir	7 years ago
Zach Ramsay	3c57c24921	linting: next round of fixes	7 years ago
Zach Ramsay	d6e03d2368	linting: add to Makefile & do some fixes	7 years ago
Ethan Buchman	9a2438e0dc	common: Fingerprint comment	7 years ago
Anton Kaliaev	956966e658	add missing validator package to glide.yaml	7 years ago
Emmanuel Odeke	b4a51871b9	common/IsDirEmpty: do not mask non-existance errors Currently IsDirEmpty returns true, err if it encounters any error after trying to os.Open the directory. I noticed this while studying the code and recalled a bug from an earlier project in which doing the exact same thing on code without permissions would trip out and falsely report that the directory was empty. Given demo.go in https://play.golang.org/p/vhTPU2RiCJ * Demo: ```shell $ mkdir -p sample-demo/1 && touch sample-demo/2 $ echo "1st round" && go run demo.go sample-demo $ sudo chown root sample-demo && sudo chmod 0700 sample-demo $ echo "2nd round" && go run demo.go sample-demo ``` That then prints out ```shell 1st round original:: empty: false err: <nil> updated:: empty: false err: <nil> 2nd round original:: empty: true err: open data/: permission denied updated:: empty: false err: open data/: permission denied ``` where in "2nd round", the original code falsely reports that the directory is empty but that's a permission error. I could write a code test for it, but that test requires me to change users and switch to root as a Go user so no point in complicating our tests, but otherwise it is a 1-to-1 translation between shell and Go.	7 years ago

1 2 3

121 Commits (357648b8d63732df77fb1dd0f5ad813800912854)