tendermint

Commit Graph

Author	SHA1	Message	Date
Emmanuel Odeke	7b0fa6c889	p2p: peer should respect errors from SetDeadline Noticed while auditing the code that we aren't respecting (net.Conn) SetDeadline errors which return after a connection has been killed and is simultaneously being used. For example given program, without SetDeadline error checks ```go package main import ( "log" "net" "time" ) func main() { conn, err := net.Dial("tcp", "tendermint.com:443") if err != nil { log.Fatal(err) } go func() { <-time.After(400 time.Millisecond) conn.Close() }() for i := 0; i < 5; i++ { if err := conn.SetDeadline(time.Now().Add(time.Duration(10 * time.Second))); err != nil { log.Fatalf("set deadline #%d, err: %v", i, err) } log.Printf("Successfully set deadline #%d", i) <-time.After(150 * time.Millisecond) } } ``` erraneously gives ```shell 2017/11/14 17:46:28 Successfully set deadline #0 2017/11/14 17:46:29 Successfully set deadline #1 2017/11/14 17:46:29 Successfully set deadline #2 2017/11/14 17:46:29 Successfully set deadline #3 2017/11/14 17:46:29 Successfully set deadline #4 ``` However, if we properly fix it to respect that error with ```diff --- wild.go 2017-11-14 17:44:38.000000000 -0700 +++ main.go 2017-11-14 17:45:40.000000000 -0700 @@ -16,7 +16,9 @@ conn.Close() }() for i := 0; i < 5; i++ { - conn.SetDeadline(time.Now().Add(time.Duration(10 * time.Second))) + if err := conn.SetDeadline(time.Now().Add(time.Duration(10 * time.Second))); err != nil { + log.Fatalf("set deadline #%d, err: %v", i, err) + } log.Printf("Successfully set deadline #%d", i) <-time.After(150 * time.Millisecond) } ``` properly catches any problems and gives ```shell $ go run main.go 2017/11/14 17:43:44 Successfully set deadline #0 2017/11/14 17:43:45 Successfully set deadline #1 2017/11/14 17:43:45 Successfully set deadline #2 2017/11/14 17:43:45 set deadline #3, err: set tcp 10.182.253.51:57395: use of closed network connection exit status 1 ```	7 years ago
Anton Kaliaev	a1cdc2b68a	set logger for peer's MConnection	7 years ago
Ethan Buchman	c931279960	p2p: some fixes re @odeke-em issues #813,#816,#817	7 years ago
Petabyte Storage	ceedd4d968	remove unnecessary plus [ci skip]	7 years ago
Zach Ramsay	d56b44f3a5	all: no more anonymous imports	7 years ago
Ethan Buchman	aea8629272	peer interface	7 years ago
Ethan Buchman	5f6b996d22	breakup some long lines; add more comments to consensus reactor	7 years ago
Ethan Buchman	e6cecb9595	p2p: fix test	7 years ago
Ethan Buchman	3c10f7a122	add p2p flush throttle to config	7 years ago
Anton Kaliaev	f8fdbe3dbc	changes as per Bucky's review	8 years ago
Anton Kaliaev	f803544195	new logging	8 years ago
Ethan Buchman	5d660e073a	remove viper from p2p	8 years ago
Ethan Buchman	23a6a6f8fc	move into p2p package	8 years ago
Ethan Buchman	34965f610d	crypto Wrap/Unwrap	8 years ago
Ethan Buchman	eaeb547938	use tmlibs	8 years ago
Anton Kaliaev	06d219db8e	test peer with no auth enc	8 years ago
Anton Kaliaev	1d01f6af98	2 kinds of peers: outbound and inbound	8 years ago
Anton Kaliaev	5965578c56	[fuzz] only one way to set config variables	8 years ago
Anton Kaliaev	7dcc3dbcd1	test peer	8 years ago
Ethan Buchman	8067cdb5f2	fix closing conn	8 years ago
Ethan Buchman	9a1a6c56b4	dont expose makePersistent	8 years ago
Ethan Buchman	a9bb6734e7	SetDeadline for authEnc. Stop peer if Add fails	8 years ago
Anton Kaliaev	8bb3a2e1d7	persistent peers (Refs #13 )	8 years ago
Anton Kaliaev	5b0489cdb4	use plain struct instead of go-config	8 years ago
Jae Kwon	7d997ca8e6	No global config	9 years ago
Jae Kwon	432a37857d	Add RemoteAddr and ListenAddr to NodeInfo; Refactor IPRange logic	9 years ago
Jae Kwon	1c628a97ad	Conform to go-wire 1.0	9 years ago
Jae Kwon	abc3a2cc3c	initial commit	9 years ago

1 2 3

114 Commits (27ba6e8a426bf12aeb8a210d79a8edc08c5ed0e0)