M. J. Fromberger
1ea83f6cb2
Don't indirect nil after a return.
3 years ago
M. J. Fromberger
deb10458d1
Restore original count.
3 years ago
M. J. Fromberger
6344076efe
Fix lint.
3 years ago
M. J. Fromberger
01371f09ae
Fix merge damage.
3 years ago
M. J. Fromberger
6041599f0a
Be consistent.
3 years ago
M. J. Fromberger
a597b6101b
Fix voting power check.
3 years ago
M. J. Fromberger
ca70e0d75d
Load state before starting reactors.
3 years ago
tycho garen
7135846724
more tweaking
3 years ago
tycho garen
7bb795dce1
better logs
3 years ago
tycho garen
80cf392c32
more buffer amore time
3 years ago
tycho garen
cb5d81f588
bigger buffers
3 years ago
tycho garen
f1435149ba
privval
3 years ago
M. J. Fromberger
8e17c96413
move lock
3 years ago
tycho garen
2781096b57
elide deadlock
3 years ago
tycho garen
8256f7099a
more locking gpt
3 years ago
tycho garen
115a889a4b
safer send
3 years ago
tycho garen
baff005c2c
fix lint
3 years ago
tycho garen
5b8e30e900
another lock
3 years ago
tycho garen
76c25e3a77
clean up
3 years ago
tycho garen
a40b52237e
shrink and fix
3 years ago
tycho garen
3c63f657af
fix shutdown lock
3 years ago
tycho garen
c64d7c5b0a
fix lint
3 years ago
tycho garen
8f627b03fe
move init closer
3 years ago
tycho garen
c2d6c5b092
clarify an error
3 years ago
tycho garen
ed68222bdd
avoid calling start
3 years ago
tycho garen
e675ffa552
reduce chance of deadlocks
3 years ago
tycho garen
e256bef4ee
more granular locks
3 years ago
tycho garen
57118ecccc
fix lint
3 years ago
tycho garen
7fb735fe87
retry
3 years ago
tycho garen
b9d25538ce
back out of consensus changes
3 years ago
tycho garen
4ced364442
minimal
3 years ago
tycho garen
82de1d7524
avoid deadlock
3 years ago
Sam Kleinman
53ab56bb9e
Apply suggestions from code review
Co-authored-by: M. J. Fromberger <michael.j.fromberger@gmail.com>
3 years ago
tycho garen
6738ef6f85
fixes
3 years ago
tycho garen
2740cdfc05
fix
3 years ago
tycho garen
8e65f78141
node: alter initialization order to avoid panic during statesync
3 years ago
William Banfield
485c96b0d3
consensus: change lock handling in reactor and handleMsg for RoundState (forward-port #7994 #7992 ) ( #8139 )
Related to #8157
3 years ago
Sam Kleinman
9a833a8495
consensus: skip channel close during shutdown ( #8155 )
I see this panic in tests occasionally, and I don't think there's any
need to close this channel:
- it's only sent to in one place which has a select case with a
default clause, so there's no chance of deadlocks.
- the only place we recieve from it thas a timeout.
3 years ago
Sam Kleinman
0bded371c5
testing: logger cleanup ( #8153 )
This contains two major changes:
- Remove the legacy test logging method, and just explicitly call the
noop logger. This is just to make the test logging behavior more
coherent and clear.
- Move the logging in the light package from the testing.T logger to
the noop logger. It's really the case that we very rarely need/want
to consider test logs unless we're doing reproductions and running a
narrow set of tests.
In most cases, I (for one) prefer to run in verbose mode so I can
watch progress of tests, but I basically never need to consider
logs. If I do want to see logs, then I can edit in the testing.T
logger locally (which is what you have to do today, anyway.)
3 years ago
Sam Kleinman
12d13cd31d
mempool: reduce size of test ( #8152 )
This is failing intermittently, but it's a really simple test, and I
suspect that we're just running into thread scheduling issues on CI
nodes. I don't think making the test smaller reduces the utility of
this test.
3 years ago
William Banfield
bba8367aac
state: panic on ResponsePrepareProposal validation error ( #8145 )
* state: panic on ResponsePrepareProposal validation error
* lint++
Co-authored-by: Sam Kleinman <garen@tychoish.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Sam Kleinman
f1a8f47d4d
types: minor cleanup of un or minimally used types ( #8154 )
3 years ago
Sam Kleinman
f61e6e4201
autofile: remove vestigal close mechanism ( #8150 )
3 years ago
Sam Kleinman
1db41663c7
consensus: avoid race in accessing channel ( #8149 )
3 years ago
Sam Kleinman
5e0e05f938
consensus: avoid persistent kvstore in tests ( #8148 )
3 years ago
Sam Kleinman
5bb51aab03
events: remove service aspects of event switch ( #8146 )
3 years ago
Sam Kleinman
13f7501950
blocksync: remove intermediate channel ( #8140 )
Based on local testing, I'm now convinced that this is ok, and also I think the fact that the new p2p layer has more caching and queue.
3 years ago
JayT106
4400b0f6d3
p2p: adjust max non-persistent peer score ( #8137 )
Guarantee persistent peers have the highest connecting priority.
The peerStore.Ranked returns an arbitrary order of peers with the same scores.
3 years ago
frog power 4000
5b6849ccf7
Docs: abci++ typo ( #8147 )
3 years ago
Sam Kleinman
a68e356596
consensus: avoid extra close channel ( #8144 )
Saw this in a test panic, doesn't seem neccessary.
3 years ago