Browse Source

test: disable TestPEXReactorSeedModeFlushStop due to flake (#5996)

This test occasionally fails because the peer is already stopped. It is unclear to me exactly what this test is supposed to do, since calling `FlushStop()` will stop the peer, but the test asserts that the peer shouldn't have been stopped by `FlushStop()` since calling `Stop()` afterwards will error in that case.

The current PEX reactor will be removed in the new P2P stack anyway.
pull/5995/merge
Erik Grinaker 4 years ago
committed by GitHub
parent
commit
4dca066aab
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 0 deletions
  1. +1
    -0
      p2p/pex/pex_reactor_test.go

+ 1
- 0
p2p/pex/pex_reactor_test.go View File

@ -376,6 +376,7 @@ func TestPEXReactorDialsPeerUpToMaxAttemptsInSeedMode(t *testing.T) {
// with FlushStop. Before a fix, this non-deterministically reproduced
// https://github.com/tendermint/tendermint/issues/3231.
func TestPEXReactorSeedModeFlushStop(t *testing.T) {
t.Skip("flaky test, will be replaced by new P2P stack")
N := 2
switches := make([]*p2p.Switch, N)


Loading…
Cancel
Save