Browse Source

test: fix TestSwitchAcceptRoutine flake by ignoring error type (#6000)

Fixes #5998. Sometimes the connection returns "use of closed network connection" instead, so for now we just accept any error. The switch is not long for this world anyway.
pull/5995/merge
Erik Grinaker 4 years ago
committed by GitHub
parent
commit
6e3c58204a
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 6 deletions
  1. +4
    -6
      p2p/switch_test.go

+ 4
- 6
p2p/switch_test.go View File

@ -5,7 +5,6 @@ import (
"context"
"errors"
"fmt"
"io"
"io/ioutil"
"net"
"net/http"
@ -607,9 +606,8 @@ func TestSwitchAcceptRoutine(t *testing.T) {
err = sw.Start()
require.NoError(t, err)
t.Cleanup(func() {
if err := sw.Stop(); err != nil {
t.Error(err)
}
err := sw.Stop()
require.NoError(t, err)
})
// 0. check there are no peers
@ -634,7 +632,7 @@ func TestSwitchAcceptRoutine(t *testing.T) {
}
}(c)
}
time.Sleep(10 * time.Millisecond)
time.Sleep(100 * time.Millisecond)
assert.Equal(t, cfg.MaxNumInboundPeers, sw.Peers().Size())
// 2. check we close new connections if we already have MaxNumInboundPeers peers
@ -647,7 +645,7 @@ func TestSwitchAcceptRoutine(t *testing.T) {
err = conn.SetReadDeadline(time.Now().Add(10 * time.Millisecond))
require.NoError(t, err)
_, err = conn.Read(one)
assert.Equal(t, io.EOF, err)
assert.Error(t, err)
assert.Equal(t, cfg.MaxNumInboundPeers, sw.Peers().Size())
peer.Stop()


Loading…
Cancel
Save