You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

331 lines
8.8 KiB

abci: localClient improvements & bugfixes & pubsub Unsubscribe issues (#2748) * use READ lock/unlock in ConsensusState#GetLastHeight Refs #2721 * do not use defers when there's no need * fix peer formatting (output its address instead of the pointer) ``` [54310]: E[11-02|11:59:39.851] Connection failed @ sendRoutine module=p2p peer=0xb78f00 conn=MConn{74.207.236.148:26656} err="pong timeout" ``` https://github.com/tendermint/tendermint/issues/2721#issuecomment-435326581 * panic if peer has no state https://github.com/tendermint/tendermint/issues/2721#issuecomment-435347165 It's confusing that sometimes we check if peer has a state, but most of the times we expect it to be there 1. https://github.com/tendermint/tendermint/blob/add79700b5fe84417538202b6c927c8cc5383672/mempool/reactor.go#L138 2. https://github.com/tendermint/tendermint/blob/add79700b5fe84417538202b6c927c8cc5383672/rpc/core/consensus.go#L196 (edited) I will change everything to always assume peer has a state and panic otherwise that should help identify issues earlier * abci/localclient: extend lock on app callback App callback should be protected by lock as well (note this was already done for InitChainAsync, why not for others???). Otherwise, when we execute the block, tx might come in and call the callback in the same time we're updating it in execBlockOnProxyApp => DATA RACE Fixes #2721 Consensus state is locked ``` goroutine 113333 [semacquire, 309 minutes]: sync.runtime_SemacquireMutex(0xc00180009c, 0xc0000c7e00) /usr/local/go/src/runtime/sema.go:71 +0x3d sync.(*RWMutex).RLock(0xc001800090) /usr/local/go/src/sync/rwmutex.go:50 +0x4e github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).GetRoundState(0xc001800000, 0x0) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:218 +0x46 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusReactor).queryMaj23Routine(0xc0017def80, 0x11104a0, 0xc0072488f0, 0xc007248 9c0) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/reactor.go:735 +0x16d created by github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusReactor).AddPeer /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/reactor.go:172 +0x236 ``` because localClient is locked ``` goroutine 1899 [semacquire, 309 minutes]: sync.runtime_SemacquireMutex(0xc00003363c, 0xc0000cb500) /usr/local/go/src/runtime/sema.go:71 +0x3d sync.(*Mutex).Lock(0xc000033638) /usr/local/go/src/sync/mutex.go:134 +0xff github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/abci/client.(*localClient).SetResponseCallback(0xc0001fb560, 0xc007868540) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/abci/client/local_client.go:32 +0x33 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/proxy.(*appConnConsensus).SetResponseCallback(0xc00002f750, 0xc007868540) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/proxy/app_conn.go:57 +0x40 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/state.execBlockOnProxyApp(0x1104e20, 0xc002ca0ba0, 0x11092a0, 0xc00002f750, 0xc0001fe960, 0xc000bfc660, 0x110cfe0, 0xc000090330, 0xc9d12, 0xc000d9d5a0, ...) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/state/execution.go:230 +0x1fd github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/state.(*BlockExecutor).ApplyBlock(0xc002c2a230, 0x7, 0x0, 0xc000eae880, 0x6, 0xc002e52c60, 0x16, 0x1f927, 0xc9d12, 0xc000d9d5a0, ...) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/state/execution.go:96 +0x142 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).finalizeCommit(0xc001800000, 0x1f928) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:1339 +0xa3e github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).tryFinalizeCommit(0xc001800000, 0x1f928) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:1270 +0x451 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).enterCommit.func1(0xc001800000, 0x0, 0x1f928) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:1218 +0x90 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).enterCommit(0xc001800000, 0x1f928, 0x0) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:1247 +0x6b8 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).addVote(0xc001800000, 0xc003d8dea0, 0xc000cf4cc0, 0x28, 0xf1, 0xc003bc7ad0, 0xc003bc7b10) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:1659 +0xbad github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).tryAddVote(0xc001800000, 0xc003d8dea0, 0xc000cf4cc0, 0x28, 0xf1, 0xf1, 0xf1) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:1517 +0x59 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).handleMsg(0xc001800000, 0xd98200, 0xc0070dbed0, 0xc000cf4cc0, 0x28) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:660 +0x64b github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).receiveRoutine(0xc001800000, 0x0) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:617 +0x670 created by github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).OnStart /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:311 +0x132 ``` tx comes in and CheckTx is executed right when we execute the block ``` goroutine 111044 [semacquire, 309 minutes]: sync.runtime_SemacquireMutex(0xc00003363c, 0x0) /usr/local/go/src/runtime/sema.go:71 +0x3d sync.(*Mutex).Lock(0xc000033638) /usr/local/go/src/sync/mutex.go:134 +0xff github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/abci/client.(*localClient).CheckTxAsync(0xc0001fb0e0, 0xc002d94500, 0x13f, 0x280, 0x0) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/abci/client/local_client.go:85 +0x47 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/proxy.(*appConnMempool).CheckTxAsync(0xc00002f720, 0xc002d94500, 0x13f, 0x280, 0x1) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/proxy/app_conn.go:114 +0x51 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/mempool.(*Mempool).CheckTx(0xc002d3a320, 0xc002d94500, 0x13f, 0x280, 0xc0072355f0, 0x0, 0x0) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/mempool/mempool.go:316 +0x17b github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/core.BroadcastTxSync(0xc002d94500, 0x13f, 0x280, 0x0, 0x0, 0x0) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/core/mempool.go:93 +0xb8 reflect.Value.call(0xd85560, 0x10326c0, 0x13, 0xec7b8b, 0x4, 0xc00663f180, 0x1, 0x1, 0xc00663f180, 0xc00663f188, ...) /usr/local/go/src/reflect/value.go:447 +0x449 reflect.Value.Call(0xd85560, 0x10326c0, 0x13, 0xc00663f180, 0x1, 0x1, 0x0, 0x0, 0xc005cc9344) /usr/local/go/src/reflect/value.go:308 +0xa4 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/lib/server.makeHTTPHandler.func2(0x1102060, 0xc00663f100, 0xc0082d7900) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/lib/server/handlers.go:269 +0x188 net/http.HandlerFunc.ServeHTTP(0xc002c81f20, 0x1102060, 0xc00663f100, 0xc0082d7900) /usr/local/go/src/net/http/server.go:1964 +0x44 net/http.(*ServeMux).ServeHTTP(0xc002c81b60, 0x1102060, 0xc00663f100, 0xc0082d7900) /usr/local/go/src/net/http/server.go:2361 +0x127 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/lib/server.maxBytesHandler.ServeHTTP(0x10f8a40, 0xc002c81b60, 0xf4240, 0x1102060, 0xc00663f100, 0xc0082d7900) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/lib/server/http_server.go:219 +0xcf github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/lib/server.RecoverAndLogHandler.func1(0x1103220, 0xc00121e620, 0xc0082d7900) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/lib/server/http_server.go:192 +0x394 net/http.HandlerFunc.ServeHTTP(0xc002c06ea0, 0x1103220, 0xc00121e620, 0xc0082d7900) /usr/local/go/src/net/http/server.go:1964 +0x44 net/http.serverHandler.ServeHTTP(0xc001a1aa90, 0x1103220, 0xc00121e620, 0xc0082d7900) /usr/local/go/src/net/http/server.go:2741 +0xab net/http.(*conn).serve(0xc00785a3c0, 0x11041a0, 0xc000f844c0) /usr/local/go/src/net/http/server.go:1847 +0x646 created by net/http.(*Server).Serve /usr/local/go/src/net/http/server.go:2851 +0x2f5 ``` * consensus: use read lock in Receive#VoteMessage * use defer to unlock mutex because application might panic * use defer in every method of the localClient * add a changelog entry * drain channels before Unsubscribe(All) Read https://github.com/tendermint/tendermint/blob/55362ed76630f3e1ebec159a598f6a9fb5892cb1/libs/pubsub/pubsub.go#L13 for the detailed explanation of the issue. We'll need to fix it someday. Make sure to keep an eye on https://github.com/tendermint/tendermint/blob/master/docs/architecture/adr-033-pubsub.md * retry instead of panic when peer has no state in reactors other than consensus in /dump_consensus_state RPC endpoint, skip a peer with no state * rpc/core/mempool: simplify error messages * rpc/core/mempool: use time.After instead of timer also, do not log DeliverTx result (to be consistent with other memthods) * unlock before calling the callback in reqRes#SetCallback
6 years ago
  1. package core
  2. import (
  3. cm "github.com/tendermint/tendermint/consensus"
  4. ctypes "github.com/tendermint/tendermint/rpc/core/types"
  5. sm "github.com/tendermint/tendermint/state"
  6. "github.com/tendermint/tendermint/types"
  7. )
  8. // Get the validator set at the given block height.
  9. // If no height is provided, it will fetch the current validator set.
  10. //
  11. // ```shell
  12. // curl 'localhost:26657/validators'
  13. // ```
  14. //
  15. // ```go
  16. // client := client.NewHTTP("tcp://0.0.0.0:26657", "/websocket")
  17. // err := client.Start()
  18. // if err != nil {
  19. // // handle error
  20. // }
  21. // defer client.Stop()
  22. // state, err := client.Validators()
  23. // ```
  24. //
  25. // The above command returns JSON structured like this:
  26. //
  27. // ```json
  28. // {
  29. // "error": "",
  30. // "result": {
  31. // "validators": [
  32. // {
  33. // "proposer_priority": "0",
  34. // "voting_power": "10",
  35. // "pub_key": {
  36. // "data": "68DFDA7E50F82946E7E8546BED37944A422CD1B831E70DF66BA3B8430593944D",
  37. // "type": "ed25519"
  38. // },
  39. // "address": "E89A51D60F68385E09E716D353373B11F8FACD62"
  40. // }
  41. // ],
  42. // "block_height": "5241"
  43. // },
  44. // "id": "",
  45. // "jsonrpc": "2.0"
  46. // }
  47. // ```
  48. func Validators(heightPtr *int64) (*ctypes.ResultValidators, error) {
  49. // The latest validator that we know is the
  50. // NextValidator of the last block.
  51. height := consensusState.GetState().LastBlockHeight + 1
  52. height, err := getHeight(height, heightPtr)
  53. if err != nil {
  54. return nil, err
  55. }
  56. validators, err := sm.LoadValidators(stateDB, height)
  57. if err != nil {
  58. return nil, err
  59. }
  60. return &ctypes.ResultValidators{height, validators.Validators}, nil
  61. }
  62. // DumpConsensusState dumps consensus state.
  63. // UNSTABLE
  64. //
  65. // ```shell
  66. // curl 'localhost:26657/dump_consensus_state'
  67. // ```
  68. //
  69. // ```go
  70. // client := client.NewHTTP("tcp://0.0.0.0:26657", "/websocket")
  71. // err := client.Start()
  72. // if err != nil {
  73. // // handle error
  74. // }
  75. // defer client.Stop()
  76. // state, err := client.DumpConsensusState()
  77. // ```
  78. //
  79. // The above command returns JSON structured like this:
  80. //
  81. // ```json
  82. // {
  83. // "jsonrpc": "2.0",
  84. // "id": "",
  85. // "result": {
  86. // "round_state": {
  87. // "height": "7185",
  88. // "round": "0",
  89. // "step": "1",
  90. // "start_time": "2018-05-12T13:57:28.440293621-07:00",
  91. // "commit_time": "2018-05-12T13:57:27.440293621-07:00",
  92. // "validators": {
  93. // "validators": [
  94. // {
  95. // "address": "B5B3D40BE53982AD294EF99FF5A34C0C3E5A3244",
  96. // "pub_key": {
  97. // "type": "tendermint/PubKeyEd25519",
  98. // "value": "SBctdhRBcXtBgdI/8a/alTsUhGXqGs9k5ylV1u5iKHg="
  99. // },
  100. // "voting_power": "10",
  101. // "proposer_priority": "0"
  102. // }
  103. // ],
  104. // "proposer": {
  105. // "address": "B5B3D40BE53982AD294EF99FF5A34C0C3E5A3244",
  106. // "pub_key": {
  107. // "type": "tendermint/PubKeyEd25519",
  108. // "value": "SBctdhRBcXtBgdI/8a/alTsUhGXqGs9k5ylV1u5iKHg="
  109. // },
  110. // "voting_power": "10",
  111. // "proposer_priority": "0"
  112. // }
  113. // },
  114. // "proposal": null,
  115. // "proposal_block": null,
  116. // "proposal_block_parts": null,
  117. // "locked_round": "0",
  118. // "locked_block": null,
  119. // "locked_block_parts": null,
  120. // "valid_round": "0",
  121. // "valid_block": null,
  122. // "valid_block_parts": null,
  123. // "votes": [
  124. // {
  125. // "round": "0",
  126. // "prevotes": "_",
  127. // "precommits": "_"
  128. // }
  129. // ],
  130. // "commit_round": "-1",
  131. // "last_commit": {
  132. // "votes": [
  133. // "Vote{0:B5B3D40BE539 7184/00/2(Precommit) 14F946FA7EF0 /702B1B1A602A.../ @ 2018-05-12T20:57:27.342Z}"
  134. // ],
  135. // "votes_bit_array": "x",
  136. // "peer_maj_23s": {}
  137. // },
  138. // "last_validators": {
  139. // "validators": [
  140. // {
  141. // "address": "B5B3D40BE53982AD294EF99FF5A34C0C3E5A3244",
  142. // "pub_key": {
  143. // "type": "tendermint/PubKeyEd25519",
  144. // "value": "SBctdhRBcXtBgdI/8a/alTsUhGXqGs9k5ylV1u5iKHg="
  145. // },
  146. // "voting_power": "10",
  147. // "proposer_priority": "0"
  148. // }
  149. // ],
  150. // "proposer": {
  151. // "address": "B5B3D40BE53982AD294EF99FF5A34C0C3E5A3244",
  152. // "pub_key": {
  153. // "type": "tendermint/PubKeyEd25519",
  154. // "value": "SBctdhRBcXtBgdI/8a/alTsUhGXqGs9k5ylV1u5iKHg="
  155. // },
  156. // "voting_power": "10",
  157. // "proposer_priority": "0"
  158. // }
  159. // }
  160. // },
  161. // "peers": [
  162. // {
  163. // "node_address": "30ad1854af22506383c3f0e57fb3c7f90984c5e8@172.16.63.221:26656",
  164. // "peer_state": {
  165. // "round_state": {
  166. // "height": "7185",
  167. // "round": "0",
  168. // "step": "1",
  169. // "start_time": "2018-05-12T13:57:27.438039872-07:00",
  170. // "proposal": false,
  171. // "proposal_block_parts_header": {
  172. // "total": "0",
  173. // "hash": ""
  174. // },
  175. // "proposal_block_parts": null,
  176. // "proposal_pol_round": "-1",
  177. // "proposal_pol": "_",
  178. // "prevotes": "_",
  179. // "precommits": "_",
  180. // "last_commit_round": "0",
  181. // "last_commit": "x",
  182. // "catchup_commit_round": "-1",
  183. // "catchup_commit": "_"
  184. // },
  185. // "stats": {
  186. // "last_vote_height": "7184",
  187. // "votes": "255",
  188. // "last_block_part_height": "7184",
  189. // "block_parts": "255"
  190. // }
  191. // }
  192. // }
  193. // ]
  194. // }
  195. // }
  196. // ```
  197. func DumpConsensusState() (*ctypes.ResultDumpConsensusState, error) {
  198. // Get Peer consensus states.
  199. peers := p2pPeers.Peers().List()
  200. peerStates := make([]ctypes.PeerStateInfo, len(peers))
  201. for i, peer := range peers {
  202. peerState, ok := peer.Get(types.PeerStateKey).(*cm.PeerState)
  203. if !ok { // peer does not have a state yet
  204. continue
  205. }
  206. peerStateJSON, err := peerState.ToJSON()
  207. if err != nil {
  208. return nil, err
  209. }
  210. peerStates[i] = ctypes.PeerStateInfo{
  211. // Peer basic info.
  212. NodeAddress: peer.NodeInfo().NetAddress().String(),
  213. // Peer consensus state.
  214. PeerState: peerStateJSON,
  215. }
  216. }
  217. // Get self round state.
  218. roundState, err := consensusState.GetRoundStateJSON()
  219. if err != nil {
  220. return nil, err
  221. }
  222. return &ctypes.ResultDumpConsensusState{roundState, peerStates}, nil
  223. }
  224. // ConsensusState returns a concise summary of the consensus state.
  225. // UNSTABLE
  226. //
  227. // ```shell
  228. // curl 'localhost:26657/consensus_state'
  229. // ```
  230. //
  231. // ```go
  232. // client := client.NewHTTP("tcp://0.0.0.0:26657", "/websocket")
  233. // err := client.Start()
  234. // if err != nil {
  235. // // handle error
  236. // }
  237. // defer client.Stop()
  238. // state, err := client.ConsensusState()
  239. // ```
  240. //
  241. // The above command returns JSON structured like this:
  242. //
  243. // ```json
  244. //{
  245. // "jsonrpc": "2.0",
  246. // "id": "",
  247. // "result": {
  248. // "round_state": {
  249. // "height/round/step": "9336/0/1",
  250. // "start_time": "2018-05-14T10:25:45.72595357-04:00",
  251. // "proposal_block_hash": "",
  252. // "locked_block_hash": "",
  253. // "valid_block_hash": "",
  254. // "height_vote_set": [
  255. // {
  256. // "round": "0",
  257. // "prevotes": [
  258. // "nil-Vote"
  259. // ],
  260. // "prevotes_bit_array": "BA{1:_} 0/10 = 0.00",
  261. // "precommits": [
  262. // "nil-Vote"
  263. // ],
  264. // "precommits_bit_array": "BA{1:_} 0/10 = 0.00"
  265. // }
  266. // ]
  267. // }
  268. // }
  269. //}
  270. //```
  271. func ConsensusState() (*ctypes.ResultConsensusState, error) {
  272. // Get self round state.
  273. bz, err := consensusState.GetRoundStateSimpleJSON()
  274. return &ctypes.ResultConsensusState{bz}, err
  275. }
  276. // Get the consensus parameters at the given block height.
  277. // If no height is provided, it will fetch the current consensus params.
  278. //
  279. // ```shell
  280. // curl 'localhost:26657/consensus_params'
  281. // ```
  282. //
  283. // ```go
  284. // client := client.NewHTTP("tcp://0.0.0.0:26657", "/websocket")
  285. // err := client.Start()
  286. // if err != nil {
  287. // // handle error
  288. // }
  289. // defer client.Stop()
  290. // state, err := client.ConsensusParams()
  291. // ```
  292. //
  293. // The above command returns JSON structured like this:
  294. //
  295. // ```json
  296. // {
  297. // "jsonrpc": "2.0",
  298. // "id": "",
  299. // "result": {
  300. // "block_height": "1",
  301. // "consensus_params": {
  302. // "block_size_params": {
  303. // "max_txs_bytes": "22020096",
  304. // "max_gas": "-1"
  305. // },
  306. // "evidence_params": {
  307. // "max_age": "100000"
  308. // }
  309. // }
  310. // }
  311. // }
  312. // ```
  313. func ConsensusParams(heightPtr *int64) (*ctypes.ResultConsensusParams, error) {
  314. height := consensusState.GetState().LastBlockHeight + 1
  315. height, err := getHeight(height, heightPtr)
  316. if err != nil {
  317. return nil, err
  318. }
  319. consensusparams, err := sm.LoadConsensusParams(stateDB, height)
  320. if err != nil {
  321. return nil, err
  322. }
  323. return &ctypes.ResultConsensusParams{BlockHeight: height, ConsensusParams: consensusparams}, nil
  324. }