You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

208 lines
5.3 KiB

limit number of /subscribe clients and queries per client (#3269) * limit number of /subscribe clients and queries per client Add the following config variables (under [rpc] section): * max_subscription_clients * max_subscriptions_per_client * timeout_broadcast_tx_commit Fixes #2826 new HTTPClient interface for subscriptions finalize HTTPClient events interface remove EventSubscriber fix data race ``` WARNING: DATA RACE Read at 0x00c000a36060 by goroutine 129: github.com/tendermint/tendermint/rpc/client.(*Local).Subscribe.func1() /go/src/github.com/tendermint/tendermint/rpc/client/localclient.go:168 +0x1f0 Previous write at 0x00c000a36060 by goroutine 132: github.com/tendermint/tendermint/rpc/client.(*Local).Subscribe() /go/src/github.com/tendermint/tendermint/rpc/client/localclient.go:191 +0x4e0 github.com/tendermint/tendermint/rpc/client.WaitForOneEvent() /go/src/github.com/tendermint/tendermint/rpc/client/helpers.go:64 +0x178 github.com/tendermint/tendermint/rpc/client_test.TestTxEventsSentWithBroadcastTxSync.func1() /go/src/github.com/tendermint/tendermint/rpc/client/event_test.go:139 +0x298 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 Goroutine 129 (running) created at: github.com/tendermint/tendermint/rpc/client.(*Local).Subscribe() /go/src/github.com/tendermint/tendermint/rpc/client/localclient.go:164 +0x4b7 github.com/tendermint/tendermint/rpc/client.WaitForOneEvent() /go/src/github.com/tendermint/tendermint/rpc/client/helpers.go:64 +0x178 github.com/tendermint/tendermint/rpc/client_test.TestTxEventsSentWithBroadcastTxSync.func1() /go/src/github.com/tendermint/tendermint/rpc/client/event_test.go:139 +0x298 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 Goroutine 132 (running) created at: testing.(*T).Run() /usr/local/go/src/testing/testing.go:878 +0x659 github.com/tendermint/tendermint/rpc/client_test.TestTxEventsSentWithBroadcastTxSync() /go/src/github.com/tendermint/tendermint/rpc/client/event_test.go:119 +0x186 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 ================== ``` lite client works (tested manually) godoc comments httpclient: do not close the out channel use TimeoutBroadcastTxCommit no timeout for unsubscribe but 1s Local (5s HTTP) timeout for resubscribe format code change Subscribe#out cap to 1 and replace config vars with RPCConfig TimeoutBroadcastTxCommit can't be greater than rpcserver.WriteTimeout rpc: Context as first parameter to all functions reformat code fixes after my own review fixes after Ethan's review add test stubs fix config.toml * fixes after manual testing - rpc: do not recommend to use BroadcastTxCommit because it's slow and wastes Tendermint resources (pubsub) - rpc: better error in Subscribe and BroadcastTxCommit - HTTPClient: do not resubscribe if err = ErrAlreadySubscribed * fixes after Ismail's review * Update rpc/grpc/grpc_test.go Co-Authored-By: melekes <anton.kalyaev@gmail.com>
6 years ago
limit number of /subscribe clients and queries per client (#3269) * limit number of /subscribe clients and queries per client Add the following config variables (under [rpc] section): * max_subscription_clients * max_subscriptions_per_client * timeout_broadcast_tx_commit Fixes #2826 new HTTPClient interface for subscriptions finalize HTTPClient events interface remove EventSubscriber fix data race ``` WARNING: DATA RACE Read at 0x00c000a36060 by goroutine 129: github.com/tendermint/tendermint/rpc/client.(*Local).Subscribe.func1() /go/src/github.com/tendermint/tendermint/rpc/client/localclient.go:168 +0x1f0 Previous write at 0x00c000a36060 by goroutine 132: github.com/tendermint/tendermint/rpc/client.(*Local).Subscribe() /go/src/github.com/tendermint/tendermint/rpc/client/localclient.go:191 +0x4e0 github.com/tendermint/tendermint/rpc/client.WaitForOneEvent() /go/src/github.com/tendermint/tendermint/rpc/client/helpers.go:64 +0x178 github.com/tendermint/tendermint/rpc/client_test.TestTxEventsSentWithBroadcastTxSync.func1() /go/src/github.com/tendermint/tendermint/rpc/client/event_test.go:139 +0x298 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 Goroutine 129 (running) created at: github.com/tendermint/tendermint/rpc/client.(*Local).Subscribe() /go/src/github.com/tendermint/tendermint/rpc/client/localclient.go:164 +0x4b7 github.com/tendermint/tendermint/rpc/client.WaitForOneEvent() /go/src/github.com/tendermint/tendermint/rpc/client/helpers.go:64 +0x178 github.com/tendermint/tendermint/rpc/client_test.TestTxEventsSentWithBroadcastTxSync.func1() /go/src/github.com/tendermint/tendermint/rpc/client/event_test.go:139 +0x298 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 Goroutine 132 (running) created at: testing.(*T).Run() /usr/local/go/src/testing/testing.go:878 +0x659 github.com/tendermint/tendermint/rpc/client_test.TestTxEventsSentWithBroadcastTxSync() /go/src/github.com/tendermint/tendermint/rpc/client/event_test.go:119 +0x186 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 ================== ``` lite client works (tested manually) godoc comments httpclient: do not close the out channel use TimeoutBroadcastTxCommit no timeout for unsubscribe but 1s Local (5s HTTP) timeout for resubscribe format code change Subscribe#out cap to 1 and replace config vars with RPCConfig TimeoutBroadcastTxCommit can't be greater than rpcserver.WriteTimeout rpc: Context as first parameter to all functions reformat code fixes after my own review fixes after Ethan's review add test stubs fix config.toml * fixes after manual testing - rpc: do not recommend to use BroadcastTxCommit because it's slow and wastes Tendermint resources (pubsub) - rpc: better error in Subscribe and BroadcastTxCommit - HTTPClient: do not resubscribe if err = ErrAlreadySubscribed * fixes after Ismail's review * Update rpc/grpc/grpc_test.go Co-Authored-By: melekes <anton.kalyaev@gmail.com>
6 years ago
  1. package core
  2. import (
  3. "encoding/base64"
  4. "fmt"
  5. "time"
  6. cfg "github.com/tendermint/tendermint/config"
  7. "github.com/tendermint/tendermint/crypto"
  8. "github.com/tendermint/tendermint/internal/consensus"
  9. mempl "github.com/tendermint/tendermint/internal/mempool"
  10. "github.com/tendermint/tendermint/internal/p2p"
  11. tmjson "github.com/tendermint/tendermint/libs/json"
  12. "github.com/tendermint/tendermint/libs/log"
  13. "github.com/tendermint/tendermint/proxy"
  14. ctypes "github.com/tendermint/tendermint/rpc/core/types"
  15. sm "github.com/tendermint/tendermint/state"
  16. "github.com/tendermint/tendermint/state/indexer"
  17. "github.com/tendermint/tendermint/types"
  18. )
  19. const (
  20. // see README
  21. defaultPerPage = 30
  22. maxPerPage = 100
  23. // SubscribeTimeout is the maximum time we wait to subscribe for an event.
  24. // must be less than the server's write timeout (see rpcserver.DefaultConfig)
  25. SubscribeTimeout = 5 * time.Second
  26. // genesisChunkSize is the maximum size, in bytes, of each
  27. // chunk in the genesis structure for the chunked API
  28. genesisChunkSize = 16 * 1024 * 1024 // 16
  29. )
  30. //----------------------------------------------
  31. // These interfaces are used by RPC and must be thread safe
  32. type consensusState interface {
  33. GetState() sm.State
  34. GetValidators() (int64, []*types.Validator)
  35. GetLastHeight() int64
  36. GetRoundStateJSON() ([]byte, error)
  37. GetRoundStateSimpleJSON() ([]byte, error)
  38. }
  39. type transport interface {
  40. Listeners() []string
  41. IsListening() bool
  42. NodeInfo() types.NodeInfo
  43. }
  44. type peers interface {
  45. AddPersistentPeers([]string) error
  46. AddUnconditionalPeerIDs([]string) error
  47. AddPrivatePeerIDs([]string) error
  48. DialPeersAsync([]string) error
  49. Peers() p2p.IPeerSet
  50. }
  51. type peerManager interface {
  52. Peers() []types.NodeID
  53. Addresses(types.NodeID) []p2p.NodeAddress
  54. }
  55. //----------------------------------------------
  56. // Environment contains objects and interfaces used by the RPC. It is expected
  57. // to be setup once during startup.
  58. type Environment struct {
  59. // external, thread safe interfaces
  60. ProxyAppQuery proxy.AppConnQuery
  61. ProxyAppMempool proxy.AppConnMempool
  62. // interfaces defined in types and above
  63. StateStore sm.Store
  64. BlockStore sm.BlockStore
  65. EvidencePool sm.EvidencePool
  66. ConsensusState consensusState
  67. P2PPeers peers
  68. // Legacy p2p stack
  69. P2PTransport transport
  70. // interfaces for new p2p interfaces
  71. PeerManager peerManager
  72. // objects
  73. PubKey crypto.PubKey
  74. GenDoc *types.GenesisDoc // cache the genesis structure
  75. EventSinks []indexer.EventSink
  76. ConsensusReactor *consensus.Reactor
  77. EventBus *types.EventBus // thread safe
  78. Mempool mempl.Mempool
  79. BlockSyncReactor consensus.BlockSyncReactor
  80. Logger log.Logger
  81. Config cfg.RPCConfig
  82. // cache of chunked genesis data.
  83. genChunks []string
  84. }
  85. //----------------------------------------------
  86. func validatePage(pagePtr *int, perPage, totalCount int) (int, error) {
  87. // this can only happen if we haven't first run validatePerPage
  88. if perPage < 1 {
  89. panic(fmt.Errorf("%w (%d)", ctypes.ErrZeroOrNegativePerPage, perPage))
  90. }
  91. if pagePtr == nil { // no page parameter
  92. return 1, nil
  93. }
  94. pages := ((totalCount - 1) / perPage) + 1
  95. if pages == 0 {
  96. pages = 1 // one page (even if it's empty)
  97. }
  98. page := *pagePtr
  99. if page <= 0 || page > pages {
  100. return 1, fmt.Errorf("%w expected range: [1, %d], given %d", ctypes.ErrPageOutOfRange, pages, page)
  101. }
  102. return page, nil
  103. }
  104. func (env *Environment) validatePerPage(perPagePtr *int) int {
  105. if perPagePtr == nil { // no per_page parameter
  106. return defaultPerPage
  107. }
  108. perPage := *perPagePtr
  109. if perPage < 1 {
  110. return defaultPerPage
  111. // in unsafe mode there is no max on the page size but in safe mode
  112. // we cap it to maxPerPage
  113. } else if perPage > maxPerPage && !env.Config.Unsafe {
  114. return maxPerPage
  115. }
  116. return perPage
  117. }
  118. // InitGenesisChunks configures the environment and should be called on service
  119. // startup.
  120. func (env *Environment) InitGenesisChunks() error {
  121. if env.genChunks != nil {
  122. return nil
  123. }
  124. if env.GenDoc == nil {
  125. return nil
  126. }
  127. data, err := tmjson.Marshal(env.GenDoc)
  128. if err != nil {
  129. return err
  130. }
  131. for i := 0; i < len(data); i += genesisChunkSize {
  132. end := i + genesisChunkSize
  133. if end > len(data) {
  134. end = len(data)
  135. }
  136. env.genChunks = append(env.genChunks, base64.StdEncoding.EncodeToString(data[i:end]))
  137. }
  138. return nil
  139. }
  140. func validateSkipCount(page, perPage int) int {
  141. skipCount := (page - 1) * perPage
  142. if skipCount < 0 {
  143. return 0
  144. }
  145. return skipCount
  146. }
  147. // latestHeight can be either latest committed or uncommitted (+1) height.
  148. func (env *Environment) getHeight(latestHeight int64, heightPtr *int64) (int64, error) {
  149. if heightPtr != nil {
  150. height := *heightPtr
  151. if height <= 0 {
  152. return 0, fmt.Errorf("%w (requested height: %d)", ctypes.ErrZeroOrNegativeHeight, height)
  153. }
  154. if height > latestHeight {
  155. return 0, fmt.Errorf("%w (requested height: %d, blockchain height: %d)",
  156. ctypes.ErrHeightExceedsChainHead, height, latestHeight)
  157. }
  158. base := env.BlockStore.Base()
  159. if height < base {
  160. return 0, fmt.Errorf("%w (requested height: %d, base height: %d)", ctypes.ErrHeightNotAvailable, height, base)
  161. }
  162. return height, nil
  163. }
  164. return latestHeight, nil
  165. }
  166. func (env *Environment) latestUncommittedHeight() int64 {
  167. nodeIsSyncing := env.ConsensusReactor.WaitSync()
  168. if nodeIsSyncing {
  169. return env.BlockStore.Height()
  170. }
  171. return env.BlockStore.Height() + 1
  172. }