You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

357 lines
9.1 KiB

9 years ago
9 years ago
9 years ago
7 years ago
7 years ago
9 years ago
8 years ago
9 years ago
7 years ago
8 years ago
8 years ago
8 years ago
8 years ago
8 years ago
8 years ago
8 years ago
7 years ago
7 years ago
7 years ago
8 years ago
8 years ago
p2p: peer should respect errors from SetDeadline Noticed while auditing the code that we aren't respecting (*net.Conn) SetDeadline errors which return after a connection has been killed and is simultaneously being used. For example given program, without SetDeadline error checks ```go package main import ( "log" "net" "time" ) func main() { conn, err := net.Dial("tcp", "tendermint.com:443") if err != nil { log.Fatal(err) } go func() { <-time.After(400 * time.Millisecond) conn.Close() }() for i := 0; i < 5; i++ { if err := conn.SetDeadline(time.Now().Add(time.Duration(10 * time.Second))); err != nil { log.Fatalf("set deadline #%d, err: %v", i, err) } log.Printf("Successfully set deadline #%d", i) <-time.After(150 * time.Millisecond) } } ``` erraneously gives ```shell 2017/11/14 17:46:28 Successfully set deadline #0 2017/11/14 17:46:29 Successfully set deadline #1 2017/11/14 17:46:29 Successfully set deadline #2 2017/11/14 17:46:29 Successfully set deadline #3 2017/11/14 17:46:29 Successfully set deadline #4 ``` However, if we properly fix it to respect that error with ```diff --- wild.go 2017-11-14 17:44:38.000000000 -0700 +++ main.go 2017-11-14 17:45:40.000000000 -0700 @@ -16,7 +16,9 @@ conn.Close() }() for i := 0; i < 5; i++ { - conn.SetDeadline(time.Now().Add(time.Duration(10 * time.Second))) + if err := conn.SetDeadline(time.Now().Add(time.Duration(10 * time.Second))); err != nil { + log.Fatalf("set deadline #%d, err: %v", i, err) + } log.Printf("Successfully set deadline #%d", i) <-time.After(150 * time.Millisecond) } ``` properly catches any problems and gives ```shell $ go run main.go 2017/11/14 17:43:44 Successfully set deadline #0 2017/11/14 17:43:45 Successfully set deadline #1 2017/11/14 17:43:45 Successfully set deadline #2 2017/11/14 17:43:45 set deadline #3, err: set tcp 10.182.253.51:57395: use of closed network connection exit status 1 ```
7 years ago
8 years ago
8 years ago
7 years ago
8 years ago
8 years ago
7 years ago
7 years ago
9 years ago
7 years ago
9 years ago
7 years ago
p2p: peer should respect errors from SetDeadline Noticed while auditing the code that we aren't respecting (*net.Conn) SetDeadline errors which return after a connection has been killed and is simultaneously being used. For example given program, without SetDeadline error checks ```go package main import ( "log" "net" "time" ) func main() { conn, err := net.Dial("tcp", "tendermint.com:443") if err != nil { log.Fatal(err) } go func() { <-time.After(400 * time.Millisecond) conn.Close() }() for i := 0; i < 5; i++ { if err := conn.SetDeadline(time.Now().Add(time.Duration(10 * time.Second))); err != nil { log.Fatalf("set deadline #%d, err: %v", i, err) } log.Printf("Successfully set deadline #%d", i) <-time.After(150 * time.Millisecond) } } ``` erraneously gives ```shell 2017/11/14 17:46:28 Successfully set deadline #0 2017/11/14 17:46:29 Successfully set deadline #1 2017/11/14 17:46:29 Successfully set deadline #2 2017/11/14 17:46:29 Successfully set deadline #3 2017/11/14 17:46:29 Successfully set deadline #4 ``` However, if we properly fix it to respect that error with ```diff --- wild.go 2017-11-14 17:44:38.000000000 -0700 +++ main.go 2017-11-14 17:45:40.000000000 -0700 @@ -16,7 +16,9 @@ conn.Close() }() for i := 0; i < 5; i++ { - conn.SetDeadline(time.Now().Add(time.Duration(10 * time.Second))) + if err := conn.SetDeadline(time.Now().Add(time.Duration(10 * time.Second))); err != nil { + log.Fatalf("set deadline #%d, err: %v", i, err) + } log.Printf("Successfully set deadline #%d", i) <-time.After(150 * time.Millisecond) } ``` properly catches any problems and gives ```shell $ go run main.go 2017/11/14 17:43:44 Successfully set deadline #0 2017/11/14 17:43:45 Successfully set deadline #1 2017/11/14 17:43:45 Successfully set deadline #2 2017/11/14 17:43:45 set deadline #3, err: set tcp 10.182.253.51:57395: use of closed network connection exit status 1 ```
7 years ago
9 years ago
9 years ago
9 years ago
8 years ago
9 years ago
9 years ago
9 years ago
8 years ago
9 years ago
p2p: peer should respect errors from SetDeadline Noticed while auditing the code that we aren't respecting (*net.Conn) SetDeadline errors which return after a connection has been killed and is simultaneously being used. For example given program, without SetDeadline error checks ```go package main import ( "log" "net" "time" ) func main() { conn, err := net.Dial("tcp", "tendermint.com:443") if err != nil { log.Fatal(err) } go func() { <-time.After(400 * time.Millisecond) conn.Close() }() for i := 0; i < 5; i++ { if err := conn.SetDeadline(time.Now().Add(time.Duration(10 * time.Second))); err != nil { log.Fatalf("set deadline #%d, err: %v", i, err) } log.Printf("Successfully set deadline #%d", i) <-time.After(150 * time.Millisecond) } } ``` erraneously gives ```shell 2017/11/14 17:46:28 Successfully set deadline #0 2017/11/14 17:46:29 Successfully set deadline #1 2017/11/14 17:46:29 Successfully set deadline #2 2017/11/14 17:46:29 Successfully set deadline #3 2017/11/14 17:46:29 Successfully set deadline #4 ``` However, if we properly fix it to respect that error with ```diff --- wild.go 2017-11-14 17:44:38.000000000 -0700 +++ main.go 2017-11-14 17:45:40.000000000 -0700 @@ -16,7 +16,9 @@ conn.Close() }() for i := 0; i < 5; i++ { - conn.SetDeadline(time.Now().Add(time.Duration(10 * time.Second))) + if err := conn.SetDeadline(time.Now().Add(time.Duration(10 * time.Second))); err != nil { + log.Fatalf("set deadline #%d, err: %v", i, err) + } log.Printf("Successfully set deadline #%d", i) <-time.After(150 * time.Millisecond) } ``` properly catches any problems and gives ```shell $ go run main.go 2017/11/14 17:43:44 Successfully set deadline #0 2017/11/14 17:43:45 Successfully set deadline #1 2017/11/14 17:43:45 Successfully set deadline #2 2017/11/14 17:43:45 set deadline #3, err: set tcp 10.182.253.51:57395: use of closed network connection exit status 1 ```
7 years ago
7 years ago
7 years ago
7 years ago
8 years ago
9 years ago
9 years ago
7 years ago
9 years ago
7 years ago
9 years ago
7 years ago
9 years ago
7 years ago
9 years ago
7 years ago
9 years ago
9 years ago
7 years ago
9 years ago
7 years ago
9 years ago
9 years ago
7 years ago
9 years ago
7 years ago
9 years ago
7 years ago
9 years ago
7 years ago
9 years ago
7 years ago
9 years ago
7 years ago
7 years ago
8 years ago
7 years ago
8 years ago
  1. package p2p
  2. import (
  3. "fmt"
  4. "io"
  5. "net"
  6. "time"
  7. "github.com/pkg/errors"
  8. crypto "github.com/tendermint/go-crypto"
  9. wire "github.com/tendermint/go-wire"
  10. cmn "github.com/tendermint/tmlibs/common"
  11. "github.com/tendermint/tmlibs/log"
  12. )
  13. // Peer is an interface representing a peer connected on a reactor.
  14. type Peer interface {
  15. cmn.Service
  16. Key() string
  17. IsOutbound() bool
  18. IsPersistent() bool
  19. NodeInfo() *NodeInfo
  20. Status() ConnectionStatus
  21. Send(byte, interface{}) bool
  22. TrySend(byte, interface{}) bool
  23. Set(string, interface{})
  24. Get(string) interface{}
  25. }
  26. // Peer could be marked as persistent, in which case you can use
  27. // Redial function to reconnect. Note that inbound peers can't be
  28. // made persistent. They should be made persistent on the other end.
  29. //
  30. // Before using a peer, you will need to perform a handshake on connection.
  31. type peer struct {
  32. cmn.BaseService
  33. outbound bool
  34. conn net.Conn // source connection
  35. mconn *MConnection // multiplex connection
  36. persistent bool
  37. config *PeerConfig
  38. nodeInfo *NodeInfo
  39. key string
  40. Data *cmn.CMap // User data.
  41. }
  42. // PeerConfig is a Peer configuration.
  43. type PeerConfig struct {
  44. AuthEnc bool `mapstructure:"auth_enc"` // authenticated encryption
  45. // times are in seconds
  46. HandshakeTimeout time.Duration `mapstructure:"handshake_timeout"`
  47. DialTimeout time.Duration `mapstructure:"dial_timeout"`
  48. MConfig *MConnConfig `mapstructure:"connection"`
  49. Fuzz bool `mapstructure:"fuzz"` // fuzz connection (for testing)
  50. FuzzConfig *FuzzConnConfig `mapstructure:"fuzz_config"`
  51. }
  52. // DefaultPeerConfig returns the default config.
  53. func DefaultPeerConfig() *PeerConfig {
  54. return &PeerConfig{
  55. AuthEnc: true,
  56. HandshakeTimeout: 20, // * time.Second,
  57. DialTimeout: 3, // * time.Second,
  58. MConfig: DefaultMConnConfig(),
  59. Fuzz: false,
  60. FuzzConfig: DefaultFuzzConnConfig(),
  61. }
  62. }
  63. func newOutboundPeer(addr *NetAddress, reactorsByCh map[byte]Reactor, chDescs []*ChannelDescriptor,
  64. onPeerError func(Peer, interface{}), ourNodePrivKey crypto.PrivKeyEd25519, config *PeerConfig) (*peer, error) {
  65. conn, err := dial(addr, config)
  66. if err != nil {
  67. return nil, errors.Wrap(err, "Error creating peer")
  68. }
  69. peer, err := newPeerFromConnAndConfig(conn, true, reactorsByCh, chDescs, onPeerError, ourNodePrivKey, config)
  70. if err != nil {
  71. conn.Close()
  72. return nil, err
  73. }
  74. return peer, nil
  75. }
  76. func newInboundPeer(conn net.Conn, reactorsByCh map[byte]Reactor, chDescs []*ChannelDescriptor,
  77. onPeerError func(Peer, interface{}), ourNodePrivKey crypto.PrivKeyEd25519, config *PeerConfig) (*peer, error) {
  78. return newPeerFromConnAndConfig(conn, false, reactorsByCh, chDescs, onPeerError, ourNodePrivKey, config)
  79. }
  80. func newPeerFromConnAndConfig(rawConn net.Conn, outbound bool, reactorsByCh map[byte]Reactor, chDescs []*ChannelDescriptor,
  81. onPeerError func(Peer, interface{}), ourNodePrivKey crypto.PrivKeyEd25519, config *PeerConfig) (*peer, error) {
  82. conn := rawConn
  83. // Fuzz connection
  84. if config.Fuzz {
  85. // so we have time to do peer handshakes and get set up
  86. conn = FuzzConnAfterFromConfig(conn, 10*time.Second, config.FuzzConfig)
  87. }
  88. // Encrypt connection
  89. if config.AuthEnc {
  90. if err := conn.SetDeadline(time.Now().Add(config.HandshakeTimeout * time.Second)); err != nil {
  91. return nil, errors.Wrap(err, "Error setting deadline while encrypting connection")
  92. }
  93. var err error
  94. conn, err = MakeSecretConnection(conn, ourNodePrivKey)
  95. if err != nil {
  96. return nil, errors.Wrap(err, "Error creating peer")
  97. }
  98. }
  99. // Key and NodeInfo are set after Handshake
  100. p := &peer{
  101. outbound: outbound,
  102. conn: conn,
  103. config: config,
  104. Data: cmn.NewCMap(),
  105. }
  106. p.mconn = createMConnection(conn, p, reactorsByCh, chDescs, onPeerError, config.MConfig)
  107. p.BaseService = *cmn.NewBaseService(nil, "Peer", p)
  108. return p, nil
  109. }
  110. func (p *peer) SetLogger(l log.Logger) {
  111. p.Logger = l
  112. p.mconn.SetLogger(l)
  113. }
  114. // CloseConn should be used when the peer was created, but never started.
  115. func (p *peer) CloseConn() {
  116. p.conn.Close()
  117. }
  118. // makePersistent marks the peer as persistent.
  119. func (p *peer) makePersistent() {
  120. if !p.outbound {
  121. panic("inbound peers can't be made persistent")
  122. }
  123. p.persistent = true
  124. }
  125. // IsPersistent returns true if the peer is persitent, false otherwise.
  126. func (p *peer) IsPersistent() bool {
  127. return p.persistent
  128. }
  129. // HandshakeTimeout performs a handshake between a given node and the peer.
  130. // NOTE: blocking
  131. func (p *peer) HandshakeTimeout(ourNodeInfo *NodeInfo, timeout time.Duration) error {
  132. // Set deadline for handshake so we don't block forever on conn.ReadFull
  133. if err := p.conn.SetDeadline(time.Now().Add(timeout)); err != nil {
  134. return errors.Wrap(err, "Error setting deadline")
  135. }
  136. var peerNodeInfo = new(NodeInfo)
  137. var err1 error
  138. var err2 error
  139. cmn.Parallel(
  140. func() {
  141. var n int
  142. wire.WriteBinary(ourNodeInfo, p.conn, &n, &err1)
  143. },
  144. func() {
  145. var n int
  146. wire.ReadBinary(peerNodeInfo, p.conn, maxNodeInfoSize, &n, &err2)
  147. p.Logger.Info("Peer handshake", "peerNodeInfo", peerNodeInfo)
  148. })
  149. if err1 != nil {
  150. return errors.Wrap(err1, "Error during handshake/write")
  151. }
  152. if err2 != nil {
  153. return errors.Wrap(err2, "Error during handshake/read")
  154. }
  155. if p.config.AuthEnc {
  156. // Check that the professed PubKey matches the sconn's.
  157. if !peerNodeInfo.PubKey.Equals(p.PubKey().Wrap()) {
  158. return fmt.Errorf("Ignoring connection with unmatching pubkey: %v vs %v",
  159. peerNodeInfo.PubKey, p.PubKey())
  160. }
  161. }
  162. // Remove deadline
  163. if err := p.conn.SetDeadline(time.Time{}); err != nil {
  164. return errors.Wrap(err, "Error removing deadline")
  165. }
  166. peerNodeInfo.RemoteAddr = p.Addr().String()
  167. p.nodeInfo = peerNodeInfo
  168. p.key = peerNodeInfo.PubKey.KeyString()
  169. return nil
  170. }
  171. // Addr returns peer's remote network address.
  172. func (p *peer) Addr() net.Addr {
  173. return p.conn.RemoteAddr()
  174. }
  175. // PubKey returns peer's public key.
  176. func (p *peer) PubKey() crypto.PubKeyEd25519 {
  177. if p.config.AuthEnc {
  178. return p.conn.(*SecretConnection).RemotePubKey()
  179. }
  180. if p.NodeInfo() == nil {
  181. panic("Attempt to get peer's PubKey before calling Handshake")
  182. }
  183. return p.PubKey()
  184. }
  185. // OnStart implements BaseService.
  186. func (p *peer) OnStart() error {
  187. p.BaseService.OnStart()
  188. _, err := p.mconn.Start()
  189. return err
  190. }
  191. // OnStop implements BaseService.
  192. func (p *peer) OnStop() {
  193. p.BaseService.OnStop()
  194. p.mconn.Stop()
  195. }
  196. // Connection returns underlying MConnection.
  197. func (p *peer) Connection() *MConnection {
  198. return p.mconn
  199. }
  200. // IsOutbound returns true if the connection is outbound, false otherwise.
  201. func (p *peer) IsOutbound() bool {
  202. return p.outbound
  203. }
  204. // Send msg to the channel identified by chID byte. Returns false if the send
  205. // queue is full after timeout, specified by MConnection.
  206. func (p *peer) Send(chID byte, msg interface{}) bool {
  207. if !p.IsRunning() {
  208. // see Switch#Broadcast, where we fetch the list of peers and loop over
  209. // them - while we're looping, one peer may be removed and stopped.
  210. return false
  211. }
  212. return p.mconn.Send(chID, msg)
  213. }
  214. // TrySend msg to the channel identified by chID byte. Immediately returns
  215. // false if the send queue is full.
  216. func (p *peer) TrySend(chID byte, msg interface{}) bool {
  217. if !p.IsRunning() {
  218. return false
  219. }
  220. return p.mconn.TrySend(chID, msg)
  221. }
  222. // CanSend returns true if the send queue is not full, false otherwise.
  223. func (p *peer) CanSend(chID byte) bool {
  224. if !p.IsRunning() {
  225. return false
  226. }
  227. return p.mconn.CanSend(chID)
  228. }
  229. // WriteTo writes the peer's public key to w.
  230. func (p *peer) WriteTo(w io.Writer) (int64, error) {
  231. var n int
  232. var err error
  233. wire.WriteString(p.key, w, &n, &err)
  234. return int64(n), err
  235. }
  236. // String representation.
  237. func (p *peer) String() string {
  238. if p.outbound {
  239. return fmt.Sprintf("Peer{%v %v out}", p.mconn, p.key[:12])
  240. }
  241. return fmt.Sprintf("Peer{%v %v in}", p.mconn, p.key[:12])
  242. }
  243. // Equals reports whenever 2 peers are actually represent the same node.
  244. func (p *peer) Equals(other Peer) bool {
  245. return p.key == other.Key()
  246. }
  247. // Get the data for a given key.
  248. func (p *peer) Get(key string) interface{} {
  249. return p.Data.Get(key)
  250. }
  251. // Set sets the data for the given key.
  252. func (p *peer) Set(key string, data interface{}) {
  253. p.Data.Set(key, data)
  254. }
  255. // Key returns the peer's id key.
  256. func (p *peer) Key() string {
  257. return p.key
  258. }
  259. // NodeInfo returns a copy of the peer's NodeInfo.
  260. func (p *peer) NodeInfo() *NodeInfo {
  261. if p.nodeInfo == nil {
  262. return nil
  263. }
  264. n := *p.nodeInfo // copy
  265. return &n
  266. }
  267. // Status returns the peer's ConnectionStatus.
  268. func (p *peer) Status() ConnectionStatus {
  269. return p.mconn.Status()
  270. }
  271. func dial(addr *NetAddress, config *PeerConfig) (net.Conn, error) {
  272. conn, err := addr.DialTimeout(config.DialTimeout * time.Second)
  273. if err != nil {
  274. return nil, err
  275. }
  276. return conn, nil
  277. }
  278. func createMConnection(conn net.Conn, p *peer, reactorsByCh map[byte]Reactor, chDescs []*ChannelDescriptor,
  279. onPeerError func(Peer, interface{}), config *MConnConfig) *MConnection {
  280. onReceive := func(chID byte, msgBytes []byte) {
  281. reactor := reactorsByCh[chID]
  282. if reactor == nil {
  283. cmn.PanicSanity(cmn.Fmt("Unknown channel %X", chID))
  284. }
  285. reactor.Receive(chID, p, msgBytes)
  286. }
  287. onError := func(r interface{}) {
  288. onPeerError(p, r)
  289. }
  290. return NewMConnectionWithConfig(conn, chDescs, onReceive, onError, config)
  291. }