You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

160 lines
4.3 KiB

limit number of /subscribe clients and queries per client (#3269) * limit number of /subscribe clients and queries per client Add the following config variables (under [rpc] section): * max_subscription_clients * max_subscriptions_per_client * timeout_broadcast_tx_commit Fixes #2826 new HTTPClient interface for subscriptions finalize HTTPClient events interface remove EventSubscriber fix data race ``` WARNING: DATA RACE Read at 0x00c000a36060 by goroutine 129: github.com/tendermint/tendermint/rpc/client.(*Local).Subscribe.func1() /go/src/github.com/tendermint/tendermint/rpc/client/localclient.go:168 +0x1f0 Previous write at 0x00c000a36060 by goroutine 132: github.com/tendermint/tendermint/rpc/client.(*Local).Subscribe() /go/src/github.com/tendermint/tendermint/rpc/client/localclient.go:191 +0x4e0 github.com/tendermint/tendermint/rpc/client.WaitForOneEvent() /go/src/github.com/tendermint/tendermint/rpc/client/helpers.go:64 +0x178 github.com/tendermint/tendermint/rpc/client_test.TestTxEventsSentWithBroadcastTxSync.func1() /go/src/github.com/tendermint/tendermint/rpc/client/event_test.go:139 +0x298 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 Goroutine 129 (running) created at: github.com/tendermint/tendermint/rpc/client.(*Local).Subscribe() /go/src/github.com/tendermint/tendermint/rpc/client/localclient.go:164 +0x4b7 github.com/tendermint/tendermint/rpc/client.WaitForOneEvent() /go/src/github.com/tendermint/tendermint/rpc/client/helpers.go:64 +0x178 github.com/tendermint/tendermint/rpc/client_test.TestTxEventsSentWithBroadcastTxSync.func1() /go/src/github.com/tendermint/tendermint/rpc/client/event_test.go:139 +0x298 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 Goroutine 132 (running) created at: testing.(*T).Run() /usr/local/go/src/testing/testing.go:878 +0x659 github.com/tendermint/tendermint/rpc/client_test.TestTxEventsSentWithBroadcastTxSync() /go/src/github.com/tendermint/tendermint/rpc/client/event_test.go:119 +0x186 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 ================== ``` lite client works (tested manually) godoc comments httpclient: do not close the out channel use TimeoutBroadcastTxCommit no timeout for unsubscribe but 1s Local (5s HTTP) timeout for resubscribe format code change Subscribe#out cap to 1 and replace config vars with RPCConfig TimeoutBroadcastTxCommit can't be greater than rpcserver.WriteTimeout rpc: Context as first parameter to all functions reformat code fixes after my own review fixes after Ethan's review add test stubs fix config.toml * fixes after manual testing - rpc: do not recommend to use BroadcastTxCommit because it's slow and wastes Tendermint resources (pubsub) - rpc: better error in Subscribe and BroadcastTxCommit - HTTPClient: do not resubscribe if err = ErrAlreadySubscribed * fixes after Ismail's review * Update rpc/grpc/grpc_test.go Co-Authored-By: melekes <anton.kalyaev@gmail.com>
6 years ago
limit number of /subscribe clients and queries per client (#3269) * limit number of /subscribe clients and queries per client Add the following config variables (under [rpc] section): * max_subscription_clients * max_subscriptions_per_client * timeout_broadcast_tx_commit Fixes #2826 new HTTPClient interface for subscriptions finalize HTTPClient events interface remove EventSubscriber fix data race ``` WARNING: DATA RACE Read at 0x00c000a36060 by goroutine 129: github.com/tendermint/tendermint/rpc/client.(*Local).Subscribe.func1() /go/src/github.com/tendermint/tendermint/rpc/client/localclient.go:168 +0x1f0 Previous write at 0x00c000a36060 by goroutine 132: github.com/tendermint/tendermint/rpc/client.(*Local).Subscribe() /go/src/github.com/tendermint/tendermint/rpc/client/localclient.go:191 +0x4e0 github.com/tendermint/tendermint/rpc/client.WaitForOneEvent() /go/src/github.com/tendermint/tendermint/rpc/client/helpers.go:64 +0x178 github.com/tendermint/tendermint/rpc/client_test.TestTxEventsSentWithBroadcastTxSync.func1() /go/src/github.com/tendermint/tendermint/rpc/client/event_test.go:139 +0x298 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 Goroutine 129 (running) created at: github.com/tendermint/tendermint/rpc/client.(*Local).Subscribe() /go/src/github.com/tendermint/tendermint/rpc/client/localclient.go:164 +0x4b7 github.com/tendermint/tendermint/rpc/client.WaitForOneEvent() /go/src/github.com/tendermint/tendermint/rpc/client/helpers.go:64 +0x178 github.com/tendermint/tendermint/rpc/client_test.TestTxEventsSentWithBroadcastTxSync.func1() /go/src/github.com/tendermint/tendermint/rpc/client/event_test.go:139 +0x298 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 Goroutine 132 (running) created at: testing.(*T).Run() /usr/local/go/src/testing/testing.go:878 +0x659 github.com/tendermint/tendermint/rpc/client_test.TestTxEventsSentWithBroadcastTxSync() /go/src/github.com/tendermint/tendermint/rpc/client/event_test.go:119 +0x186 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 ================== ``` lite client works (tested manually) godoc comments httpclient: do not close the out channel use TimeoutBroadcastTxCommit no timeout for unsubscribe but 1s Local (5s HTTP) timeout for resubscribe format code change Subscribe#out cap to 1 and replace config vars with RPCConfig TimeoutBroadcastTxCommit can't be greater than rpcserver.WriteTimeout rpc: Context as first parameter to all functions reformat code fixes after my own review fixes after Ethan's review add test stubs fix config.toml * fixes after manual testing - rpc: do not recommend to use BroadcastTxCommit because it's slow and wastes Tendermint resources (pubsub) - rpc: better error in Subscribe and BroadcastTxCommit - HTTPClient: do not resubscribe if err = ErrAlreadySubscribed * fixes after Ismail's review * Update rpc/grpc/grpc_test.go Co-Authored-By: melekes <anton.kalyaev@gmail.com>
6 years ago
  1. package core
  2. import (
  3. "fmt"
  4. "time"
  5. cfg "github.com/tendermint/tendermint/config"
  6. "github.com/tendermint/tendermint/consensus"
  7. "github.com/tendermint/tendermint/crypto"
  8. "github.com/tendermint/tendermint/libs/log"
  9. mempl "github.com/tendermint/tendermint/mempool"
  10. "github.com/tendermint/tendermint/p2p"
  11. "github.com/tendermint/tendermint/proxy"
  12. ctypes "github.com/tendermint/tendermint/rpc/core/types"
  13. sm "github.com/tendermint/tendermint/state"
  14. "github.com/tendermint/tendermint/state/indexer"
  15. "github.com/tendermint/tendermint/types"
  16. )
  17. const (
  18. // see README
  19. defaultPerPage = 30
  20. maxPerPage = 100
  21. // SubscribeTimeout is the maximum time we wait to subscribe for an event.
  22. // must be less than the server's write timeout (see rpcserver.DefaultConfig)
  23. SubscribeTimeout = 5 * time.Second
  24. )
  25. //----------------------------------------------
  26. // These interfaces are used by RPC and must be thread safe
  27. type Consensus interface {
  28. GetState() sm.State
  29. GetValidators() (int64, []*types.Validator)
  30. GetLastHeight() int64
  31. GetRoundStateJSON() ([]byte, error)
  32. GetRoundStateSimpleJSON() ([]byte, error)
  33. }
  34. type transport interface {
  35. Listeners() []string
  36. IsListening() bool
  37. NodeInfo() p2p.NodeInfo
  38. }
  39. type peers interface {
  40. AddPersistentPeers([]string) error
  41. AddUnconditionalPeerIDs([]string) error
  42. AddPrivatePeerIDs([]string) error
  43. DialPeersAsync([]string) error
  44. Peers() p2p.IPeerSet
  45. }
  46. //----------------------------------------------
  47. // Environment contains objects and interfaces used by the RPC. It is expected
  48. // to be setup once during startup.
  49. type Environment struct {
  50. // external, thread safe interfaces
  51. ProxyAppQuery proxy.AppConnQuery
  52. ProxyAppMempool proxy.AppConnMempool
  53. // interfaces defined in types and above
  54. StateStore sm.Store
  55. BlockStore sm.BlockStore
  56. EvidencePool sm.EvidencePool
  57. ConsensusState Consensus
  58. P2PPeers peers
  59. P2PTransport transport
  60. // objects
  61. PubKey crypto.PubKey
  62. GenDoc *types.GenesisDoc // cache the genesis structure
  63. TxIndexer indexer.TxIndexer
  64. BlockIndexer indexer.BlockIndexer
  65. ConsensusReactor *consensus.Reactor
  66. EventBus *types.EventBus // thread safe
  67. Mempool mempl.Mempool
  68. Logger log.Logger
  69. Config cfg.RPCConfig
  70. }
  71. //----------------------------------------------
  72. func validatePage(pagePtr *int, perPage, totalCount int) (int, error) {
  73. // this can only happen if we haven't first run validatePerPage
  74. if perPage < 1 {
  75. panic(fmt.Errorf("%w (%d)", ctypes.ErrZeroOrNegativePerPage, perPage))
  76. }
  77. if pagePtr == nil { // no page parameter
  78. return 1, nil
  79. }
  80. pages := ((totalCount - 1) / perPage) + 1
  81. if pages == 0 {
  82. pages = 1 // one page (even if it's empty)
  83. }
  84. page := *pagePtr
  85. if page <= 0 || page > pages {
  86. return 1, fmt.Errorf("%w expected range: [1, %d], given %d", ctypes.ErrPageOutOfRange, pages, page)
  87. }
  88. return page, nil
  89. }
  90. func (env *Environment) validatePerPage(perPagePtr *int) int {
  91. if perPagePtr == nil { // no per_page parameter
  92. return defaultPerPage
  93. }
  94. perPage := *perPagePtr
  95. if perPage < 1 {
  96. return defaultPerPage
  97. // in unsafe mode there is no max on the page size but in safe mode
  98. // we cap it to maxPerPage
  99. } else if perPage > maxPerPage && !env.Config.Unsafe {
  100. return maxPerPage
  101. }
  102. return perPage
  103. }
  104. func validateSkipCount(page, perPage int) int {
  105. skipCount := (page - 1) * perPage
  106. if skipCount < 0 {
  107. return 0
  108. }
  109. return skipCount
  110. }
  111. // latestHeight can be either latest committed or uncommitted (+1) height.
  112. func (env *Environment) getHeight(latestHeight int64, heightPtr *int64) (int64, error) {
  113. if heightPtr != nil {
  114. height := *heightPtr
  115. if height <= 0 {
  116. return 0, fmt.Errorf("%w (requested height: %d)", ctypes.ErrZeroOrNegativeHeight, height)
  117. }
  118. if height > latestHeight {
  119. return 0, fmt.Errorf("%w (requested height: %d, blockchain height: %d)",
  120. ctypes.ErrHeightExceedsChainHead, height, latestHeight)
  121. }
  122. base := env.BlockStore.Base()
  123. if height < base {
  124. return 0, fmt.Errorf("%w (requested height: %d, base height: %d)", ctypes.ErrHeightNotAvailable, height, base)
  125. }
  126. return height, nil
  127. }
  128. return latestHeight, nil
  129. }
  130. func (env *Environment) latestUncommittedHeight() int64 {
  131. nodeIsSyncing := env.ConsensusReactor.WaitSync()
  132. if nodeIsSyncing {
  133. return env.BlockStore.Height()
  134. }
  135. return env.BlockStore.Height() + 1
  136. }