You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

197 lines
5.1 KiB

limit number of /subscribe clients and queries per client (#3269) * limit number of /subscribe clients and queries per client Add the following config variables (under [rpc] section): * max_subscription_clients * max_subscriptions_per_client * timeout_broadcast_tx_commit Fixes #2826 new HTTPClient interface for subscriptions finalize HTTPClient events interface remove EventSubscriber fix data race ``` WARNING: DATA RACE Read at 0x00c000a36060 by goroutine 129: github.com/tendermint/tendermint/rpc/client.(*Local).Subscribe.func1() /go/src/github.com/tendermint/tendermint/rpc/client/localclient.go:168 +0x1f0 Previous write at 0x00c000a36060 by goroutine 132: github.com/tendermint/tendermint/rpc/client.(*Local).Subscribe() /go/src/github.com/tendermint/tendermint/rpc/client/localclient.go:191 +0x4e0 github.com/tendermint/tendermint/rpc/client.WaitForOneEvent() /go/src/github.com/tendermint/tendermint/rpc/client/helpers.go:64 +0x178 github.com/tendermint/tendermint/rpc/client_test.TestTxEventsSentWithBroadcastTxSync.func1() /go/src/github.com/tendermint/tendermint/rpc/client/event_test.go:139 +0x298 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 Goroutine 129 (running) created at: github.com/tendermint/tendermint/rpc/client.(*Local).Subscribe() /go/src/github.com/tendermint/tendermint/rpc/client/localclient.go:164 +0x4b7 github.com/tendermint/tendermint/rpc/client.WaitForOneEvent() /go/src/github.com/tendermint/tendermint/rpc/client/helpers.go:64 +0x178 github.com/tendermint/tendermint/rpc/client_test.TestTxEventsSentWithBroadcastTxSync.func1() /go/src/github.com/tendermint/tendermint/rpc/client/event_test.go:139 +0x298 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 Goroutine 132 (running) created at: testing.(*T).Run() /usr/local/go/src/testing/testing.go:878 +0x659 github.com/tendermint/tendermint/rpc/client_test.TestTxEventsSentWithBroadcastTxSync() /go/src/github.com/tendermint/tendermint/rpc/client/event_test.go:119 +0x186 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 ================== ``` lite client works (tested manually) godoc comments httpclient: do not close the out channel use TimeoutBroadcastTxCommit no timeout for unsubscribe but 1s Local (5s HTTP) timeout for resubscribe format code change Subscribe#out cap to 1 and replace config vars with RPCConfig TimeoutBroadcastTxCommit can't be greater than rpcserver.WriteTimeout rpc: Context as first parameter to all functions reformat code fixes after my own review fixes after Ethan's review add test stubs fix config.toml * fixes after manual testing - rpc: do not recommend to use BroadcastTxCommit because it's slow and wastes Tendermint resources (pubsub) - rpc: better error in Subscribe and BroadcastTxCommit - HTTPClient: do not resubscribe if err = ErrAlreadySubscribed * fixes after Ismail's review * Update rpc/grpc/grpc_test.go Co-Authored-By: melekes <anton.kalyaev@gmail.com>
6 years ago
limit number of /subscribe clients and queries per client (#3269) * limit number of /subscribe clients and queries per client Add the following config variables (under [rpc] section): * max_subscription_clients * max_subscriptions_per_client * timeout_broadcast_tx_commit Fixes #2826 new HTTPClient interface for subscriptions finalize HTTPClient events interface remove EventSubscriber fix data race ``` WARNING: DATA RACE Read at 0x00c000a36060 by goroutine 129: github.com/tendermint/tendermint/rpc/client.(*Local).Subscribe.func1() /go/src/github.com/tendermint/tendermint/rpc/client/localclient.go:168 +0x1f0 Previous write at 0x00c000a36060 by goroutine 132: github.com/tendermint/tendermint/rpc/client.(*Local).Subscribe() /go/src/github.com/tendermint/tendermint/rpc/client/localclient.go:191 +0x4e0 github.com/tendermint/tendermint/rpc/client.WaitForOneEvent() /go/src/github.com/tendermint/tendermint/rpc/client/helpers.go:64 +0x178 github.com/tendermint/tendermint/rpc/client_test.TestTxEventsSentWithBroadcastTxSync.func1() /go/src/github.com/tendermint/tendermint/rpc/client/event_test.go:139 +0x298 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 Goroutine 129 (running) created at: github.com/tendermint/tendermint/rpc/client.(*Local).Subscribe() /go/src/github.com/tendermint/tendermint/rpc/client/localclient.go:164 +0x4b7 github.com/tendermint/tendermint/rpc/client.WaitForOneEvent() /go/src/github.com/tendermint/tendermint/rpc/client/helpers.go:64 +0x178 github.com/tendermint/tendermint/rpc/client_test.TestTxEventsSentWithBroadcastTxSync.func1() /go/src/github.com/tendermint/tendermint/rpc/client/event_test.go:139 +0x298 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 Goroutine 132 (running) created at: testing.(*T).Run() /usr/local/go/src/testing/testing.go:878 +0x659 github.com/tendermint/tendermint/rpc/client_test.TestTxEventsSentWithBroadcastTxSync() /go/src/github.com/tendermint/tendermint/rpc/client/event_test.go:119 +0x186 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 ================== ``` lite client works (tested manually) godoc comments httpclient: do not close the out channel use TimeoutBroadcastTxCommit no timeout for unsubscribe but 1s Local (5s HTTP) timeout for resubscribe format code change Subscribe#out cap to 1 and replace config vars with RPCConfig TimeoutBroadcastTxCommit can't be greater than rpcserver.WriteTimeout rpc: Context as first parameter to all functions reformat code fixes after my own review fixes after Ethan's review add test stubs fix config.toml * fixes after manual testing - rpc: do not recommend to use BroadcastTxCommit because it's slow and wastes Tendermint resources (pubsub) - rpc: better error in Subscribe and BroadcastTxCommit - HTTPClient: do not resubscribe if err = ErrAlreadySubscribed * fixes after Ismail's review * Update rpc/grpc/grpc_test.go Co-Authored-By: melekes <anton.kalyaev@gmail.com>
6 years ago
  1. package core
  2. import (
  3. "encoding/base64"
  4. "fmt"
  5. "time"
  6. cfg "github.com/tendermint/tendermint/config"
  7. "github.com/tendermint/tendermint/crypto"
  8. "github.com/tendermint/tendermint/internal/consensus"
  9. mempl "github.com/tendermint/tendermint/internal/mempool"
  10. "github.com/tendermint/tendermint/internal/p2p"
  11. tmjson "github.com/tendermint/tendermint/libs/json"
  12. "github.com/tendermint/tendermint/libs/log"
  13. "github.com/tendermint/tendermint/proxy"
  14. ctypes "github.com/tendermint/tendermint/rpc/core/types"
  15. sm "github.com/tendermint/tendermint/state"
  16. "github.com/tendermint/tendermint/state/indexer"
  17. "github.com/tendermint/tendermint/types"
  18. )
  19. const (
  20. // see README
  21. defaultPerPage = 30
  22. maxPerPage = 100
  23. // SubscribeTimeout is the maximum time we wait to subscribe for an event.
  24. // must be less than the server's write timeout (see rpcserver.DefaultConfig)
  25. SubscribeTimeout = 5 * time.Second
  26. // genesisChunkSize is the maximum size, in bytes, of each
  27. // chunk in the genesis structure for the chunked API
  28. genesisChunkSize = 16 * 1024 * 1024 // 16
  29. )
  30. //----------------------------------------------
  31. // These interfaces are used by RPC and must be thread safe
  32. type Consensus interface {
  33. GetState() sm.State
  34. GetValidators() (int64, []*types.Validator)
  35. GetLastHeight() int64
  36. GetRoundStateJSON() ([]byte, error)
  37. GetRoundStateSimpleJSON() ([]byte, error)
  38. }
  39. type transport interface {
  40. Listeners() []string
  41. IsListening() bool
  42. NodeInfo() p2p.NodeInfo
  43. }
  44. type peers interface {
  45. AddPersistentPeers([]string) error
  46. AddUnconditionalPeerIDs([]string) error
  47. AddPrivatePeerIDs([]string) error
  48. DialPeersAsync([]string) error
  49. Peers() p2p.IPeerSet
  50. }
  51. //----------------------------------------------
  52. // Environment contains objects and interfaces used by the RPC. It is expected
  53. // to be setup once during startup.
  54. type Environment struct {
  55. // external, thread safe interfaces
  56. ProxyAppQuery proxy.AppConnQuery
  57. ProxyAppMempool proxy.AppConnMempool
  58. // interfaces defined in types and above
  59. StateStore sm.Store
  60. BlockStore sm.BlockStore
  61. EvidencePool sm.EvidencePool
  62. ConsensusState Consensus
  63. P2PPeers peers
  64. P2PTransport transport
  65. // objects
  66. PubKey crypto.PubKey
  67. GenDoc *types.GenesisDoc // cache the genesis structure
  68. EventSinks []indexer.EventSink
  69. ConsensusReactor *consensus.Reactor
  70. EventBus *types.EventBus // thread safe
  71. Mempool mempl.Mempool
  72. Logger log.Logger
  73. Config cfg.RPCConfig
  74. // cache of chunked genesis data.
  75. genChunks []string
  76. }
  77. //----------------------------------------------
  78. func validatePage(pagePtr *int, perPage, totalCount int) (int, error) {
  79. // this can only happen if we haven't first run validatePerPage
  80. if perPage < 1 {
  81. panic(fmt.Errorf("%w (%d)", ctypes.ErrZeroOrNegativePerPage, perPage))
  82. }
  83. if pagePtr == nil { // no page parameter
  84. return 1, nil
  85. }
  86. pages := ((totalCount - 1) / perPage) + 1
  87. if pages == 0 {
  88. pages = 1 // one page (even if it's empty)
  89. }
  90. page := *pagePtr
  91. if page <= 0 || page > pages {
  92. return 1, fmt.Errorf("%w expected range: [1, %d], given %d", ctypes.ErrPageOutOfRange, pages, page)
  93. }
  94. return page, nil
  95. }
  96. func (env *Environment) validatePerPage(perPagePtr *int) int {
  97. if perPagePtr == nil { // no per_page parameter
  98. return defaultPerPage
  99. }
  100. perPage := *perPagePtr
  101. if perPage < 1 {
  102. return defaultPerPage
  103. // in unsafe mode there is no max on the page size but in safe mode
  104. // we cap it to maxPerPage
  105. } else if perPage > maxPerPage && !env.Config.Unsafe {
  106. return maxPerPage
  107. }
  108. return perPage
  109. }
  110. // InitGenesisChunks configures the environment and should be called on service
  111. // startup.
  112. func (env *Environment) InitGenesisChunks() error {
  113. if env.genChunks != nil {
  114. return nil
  115. }
  116. if env.GenDoc == nil {
  117. return nil
  118. }
  119. data, err := tmjson.Marshal(env.GenDoc)
  120. if err != nil {
  121. return err
  122. }
  123. for i := 0; i < len(data); i += genesisChunkSize {
  124. end := i + genesisChunkSize
  125. if end > len(data) {
  126. end = len(data)
  127. }
  128. env.genChunks = append(env.genChunks, base64.StdEncoding.EncodeToString(data[i:end]))
  129. }
  130. return nil
  131. }
  132. func validateSkipCount(page, perPage int) int {
  133. skipCount := (page - 1) * perPage
  134. if skipCount < 0 {
  135. return 0
  136. }
  137. return skipCount
  138. }
  139. // latestHeight can be either latest committed or uncommitted (+1) height.
  140. func (env *Environment) getHeight(latestHeight int64, heightPtr *int64) (int64, error) {
  141. if heightPtr != nil {
  142. height := *heightPtr
  143. if height <= 0 {
  144. return 0, fmt.Errorf("%w (requested height: %d)", ctypes.ErrZeroOrNegativeHeight, height)
  145. }
  146. if height > latestHeight {
  147. return 0, fmt.Errorf("%w (requested height: %d, blockchain height: %d)",
  148. ctypes.ErrHeightExceedsChainHead, height, latestHeight)
  149. }
  150. base := env.BlockStore.Base()
  151. if height < base {
  152. return 0, fmt.Errorf("%w (requested height: %d, base height: %d)", ctypes.ErrHeightNotAvailable, height, base)
  153. }
  154. return height, nil
  155. }
  156. return latestHeight, nil
  157. }
  158. func (env *Environment) latestUncommittedHeight() int64 {
  159. nodeIsSyncing := env.ConsensusReactor.WaitSync()
  160. if nodeIsSyncing {
  161. return env.BlockStore.Height()
  162. }
  163. return env.BlockStore.Height() + 1
  164. }