You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

344 lines
8.8 KiB

9 years ago
9 years ago
9 years ago
9 years ago
7 years ago
7 years ago
7 years ago
9 years ago
8 years ago
9 years ago
7 years ago
8 years ago
8 years ago
8 years ago
8 years ago
8 years ago
8 years ago
8 years ago
7 years ago
8 years ago
8 years ago
p2p: peer should respect errors from SetDeadline Noticed while auditing the code that we aren't respecting (*net.Conn) SetDeadline errors which return after a connection has been killed and is simultaneously being used. For example given program, without SetDeadline error checks ```go package main import ( "log" "net" "time" ) func main() { conn, err := net.Dial("tcp", "tendermint.com:443") if err != nil { log.Fatal(err) } go func() { <-time.After(400 * time.Millisecond) conn.Close() }() for i := 0; i < 5; i++ { if err := conn.SetDeadline(time.Now().Add(time.Duration(10 * time.Second))); err != nil { log.Fatalf("set deadline #%d, err: %v", i, err) } log.Printf("Successfully set deadline #%d", i) <-time.After(150 * time.Millisecond) } } ``` erraneously gives ```shell 2017/11/14 17:46:28 Successfully set deadline #0 2017/11/14 17:46:29 Successfully set deadline #1 2017/11/14 17:46:29 Successfully set deadline #2 2017/11/14 17:46:29 Successfully set deadline #3 2017/11/14 17:46:29 Successfully set deadline #4 ``` However, if we properly fix it to respect that error with ```diff --- wild.go 2017-11-14 17:44:38.000000000 -0700 +++ main.go 2017-11-14 17:45:40.000000000 -0700 @@ -16,7 +16,9 @@ conn.Close() }() for i := 0; i < 5; i++ { - conn.SetDeadline(time.Now().Add(time.Duration(10 * time.Second))) + if err := conn.SetDeadline(time.Now().Add(time.Duration(10 * time.Second))); err != nil { + log.Fatalf("set deadline #%d, err: %v", i, err) + } log.Printf("Successfully set deadline #%d", i) <-time.After(150 * time.Millisecond) } ``` properly catches any problems and gives ```shell $ go run main.go 2017/11/14 17:43:44 Successfully set deadline #0 2017/11/14 17:43:45 Successfully set deadline #1 2017/11/14 17:43:45 Successfully set deadline #2 2017/11/14 17:43:45 set deadline #3, err: set tcp 10.182.253.51:57395: use of closed network connection exit status 1 ```
7 years ago
8 years ago
8 years ago
7 years ago
8 years ago
8 years ago
7 years ago
7 years ago
9 years ago
7 years ago
9 years ago
7 years ago
p2p: peer should respect errors from SetDeadline Noticed while auditing the code that we aren't respecting (*net.Conn) SetDeadline errors which return after a connection has been killed and is simultaneously being used. For example given program, without SetDeadline error checks ```go package main import ( "log" "net" "time" ) func main() { conn, err := net.Dial("tcp", "tendermint.com:443") if err != nil { log.Fatal(err) } go func() { <-time.After(400 * time.Millisecond) conn.Close() }() for i := 0; i < 5; i++ { if err := conn.SetDeadline(time.Now().Add(time.Duration(10 * time.Second))); err != nil { log.Fatalf("set deadline #%d, err: %v", i, err) } log.Printf("Successfully set deadline #%d", i) <-time.After(150 * time.Millisecond) } } ``` erraneously gives ```shell 2017/11/14 17:46:28 Successfully set deadline #0 2017/11/14 17:46:29 Successfully set deadline #1 2017/11/14 17:46:29 Successfully set deadline #2 2017/11/14 17:46:29 Successfully set deadline #3 2017/11/14 17:46:29 Successfully set deadline #4 ``` However, if we properly fix it to respect that error with ```diff --- wild.go 2017-11-14 17:44:38.000000000 -0700 +++ main.go 2017-11-14 17:45:40.000000000 -0700 @@ -16,7 +16,9 @@ conn.Close() }() for i := 0; i < 5; i++ { - conn.SetDeadline(time.Now().Add(time.Duration(10 * time.Second))) + if err := conn.SetDeadline(time.Now().Add(time.Duration(10 * time.Second))); err != nil { + log.Fatalf("set deadline #%d, err: %v", i, err) + } log.Printf("Successfully set deadline #%d", i) <-time.After(150 * time.Millisecond) } ``` properly catches any problems and gives ```shell $ go run main.go 2017/11/14 17:43:44 Successfully set deadline #0 2017/11/14 17:43:45 Successfully set deadline #1 2017/11/14 17:43:45 Successfully set deadline #2 2017/11/14 17:43:45 set deadline #3, err: set tcp 10.182.253.51:57395: use of closed network connection exit status 1 ```
7 years ago
9 years ago
9 years ago
9 years ago
8 years ago
9 years ago
9 years ago
9 years ago
p2p: peer should respect errors from SetDeadline Noticed while auditing the code that we aren't respecting (*net.Conn) SetDeadline errors which return after a connection has been killed and is simultaneously being used. For example given program, without SetDeadline error checks ```go package main import ( "log" "net" "time" ) func main() { conn, err := net.Dial("tcp", "tendermint.com:443") if err != nil { log.Fatal(err) } go func() { <-time.After(400 * time.Millisecond) conn.Close() }() for i := 0; i < 5; i++ { if err := conn.SetDeadline(time.Now().Add(time.Duration(10 * time.Second))); err != nil { log.Fatalf("set deadline #%d, err: %v", i, err) } log.Printf("Successfully set deadline #%d", i) <-time.After(150 * time.Millisecond) } } ``` erraneously gives ```shell 2017/11/14 17:46:28 Successfully set deadline #0 2017/11/14 17:46:29 Successfully set deadline #1 2017/11/14 17:46:29 Successfully set deadline #2 2017/11/14 17:46:29 Successfully set deadline #3 2017/11/14 17:46:29 Successfully set deadline #4 ``` However, if we properly fix it to respect that error with ```diff --- wild.go 2017-11-14 17:44:38.000000000 -0700 +++ main.go 2017-11-14 17:45:40.000000000 -0700 @@ -16,7 +16,9 @@ conn.Close() }() for i := 0; i < 5; i++ { - conn.SetDeadline(time.Now().Add(time.Duration(10 * time.Second))) + if err := conn.SetDeadline(time.Now().Add(time.Duration(10 * time.Second))); err != nil { + log.Fatalf("set deadline #%d, err: %v", i, err) + } log.Printf("Successfully set deadline #%d", i) <-time.After(150 * time.Millisecond) } ``` properly catches any problems and gives ```shell $ go run main.go 2017/11/14 17:43:44 Successfully set deadline #0 2017/11/14 17:43:45 Successfully set deadline #1 2017/11/14 17:43:45 Successfully set deadline #2 2017/11/14 17:43:45 set deadline #3, err: set tcp 10.182.253.51:57395: use of closed network connection exit status 1 ```
7 years ago
7 years ago
7 years ago
9 years ago
7 years ago
9 years ago
7 years ago
9 years ago
7 years ago
9 years ago
7 years ago
9 years ago
7 years ago
9 years ago
9 years ago
7 years ago
9 years ago
7 years ago
9 years ago
7 years ago
9 years ago
9 years ago
9 years ago
7 years ago
9 years ago
7 years ago
9 years ago
7 years ago
7 years ago
7 years ago
8 years ago
7 years ago
8 years ago
  1. package p2p
  2. import (
  3. "encoding/hex"
  4. "fmt"
  5. "net"
  6. "time"
  7. "github.com/pkg/errors"
  8. crypto "github.com/tendermint/go-crypto"
  9. wire "github.com/tendermint/go-wire"
  10. cmn "github.com/tendermint/tmlibs/common"
  11. "github.com/tendermint/tmlibs/log"
  12. )
  13. // Peer is an interface representing a peer connected on a reactor.
  14. type Peer interface {
  15. cmn.Service
  16. ID() ID
  17. IsOutbound() bool
  18. IsPersistent() bool
  19. NodeInfo() *NodeInfo
  20. Status() ConnectionStatus
  21. Send(byte, interface{}) bool
  22. TrySend(byte, interface{}) bool
  23. Set(string, interface{})
  24. Get(string) interface{}
  25. }
  26. // Peer could be marked as persistent, in which case you can use
  27. // Redial function to reconnect. Note that inbound peers can't be
  28. // made persistent. They should be made persistent on the other end.
  29. //
  30. // Before using a peer, you will need to perform a handshake on connection.
  31. type peer struct {
  32. cmn.BaseService
  33. outbound bool
  34. conn net.Conn // source connection
  35. mconn *MConnection // multiplex connection
  36. persistent bool
  37. config *PeerConfig
  38. nodeInfo *NodeInfo
  39. Data *cmn.CMap // User data.
  40. }
  41. // PeerConfig is a Peer configuration.
  42. type PeerConfig struct {
  43. AuthEnc bool `mapstructure:"auth_enc"` // authenticated encryption
  44. // times are in seconds
  45. HandshakeTimeout time.Duration `mapstructure:"handshake_timeout"`
  46. DialTimeout time.Duration `mapstructure:"dial_timeout"`
  47. MConfig *MConnConfig `mapstructure:"connection"`
  48. Fuzz bool `mapstructure:"fuzz"` // fuzz connection (for testing)
  49. FuzzConfig *FuzzConnConfig `mapstructure:"fuzz_config"`
  50. }
  51. // DefaultPeerConfig returns the default config.
  52. func DefaultPeerConfig() *PeerConfig {
  53. return &PeerConfig{
  54. AuthEnc: true,
  55. HandshakeTimeout: 20, // * time.Second,
  56. DialTimeout: 3, // * time.Second,
  57. MConfig: DefaultMConnConfig(),
  58. Fuzz: false,
  59. FuzzConfig: DefaultFuzzConnConfig(),
  60. }
  61. }
  62. func newOutboundPeer(addr *NetAddress, reactorsByCh map[byte]Reactor, chDescs []*ChannelDescriptor,
  63. onPeerError func(Peer, interface{}), ourNodePrivKey crypto.PrivKey, config *PeerConfig) (*peer, error) {
  64. conn, err := dial(addr, config)
  65. if err != nil {
  66. return nil, errors.Wrap(err, "Error creating peer")
  67. }
  68. peer, err := newPeerFromConnAndConfig(conn, true, reactorsByCh, chDescs, onPeerError, ourNodePrivKey, config)
  69. if err != nil {
  70. if err := conn.Close(); err != nil {
  71. return nil, err
  72. }
  73. return nil, err
  74. }
  75. return peer, nil
  76. }
  77. func newInboundPeer(conn net.Conn, reactorsByCh map[byte]Reactor, chDescs []*ChannelDescriptor,
  78. onPeerError func(Peer, interface{}), ourNodePrivKey crypto.PrivKey, config *PeerConfig) (*peer, error) {
  79. // TODO: issue PoW challenge
  80. return newPeerFromConnAndConfig(conn, false, reactorsByCh, chDescs, onPeerError, ourNodePrivKey, config)
  81. }
  82. func newPeerFromConnAndConfig(rawConn net.Conn, outbound bool, reactorsByCh map[byte]Reactor, chDescs []*ChannelDescriptor,
  83. onPeerError func(Peer, interface{}), ourNodePrivKey crypto.PrivKey, config *PeerConfig) (*peer, error) {
  84. conn := rawConn
  85. // Fuzz connection
  86. if config.Fuzz {
  87. // so we have time to do peer handshakes and get set up
  88. conn = FuzzConnAfterFromConfig(conn, 10*time.Second, config.FuzzConfig)
  89. }
  90. // Encrypt connection
  91. if config.AuthEnc {
  92. if err := conn.SetDeadline(time.Now().Add(config.HandshakeTimeout * time.Second)); err != nil {
  93. return nil, errors.Wrap(err, "Error setting deadline while encrypting connection")
  94. }
  95. var err error
  96. conn, err = MakeSecretConnection(conn, ourNodePrivKey)
  97. if err != nil {
  98. return nil, errors.Wrap(err, "Error creating peer")
  99. }
  100. }
  101. // Key and NodeInfo are set after Handshake
  102. p := &peer{
  103. outbound: outbound,
  104. conn: conn,
  105. config: config,
  106. Data: cmn.NewCMap(),
  107. }
  108. p.mconn = createMConnection(conn, p, reactorsByCh, chDescs, onPeerError, config.MConfig)
  109. p.BaseService = *cmn.NewBaseService(nil, "Peer", p)
  110. return p, nil
  111. }
  112. func (p *peer) SetLogger(l log.Logger) {
  113. p.Logger = l
  114. p.mconn.SetLogger(l)
  115. }
  116. // CloseConn should be used when the peer was created, but never started.
  117. func (p *peer) CloseConn() {
  118. p.conn.Close() // nolint: errcheck
  119. }
  120. // makePersistent marks the peer as persistent.
  121. func (p *peer) makePersistent() {
  122. if !p.outbound {
  123. panic("inbound peers can't be made persistent")
  124. }
  125. p.persistent = true
  126. }
  127. // IsPersistent returns true if the peer is persitent, false otherwise.
  128. func (p *peer) IsPersistent() bool {
  129. return p.persistent
  130. }
  131. // HandshakeTimeout performs a handshake between a given node and the peer.
  132. // NOTE: blocking
  133. func (p *peer) HandshakeTimeout(ourNodeInfo *NodeInfo, timeout time.Duration) error {
  134. // Set deadline for handshake so we don't block forever on conn.ReadFull
  135. if err := p.conn.SetDeadline(time.Now().Add(timeout)); err != nil {
  136. return errors.Wrap(err, "Error setting deadline")
  137. }
  138. var peerNodeInfo = new(NodeInfo)
  139. var err1 error
  140. var err2 error
  141. cmn.Parallel(
  142. func() {
  143. var n int
  144. wire.WriteBinary(ourNodeInfo, p.conn, &n, &err1)
  145. },
  146. func() {
  147. var n int
  148. wire.ReadBinary(peerNodeInfo, p.conn, maxNodeInfoSize, &n, &err2)
  149. p.Logger.Info("Peer handshake", "peerNodeInfo", peerNodeInfo)
  150. })
  151. if err1 != nil {
  152. return errors.Wrap(err1, "Error during handshake/write")
  153. }
  154. if err2 != nil {
  155. return errors.Wrap(err2, "Error during handshake/read")
  156. }
  157. // Remove deadline
  158. if err := p.conn.SetDeadline(time.Time{}); err != nil {
  159. return errors.Wrap(err, "Error removing deadline")
  160. }
  161. // TODO: fix the peerNodeInfo.ListenAddr
  162. p.nodeInfo = peerNodeInfo
  163. return nil
  164. }
  165. // Addr returns peer's remote network address.
  166. func (p *peer) Addr() net.Addr {
  167. return p.conn.RemoteAddr()
  168. }
  169. // PubKey returns peer's public key.
  170. func (p *peer) PubKey() crypto.PubKey {
  171. if p.NodeInfo() != nil {
  172. return p.nodeInfo.PubKey
  173. } else if p.config.AuthEnc {
  174. return p.conn.(*SecretConnection).RemotePubKey()
  175. }
  176. panic("Attempt to get peer's PubKey before calling Handshake")
  177. }
  178. // OnStart implements BaseService.
  179. func (p *peer) OnStart() error {
  180. if err := p.BaseService.OnStart(); err != nil {
  181. return err
  182. }
  183. err := p.mconn.Start()
  184. return err
  185. }
  186. // OnStop implements BaseService.
  187. func (p *peer) OnStop() {
  188. p.BaseService.OnStop()
  189. p.mconn.Stop()
  190. }
  191. // Connection returns underlying MConnection.
  192. func (p *peer) Connection() *MConnection {
  193. return p.mconn
  194. }
  195. // IsOutbound returns true if the connection is outbound, false otherwise.
  196. func (p *peer) IsOutbound() bool {
  197. return p.outbound
  198. }
  199. // Send msg to the channel identified by chID byte. Returns false if the send
  200. // queue is full after timeout, specified by MConnection.
  201. func (p *peer) Send(chID byte, msg interface{}) bool {
  202. if !p.IsRunning() {
  203. // see Switch#Broadcast, where we fetch the list of peers and loop over
  204. // them - while we're looping, one peer may be removed and stopped.
  205. return false
  206. }
  207. return p.mconn.Send(chID, msg)
  208. }
  209. // TrySend msg to the channel identified by chID byte. Immediately returns
  210. // false if the send queue is full.
  211. func (p *peer) TrySend(chID byte, msg interface{}) bool {
  212. if !p.IsRunning() {
  213. return false
  214. }
  215. return p.mconn.TrySend(chID, msg)
  216. }
  217. // CanSend returns true if the send queue is not full, false otherwise.
  218. func (p *peer) CanSend(chID byte) bool {
  219. if !p.IsRunning() {
  220. return false
  221. }
  222. return p.mconn.CanSend(chID)
  223. }
  224. // String representation.
  225. func (p *peer) String() string {
  226. if p.outbound {
  227. return fmt.Sprintf("Peer{%v %v out}", p.mconn, p.ID())
  228. }
  229. return fmt.Sprintf("Peer{%v %v in}", p.mconn, p.ID())
  230. }
  231. // Equals reports whenever 2 peers are actually represent the same node.
  232. func (p *peer) Equals(other Peer) bool {
  233. return p.ID() == other.ID()
  234. }
  235. // Get the data for a given key.
  236. func (p *peer) Get(key string) interface{} {
  237. return p.Data.Get(key)
  238. }
  239. // Set sets the data for the given key.
  240. func (p *peer) Set(key string, data interface{}) {
  241. p.Data.Set(key, data)
  242. }
  243. // ID returns the peer's ID - the hex encoded hash of its pubkey.
  244. func (p *peer) ID() ID {
  245. return ID(hex.EncodeToString(p.PubKey().Address()))
  246. }
  247. // NodeInfo returns a copy of the peer's NodeInfo.
  248. func (p *peer) NodeInfo() *NodeInfo {
  249. if p.nodeInfo == nil {
  250. return nil
  251. }
  252. n := *p.nodeInfo // copy
  253. return &n
  254. }
  255. // Status returns the peer's ConnectionStatus.
  256. func (p *peer) Status() ConnectionStatus {
  257. return p.mconn.Status()
  258. }
  259. func dial(addr *NetAddress, config *PeerConfig) (net.Conn, error) {
  260. conn, err := addr.DialTimeout(config.DialTimeout * time.Second)
  261. if err != nil {
  262. return nil, err
  263. }
  264. return conn, nil
  265. }
  266. func createMConnection(conn net.Conn, p *peer, reactorsByCh map[byte]Reactor, chDescs []*ChannelDescriptor,
  267. onPeerError func(Peer, interface{}), config *MConnConfig) *MConnection {
  268. onReceive := func(chID byte, msgBytes []byte) {
  269. reactor := reactorsByCh[chID]
  270. if reactor == nil {
  271. cmn.PanicSanity(cmn.Fmt("Unknown channel %X", chID))
  272. }
  273. reactor.Receive(chID, p, msgBytes)
  274. }
  275. onError := func(r interface{}) {
  276. onPeerError(p, r)
  277. }
  278. return NewMConnectionWithConfig(conn, chDescs, onReceive, onError, config)
  279. }