Yen Chi Hsuan
8e2915d70b
Revert "[postprocessor/embedthumbnail] Allow mkv to embed thumbnails"
This reverts commit 7360db05b4
.
This commit was added as an attempt to fix #6046 . Unfortunately, the fix
is completely wrong. As reported on #10359 , embedded thumbnails are not
displayed in VLC, and Se7en on IRC reports that the embedded thumbnail
misleads mpv as well.
The correct way is using -attachment of ffmpeg, while the current
run_ffmpeg_multiple_files API can't handle it cleanly.
8 years ago
Sergey M․
0b94dbb115
[postprocessor/ffmpeg] PEP 8
8 years ago
Pierre Mdawar
2273e2c530
[postprocessor/ffmpeg] Return correct filepath and ext in updated information in FFmpegExtractAudioPP
Return correct audio's filepath and ext instead of the video's when extracting audio and audio file already exists.
8 years ago
Déstin Reed
dcdb292fdd
Unify coding cookie
8 years ago
Yen Chi Hsuan
efa97bdcf1
Move write_xattr to utils.py
There are some other places that use xattr functions. It's better to
move it to a common place so that others can use it.
8 years ago
Remita Amine
30d9e20938
[postprocessor/ffmpeg] apply FFmpegFixupM3u8PP only for videos with aac codec( #5591 )
8 years ago
Sergey M․
25dd58ca6a
[metadatafromtitle] Remove unused exception class
8 years ago
nyorain
5e42f8a0ad
Make --metadata-from-title non fatal
Output a warning if the metadata can't be parsed from the title (and don't write any metadata) instead of raising a critical error.
9 years ago
Yen Chi Hsuan
23495d6a39
Revert "[ffmpeg] Fix embedding subtitles ( #9063 )"
This reverts commit ccff2c404d
.
Fixes #10081 .
The new approach breaks embedding subtitles into video-only or
audio-only files. FFMpeg provides a trick: add '?' after the argument of
'-map' so that a missing stream is ignored. For example:
opts = [
'-map', '0:v?',
'-c:v', 'copy',
'-map', '0:a?',
'-c:a', 'copy',
# other options...
]
Unfortunately, such a format is not implemented in avconv, either.
I guess adding '-ignore_unknown' if self.basename == 'ffmpeg' is the
best solution. However, the example mentioned in #9063 no longer serves
problematic files, so I can't test it. I'll reopen #9063 and wait for
another example so that I can test '-ignore_unknown'.
9 years ago
Yen Chi Hsuan
702ccf2dc0
[compat] Rename shlex_quote and remove unused subprocess_check_output
9 years ago
Sergey M․
4bd143a3a0
[postprocessor/ffmpeg] Simplify metadata preparation and add track related metafields ( Closes #9357 )
9 years ago
Wang Jun Tham
ccff2c404d
[ffmpeg] Fix embedding subtitles ( #9063 )
Changed command line parameters for ffmpeg when embedding subtitles.
Changed to ‘-map 0:v -c:v copy -map 0:a -c:a copy’
9 years ago
remitamine
b9f2fdd37f
[ffmpeg] Clarify rationale for pipe(-) exclusion in _ffmpeg_filename_argument
9 years ago
remitamine
d868f43c58
[ffmpeg] check for - file name in _ffmpeg_filename_argument
9 years ago
remitamine
0750b2491f
[ffmpeg] try to convert tt subtitles usng dfxp2srt
9 years ago
Sergey M․
40025ee2a3
[postprocessort/ffmpeg] Allow embedding webvtt into webm ( Closes #8874 )
9 years ago
remitamine
a755f82549
[ffmpeg] convert format ext to ffmpeg output formats codes
9 years ago
Yen Chi Hsuan
e9c0cdd389
[jython] Introduce compat_os_name
os.name is always 'java' on Jython
9 years ago
remitamine
f17f86513e
Add fixup for media files produced by HlsNative downloader( fixes #4776 )
9 years ago
Yen Chi Hsuan
7360db05b4
[postprocessor/embedthumbnail] Allow mkv to embed thumbnails
Fixes #6046
9 years ago
Sergey M․
611c1dd96e
[refactor] Single quotes consistency
9 years ago
Jaime Marquínez Ferrándiz
d4f8e83404
[FFmpegSubtitlesConvertorPP] remove unused variable
9 years ago
Jaime Marquínez Ferrándiz
7b8b007cd9
[FFmpegSubtitlesConvertorPP] remove intermediate srt files
9 years ago
Jaime Marquínez Ferrándiz
3547d26587
[FFmpegSubtitlesConvertorPP] correctly update the extension ( fixes #8444 )
9 years ago
Jaime Marquínez Ferrándiz
7e62c2eb6d
[FFmpegSubtitlesConvertorPP] fix not working when srt is used as the intermediate format between ttml/dfxp and other format
It was trying to use the ttml/dfxp file with ffmpeg, which doesn't have support for them.
I broke it in e04398e397
.
9 years ago
remitamine
7d3a035ee0
[ffmpeg] check for m3u8 protocol in FFmpegMetadataPP
9 years ago
remitamine
593e0f43b4
[ffmpeg] fix condition( fixes #8440 )
9 years ago
remitamine
6fba62c87a
[ffmpeg] fix adding metadata when using --hls-prefer-native( #8350 )
9 years ago
Jaime Marquínez Ferrándiz
e04398e397
[FFmpegSubtitlesConvertorPP] delete old subtitle files ( fixes #8382 )
9 years ago
remitamine
cf57433bbd
[ffmpeg] fix adding metadata when using m3u8_native( fixes #8350 )
9 years ago
Juan M Martínez
374c761e77
[FFmpegPostProcessor] Default of prefer ffmpeg
When no `downloader` is passed to `FFmpegPostProcessor`
an exception was raised trying to get the prefer ffmpeg param.
AttributeError: 'NoneType' object has no attribute 'params'
This fixes and defaults to `False`.
9 years ago
Sergey M․
deb85c32bb
[postprocessor/ffmpeg] Use ffmpeg as prefix since it's used all over the places ( Closes #7371 )
9 years ago
Jaime Marquínez Ferrándiz
8a7bbd1606
[postprocessor/ffmpeg] Always use the 'file:' protocol for filenames ( fixes #6874 )
If the filename contains ':' it is interpreted as a protocol.
It also handles filenames starting with '-'.
9 years ago
Jaime Marquínez Ferrándiz
3026164b16
[postprocessor/common] Use 'self._downloader.params' instead of 'self.params'
'self.params' is not defined
9 years ago
Sergey M․
6270239a6d
[postprocessor/common] Use generalized cli option converters
9 years ago
Jaime Marquínez Ferrándiz
9750e7d70e
[postprocessor/ffmpeg] Don't use '[youtube] ...' in messages
Because it can be used for other extractors.
10 years ago
Sergey M․
15006fedb9
[postprocessor/ffmpeg] Spread postprocessor args usage on all ffmpeg extractors
10 years ago
Sergey M․
e35b23f54d
[postprocessor/common] Improve postprocessor args fetching and clarify doc
10 years ago
Sergey M․
f72b0a6032
Revert xvid to avi and make docs to be similar to existing external downloader option
10 years ago
Aurélio A. Heckert
aa5d9a79d6
Simplify `postprocessor_args` transmission to PP base class
* Remove `extra_cmd_args` transmission from sub to super class.
* Simplify params transmission through `downloader.params`.
10 years ago
Aurélio A. Heckert
1866432db7
Rename --pp-params to --postprocessor-args and access value as super class attribute
10 years ago
Yen Chi Hsuan
396726244a
[utils/ffmpeg] Move ISO 639 related codes to utils
10 years ago
Yen Chi Hsuan
c33a8639a7
[postprocessor/embedthumbnail] Skipping if thumbnail file missing
Fixes #5996
10 years ago
Aurélio A. Heckert
14835de9fb
Use shlex.split for --pp-params and update related docs.
10 years ago
Aurélio A. Heckert
d84f1d14b5
Adds support for XviD output with extra parametrization
As the "LG Time Machine" (a (not so) smart TV) has a limitation for video dimensions (as for codecs), I take to implement an extra parameter `--pp-params` where we can send extra parameterization for the video converter (post-processor).
Example:
```
$ youtube-dl --recode-video=xvid --pp-params='-s 720x480' -c https://www.youtube.com/watch?v=BE7Qoe2ZiXE
```
That works fine on a 4yo LG Time Machine.
Closes #5733
10 years ago
pulpe
d6aa68ce75
[postprocessor/embedthumbnail] embed mp4 too ( fixes #5840 )
10 years ago
Yen Chi Hsuan
c827d4cfdb
[xattr] Enhanced error messages on Windows
10 years ago
Yen Chi Hsuan
fbff30d2db
[xattr] Catch 'Argument list too long'
10 years ago
Yen Chi Hsuan
86c7fdb17c
[xattr] Enhance error handling to catch ENOSPC
Fixes #5589
10 years ago
Yen Chi Hsuan
2cc6d13547
[postprocessor/embedthumbnail] Encode arguments in calling AtomicParsley
10 years ago