Browse Source

[utils] Recognize more patterns in strip_jsonp()

Used in Youku Show pages
master-ytdl-org
Yen Chi Hsuan 8 years ago
parent
commit
5552c9eb0f
No known key found for this signature in database GPG Key ID: 7F902A182457CA23
3 changed files with 15 additions and 1 deletions
  1. +1
    -0
      ChangeLog
  2. +8
    -0
      test/test_utils.py
  3. +6
    -1
      youtube_dl/utils.py

+ 1
- 0
ChangeLog View File

@ -1,6 +1,7 @@
version <unreleased>
Core
+ [utils] strip_jsonp() can recognize more patterns
* [postprocessor/ffmpeg] Fix metadata filename handling on Python 2 (#13182)
Extractors


+ 8
- 0
test/test_utils.py View File

@ -678,6 +678,14 @@ class TestUtil(unittest.TestCase):
d = json.loads(stripped)
self.assertEqual(d, {'status': 'success'})
stripped = strip_jsonp('window.cb && window.cb({"status": "success"});')
d = json.loads(stripped)
self.assertEqual(d, {'status': 'success'})
stripped = strip_jsonp('window.cb && cb({"status": "success"});')
d = json.loads(stripped)
self.assertEqual(d, {'status': 'success'})
def test_uppercase_escape(self):
self.assertEqual(uppercase_escape(''), '')
self.assertEqual(uppercase_escape('\\U0001d550'), '𝕐')


+ 6
- 1
youtube_dl/utils.py View File

@ -2211,7 +2211,12 @@ def parse_age_limit(s):
def strip_jsonp(code):
return re.sub(
r'(?s)^[a-zA-Z0-9_.$]+\s*\(\s*(.*)\);?\s*?(?://[^\n]*)*$', r'\1', code)
r'''(?sx)^
(?:window\.)?(?P<func_name>[a-zA-Z0-9_.$]+)
(?:\s*&&\s*(?P=func_name))?
\s*\(\s*(?P<callback_data>.*)\);?
\s*?(?://[^\n]*)*$''',
r'\g<callback_data>', code)
def js_to_json(code):


Loading…
Cancel
Save