Browse Source

[soundcloud] Do not match sets (Fixes #1930)

totalwebcasting
Philipp Hagemeister 11 years ago
parent
commit
4ff50ef846
2 changed files with 5 additions and 1 deletions
  1. +3
    -0
      test/test_all_urls.py
  2. +2
    -1
      youtube_dl/extractor/soundcloud.py

+ 3
- 0
test/test_all_urls.py View File

@ -110,6 +110,9 @@ class TestAllURLsMatching(unittest.TestCase):
self.assertMatch('http://vimeo.com/channels/tributes', ['vimeo:channel'])
self.assertMatch('http://vimeo.com/user7108434', ['vimeo:user'])
# https://github.com/rg3/youtube-dl/issues/1930
def test_soundcloud_not_matching_sets(self):
self.assertMatch('http://soundcloud.com/floex/sets/gone-ep', ['soundcloud:set'])
if __name__ == '__main__':
unittest.main()

+ 2
- 1
youtube_dl/extractor/soundcloud.py View File

@ -25,7 +25,8 @@ class SoundcloudIE(InfoExtractor):
_VALID_URL = r'''^(?:https?://)?
(?:(?:(?:www\.)?soundcloud\.com/
(?P<uploader>[\w\d-]+)/(?P<title>[\w\d-]+)/?
(?P<uploader>[\w\d-]+)/
(?!sets/)(?P<title>[\w\d-]+)/?
(?P<token>[^?]+?)?(?:[?].*)?$)
|(?:api\.soundcloud\.com/tracks/(?P<track_id>\d+))
|(?P<widget>w\.soundcloud\.com/player/?.*?url=.*)


Loading…
Cancel
Save