zolfa/tendermint - tendermint - Gitea: Git with a cup of tea

bft blockchain consensus consistency cryptocurrency cryptography db distributed-systems go

History

Erik Grinaker fe5b312337 p2p: resolve PEX addresses in PEX reactor (#5980 ) This changes the new prototype PEX reactor to resolve peer address URLs into IP/port PEX addresses itself. Branched off of #5974. I've spent some time thinking about address handling in the P2P stack. We currently use `PeerAddress` URLs everywhere, except for two places: when dialing a peer, and when exchanging addresses via PEX. We had two options: 1. Resolve addresses to endpoints inside `PeerManager`. This would introduce a lot of added complexity: we would have to track connection statistics per endpoint, have goroutines that asynchronously resolve and refresh these endpoints, deal with resolve scheduling before dialing (which is trickier than it sounds since it involves multiple goroutines in the peer manager and router and messes with peer rating order), handle IP address visibility issues, and so on. 2. Resolve addresses to endpoints (IP/port) only where they're used: when dialing, and in PEX. Everywhere else we use URLs. I went with 2, because this significantly simplifies the handling of hostname resolution, and because I really think the PEX reactor should migrate to exchanging URLs instead of IP/port numbers anyway -- this allows operators to use DNS names for validators (and can easily migrate them to new IPs and/or load balance requests), and also allows different protocols (e.g. QUIC and `MemoryTransport`). Happy to discuss this.		4 years ago
..
addrbook.go	p2p: rename ID to NodeID	4 years ago
addrbook_test.go	p2p: rename ID to NodeID	4 years ago
errors.go	p2p: ensure peers can't change IP of known nodes (#5136)	4 years ago
file.go	linter: (1/2) enable errcheck (#5064)	4 years ago
known_address.go	p2p: rename ID to NodeID	4 years ago
params.go	fix build and test	7 years ago
pex_reactor.go	proto/p2p: rename PEX messages and fields (#5974)	4 years ago
pex_reactor_test.go	proto/p2p: rename PEX messages and fields (#5974)	4 years ago
reactor.go	p2p: resolve PEX addresses in PEX reactor (#5980)	4 years ago