zolfa/tendermint - tendermint - Gitea: Git with a cup of tea

bft blockchain consensus consistency cryptocurrency cryptography db distributed-systems go

History

William Banfield 0b8a62c87b abci: Synchronize FinalizeBlock with the updated specification (#7983 ) This change set implements the most recent version of `FinalizeBlock`. # What does this change actually contain? * This change set is rather large but fear not! The majority of the files touched and changes are renaming `ResponseDeliverTx` to `ExecTxResult`. This should be a pretty inoffensive change since they're effectively the same type but with a different name. * The `execBlockOnProxyApp` was totally removed since it served as just a wrapper around the logic that is now mostly encapsulated within `FinalizeBlock` * The `updateState` helper function has been made a public method on `State`. It was being exposed as a shim through the testing infrastructure, so this seemed innocuous. * Tests already existed to ensure that the application received the `ByzantineValidators` and the `ValidatorUpdates`, but one was fixed up to ensure that `LastCommitInfo` was being sent across. * Tests were removed from the `psql` indexer that seemed to search for an event in the indexer that was not being created. # Questions for reviewers * We store this [ABCIResponses](`5721a13ab1/proto/tendermint/state/types.pb.go (L37))` type in the data base as the block results. This type has changed since v0.35 to contain the `FinalizeBlock` response. I'm wondering if we need to do any shimming to keep the old data retrieveable? * Similarly, this change is exposed via the RPC through [ResultBlockResults](`5721a13ab1/rpc/coretypes/responses.go (L69))` changing. Should we somehow shim or notify for this change? closes: #7658		3 years ago
..
kv	abci: Synchronize FinalizeBlock with the updated specification (#7983)	3 years ago
null	Completed the existing `FinalizeBlock` PR and rebased to master (#7798)	3 years ago
psql	abci: Synchronize FinalizeBlock with the updated specification (#7983)	3 years ago
sink.go	Remove now-unused nolint:lll directives. (#7356)	3 years ago