zolfa/tendermint - tendermint - Gitea: Git with a cup of tea

bft blockchain consensus consistency cryptocurrency cryptography db distributed-systems go

History

Juan Leni 853dd34d31 privval: improve Remote Signer implementation (#3351 ) This issue is related to #3107 This is a first renaming/refactoring step before reworking and removing heartbeats. As discussed with @Liamsi , we preferred to go for a couple of independent and separate PRs to simplify review work. The changes: Help to clarify the relation between the validator and remote signer endpoints Differentiate between timeouts and deadlines Prepare to encapsulate networking related code behind RemoteSigner in the next PR My intention is to separate and encapsulate the "network related" code from the actual signer. SignerRemote ---(uses/contains)--> SignerValidatorEndpoint <--(connects to)--> SignerServiceEndpoint ---> SignerService (future.. not here yet but would like to decouple too) All reconnection/heartbeat/whatever code goes in the endpoints. Signer[Remote/Service] do not need to know about that. I agree Endpoint may not be the perfect name. I tried to find something "Go-ish" enough. It is a common name in go-kit, kubernetes, etc. Right now: SignerValidatorEndpoint: handles the listener contains SignerRemote Implements the PrivValidator interface connects and sets a connection object in a contained SignerRemote delegates PrivValidator some calls to SignerRemote which in turn uses the conn object that was set externally SignerRemote: Implements the PrivValidator interface read/writes from a connection object directly handles heartbeats SignerServiceEndpoint: Does most things in a single place delegates to a PrivValidator IIRC. * cleanup * Refactoring step 1 * Refactoring step 2 * move messages to another file * mark for future work / next steps * mark deprecated classes in docs * Fix linter problems * additional linter fixes		6 years ago
..
doc.go	privval: improve Remote Signer implementation (#3351)	6 years ago
errors.go	privval: improve Remote Signer implementation (#3351)	6 years ago
file.go	privval: improve Remote Signer implementation (#3351)	6 years ago
file_deprecated.go	privval: improve Remote Signer implementation (#3351)	6 years ago
file_deprecated_test.go	privval: improve Remote Signer implementation (#3351)	6 years ago
file_test.go	Close and retry a RemoteSigner on err (#2923)	6 years ago
messages.go	privval: improve Remote Signer implementation (#3351)	6 years ago
signer_remote.go	privval: improve Remote Signer implementation (#3351)	6 years ago
signer_remote_test.go	privval: improve Remote Signer implementation (#3351)	6 years ago
signer_service_endpoint.go	privval: improve Remote Signer implementation (#3351)	6 years ago
signer_validator_endpoint.go	privval: improve Remote Signer implementation (#3351)	6 years ago
signer_validator_endpoint_test.go	privval: improve Remote Signer implementation (#3351)	6 years ago
socket_dialers.go	privval: improve Remote Signer implementation (#3351)	6 years ago
socket_dialers_test.go	privval: improve Remote Signer implementation (#3351)	6 years ago
socket_listeners.go	privval: improve Remote Signer implementation (#3351)	6 years ago
socket_listeners_test.go	privval: improve Remote Signer implementation (#3351)	6 years ago
utils.go	privval: improve Remote Signer implementation (#3351)	6 years ago
utils_test.go	privval: improve Remote Signer implementation (#3351)	6 years ago
wire.go	alias amino imports (#3219)	6 years ago