zolfa/tendermint - tendermint - Gitea: Git with a cup of tea

bft blockchain consensus consistency cryptocurrency cryptography db distributed-systems go

History

M. J. Fromberger ce61abc038 rpc: remove the placeholder RunState type. (#7749 ) * rpc/client: remove the placeholder RunState type. I added the RunState type in #6971 to disconnect clients from the service plumbing, which they do not need. Now that we have more complete context plumbing, the lifecycle of a client no longer depends on this type: It serves as a carrier for a logger, and a Boolean flag for "running" status, neither of which is used outside of tests. Logging in particular is defaulted to a no-op logger in all production use. Arguably we could just remove the logging calls, since they are never invoked except in tests. To defer the question of whether we should do that or make the logging go somewhere more productive, I've preserved the existing use here. Remove use of the IsRunning method that was provided by the RunState, and use the Start method and context to govern client lifecycle. Remove the one test that exercised "unstarted" clients. I would like to remove that method entirely, but that will require updating the constructors for all the client types to plumb a context and possibly other options. I have deferred that for now.		2 years ago
..
client	rpc: remove the placeholder RunState type. (#7749)	2 years ago
coretypes	rpc: add application info to `status` call (#7701)	2 years ago
jsonrpc	rpc: remove the placeholder RunState type. (#7749)	2 years ago
openapi	rpc: paginate mempool /unconfirmed_txs endpoint (#7612)	2 years ago
test	rpc: simplify the JSON-RPC client Caller interface (#7549)	2 years ago