zolfa/tendermint - tendermint - Gitea: Git with a cup of tea

bft blockchain consensus consistency cryptocurrency cryptography db distributed-systems go

History

Anton Kaliaev 27909e5d2a mempool: remove only valid (Code==0) txs on Update (#3625 ) * mempool: remove only valid (Code==0) txs on Update so evil proposers can't drop valid txs in Commit stage. Also remove invalid (Code!=0) txs from the cache so they can be resubmitted. Fixes #3322 @rickyyangz: In the end of commit stage, we will update mempool to remove all the txs in current block. // Update mempool. err = blockExec.mempool.Update( block.Height, block.Txs, TxPreCheck(state), TxPostCheck(state), ) Assum an account has 3 transactions in the mempool, the sequences are 100, 101 and 102 separately, So an evil proposal can only package the 101 and 102 transactions into its proposal block, and leave 100 still in mempool, then the two txs will be removed from all validators' mempool when commit. So the account lost the two valid txs. @ebuchman: In the longer term we may want to do something like #2639 so we can validate txs before we commit the block. But even in this case we'd only want to run the equivalent of CheckTx, which means the DeliverTx could still fail even if the CheckTx passes depending on how the app handles the ABCI Code semantics. So more work will be required around the ABCI code. See also #2185 * add changelog entry and tests * improve changelog message * reformat code		6 years ago
..
bench_test.go	mempool no gossip back (#2778)	6 years ago
cache_test.go	mempool: remove only valid (Code==0) txs on Update (#3625)	6 years ago
clist_mempool.go	mempool: remove only valid (Code==0) txs on Update (#3625)	6 years ago
clist_mempool_test.go	mempool: remove only valid (Code==0) txs on Update (#3625)	6 years ago
doc.go	mempool: move interface into mempool package (#3524)	6 years ago
errors.go	mempool: move interface into mempool package (#3524)	6 years ago
mempool.go	mempool: remove only valid (Code==0) txs on Update (#3625)	6 years ago
metrics.go	add "chain_id" label for all metrics (#3123)	6 years ago
reactor.go	mempool: move interface into mempool package (#3524)	6 years ago
reactor_test.go	mempool: move interface into mempool package (#3524)	6 years ago
wire.go	alias amino imports (#3219)	6 years ago