tendermint

bft blockchain consensus consistency cryptocurrency cryptography db distributed-systems go

History

M. J. Fromberger 1f5e64e5b6 rpc: remove cache control settings from the HTTP server (#7568 ) We should not set cache-control headers on RPC responses. HTTP caching interacts poorly with resources that are expected to change frequently, or whose rate of change is unpredictable. More subtly, all calls to the POST endpoint use the same URL, which means a cacheable response from one call may actually "hide" an uncacheable response from a subsequent one. This is less of a problem for the GET endpoints, but that means the behaviour of RPCs varies depending on which HTTP method your client happens to use. Websocket requests were already marked statically uncacheable, adding yet a third combination. To address this: - Stop setting cache-control headers. - Update the tests that were checking for those headers. - Remove the flags to request cache-control. Apart from affecting the HTTP response headers, this change does not modify the behaviour of any of the RPC methods.	3 years ago
..
proxy.go	Move the libs/pubsub package to internal scope (#7451)	3 years ago
routes.go	rpc: remove cache control settings from the HTTP server (#7568)	3 years ago

rpc: remove cache control settings from the HTTP server (#7568 )

We should not set cache-control headers on RPC responses. HTTP caching
interacts poorly with resources that are expected to change frequently, or
whose rate of change is unpredictable.

More subtly, all calls to the POST endpoint use the same URL, which means a
cacheable response from one call may actually "hide" an uncacheable response
from a subsequent one. This is less of a problem for the GET endpoints, but
that means the behaviour of RPCs varies depending on which HTTP method your
client happens to use. Websocket requests were already marked statically
uncacheable, adding yet a third combination.

To address this:

- Stop setting cache-control headers.
- Update the tests that were checking for those headers.
- Remove the flags to request cache-control.

Apart from affecting the HTTP response headers, this change does not modify the
behaviour of any of the RPC methods.

3 years ago

proxy.go

Move the libs/pubsub package to internal scope (#7451)

3 years ago

routes.go

rpc: remove cache control settings from the HTTP server (#7568)

3 years ago