bft blockchain consensus consistency cryptocurrency cryptography db distributed-systems go

History

Anton Kaliaev d741c7b478 limit number of /subscribe clients and queries per client (#3269 ) * limit number of /subscribe clients and queries per client Add the following config variables (under [rpc] section): * max_subscription_clients * max_subscriptions_per_client * timeout_broadcast_tx_commit Fixes #2826 new HTTPClient interface for subscriptions finalize HTTPClient events interface remove EventSubscriber fix data race ``` WARNING: DATA RACE Read at 0x00c000a36060 by goroutine 129: github.com/tendermint/tendermint/rpc/client.(Local).Subscribe.func1() /go/src/github.com/tendermint/tendermint/rpc/client/localclient.go:168 +0x1f0 Previous write at 0x00c000a36060 by goroutine 132: github.com/tendermint/tendermint/rpc/client.(Local).Subscribe() /go/src/github.com/tendermint/tendermint/rpc/client/localclient.go:191 +0x4e0 github.com/tendermint/tendermint/rpc/client.WaitForOneEvent() /go/src/github.com/tendermint/tendermint/rpc/client/helpers.go:64 +0x178 github.com/tendermint/tendermint/rpc/client_test.TestTxEventsSentWithBroadcastTxSync.func1() /go/src/github.com/tendermint/tendermint/rpc/client/event_test.go:139 +0x298 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 Goroutine 129 (running) created at: github.com/tendermint/tendermint/rpc/client.(Local).Subscribe() /go/src/github.com/tendermint/tendermint/rpc/client/localclient.go:164 +0x4b7 github.com/tendermint/tendermint/rpc/client.WaitForOneEvent() /go/src/github.com/tendermint/tendermint/rpc/client/helpers.go:64 +0x178 github.com/tendermint/tendermint/rpc/client_test.TestTxEventsSentWithBroadcastTxSync.func1() /go/src/github.com/tendermint/tendermint/rpc/client/event_test.go:139 +0x298 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 Goroutine 132 (running) created at: testing.(T).Run() /usr/local/go/src/testing/testing.go:878 +0x659 github.com/tendermint/tendermint/rpc/client_test.TestTxEventsSentWithBroadcastTxSync() /go/src/github.com/tendermint/tendermint/rpc/client/event_test.go:119 +0x186 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 ================== ``` lite client works (tested manually) godoc comments httpclient: do not close the out channel use TimeoutBroadcastTxCommit no timeout for unsubscribe but 1s Local (5s HTTP) timeout for resubscribe format code change Subscribe#out cap to 1 and replace config vars with RPCConfig TimeoutBroadcastTxCommit can't be greater than rpcserver.WriteTimeout rpc: Context as first parameter to all functions reformat code fixes after my own review fixes after Ethan's review add test stubs fix config.toml * fixes after manual testing - rpc: do not recommend to use BroadcastTxCommit because it's slow and wastes Tendermint resources (pubsub) - rpc: better error in Subscribe and BroadcastTxCommit - HTTPClient: do not resubscribe if err = ErrAlreadySubscribed * fixes after Ismail's review * Update rpc/grpc/grpc_test.go Co-Authored-By: melekes <anton.kalyaev@gmail.com>		6 years ago
..
types	bound mempool memory usage (#3248)	6 years ago
README.md	rpc: Improve slate for Jenkins (#2070)	6 years ago
abci.go	limit number of /subscribe clients and queries per client (#3269)	6 years ago
blocks.go	limit number of /subscribe clients and queries per client (#3269)	6 years ago
blocks_test.go	rpc: fix /blockchain OOM #2049	6 years ago
consensus.go	limit number of /subscribe clients and queries per client (#3269)	6 years ago
dev.go	limit number of /subscribe clients and queries per client (#3269)	6 years ago
doc.go	2582 Enable CORS on RPC API (#2800)	6 years ago
doc_template.txt	generate md for Slate	7 years ago
events.go	limit number of /subscribe clients and queries per client (#3269)	6 years ago
health.go	limit number of /subscribe clients and queries per client (#3269)	6 years ago
mempool.go	limit number of /subscribe clients and queries per client (#3269)	6 years ago
net.go	limit number of /subscribe clients and queries per client (#3269)	6 years ago
pipe.go	limit number of /subscribe clients and queries per client (#3269)	6 years ago
pipe_test.go	return maxPerPage (not defaultPerPage) if per_page is greater than max (#3124)	6 years ago
routes.go	[rpc] fix /abci_query: trusted was renamed to prove (#2531)	6 years ago
slate_header.txt	rpc: Improve slate for Jenkins (#2070)	6 years ago
status.go	limit number of /subscribe clients and queries per client (#3269)	6 years ago
tx.go	limit number of /subscribe clients and queries per client (#3269)	6 years ago

README.md

Tendermint RPC

We are using Slate to power our RPC documentation. For generating markdown use:

go get github.com/davecheney/godoc2md

# from root of this repo
make rpc-docs

Pagination

Requests that return multiple items will be paginated to 30 items by default. You can specify further pages with the ?page parameter. You can also set a custom page size up to 100 with the ?per_page parameter.