tendermint

bft blockchain consensus consistency cryptocurrency cryptography db distributed-systems go

History

Marko 6ab2a19088 header: check block protocol (#5340 ) ## Description Check block protocol version in header validate basic. I tried searching for where we check the P2P protocol version but was unable to find it. When we check compatibility with a node we check we both have the same block protocol and are on the same network, but we do not check if we are on the same P2P protocol. It makes sense if there is a handshake change because we would not be able to establish a secure connection, but a p2p protocol version bump may be because of a p2p message change, which would go unnoticed until that message is sent over the wire. Is this purposeful? Closes: #4790	4 years ago
..
store.go	libs: wrap mutexes for build flag with godeadlock (#5126)	4 years ago
store_test.go	header: check block protocol (#5340)	4 years ago

Marko 6ab2a19088

## Description

Check block protocol version in header validate basic. 

I tried searching for where we check the P2P protocol version but was unable to find it. When we check compatibility with a node we check we both have the same block protocol and are on the same network, but we do not check if we are on the same P2P protocol. It makes sense if there is a handshake change because we would not be able to establish a secure connection, but a p2p protocol version bump may be because of a p2p message change, which would go unnoticed until that message is sent over the wire.  Is this purposeful?

Closes: #4790

4 years ago

store.go

libs: wrap mutexes for build flag with godeadlock (#5126)

4 years ago

store_test.go

header: check block protocol (#5340)

4 years ago