tendermint

bft blockchain consensus consistency cryptocurrency cryptography db distributed-systems go

History

Sam Kleinman d7606777cf libs/service: pass logger explicitly (#7288 ) This is a very small change, but removes a method from the `service.Service` interface (a win!) and forces callers to explicitly pass loggers in to objects during construction rather than (later) injecting them. There's not a real need for this kind of lazy construction of loggers, and I think a decent potential for confusion for mutable loggers. The main concern I have is that this changes the constructor API for ABCI clients. I think this is fine, and I suspect that as we plumb contexts through, and make changes to the RPC services there'll be a number of similar sorts of changes to various (quasi) public interfaces, which I think we should welcome.	3 years ago
..
event_bus.go	libs/service: pass logger explicitly (#7288)	3 years ago
event_bus_test.go	libs/service: pass logger explicitly (#7288)	3 years ago

libs/service: pass logger explicitly (#7288 )

This is a very small change, but removes a method from the
`service.Service` interface (a win!) and forces callers to explicitly
pass loggers in to objects during construction rather than (later)
injecting them. There's not a real need for this kind of lazy
construction of loggers, and I think a decent potential for confusion
for mutable loggers.

The main concern I have is that this changes the constructor API for
ABCI clients. I think this is fine, and I suspect that as we plumb
contexts through, and make changes to the RPC services there'll be a
number of similar sorts of changes to various (quasi) public
interfaces, which I think we should welcome.

3 years ago

event_bus.go

libs/service: pass logger explicitly (#7288)

3 years ago

event_bus_test.go

libs/service: pass logger explicitly (#7288)

3 years ago