zolfa/tendermint - tendermint - Gitea: Git with a cup of tea

bft blockchain consensus consistency cryptocurrency cryptography db distributed-systems go

History

Anton Kaliaev 44a3fbf109 rpc/lib/client & server: try to conform to JSON-RPC 2.0 spec (#4141 ) https://www.jsonrpc.org/specification What is done in this PR: JSONRPCClient: validate that Response.ID matches Request.ID I wanted to do the same for the WSClient, but since we're sending events as responses, not notifications, checking IDs would require storing them in memory indefinitely (and we won't be able to remove them upon client unsubscribing because ID is different then). Request.ID is now optional. Notification is a Request without an ID. Previously "" or 0 were considered as notifications Remove #event suffix from ID from an event response (partially fixes #2949) ID must be either string, int or null AND must be equal to request's ID. Now, because we've implemented events as responses, WS clients are tripping when they see Response.ID("0#event") != Request.ID("0"). Implementing events as requests would require a lot of time (~ 2 days to completely rewrite WS client and server) generate unique ID for each request switch to integer IDs instead of "json-client-XYZ" id=0 method=/subscribe id=0 result=... id=1 method=/abci_query id=1 result=... > send events (resulting from /subscribe) as requests+notifications (not responses) this will require a lot of work. probably not worth it * rpc: generate an unique ID for each request in conformance with JSON-RPC spec * WSClient: check for unsolicited responses * fix golangci warnings * save commit * fix errors * remove ID from responses from subscribe Refs #2949 * clients are safe for concurrent access * tm-bench: switch to int ID * fixes after my own review * comment out sentIDs in WSClient see commit body for the reason * remove body.Close it will be closed automatically * stop ws connection outside of write/read routines also, use t.Rate in tm-bench indexer when calculating ID fix gocritic issues * update swagger.yaml * Apply suggestions from code review * fix stylecheck and golint linter warnings * update changelog * update changelog2		5 years ago
..
http_json_handler.go	rpc/lib/client & server: try to conform to JSON-RPC 2.0 spec (#4141)	5 years ago
http_json_handler_test.go	rpc/lib/client & server: try to conform to JSON-RPC 2.0 spec (#4141)	5 years ago
http_params.go	rpc: add support for batched requests/responses (#3534)	6 years ago
http_server.go	rpc/lib/client & server: try to conform to JSON-RPC 2.0 spec (#4141)	5 years ago
http_server_test.go	rpc/lib: write a test for TLS server (#3703)	5 years ago
http_uri_handler.go	rpc/lib/client & server: try to conform to JSON-RPC 2.0 spec (#4141)	5 years ago
parse_test.go	limit number of /subscribe clients and queries per client (#3269)	6 years ago
rpc_func.go	rpc/lib/client & server: try to conform to JSON-RPC 2.0 spec (#4141)	5 years ago
test.crt	rpc/lib: write a test for TLS server (#3703)	5 years ago
test.key	rpc/lib: write a test for TLS server (#3703)	5 years ago
ws_handler.go	rpc/lib/client & server: try to conform to JSON-RPC 2.0 spec (#4141)	5 years ago
ws_handler_test.go	rpc/lib/client & server: try to conform to JSON-RPC 2.0 spec (#4141)	5 years ago