bft blockchain consensus consistency cryptocurrency cryptography db distributed-systems go

History

Anton Kaliaev 44a3fbf109 rpc/lib/client & server: try to conform to JSON-RPC 2.0 spec (#4141 ) https://www.jsonrpc.org/specification What is done in this PR: JSONRPCClient: validate that Response.ID matches Request.ID I wanted to do the same for the WSClient, but since we're sending events as responses, not notifications, checking IDs would require storing them in memory indefinitely (and we won't be able to remove them upon client unsubscribing because ID is different then). Request.ID is now optional. Notification is a Request without an ID. Previously "" or 0 were considered as notifications Remove #event suffix from ID from an event response (partially fixes #2949) ID must be either string, int or null AND must be equal to request's ID. Now, because we've implemented events as responses, WS clients are tripping when they see Response.ID("0#event") != Request.ID("0"). Implementing events as requests would require a lot of time (~ 2 days to completely rewrite WS client and server) generate unique ID for each request switch to integer IDs instead of "json-client-XYZ" id=0 method=/subscribe id=0 result=... id=1 method=/abci_query id=1 result=... > send events (resulting from /subscribe) as requests+notifications (not responses) this will require a lot of work. probably not worth it * rpc: generate an unique ID for each request in conformance with JSON-RPC spec * WSClient: check for unsolicited responses * fix golangci warnings * save commit * fix errors * remove ID from responses from subscribe Refs #2949 * clients are safe for concurrent access * tm-bench: switch to int ID * fixes after my own review * comment out sentIDs in WSClient see commit body for the reason * remove body.Close it will be closed automatically * stop ws connection outside of write/read routines also, use t.Rate in tm-bench indexer when calculating ID fix gocritic issues * update swagger.yaml * Apply suggestions from code review * fix stylecheck and golint linter warnings * update changelog * update changelog2		5 years ago
..
types	rpc: remove duplication of data in `ResultBlock ` (#3856)	5 years ago
CONTRIBUTING.md	rpc: remove godoc comments in favor of swagger docs (#4126)	5 years ago
README.md	makefile: minor cleanup (#3994)	5 years ago
abci.go	rpc: remove godoc comments in favor of swagger docs (#4126)	5 years ago
blocks.go	rpc: remove duplication of data in `ResultBlock ` (#3856)	5 years ago
blocks_test.go	rpc: /block_results fix docs + write test + restructure response (#3615)	5 years ago
consensus.go	rpc: add pagination to /validators (#3993)	5 years ago
dev.go	limit number of /subscribe clients and queries per client (#3269)	6 years ago
doc.go	Fix linter errors thrown by `lll` (#3970)	5 years ago
doc_template.txt	generate md for Slate	7 years ago
events.go	rpc/lib/client & server: try to conform to JSON-RPC 2.0 spec (#4141)	5 years ago
evidence.go	rpc: remove godoc comments in favor of swagger docs (#4126)	5 years ago
health.go	rpc: remove godoc comments in favor of swagger docs (#4126)	5 years ago
mempool.go	rpc: remove godoc comments in favor of swagger docs (#4126)	5 years ago
net.go	rpc: remove godoc comments in favor of swagger docs (#4126)	5 years ago
net_test.go	p2p: make persistent prop independent of conn direction (#3593)	6 years ago
pipe.go	New lint version upgrade (#4056)	5 years ago
pipe_test.go	rpc: return err if page is incorrect (less than 0 or greater than tot… (#3825)	5 years ago
routes.go	rpc: add pagination to /validators (#3993)	5 years ago
status.go	rpc: remove godoc comments in favor of swagger docs (#4126)	5 years ago
tx.go	rpc: remove godoc comments in favor of swagger docs (#4126)	5 years ago

README.md

Tendermint RPC

Pagination

Requests that return multiple items will be paginated to 30 items by default. You can specify further pages with the ?page parameter. You can also set a custom page size up to 100 with the ?per_page parameter.