tendermint

bft blockchain consensus consistency cryptocurrency cryptography db distributed-systems go

History

M. J. Fromberger cf7537ea5f cleanup: Reduce and normalize import path aliasing. (#6975 ) The code in the Tendermint repository makes heavy use of import aliasing. This is made necessary by our extensive reuse of common base package names, and by repetition of similar names across different subdirectories. Unfortunately we have not been very consistent about which packages we alias in various circumstances, and the aliases we use vary. In the spirit of the advice in the style guide and https://github.com/golang/go/wiki/CodeReviewComments#imports, his change makes an effort to clean up and normalize import aliasing. This change makes no API or behavioral changes. It is a pure cleanup intended o help make the code more readable to developers (including myself) trying to understand what is being imported where. Only unexported names have been modified, and the changes were generated and applied mechanically with gofmt -r and comby, respecting the lexical and syntactic rules of Go. Even so, I did not fix every inconsistency. Where the changes would be too disruptive, I left it alone. The principles I followed in this cleanup are: - Remove aliases that restate the package name. - Remove aliases where the base package name is unambiguous. - Move overly-terse abbreviations from the import to the usage site. - Fix lexical issues (remove underscores, remove capitalization). - Fix import groupings to more closely match the style guide. - Group blank (side-effecting) imports and ensure they are commented. - Add aliases to multiple imports with the same base package name.		3 years ago
..
grpc	cleanup: Reduce and normalize import path aliasing. (#6975)	3 years ago
doc.go	privval: retry GetPubKey/SignVote/SignProposal N times before	4 years ago
errors.go	privval: if remote signer errors, don't retry (#5140)	4 years ago
file.go	libs/time: move types/time into libs (#6595)	3 years ago
file_test.go	libs/time: move types/time into libs (#6595)	3 years ago
msgs.go	privval: fix ping message encoding (#5441)	4 years ago
msgs_test.go	cleanup: Reduce and normalize import path aliasing. (#6975)	3 years ago
retry_signer_client.go	state/privval: no GetPubKey retry beyond the proposal/voting window (#6578)	3 years ago
secret_connection.go	cleanup: Reduce and normalize import path aliasing. (#6975)	3 years ago
signer_client.go	cleanup: Reduce and normalize import path aliasing. (#6975)	3 years ago
signer_client_test.go	privval: add ctx to privval interface (#6240)	3 years ago
signer_dialer_endpoint.go	privval: increase read/write timeout to 5s and calculate ping interval based on it (#5638)	4 years ago
signer_endpoint.go	libs: internalize some packages (#6366)	3 years ago
signer_listener_endpoint.go	cleanup: remove redundant error plumbing (#6778)	3 years ago
signer_listener_endpoint_test.go	privval: increase read/write timeout to 5s and calculate ping interval based on it (#5638)	4 years ago
signer_requestHandler.go	cleanup: Reduce and normalize import path aliasing. (#6975)	3 years ago
signer_server.go	libs: internalize some packages (#6366)	3 years ago
socket_dialers.go	privval: duplicate SecretConnection from p2p package (#5672)	4 years ago
socket_dialers_test.go	change use of errors.Wrap to fmt.Errorf with %w verb	4 years ago
socket_listeners.go	correct spelling to US english (#6077)	3 years ago
socket_listeners_test.go	crypto: remove key suffixes (#4941)	4 years ago
utils.go	change use of errors.Wrap to fmt.Errorf with %w verb	4 years ago
utils_test.go	change use of errors.Wrap to fmt.Errorf with %w verb	4 years ago