Sam Kleinman
abfcd08903
While I'd hoped to be able to make the socket client less weird, I think that this is a nice middle ground in terms of improving readability and removing the vestigal components without breaking anything or radically changing the underlying assumptions. In the future we'd want to have requests be identified by a request ID, and then we could drop the request tracking logic in the client entirely, and this is protocol breaking. The alternatives aren't substantively different than the current implementation. |
3 years ago | |
---|---|---|
.. | ||
mocks | abci/client: remove lingering async client code (#7876) | 3 years ago |
client.go | abci/client: remove lingering async client code (#7876) | 3 years ago |
creators.go | abci/client: remove client-level callback (#7845) | 3 years ago |
doc.go | abci/client: remove lingering async client code (#7876) | 3 years ago |
grpc_client.go | abci/client: remove lingering async client code (#7876) | 3 years ago |
local_client.go | abci/client: remove lingering async client code (#7876) | 3 years ago |
socket_client.go | abci/client: remove lingering async client code (#7876) | 3 years ago |
socket_client_test.go | Completed the existing `FinalizeBlock` PR and rebased to master (#7798) | 3 years ago |