William Banfield
02c7199eec
The `.proto` file do not have the `nullable = false` annotation present on the `SynchronyParams` durations. This pull request updates the `SynchronyParams` to match the checked in proto files. Note, this does not make the code buildable against the latest protos. This pull request was achieved by checking out all files _not relevant_ to the `SynchronyParams` and removing the new `TimeoutParams` from the the `params.proto` file. Future updates will add these back. This pull request also adds a `nil` check to the `pbParams.Synchrony` field in `ConsensusParamsFromProto`. Old versions of Tendermint will not have the `Synchrony` parameters filled in so this code would panic on startup. We will fill in the empty fields with defaults, but per https://github.com/tendermint/tendermint/blob/master/docs/rfc/rfc-009-consensus-parameter-upgrades.md#only-update-hashedparams-on-hash-breaking-releases we will keep out of the hash during this release. |
2 years ago | |
---|---|---|
.. | ||
message.go | cleanup: Reduce and normalize import path aliasing. (#6975) | 3 years ago |
message_test.go | types: update synchrony params to match checked in proto (#8142) | 2 years ago |
types.pb.go | proto: rebuild the proto files from the spec repository (#7291) | 3 years ago |
types.proto | proto: update proto generation to use buf (#7975) | 2 years ago |