tendermint

6865 Commits

183 Branches

291 MiB

Tree: fd8d1d6b69

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Ismail Khoffi	3ff820bdf4	fix amino overhead computation for Tx (#2792 ) * fix amino overhead computation for Tx: - also count the fieldnum / typ3 - add method to compute overhead per Tx - slightly clarify comment on MaxAminoOverheadForBlock - add tests * fix TestReapMaxBytesMaxGas according to amino overhead * fix TestMempoolFilters according to amino overhead * address review comments: - add a note about fieldNum = 1 - add forgotten godoc comment * fix and use sm.TxPreCheck * fix test * remove print statement	6 years ago
Anton Kaliaev	8d50bb9dad	conesnsu: follow up to removing some consensus params (#2427 ) * follow up to removing some consensus params Refs #2382 * change args type to int64 in state#makeParams * make valsCount and evidenceCount ints again * MaxEvidenceBytesPerBlock: include magic number in godoc * [spec] creating a proposal * test state#TxFilter * panic if MaxDataBytes is less than 0 * fixes after review * use amino#UvarintSize to calculate overhead `0c74291f3b/encoder.go (L85-L90)` * avoid cyclic imports * you can do better Go, come on * remove testdouble package	6 years ago

Ismail Khoffi

3ff820bdf4

fix amino overhead computation for Tx (#2792 )

* fix amino overhead computation for Tx:

- also count the fieldnum / typ3
- add method to compute overhead per Tx
- slightly clarify comment on MaxAminoOverheadForBlock
- add tests

* fix TestReapMaxBytesMaxGas according to amino overhead

* fix TestMempoolFilters according to amino overhead

* address review comments:

 - add a note about fieldNum = 1
 - add forgotten godoc comment

* fix and use sm.TxPreCheck

* fix test

* remove print statement

6 years ago

Anton Kaliaev

8d50bb9dad

conesnsu: follow up to removing some consensus params (#2427 )

* follow up to removing some consensus params Refs #2382
* change args type to int64 in state#makeParams
* make valsCount and evidenceCount ints again
* MaxEvidenceBytesPerBlock: include magic number in godoc
* [spec] creating a proposal
* test state#TxFilter
* panic if MaxDataBytes is less than 0
* fixes after review
* use amino#UvarintSize to calculate overhead
0c74291f3b/encoder.go (L85-L90)
* avoid cyclic imports
* you can do better Go, come on
* remove testdouble package

6 years ago

2 Commits (fd8d1d6b69a84f7c817056fbc3d490d13570b1f8)