tendermint

Commit Graph

Author	SHA1	Message	Date
Emmanuel Odeke	59556ab030	rpc/lib/server: add handlers tests Follow up of PR https://github.com/tendermint/tendermint/pull/724 For https://github.com/tendermint/tendermint/issues/708 Reported initially in #708, this bug was reconfirmed by the fuzzer. This fix ensures that: * if the user doesn't pass in `"id"` that we send them back a message in an error telling them to send `"id"`. Previously we let the handler return a 200 with nothing. * passing in nil `params` doesn't crash * not passing in `params` doesn't crash * passing in non-JSON parseable data to `params` doesn't crash	7 years ago
Emmanuel Odeke	6e5cd10399	rpc/lib/client: jitter test updates and only to-be run on releases * Updated code with feedback from @melekes, @ebuchman and @silasdavis. * Added Makefile clause `release` to only run the test on seeing tag `release` during releases i.e ```shell make release ``` which will run the comprehensive and long integration-ish tests.	7 years ago
Silas Davis	4cb02d0bf2	Exploit the fact the BaseService's closed Quit channel will keep emitting quit signals to close both readRoutine and writeRoutine	7 years ago
Silas Davis	f6adddb4a8	Replace ResultsCh with ResponsesCh	7 years ago
Silas Davis	01be6fa309	Fix WSClient blocking in the readRoutine after Stop() as it tries to write to ResultsCh	7 years ago
Emmanuel Odeke	5504920ba3	rpc/lib/client: add jitter for exponential backoff of WSClient Fixes https://github.com/tendermint/tendermint/issues/751. Adds jitter to our exponential backoff to mitigate a self DDOS vector. The jitter is a randomly picked percentage of a second whose purpose is to ensure that each exponential backoff retry occurs within (1<<attempts) == 2*attempts, but with the delay each client will have a random buffer time before it tries to reconnect instead of all at once reconnections that might even bring back the previous conditions that might have caused the dial to the WSServer to have failed e.g Network outage * File descriptor exhaustion * False positives from firewalls etc	7 years ago
Adrian Brink	036d3b59a3	Address reviews	7 years ago
Adrian Brink	782a836db0	Cleanup of code and code docs This cleans up some of the code in the state package	7 years ago
Silas Davis	3e3d53daef	Make RPCError an actual error and don't swallow its companion data	7 years ago
Anton Kaliaev	aae4e94998	make RPCRequest params not a pointer https://github.com/tendermint/tendermint/pull/724#issuecomment-335362927	7 years ago
Anton Kaliaev	d935a4f0a8	recover from panic in WS JSON RPC readRoutine https://github.com/tendermint/tendermint/pull/724#issuecomment-335316484	7 years ago
Anton Kaliaev	5c331d8276	log a notification to help debug user issues	7 years ago
Anton Kaliaev	13b9de6778	return missing package declaration	7 years ago
Anton Kaliaev	99c4e48038	return missing package declaration	7 years ago
Anton Kaliaev	a3adac3787	[rpc] do not try to parse params if they were not provided (Refs #708 )	7 years ago
Anton Kaliaev	3702cb7e7c	restore rpc/lib readme as doc.go (Refs #710 ) [ci skip] I don't want to lose any documentation. Correct me if I am wrong, but we don't have this docs anywhere else.	7 years ago
Zach Ramsay	136b6a7673	rpc/lib: remove dead files, closes #710	7 years ago
Zach Ramsay	d56b44f3a5	all: no more anonymous imports	7 years ago
Anton Kaliaev	45ff7cdd0c	rewrite ws client to expose a callback instead of a channel callback gives more power to the publisher. plus it is optional comparing to a channel, which will block the whole client if you won't read from it.	7 years ago
Alexandre Thibault	ce36a0111a	rpc: subscribe on reconnection (#689 ) * rpc: subscribe on reconnection * rpc: fix unit tests	7 years ago
Alexandre Thibault	382bead548	rpc: fix client websocket timeout (#687 )	7 years ago
Anton Kaliaev	f9479b34cb	sleep time should be greater than readTimeout (5 sec) otherwise, we're not testing ping/pongs. see https://github.com/tendermint/tendermint/pull/687#issuecomment-332494735	7 years ago
Ethan Buchman	ddb3d8945d	p2p: allow listener with no external connection	7 years ago
Anton Kaliaev	f8b152972f	return method not found error if somebody tries to access WS method in non-ws context	7 years ago
Anton Kaliaev	95875c55fc	ID must be present in both request and response from the spec: This member is REQUIRED. It MUST be the same as the value of the id member in the Request Object. If there was an error in detecting the id in the Request object (e.g. Parse error/Invalid Request), it MUST be Null.	7 years ago
Anton Kaliaev	7fadde0b37	check for request ID after receiving it	7 years ago
Anton Kaliaev	e36c79f713	capitalize RpcError	7 years ago
Anton Kaliaev	b700ed8e31	remove check for non-empty message as it should always be present	7 years ago
Anton Kaliaev	f74de4cb86	include optional data field in error object ``` data A Primitive or Structured value that contains additional information about the error. This may be omitted. The value of this member is defined by the Server (e.g. detailed error information, nested errors etc.). ```	8 years ago
Anton Kaliaev	6c1572c9b8	fix invalid memory address or nil pointer dereference	8 years ago
Dave Bryson	60a1f49a5c	updated json response to match spec by @davebryson	8 years ago
Ethan Buchman	9dde1a0bd4	rpc: comments	7 years ago
Anton Kaliaev	2fd8496bc1	correct handling of pings and pongs server: - always has read & write timeouts - ping handler never blocks the reader (see A) - sends regular pings to check up on a client A: at some point server write buffer can become full, so in order not to block reads from a client (see https://github.com/gorilla/websocket/issues/97), server may skip some pongs. As a result, client may disconnect. But you either have to do that or block the reader. There is no third way. client: - optional read & write timeouts - optional ping/pong to measure latency	7 years ago
Anton Kaliaev	236489aecf	backlog must always have higher priority	7 years ago
Ethan Buchman	797acbe911	ws: small comment	7 years ago
Anton Kaliaev	9b5f21a650	[ws-server] reset readTimeout when we receive something	7 years ago
Anton Kaliaev	8267920749	[ws-client] write normal close message	7 years ago
Anton Kaliaev	6c85e4be4f	change server ping period to be less frequent no need to ping ws every 10 sec	7 years ago
Anton Kaliaev	23a87304cc	add a comment for PingPongLatencyTimer [ci skip]	7 years ago
Anton Kaliaev	c14b39da5f	make RPC server's ping period and pong wait configurable via options	7 years ago
Anton Kaliaev	57eee2466b	make WSClient thread-safe	7 years ago
Anton Kaliaev	5d66d1c28c	fixes from review	7 years ago
Anton Kaliaev	0013053fae	allow to change pong wait and ping period	7 years ago
Anton Kaliaev	1abbb11b44	do not exit from reconnectRoutine!	7 years ago
Anton Kaliaev	54903adeff	add IsReconnecting and IsActive methods	7 years ago
Anton Kaliaev	c08618f7e9	expose latency timer on WSClient	7 years ago
Anton Kaliaev	d578f7f81e	biff up WS client What's new: - auto reconnect - ping/pong - colored tests	7 years ago
Ethan Buchman	0d1fa8e884	fixes from review	7 years ago
Ethan Buchman	e2ed15fa02	rpc: SetWriteDeadline for ws ping. fixes #553	7 years ago
Ethan Buchman	b6031d5f4b	rpc/lib: set logger on ws conn	8 years ago

1 2 3 4

176 Commits (ee6601ad48ca8ae67610e8f94a28341caf30dec4)