Emmanuel Odeke
62c1bc0a20
p2p: comment on the wg.Add before go saveRoutine()
Just noticed while auditing the code in p2p/addrbook.go,
wg.Add(1) but no subsequent defer.
@jaekwon and I had a discussion offline and we agreed to
comment about why the code was that way and why
we shouldn't move the wg.Add(1) into .saveRoutine() because
if go a.saveRoutine() isn't started before anyone invokes
a.Wait(), then we'd have raced a.saveRoutine().
7 years ago
Petabyte Storage
3863885c71
WIP: begin parallel refactoring with go-wire Write methods and MConnection
7 years ago
Anton Kaliaev
a1cdc2b68a
set logger for peer's MConnection
7 years ago
Ethan Buchman
c931279960
p2p: some fixes re @odeke-em issues #813,#816,#817
7 years ago
Petabyte Storage
51c9211cf4
add test for MConnection TrySend and Send
7 years ago
Anton Kaliaev
7869e541f6
change MakeConnectedSwitches to not connect to itself
and a test for it
7 years ago
Anton Kaliaev
e0daca5693
fixes from Bucky's review
7 years ago
Ethan Buchman
37ce171061
p2p/connetion: remove panics, test error cases
7 years ago
Ethan Buchman
e01986e2b3
p2p: update readme, some minor things
7 years ago
Anton Kaliaev
2d4ad02356
prefer tickers to time.Sleep (Refs #790 )
7 years ago
Anton Kaliaev
e785697a64
connect first switch to others (Refs #808 )
7 years ago
Petabyte Storage
fe9ff62297
fix comment typos
7 years ago
Petabyte Storage
6b366b2443
fix test using uncommon names
7 years ago
Petabyte Storage
ceedd4d968
remove unnecessary plus [ci skip]
7 years ago
Ethan Buchman
0bbf38141a
blockchain/pool: some comments and small changes
7 years ago
Zach Ramsay
136b6a7673
rpc/lib: remove dead files, closes #710
7 years ago
Zach Ramsay
f23d47e5d2
upnp: keep a link
7 years ago
Zach Ramsay
d56b44f3a5
all: no more anonymous imports
7 years ago
Ethan Buchman
ddb3d8945d
p2p: allow listener with no external connection
7 years ago
Ethan Buchman
b50339e8e7
p2p: sw.AddPeer -> sw.addPeer
7 years ago
Ethan Buchman
aea8629272
peer interface
7 years ago
Emmanuel Odeke
5138bcb1c7
p2p: delete unused and untested *IPRangeCount functions
Fixes #602
Delete unused and untested functions:
- AddToIPRangeCounts
- CheckIPRangeCounts
7 years ago
Ethan Buchman
54c63726b0
p2p: minor comment fixes
7 years ago
Emmanuel Odeke
c48e772115
p2p: fully test PeerSet, more docs, parallelize PeerSet tests
* Full test PeerSet and check its concurrent guarantees
* Improve the doc for PeerSet.Has and remove unnecessary
defer for a path that sets a variable, make it fast anyways.
* Parallelize PeerSet tests with t.Parallel()
* Document functions in peer_set.go more.
7 years ago
Ethan Buchman
cc2b418f7f
p2p: test fix
7 years ago
Ethan Buchman
88138c38cf
mempool: reactor test
7 years ago
Ethan Buchman
daa258ea6d
p2p: put maxMsgPacketPayloadSize, recvRate, sendRate in config
Updates #628
7 years ago
caojingqi
086544e367
p2p: sw.peers.List() is empty in sw.OnStart
7 years ago
Ethan Buchman
75df0d91ba
comments from review
7 years ago
Ethan Buchman
5f6b996d22
breakup some long lines; add more comments to consensus reactor
7 years ago
Ethan Buchman
74a3a2b56a
fix comments
7 years ago
Adrian Brink
b07d01f102
Add more comments on public functions and extra logging during 'enterPrevote'
Signed-off-by: Adrian Brink <adrian@brink-holdings.com>
7 years ago
Ethan Buchman
e6cecb9595
p2p: fix test
7 years ago
Ethan Buchman
3c10f7a122
add p2p flush throttle to config
7 years ago
Ethan Buchman
0d1fa8e884
fixes from review
7 years ago
Ethan Buchman
3c0128a680
undo some megacheck suggestions
8 years ago
Anton Kaliaev
b4ece65726
standardize key for errors (should be "err")
8 years ago
zramsay
bf5181d9ca
address PR comments
8 years ago
zramsay
cf31f8d06f
core: apply megacheck vet tool (unused, gosimple, staticcheck)
8 years ago
Anton Kaliaev
4fe67652ff
move SetLogger down
8 years ago
Anton Kaliaev
c5bccc5474
set missing logger on switch
```
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x882cec]
goroutine 328 [running]:
github.com/tendermint/tendermint/p2p.(*Switch).DialPeerWithAddress(0xc42000a500, 0xc4202088d0, 0xc420403500, 0x0, 0x0, 0x0)
/home/vagrant/go/src/github.com/tendermint/tendermint/p2p/switch.go:324 +0x2fc
github.com/tendermint/tendermint/p2p.(*PEXReactor).ensurePeers.func1(0xc4201663f0, 0xc4202088d0)
/home/vagrant/go/src/github.com/tendermint/tendermint/p2p/pex_reactor.go:280 +0x3e
created by github.com/tendermint/tendermint/p2p.(*PEXReactor).ensurePeers
/home/vagrant/go/src/github.com/tendermint/tendermint/p2p/pex_reactor.go:284 +0x5d4
```
8 years ago
Anton Kaliaev
f8fdbe3dbc
changes as per Bucky's review
8 years ago
Anton Kaliaev
c9cd8de9c6
set logger
8 years ago
Anton Kaliaev
bc4e6566e7
[p2p] refactor upnp to use new logger
8 years ago
Ethan Buchman
16509ac3db
p2p: fix race by peer.Start() before peers.Add()
8 years ago
Anton Kaliaev
f803544195
new logging
8 years ago
Ethan Frey
57527f9f67
One silly tests passes on osx, fails on linux... comment out so i can develop
8 years ago
Ethan Buchman
46151720f8
fix tests
8 years ago
Ethan Frey
604bf03f3a
Pulled out all config structs (except p2p.PeerConfig) into config package
8 years ago
Ethan Buchman
92bafa7ecd
consensus: fix tests
8 years ago