tendermint

10009 Commits

183 Branches

291 MiB

Tree: cc838a5a19

Commit Graph

Author	SHA1	Message	Date
William Banfield	cc838a5a19	ABCI++: Update new protos to use enum instead of bool (#8158 ) closes: #8039 This pull request updates the new ABCI++ protos to use `enum`s in place of `bool`s. `enums` may be preferred over `bool` because an `enum` can be udpated to include new statuses in the future, whereas a `bool` cannot and is fixed as just `true` or `false` over the whole lifecycle of the API.	2 years ago
William Banfield	c80734e5af	state: synchronize the ProcessProposal implementation with the latest version of the spec (#7961 ) This change implements the spec for `ProcessProposal`. It first calls the Tendermint block validation logic to check that all of the proposed block fields are well formed and do not violate any of the rules for Tendermint to consider the block valid and then passes the validated block the `ProcessProposal`. This change also adds additional fixtures to test the change. It adds the `baseMock` types that holds a mock as well as a reference to `BaseApplication`. If the function was not setup by the test on the contained mock Application, the type delegates to the `BaseApplication` and returns what `BaseApplication` returns. The change also switches the `makeState` helper to take an arg struct so that an ABCI application can be plumbed through when needed. closes: #7656	2 years ago

Author

SHA1

Message

Date

William Banfield

cc838a5a19

ABCI++: Update new protos to use enum instead of bool (#8158 )

closes: #8039 

This pull request updates the new ABCI++ protos to use `enum`s in place of `bool`s. `enums` may be preferred over `bool` because an `enum` can be udpated to include new statuses in the future, whereas a `bool` cannot and is fixed as just `true` or `false` over the whole lifecycle of the API.

2 years ago

William Banfield

c80734e5af

state: synchronize the ProcessProposal implementation with the latest version of the spec (#7961 )

This change implements the spec for `ProcessProposal`. It first calls the Tendermint block validation logic to check that all of the proposed block fields are well formed and do not violate any of the rules for Tendermint to consider the block valid and then passes the validated block the `ProcessProposal`.

This change also adds additional fixtures to test the change. It adds the `baseMock` types that holds a mock as well as a reference to `BaseApplication`. If the function was not setup by the test on the contained mock Application, the type delegates to the `BaseApplication` and returns what `BaseApplication` returns. 

The change also switches the `makeState` helper to take an arg struct so that an ABCI application can be plumbed through when needed.

closes: #7656

2 years ago

2 Commits (cc838a5a19401e6b349f9eae4c9d8ab2b35ce4a5)