tendermint

8299 Commits

183 Branches

291 MiB

Tree: bf9e36d02d

Commit Graph

Author	SHA1	Message	Date
Marko	7e2cc1db5e	linter: (1/2) enable errcheck (#5064 ) ## Description partially cleanup in preparation for errcheck i ignored a bunch of defer errors in tests but with the update to go 1.14 we can use `t.Cleanup(func() { if err := <>; err != nil {..}}` to cover those errors, I will do this in pr number two of enabling errcheck. ref #5059	4 years ago
Erik Grinaker	66b0ec0af1	clarify service logging The service logging can be a bit unclear. For example, with state sync it would log: ``` I[2020-04-20\|08:40:47.366] Starting StateSync module=statesync impl=Reactor I[2020-04-20\|08:40:47.834] Starting state sync module=statesync ``` Where the first message is the reactor service startup, and the second message is the start of the actual state sync process. This clarifies the first message by changing it to `Starting StateSync service`. ______ For contributor use: - [ ] ~Wrote tests~ - [ ] ~Updated CHANGELOG_PENDING.md~ - [ ] ~Linked to Github issue with discussion and accepted design OR link to spec that describes this work.~ - [ ] ~Updated relevant documentation (`docs/`) and code comments~ - [x] Re-reviewed `Files changed` in the Github PR explorer	5 years ago
Marko	27b00cf8d1	libs/common: refactor libs common 3 (#4232 ) * libs/common: refactor libs common 3 - move nil.go into types folder and make private - move service & baseservice out of common into service pkg ref #4147 Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * add changelog entry	5 years ago

Author

SHA1

Message

Date

Marko

7e2cc1db5e

linter: (1/2) enable errcheck (#5064 )

## Description

partially cleanup in preparation for errcheck

i ignored a bunch of defer errors in tests but with the update to go 1.14 we can use `t.Cleanup(func() { if err := <>; err != nil {..}}` to cover those errors, I will do this in pr number two of enabling errcheck.

ref #5059

4 years ago

Erik Grinaker

66b0ec0af1

clarify service logging

The service logging can be a bit unclear. For example, with state sync it would log:

```
I[2020-04-20|08:40:47.366] Starting StateSync     module=statesync impl=Reactor
I[2020-04-20|08:40:47.834] Starting state sync    module=statesync
```

Where the first message is the reactor service startup, and the second message is the start of the actual state sync process. This clarifies the first message by changing it to `Starting StateSync service`.

______

For contributor use:

- [ ] ~Wrote tests~
- [ ] ~Updated CHANGELOG_PENDING.md~
- [ ] ~Linked to Github issue with discussion and accepted design OR link to spec that describes this work.~
- [ ] ~Updated relevant documentation (`docs/`) and code comments~
- [x] Re-reviewed `Files changed` in the Github PR explorer

5 years ago

Marko

27b00cf8d1

libs/common: refactor libs common 3 (#4232 )

* libs/common: refactor libs common 3

- move nil.go into types folder and make private
- move service & baseservice out of common into service pkg

ref #4147

Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>

* add changelog entry

5 years ago

3 Commits (bf9e36d02d2eb22f6fe8961d0d7d3d34307ba38e)