tendermint

291 MiB

Tree: bce20dbfb6

Author	SHA1	Message	Date
Juan Leni	bce20dbfb6	fix linter issues	6 years ago
Juan Leni	33b8c6307b	fixing unit test	6 years ago
Juan Leni	a66063f946	Improving service endpoint	6 years ago
Juan Leni	c7348985af	Fix/improve unit tests	6 years ago
Juan Leni	588e7f32dc	Clean up	6 years ago
Juan Leni	91e00b3620	Improve tests	6 years ago
Juan Leni	d9b3001d13	Encapsulating and fixing unit tests	6 years ago
Juan Leni	07501137c4	reworking unit tests	6 years ago
Juan Leni	c879c6e58d	refactoring - work in progress	6 years ago
Juan Leni	853dd34d31	privval: improve Remote Signer implementation (#3351 ) This issue is related to #3107 This is a first renaming/refactoring step before reworking and removing heartbeats. As discussed with @Liamsi , we preferred to go for a couple of independent and separate PRs to simplify review work. The changes: Help to clarify the relation between the validator and remote signer endpoints Differentiate between timeouts and deadlines Prepare to encapsulate networking related code behind RemoteSigner in the next PR My intention is to separate and encapsulate the "network related" code from the actual signer. SignerRemote ---(uses/contains)--> SignerValidatorEndpoint <--(connects to)--> SignerServiceEndpoint ---> SignerService (future.. not here yet but would like to decouple too) All reconnection/heartbeat/whatever code goes in the endpoints. Signer[Remote/Service] do not need to know about that. I agree Endpoint may not be the perfect name. I tried to find something "Go-ish" enough. It is a common name in go-kit, kubernetes, etc. Right now: SignerValidatorEndpoint: handles the listener contains SignerRemote Implements the PrivValidator interface connects and sets a connection object in a contained SignerRemote delegates PrivValidator some calls to SignerRemote which in turn uses the conn object that was set externally SignerRemote: Implements the PrivValidator interface read/writes from a connection object directly handles heartbeats SignerServiceEndpoint: Does most things in a single place delegates to a PrivValidator IIRC. * cleanup * Refactoring step 1 * Refactoring step 2 * move messages to another file * mark for future work / next steps * mark deprecated classes in docs * Fix linter problems * additional linter fixes	6 years ago

5 Commits (bce20dbfb6a4f4c3737f18180402dc4a3130cdd0)