tendermint

7471 Commits

183 Branches

291 MiB

Tree: ac099aa272

Commit Graph

Author	SHA1	Message	Date
Ethan Buchman	fc1c37c4ac	Update ADR-025 and mark it as Accepted (#3958 ) * update adr-025, mark accepted * minor update * Update docs/architecture/adr-025-commit.md Co-Authored-By: Anton Kaliaev <anton.kalyaev@gmail.com>	5 years ago
Ethan Buchman	4905640e9b	types: CommitVotes struct as last step towards #1648 (#3298 ) * VoteSignBytes builds CanonicalVote * CommitVotes implements VoteSetReader - new CommitVotes struct holds both the Commit and the ValidatorSet and implements VoteSetReader - ToVote takes a ValidatorSet * fix TestCommit * use CommitSig.BlockID Commits may include votes for a different BlockID, could be nil, or different altogether. This means we can't use `commit.BlockID` for reconstructing the sign bytes, since up to -1/3 of the commits might be for independent BlockIDs. This means CommitSig will need to include an indicator for what BlockID it signed - if it's not the committed one or nil, it will need to include it fully in order to be verified. This is unfortunate but unavoidable so long as we include votes for non-committed BlockIDs (which we do to track validator liveness) * fixes from review * remove CommitVotes. CommitSig contains address * remove commit.canonicalVote method * toVote -> getVote, takes valIdx * update adr-025 * commit.ToVoteSet -> CommitToVoteSet * add test * fix from review	6 years ago
Jeremiah Andrews	f11aef20a0	Add ADR for Commit changes (#2374 )	6 years ago

Author

SHA1

Message

Date

Ethan Buchman

fc1c37c4ac

Update ADR-025 and mark it as Accepted (#3958 )

* update adr-025, mark accepted

* minor update

* Update docs/architecture/adr-025-commit.md

Co-Authored-By: Anton Kaliaev <anton.kalyaev@gmail.com>

5 years ago

Ethan Buchman

4905640e9b

types: CommitVotes struct as last step towards #1648 (#3298 )

* VoteSignBytes builds CanonicalVote

* CommitVotes implements VoteSetReader

- new CommitVotes struct holds both the Commit and the ValidatorSet and
  implements VoteSetReader
- ToVote takes a ValidatorSet

* fix TestCommit

* use CommitSig.BlockID

Commits may include votes for a different BlockID, could be nil,
or different altogether. This means we can't use `commit.BlockID`
for reconstructing the sign bytes, since up to -1/3 of the commits
might be for independent BlockIDs. This means CommitSig will need to
include an indicator for what BlockID it signed - if it's not the
committed one or nil, it will need to include it fully in order to be
verified. This is unfortunate but unavoidable so long as we include
votes for non-committed BlockIDs (which we do to track validator
liveness)

* fixes from review

* remove CommitVotes. CommitSig contains address

* remove commit.canonicalVote method

* toVote -> getVote, takes valIdx

* update adr-025

* commit.ToVoteSet -> CommitToVoteSet

* add test

* fix from review

6 years ago

Jeremiah Andrews

f11aef20a0

Add ADR for Commit changes (#2374 )

6 years ago

3 Commits (ac099aa272a05ddf0d254e06c1cddb0fbc7884f8)