tendermint

Commit Graph

Author	SHA1	Message	Date
Sam Kleinman	a62ac27047	service: remove exported logger from base implemenation (#7381 )	3 years ago
Sam Kleinman	8a991e288c	service: plumb contexts to all (most) threads (#7363 ) This continues the push of plumbing contexts through tendermint. I attempted to find all goroutines in the production code (non-test) and made sure that these threads would exit when their contexts were canceled, and I believe this PR does that.	3 years ago
Sam Kleinman	a823d167bc	service: cleanup base implementation and some caller implementations (#7301 )	3 years ago
Sam Kleinman	6ab62fe7b6	service: remove stop method and use contexts (#7292 )	3 years ago
Sam Kleinman	d7606777cf	libs/service: pass logger explicitly (#7288 ) This is a very small change, but removes a method from the `service.Service` interface (a win!) and forces callers to explicitly pass loggers in to objects during construction rather than (later) injecting them. There's not a real need for this kind of lazy construction of loggers, and I think a decent potential for confusion for mutable loggers. The main concern I have is that this changes the constructor API for ABCI clients. I think this is fine, and I suspect that as we plumb contexts through, and make changes to the RPC services there'll be a number of similar sorts of changes to various (quasi) public interfaces, which I think we should welcome.	3 years ago
Sam Kleinman	a855f96946	p2p: renames for reactors and routing layer internal moves (#6547 )	3 years ago
Marko	27b00cf8d1	libs/common: refactor libs common 3 (#4232 ) * libs/common: refactor libs common 3 - move nil.go into types folder and make private - move service & baseservice out of common into service pkg ref #4147 Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * add changelog entry	5 years ago
Zach Ramsay	44dad6d70b	Revert "detele everything" This reverts commit `d02c5d1e30`.	6 years ago
Zach Ramsay	d02c5d1e30	detele everything	6 years ago
Ethan Buchman	d55243f0e6	fix import paths	6 years ago
Liamsi	d2c05bc5b9	Revert "delete everything" (includes everything non-go-crypto) This reverts commit `96a3502`	6 years ago
Liamsi	96a3502126	delete everything	6 years ago
Anton Kaliaev	2a24ae90c1	fixes from Jae's review 1. remove pointer 2. add Quit() method to Service interface	6 years ago
Ricardo Domingos	59e89e7664	consensus: Fix typo on ticker.go documentation	7 years ago
Anton Kaliaev	69b5da766c	service#Start, service#Stop signatures were changed See https://github.com/tendermint/tmlibs/issues/45	7 years ago
Ethan Buchman	e9b7221292	consensus: more comments	7 years ago
spring1843	cf686d4f83	Fix commonly misspelled words	7 years ago
Anton Kaliaev	f8fdbe3dbc	changes as per Bucky's review	7 years ago
Anton Kaliaev	f803544195	new logging	7 years ago
Ethan Buchman	d1926bcad1	use tmlibs	7 years ago
Ethan Buchman	4fd1471f11	remove BaseService.OnStart	7 years ago
Ethan Buchman	55b4bfa1fe	consensus: let time.Timer handle non-positive durations	8 years ago
Ethan Buchman	f30a9752e2	more fixes from review	8 years ago
Ethan Buchman	40b08f2494	consensus: mv timeoutRoutine into TimeoutTicker	8 years ago

6 Commits (a62ac2704750447b35bc465d4203cdf22c828d85)