tendermint

291 MiB

Tree: 994912211c

Author	SHA1	Message	Date
Anton Kaliaev	ad715fe966	types: change `Commit` to consist of just signatures (#4146 ) * types: change `Commit` to consist of just signatures These are final changes towards removing votes from commit and leaving only signatures (see ADR-25) Fixes #1648 * bring back TestCommitToVoteSetWithVotesForAnotherBlockOrNilBlock + add absent flag to Vote to indicate that it's for another block * encode nil votes as CommitSig with BlockIDFlagAbsent + make Commit#Precommits array of non-pointers because precommit will never be nil * add NewCommitSigAbsent and Absent() funcs * uncomment validation in CommitSig#ValidateBasic * add comments to ValidatorSet funcs * add a changelog entry * break instead of continue continue does not make sense in these cases * types: rename Commit#Precommits to Signatures * swagger: fix /commit response * swagger: change block_id_flag type * fix merge conflicts	5 years ago
Thane Thomson	228bba799d	state: add more tests for block validation (#3674 ) * Expose priv validators for use in testing * Generalize block header validation test past height 1 * Remove ineffectual assignment * Remove redundant SaveState call * Reorder comment for clarity * Use the block executor ApplyBlock function instead of implementing a stripped-down version of it * Remove commented-out code * Remove unnecessary test The required tests already appear to be implemented (implicitly) through the TestValidateBlockHeader test. * Allow for catching of specific error types during TestValidateBlockCommit * Make return error testable * Clean up and add TestValidateBlockCommit code * Fix formatting * Extract function to create a new mock test app * Update comment for clarity * Fix comment * Add skeleton code for evidence-related test * Allow for addressing priv val by address * Generalize test beyond a single validator * Generalize TestValidateBlockEvidence past first height * Reorder code to clearly separate tests and utility code * Use a common constant for stop height for testing in state/validation_test.go * Refactor errors to resemble existing conventions * Fix formatting * Extract common helper functions Having the tests littered with helper functions makes them less easily readable imho, so I've pulled them out into a separate file. This also makes it easier to see what helper functions are available during testing, so we minimize the chance of duplication when writing new tests. * Remove unused parameter * Remove unused parameters * Add field keys * Remove unused height constant * Fix typo * Fix incorrect return error * Add field keys * Use separate package for tests This refactors all of the state package's tests into a state_test package, so as to keep any usage of the state package's internal methods explicit. Any internal methods/constants used by tests are now explicitly exported in state/export_test.go * Refactor: extract helper function to make, validate, execute and commit a block * Rename state function to makeState * Remove redundant constant for number of validators * Refactor mock evidence registration into TestMain * Remove extraneous nVals variable * Replace function-level TODOs with file-level TODO and explanation * Remove extraneous comment * Fix linting issues brought up by GolangCI (pulled in from latest merge from develop)	5 years ago
Anton Kaliaev	91efacfabc	remove types.Result	7 years ago
Anton Kaliaev	f01f2bbf3a	DeliverTxSync/CheckTxSync/CommitSync now return error as well	7 years ago
Anton Kaliaev	5fd83b3eee	implement error interface for ResponseDeliverTx/CheckTx/Commit	7 years ago
Jae Kwon	ca95184373	s/Invalid[Address,Amount]/Invalid[Input,Output]/g	9 years ago
Jae Kwon	121db71f48	Add ErrBaseUnknownPlugin	9 years ago
Jae Kwon	ccc55bd304	Add ErrUnknownAddress	9 years ago
Jae Kwon	6785b9a3b6	CommitSync returns tmsp.Result	9 years ago

2 Commits (994912211c6911684a1db9f39f524677e4cd1154)