tendermint

Commit Graph

Author	SHA1	Message	Date
Phil Salant	04d13d9945	fix linter errors thrown by `unconvert`, `goconst`, and `nakedret` (#3960 ) * Remove unnecessary type conversions * Consolidate repeated strings into consts * Clothe return statements * Update blockchain/v1/reactor_fsm_test.go Co-Authored-By: Anton Kaliaev <anton.kalyaev@gmail.com> This PR repairs linter errors seen when running the following commands: golangci-lint run --no-config --disable-all=true --enable=unconvert golangci-lint run --no-config --disable-all=true --enable=goconst golangci-lint run --no-config --disable-all=true --enable=nakedret Contributes to #3262	5 years ago
Marko	f9cce282da	gocritic (2/2) (#3864 ) Refs #3262	5 years ago
Thane Thomson	62f97a69e9	abci: Refactor CheckTx to notify of recheck (#3744 ) As per #2127, this refactors the RequestCheckTx ProtoBuf struct to allow for a flag indicating whether a query is a recheck or not (and allows for possible future, more nuanced states). In order to pass this extended information through to the ABCI app, the proxy.AppConnMempool (and, for consistency, the proxy.AppConnConsensus) interface seems to need to be refactored along with abcicli.Client. And, as per this comment, I've made the following modification to the protobuf definition for the RequestCheckTx structure: enum CheckTxType { New = 0; Recheck = 1; } message RequestCheckTx { bytes tx = 1; CheckTxType type = 2; } * Refactor ABCI CheckTx to notify of recheck As per #2127, this refactors the `RequestCheckTx` ProtoBuf struct to allow for: 1. a flag indicating whether a query is a recheck or not (and allows for possible future, more nuanced states) 2. an `additional_data` bytes array to provide information for those more nuanced states. In order to pass this extended information through to the ABCI app, the `proxy.AppConnMempool` (and, for consistency, the `proxy.AppConnConsensus`) interface seems to need to be refactored. Commits: * Fix linting issue * Add CHANGELOG_PENDING entry * Remove extraneous explicit initialization * Update ABCI spec doc to include new CheckTx params * Rename method param for consistency * Rename CheckTxType enum values and remove additional_data param	6 years ago
Thane Thomson	9d5ba576ee	abci: Refactor ABCI CheckTx and DeliverTx signatures (#3735 ) * Refactor signature of Application.CheckTx * Refactor signature of Application.DeliverTx * Refactor example variable names for clarity and consistency * Rename method variables for consistency * Rename method variables for consistency * add a changelog entry * update docs	6 years ago
Ethan Buchman	e3f54ece2f	abci: VoteInfo, ValidatorUpdate. See ADR-018	6 years ago
Dev Ojha	2756be5a59	libs: Remove usage of custom Fmt, in favor of fmt.Sprintf (#2199 ) * libs: Remove usage of custom Fmt, in favor of fmt.Sprintf Closes #2193 * Fix bug that was masked by custom Fmt!	6 years ago
Anton Kaliaev	96ae535fb8	proto3 timestamp (#2064 ) This PR changes ABCI time format from int64 (Unix seconds) to WKT (WellKnownType) google.protobuf.Timestamp. Refs #1857 Reasons: better precision standard DT for proto * update Gopkg.lock * [makefile] remove extra grep - go list excludes vendor by default now * proto3 timestamp * [docs/abci-spec] note about serialisation format * make time non-nullable	7 years ago
Zach Ramsay	44dad6d70b	Revert "detele everything" This reverts commit `d02c5d1e30`.	7 years ago
Zach Ramsay	d02c5d1e30	detele everything	7 years ago
Ethan Buchman	d55243f0e6	fix import paths	7 years ago
Alexander Simmerl	a605b66c5a	Move abci imports	7 years ago

10 Commits (961e1d360fe8ef4efb573f15fa7da0e907809fc0)