Ethan Frey
8b518fadb2
Don't close throttle channel, explain why
7 years ago
Ethan Frey
e430d3f844
One more attempt with a read-only channel
7 years ago
Ethan Frey
1ac4c5dd6d
Made throttle output non-blocking
7 years ago
Ethan Frey
0a8721113a
First pass of PR updates
7 years ago
Ethan Frey
4ec7883891
Cleanup
7 years ago
Ethan Frey
dcb4395604
Refactor throttle timer
7 years ago
Ethan Frey
3d9113c16e
Add a bit more padding to tests so they pass on osx with -race
7 years ago
Ethan Buchman
bfcc0217f1
Merge pull request #93 from tendermint/release/0.5.0
Release/0.5.0
7 years ago
Ethan Buchman
e6be03db31
update license and changelog
7 years ago
Anton Kaliaev
b166d627f3
bump up version to 0.5.0
7 years ago
Anton Kaliaev
303b6df812
update changelog
7 years ago
Anton Kaliaev
283462dfe4
Merge pull request #86 from tendermint/fix-lint
fix warnings
7 years ago
Anton Kaliaev
c325ce2182
use NoErrorf and Errorf functions
7 years ago
Anton Kaliaev
27ab1f6bd9
Merge pull request #90 from tendermint/feature/throttle-timer
test timers
7 years ago
Ethan Frey
26abd65e34
Add tests for repeat timer
7 years ago
Ethan Frey
53cdb6cf82
Demo throttle timer is broken
7 years ago
Petabyte Storage
4769719a4b
fix Errorf
7 years ago
Anton Kaliaev
d625020c90
Merge pull request #89 from tendermint/license
add license file (Fixes #87 ) [ci skip]
7 years ago
Anton Kaliaev
3af6044fdf
add license file ( Fixes #87 ) [ci skip]
7 years ago
Jae Kwon
17dc8a7449
SetDeleter/Batch separation
7 years ago
Petabyte Storage
ebc543ebe3
fix warnings
7 years ago
Anton Kaliaev
21fb781989
Merge pull request #84 from tendermint/85-indexing
query#Conditions for indexing
7 years ago
Anton Kaliaev
c9694b1ba1
fix warnings
7 years ago
Anton Kaliaev
3822727981
add Conditions function
Refs https://github.com/tendermint/tendermint/pull/835
7 years ago
Anton Kaliaev
850fd24ee9
Merge pull request #85 from tendermint/85-indexing-2
IntInSlice and StringInSlice functions
7 years ago
Anton Kaliaev
33abe87c5b
IntInSlice and StringInSlice functions
Refs https://github.com/tendermint/tendermint/pull/835
7 years ago
Ethan Buchman
1e12754b3a
Merge pull request #75 from tendermint/45-change-common-start-signature
change common start signature
7 years ago
Ethan Buchman
4d991acae0
common: comments for Service
7 years ago
Ethan Buchman
ddd141c1c5
Merge branch 'develop' into 45-change-common-start-signature
7 years ago
Ethan Buchman
57fea1335a
Makefile and linter
7 years ago
Anton Kaliaev
c2fcc093b2
remove bool from Service#Reset
7 years ago
Anton Kaliaev
f75339264f
Merge pull request #83 from tendermint/gut-process
remove package process
7 years ago
Emmanuel Odeke
e07ad01f62
remove package process
Fixes https://github.com/tendermint/tmlibs/issues/81
That package is untested and racy, and not used except in
a test, but even that's now gutted with
https://github.com/tendermint/abci/pull/139
so the general consensus is that we sunset this package.
7 years ago
Anton Kaliaev
eb31c04f47
Merge tag 'v0.4.1' into develop
Tagged 0.4.1 release
7 years ago
Anton Kaliaev
b854baa1fc
Merge branch 'release/0.4.1'
7 years ago
Anton Kaliaev
3244f73f32
update version
7 years ago
Anton Kaliaev
4e705a3157
update changelog
7 years ago
Ethan Buchman
d3bac7a6fe
clist: reduce numTimes in test
7 years ago
Ethan Buchman
135a1a7cd7
db: sort keys for memdb iterator
7 years ago
Jae Kwon
56e51bc113
CacheWrap() -> CacheDB() CacheDB
7 years ago
Anton Kaliaev
2442a0a698
Merge pull request #78 from tendermint/editorconfig
add .editorconfig
7 years ago
Anton Kaliaev
4ea6340f1a
add .editorconfig
7 years ago
Jae Kwon
8481c49c82
CacheDB ( #67 )
* Add CacheDB & SimpleMap
* Generic memBatch; Fix cLevelDB tests
* CacheWrap() for CacheDB and MemDB
* Change Iterator to match LeviGo Iterator
* Fixes from review
* cacheWrapWriteMutex and some race fixes
* Use tmlibs/common
* NewCWWMutex is exposed. DB can be CacheWrap'd
* Remove GetOK, not needed
* Fsdb (#72 )
* Add FSDB
* Review fixes from Anton
* Review changes
* Fixes from review
7 years ago
Anton Kaliaev
176c2ceed6
Merge pull request #77 from tendermint/18-unsupported-value-type
encode complex types as "%+v"
7 years ago
Anton Kaliaev
798848320f
Merge pull request #76 from tendermint/29-log-logger-errors
log logger's errors
7 years ago
Anton Kaliaev
69447564b8
encode complex types as "%+v" (Refs #18 )
7 years ago
Anton Kaliaev
4b989151ed
log logger's errors (Refs #29 )
7 years ago
Anton Kaliaev
e6164d4052
change service#Stop to be similar to Start
7 years ago
Anton Kaliaev
4123d54bf6
change service#Start to return just error (Refs #45 )
```
@melekes
yeah, bool is superfluous
@ethanfrey
If I remember correctly when I was writing test code, if I call Start() on a Service that is already running, it returns (false, nil). Only if I try to legitimately start it, but it fails in startup do I get an error.
The distinction is quite important to make it safe for reentrant calls. The other approach would be to have a special error type like ErrAlreadyStarted, then check for that in your code explicitly. Kind of like if I make a db call in gorm, and get an error, I check if it is a RecordNotFound error, or whether there was a real error with the db query.
@melekes
Ah, I see. Thanks. I must say I like ErrAlreadyStarted approach more (not just in Golang)
```
7 years ago
Anton Kaliaev
ac0cf0b2e2
Merge pull request #74 from tendermint/73-undefined-syscall-kill
use os.Process#Kill (Fixes #73 )
7 years ago