Emmanuel T Odeke
58f36bb321
Review feedback from @melekes
* Fix typo on naming s/deabBeef/deadBeef/g
* Use `assert.*(t,` instead of `assert.New(t);...;assert.*(`
7 years ago
Emmanuel T Odeke
4c2f56626a
lite/proxy: Validation* tests and hardening for nil dereferences
Updates https://github.com/tendermint/tendermint/issues/1017
Ensure that the Validate* functions in proxy are tests
and cover the case of sneakish bugs that have been encountered
a few times from nil dereferences. The lite package should
theoretically never panic with a nil dereference. It is meant
to contain the certifiers hence it should never panic with such.
Requires the following bugs to be fixed first;
* https://github.com/tendermint/tendermint/issues/1298
* https://github.com/tendermint/tendermint/issues/1299
7 years ago
Ethan Buchman
e3337d764a
Merge pull request #1354 from tendermint/bucky/dep
update dep
7 years ago
Anton Kaliaev
214817ed17
do not add peer to switch if it fails to start
7 years ago
Anton Kaliaev
116a4ec705
temporary fix
I assume there is a deeper issue with how UnmarshalBinary works in
go-amino (i.e., when loading array of some objects, the empty array
becomes []object{nil}). Note when Marshaling, the object is nil.
7 years ago
Ethan Buchman
bbaad22982
update dep
7 years ago
Anton Kaliaev
a7250af303
Exponential backoff follow up ( #1349 )
* document new functionality [ci skip]
Refs #1304
* add fixme [ci skip]
Refs #1304
* ensure that we dial peer after backoff duration
Refs #1304
7 years ago
Zach
6545a21369
docs/examples: update quick start guide ( #1351 )
7 years ago
Zarko Milosevic
416f03c05b
Add light client spec
7 years ago
Ethan Buchman
8c0c8e8e01
Merge pull request #1301 from tendermint/types-data+header+non-nil-panics
types: Hash invoked for nil Data and Header should not panic
7 years ago
Alexander Simmerl
79315efd1f
Merge pull request #1341 from EugeneChung/develop
Remove unnecessary bytes.Compare() call
7 years ago
Eugene Chung
a61130aebb
Remove unnecessary bytes.Compare() call
7 years ago
Alexander Simmerl
5a51a0ba06
Merge pull request #1337 from tendermint/1296-follow-up
Follow up for /health endpoint
7 years ago
Ethan Buchman
0d0b56739d
Merge pull request #1335 from tendermint/zarko/1146-improve-bft-time-spec
Improve BFT time spec
7 years ago
Ethan Buchman
eb1816c9ff
Merge pull request #1338 from tendermint/1266/xla-fix-flaky-testswitchreconnectstopersistentpeer
p2p: Keep reference to connections in test peer
7 years ago
Alexander Simmerl
50ae892d5e
p2p: Keep reference to connections in test peer
We observed non-deterministic test failures in one of our switch tests,
which would happen if the GC would run between iterations of the accept
loop. As we don't hold any reference to the connection the setup
finalizer might get triggered and therefore the file handle closed. For
the curious check the references on finalizers and the variable scoping
in the spec:
https://groups.google.com/forum/#!topic/golang-nuts/xWkhGJ5PY6c
https://groups.google.com/forum/#!topic/golang-nuts/d8aF4rAob7U/discussion
https://golang.org/ref/spec#Declarations_and_scope
Fixes #1266
7 years ago
Zarko Milosevic
5a79b3d74a
Improve the spec to make explicit median computation based on voting power
7 years ago
Anton Kaliaev
460599ef75
fix comment
7 years ago
Anton Kaliaev
830bb72d6f
add Health method to clients
Refs #1296
7 years ago
Anton Kaliaev
b11c26cc1c
update CHANGELOG
7 years ago
Constantine
152290db7e
Add `\health` rpc endpoint ( #1306 )
* Init `\health` rpc endpoint
* remove additional info from `\health` rpc endpoint
* Cleanup imports
* Added time threshold for health check
* Update rpc doc
* Remove unnecessary checks for blocktime creation lag
* Clean up of unnecessary config usage
7 years ago
Ethan Buchman
20b198681b
Merge pull request #1328 from tendermint/bucky/add-vote-readability
addVote readability
7 years ago
Ethan Buchman
2bf106a1b3
Merge pull request #1333 from tendermint/1244-follow-up
consensus: fix tracking for MarkGood
7 years ago
Anton Kaliaev
2c445059f2
mark peer as good every blocksToContributeToBecomeGoodPeer blocks
if enough peers are marked good eventually some will become unmarked, so
good to have a force that will continue to cycle them back into good
territory!
Refs #1317
7 years ago
Anton Kaliaev
d8b08cd943
return back panic in peer#onReceive
Refs #1317
7 years ago
Anton Kaliaev
ab59f64f57
test we record votes and block parts
Refs #1317
7 years ago
Anton Kaliaev
42e3457884
fix tracking of votes and blockparts to not allow old information
also remove mutex
Refs #1317
7 years ago
Anton Kaliaev
31f3dd42e7
mark peer as good only once
or should we do it every N blocks?
Refs #1317
7 years ago
Anton Kaliaev
5fab8e404d
replace magic number with blocksToContributeToBecomeGoodPeer const
Refs #1317
7 years ago
Anton Kaliaev
701df09971
do not use keywords
Refs #1317
7 years ago
Ethan Buchman
d350da3135
config: fix private_peer_ids
7 years ago
Ethan Buchman
ab7dea4f20
consensus: return from errors sooner in addVote
7 years ago
Ethan Buchman
b297efb532
consensus: return from go-routine in test
7 years ago
Ethan Buchman
eaabdb5cac
Merge pull request #1282 from tendermint/1126-private-peers
private peers
7 years ago
racin
066aee3045
Documentation: The character for 1/3 fraction could not be rendered in PDF on readthedocs. ( #1326 )
7 years ago
Ethan Buchman
ff1ec0260e
Merge pull request #1318 from tendermint/bucky/testnet-cmd-fix
testnet cmd: ensure config dir exists. closes #1290
7 years ago
Emmanuel T Odeke
7cb3188fbc
testnet cmd: ensure config dir exists. closes #1290
7 years ago
Alexander Simmerl
9b9022f8df
privVal: Improve SocketClient network code ( #1315 )
Follow-up to feedback from #1286 , this change simplifies the connection
handling in the SocketClient and makes the communication via TCP more
robust. It introduces the tcpTimeoutListener to encapsulate accept and
i/o timeout handling as well as connection keep-alive, this type could
likely be upgraded to handle more fine-grained tuning of the tcp stack
(linger, nodelay, etc.) according to the properties we desire. The same
methods should be applied to the RemoteSigner which will be overhauled
when the priv_val_server is fleshed out.
* require private key
* simplify connect logic
* break out conn upgrades to tcpTimeoutListener
* extend test coverage and simplify component setup
7 years ago
Ethan Buchman
68e049d3af
Merge pull request #1244 from tendermint/1147-using-mark-good-and-stop-peer-for-error
Using MarkGood and StopPeerForError
7 years ago
Anton Kaliaev
86ddf17db0
add a todo
Refs #1281
7 years ago
Anton Kaliaev
a655500047
fix copy-pasted comment [ci skip]
7 years ago
Anton Kaliaev
714f885dac
mark peer as good if it contributed enough votes or block parts
Refs #1147
7 years ago
Anton Kaliaev
b0d8f552c5
return err if peer has sent a vote that does not match our round
7 years ago
Anton Kaliaev
63cb69cb96
comment out ErrAddingVote because it breaks byzantine_test
7 years ago
Anton Kaliaev
266974cb59
stop peer if it sends invalid vote
7 years ago
Anton Kaliaev
bcf54b0aa3
PanicSanity is deprecated
7 years ago
Anton Kaliaev
d86855ad7a
stop peer if it sends us msg with unknown channel
7 years ago
Anton Kaliaev
d0c67bbe16
stop peer if evidence is not valid
7 years ago
Anton Kaliaev
4242352852
stop peer on decoding error
7 years ago
Anton Kaliaev
f299689573
return back defaultChannelCapacity
7 years ago