Marko
866b343c0c
Changes to files that had linting issue ( #3731 )
- Govet issues fixed
- 1 gosec issue solved using nolint
Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
6 years ago
Anton Kaliaev
1d4afb179b
replace PB2TM.ConsensusParams with a call to params#Update ( #3448 )
Fixes #3444
6 years ago
Anton Kaliaev
4162ebe8b5
types: refactor PB2TM.ConsensusParams to take BlockTimeIota as an arg ( #3442 )
See https://github.com/tendermint/tendermint/pull/3403/files#r266208947
In #3403 we unexposed BlockTimeIota from the ABCI, but it's still part
of the ConsensusParams struct, so we have to remember to add it back
after calling PB2TM.ConsensusParams. Instead, PB2TM.ConsensusParams
should take it as an argument
Fixes #3432
6 years ago
Anton Kaliaev
15f621141d
remove TimeIotaMs from ABCI consensus params ( #3403 )
Also
- init substructures to avoid panic in pb2tm.ConsensusParams
Before: if csp.Block is nil and we later try to access/write to it,
we'll panic.
After: if csp.Block is nil and we later try to access/write to it,
there'll be no panic.
6 years ago
Thane Thomson
a335caaedb
alias amino imports ( #3219 )
As per conversation here: https://github.com/tendermint/tendermint/pull/3218#discussion_r251364041
This is the result of running the following code on the repo:
```bash
find . -name '*.go' | grep -v 'vendor/' | xargs -n 1 goimports -w
```
6 years ago
Ismail Khoffi
6a80412a01
Remove privval.GetAddress(), memoize pubkey ( #2948 )
privval: remove GetAddress(), memoize pubkey
6 years ago
Dev Ojha
56d7160606
Add ValidatorPubkeyTypes as a consensus param ( #2636 )
* Add ValidatorPubkeyTypes as a consensus param
Ref #2414
* update spec
* address anton's comment
* Switch to Validator and Validator Params
* Correct changelog entry
* Address bucky's comments!
* forgot to update changelog
* fix typo
* fix Params naming
6 years ago
Ethan Buchman
be929acd6a
Update to Amino v0.13.0-rc0 ( #2687 )
* types: test tm2pm on fully populated header
* upgrade for amino v0.13.0-rc0
* fix lint
* comment out final test
6 years ago
Ethan Buchman
fe1d59ab7b
Set protocol versions in NodeInfo from state ( #2686 )
* use types.NewValidator
* node: set p2p.ProtocolVersion from state, not globals
6 years ago
Ethan Buchman
eabb1ece8e
tmtime: Canonical, some comments ( #2312 )
6 years ago
Anton Kaliaev
d73c5cbdb1
reap max bytes from the mempool & check transaction size
See ADR 020: Limiting txs size inside a block docs/architecture/adr-020-block-size.md
Refs #2035
6 years ago
Ethan Buchman
0701d79046
minor fixes
6 years ago
Ethan Buchman
e3f54ece2f
abci: VoteInfo, ValidatorUpdate. See ADR-018
6 years ago
Dev Ojha
2756be5a59
libs: Remove usage of custom Fmt, in favor of fmt.Sprintf ( #2199 )
* libs: Remove usage of custom Fmt, in favor of fmt.Sprintf
Closes #2193
* Fix bug that was masked by custom Fmt!
6 years ago
ValarDragon
f903947ff3
crypto: Remove interface from crypto.Signature
Signatures are now []byte, which saves on the number of bytes after
amino encoding
(squash this) address Ismail's comment
6 years ago
Anton Kaliaev
bec9d5cba9
add proposer address to block's Header
Refs #1134
Validation:
- ignored in block.ValidateBasic since it's stateful information
- checked in blockExec.ValidateBlock
7 years ago
Anton Kaliaev
0c7338c5f0
abci: Change validators to last_commit_info in RequestBeginBlock ( #2074 )
* change validators to last_commit_info in RequestBeginBlock
* do not send pubkeys with RequestBeginBlock
Refs #1856
7 years ago
ValarDragon
c798702764
crypto: Remove Ed25519 and Secp256k1 suffix on GenPrivKey
7 years ago
ValarDragon
99e582d79a
crypto: Refactor to move files out of the top level directory
Currently the top level directory contains basically all of the code
for the crypto package. This PR moves the crypto code into submodules
in a similar manner to what `golang/x/crypto` does. This improves code
organization.
Ref discussion: https://github.com/tendermint/tendermint/pull/1966
Closes #1956
7 years ago
Anton Kaliaev
3ffda994c2
Revert "rename privval#GetAddress and GetPubKey to Address and PubKey"
This reverts commit 58d0c8de89
.
7 years ago
Anton Kaliaev
ff8ddee708
rename privval#GetAddress and GetPubKey to Address and PubKey
7 years ago
Anton Kaliaev
715ec19c96
add tests for protobuf
Refs #693
7 years ago
Zach Ramsay
44dad6d70b
Revert "detele everything"
This reverts commit d02c5d1e30
.
7 years ago
Zach Ramsay
d02c5d1e30
detele everything
7 years ago
Alexander Simmerl
a605b66c5a
Move abci imports
7 years ago
Liamsi
d2c05bc5b9
Revert "delete everything" (includes everything non-go-crypto)
This reverts commit 96a3502
7 years ago
Liamsi
96a3502126
delete everything
7 years ago
Ethan Buchman
76c82fd433
add more tests
7 years ago